usps-imis-api 0.6.5 → 0.6.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2cb3b6691433ac4025d4754b093d3843620e13396cdd61995cce7b8b0c330da5
-  data.tar.gz: a46f9929ea1dd7eabf47eb6364768014807129cf495f84748e6cb8d2cb95aa72
+  metadata.gz: ac6724a275018ca6e957f9342236882dde2232e1c6e9cf8f0f11e962e2ae5bb7
+  data.tar.gz: 196dc78c0f36f2921e79aba9cfd6157818932f62751475817f0b054cd2decc8d
 SHA512:
-  metadata.gz: 2cf22b22ca0e4c99e450e5805a58a841d462e86fd0b61f54c8ec62abb04d7cd875808f80fb078933490af9db7082b8bc6b88a4f3a1855e266c1aefbd76479516
-  data.tar.gz: b666bb26b1ffd36d48fd968c6eeb20a137d91abdf807013716b297c3a2ccb1a8166bf2b1968b4dd9a85dbf5a9114212d521f4235c050948c907b300227cc4444
+  metadata.gz: 6ef1c062d0d887efcb0d9c0884e43df859d992f65546b16de6d359545c6f0fa92bc0d6d533c6dbca212e5fbdd47b1e3d1cd23e7a91b4af304ed4e95199e8cdb1
+  data.tar.gz: 1fe0de2b0c8f722afa9159779973ef9491f007dad2667cd18f2e863128d69c487f7a09801fba1c9bb0c0710c002e84396064d0a3a98c725f43b4d75f006ca907

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    usps-imis-api (0.6.5)
+    usps-imis-api (0.6.6)
       activesupport (~> 8.0)
 
 GEM

data/lib/usps/imis/panel/base_panel.rb

@@ -117,9 +117,20 @@ module Usps
           @properties << {
             '$type' => 'Asi.Soa.Core.DataContracts.GenericPropertyData, Asi.Contracts',
             'Name' => name,
-            'Value' => value
+            'Value' => property_value(value)
           }
         end
+
+        def property_value(value)
+          case value
+          when String then value
+          when Time, DateTime then value.strftime('%Y-%m-%dT%H:%I:%S')
+          when Integer then { '$type' => 'System.Int32', '$value' => value }
+          when true, false then { '$type' => 'System.Boolean', '$value' => value }
+          else
+            raise Error::ApiError, "Unexpected property type: #{value.inspect}"
+          end
+        end
       end
     end
   end

data/lib/usps/imis/panel/education.rb

@@ -15,13 +15,13 @@ module Usps
         def payload(data)
           properties(data) do
             property 'ID', api.imis_id
-            property 'Ordinal', { '$type' => 'System.Int32', '$value' => data[:ordinal] } if data[:ordinal]
+            property 'Ordinal', data[:ordinal] if data[:ordinal]
             property 'ABC_EDUC_THRU_DATE', data[:thru_date] || '0001-01-01T00:00:00'
             property 'ABC_ECertificate', data[:certificate]
             property 'ABC_Educ_Description', data[:description]
             property 'ABC_Educ_Effective_Date', data[:effective_date]
             property 'ABC_Educ_Source_System', data[:source]
-            property 'ABC_Educ_Transaction_Date', Time.now.strftime('%Y-%m-%dT%H:%I:%S')
+            property 'ABC_Educ_Transaction_Date', Time.now
             property 'ABC_Other_Code', data[:code]
             property 'ABC_Product_Code', data[:type_code]
             property 'ABC_TYPE', data[:abc_type_code] || 'EDUC'

data/lib/usps/imis/panel/vsc.rb

@@ -15,15 +15,15 @@ module Usps
         def payload(data)
           properties(data) do
             property 'ID', api.imis_id
-            property 'Ordinal', { '$type' => 'System.Int32', '$value' => data[:ordinal] } if data[:ordinal]
+            property 'Ordinal', data[:ordinal] if data[:ordinal]
             property 'Source_System', 'Manual ITCom Entry'
             property 'ABC_ECertificate', data[:certificate]
             property 'Activity_Type', 'VSC'
             property 'Description', 'Vessel Safety Checks'
             property 'Effective_Date', "#{data[:year]}-12-01T00:00:00"
-            property 'Quantity', { '$type' => 'System.Int32', '$value' => data[:count] }
+            property 'Quantity', data[:count]
             property 'Thru_Date', "#{data[:year]}-12-31T00:00:00"
-            property 'Transaction_Date', Time.now.strftime('%Y-%m-%dT%H:%M:%S')
+            property 'Transaction_Date', Time.now
           end
         end
       end

data/lib/usps/imis/version.rb

@@ -2,6 +2,6 @@
 
 module Usps
   module Imis
-    VERSION = '0.6.5'
+    VERSION = '0.6.6'
   end
 end

data/spec/lib/usps/imis/panel/base_panel_spec.rb

@@ -35,4 +35,16 @@ describe Usps::Imis::Panel::BasePanel do
       Usps::Imis::Error::ApiError, 'Must be called within a `properties` block'
     )
   end
+
+  it 'handles boolean property values' do
+    expect(described_class.new.send(:property_value, true)).to eq(
+      '$type' => 'System.Boolean', '$value' => true
+    )
+  end
+
+  it 'raises an error for unexpected property types' do
+    expect { described_class.new.send(:property_value, {}) }.to raise_error(
+      Usps::Imis::Error::ApiError, 'Unexpected property type: {}'
+    )
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: usps-imis-api
 version: !ruby/object:Gem::Version
-  version: 0.6.5
+  version: 0.6.6
 platform: ruby
 authors:
 - Julian Fiander