usps-imis-api 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1febbdb28781a5589ce97b66eb071728aef8b8e81991970854620c9fc128cf54
-  data.tar.gz: cc5aeb7ddab766c885d4bb009b1fa9afcdaa8f71d68b56f2e86861c12f8eda72
+  metadata.gz: 93af4ce91eacb92695d10144b3885da6bd1e8ff31e26f8b22c8ae9404595f951
+  data.tar.gz: 6c2df89c1531953ef37d8fd867699fc8917d2aca3db3e204cf3937bf679cf7ed
 SHA512:
-  metadata.gz: '09fdb03097ef67813356bf1a4378f53827bcacc3c8115fb9128ce0f2a8dcdceb26aafc3296b8132468860906ac3884965c53b4e47729aa8dc0a964a13346717e'
-  data.tar.gz: 3703f4325f53afde2c9350c4382d0cbfeb4d53489275c866a1041749ba5324d7833c4a3fe14f11e70bcd3a1729981f2b3b3befcd3a603a5ab5703a03ae6a9cc5
+  metadata.gz: 299a9220c4232cd0a1d45681a4f5c32800c0188e3e86f2740b7106f5ccc256f22dfe15bbafe6bd8c06152b4af9f3434c2cba5e49c632eed5a3a1540a4305ca59
+  data.tar.gz: 2d0310cea22d9160330cb4d1438679dc17565ab9e43d32dc0db7fd2dea7315a070cbd949bc30e0cde9ecbca09302a5c1e4033c034667fffb52d44462177766a9

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    usps-imis-api (0.5.0)
+    usps-imis-api (0.5.1)
 
 GEM
   remote: https://rubygems.org/

data/lib/usps/imis/api.rb

@@ -31,6 +31,10 @@ module Usps
       #
       attr_reader :imis_id
 
+      # Whether to lock changes to the selected iMIS ID
+      #
+      attr_reader :lock_imis_id
+
       # A new instance of +Api+
       #
       # @param skip_authentication [bool] Skip authentication on initialization (used for tests)
@@ -46,6 +50,8 @@ module Usps
       # @param id [Integer, String] iMIS ID to select for future requests
       #
       def imis_id=(id)
+        raise Error::ApiError, 'Cannot change iMIS ID while locked' if lock_imis_id
+
         @imis_id = id.to_i.to_s
       end
 
@@ -56,15 +62,19 @@ module Usps
       # @return [String] Corresponding iMIS ID
       #
       def imis_id_for(certificate)
-        result = query(Imis.configuration.imis_id_query_name, { certificate: })
-        @imis_id = result['Items']['$values'][0]['ID']
-      rescue StandardError
-        raise Error::ApiError, 'Member not found'
+        raise Error::ApiError, 'Cannot change iMIS ID while locked' if lock_imis_id
+
+        begin
+          result = query(Imis.configuration.imis_id_query_name, { certificate: })
+          @imis_id = result['Items']['$values'][0]['ID']
+        rescue StandardError
+          raise Error::ApiError, 'Member not found'
+        end
       end
 
       # Run requests as DSL, with specific iMIS ID only maintained for this scope
       #
-      # This should be used with methods that do not change the value of `imis_id`
+      # While in this block, changes to the value of +imis_id+ are not allowed
       #
       # @param id [Integer, String] iMIS ID to select for requests within the block
       #
@@ -76,8 +86,11 @@ module Usps
       def with(id, &)
         old_id = imis_id
         self.imis_id = id
+
+        @lock_imis_id = true
         instance_eval(&)
       ensure
+        @lock_imis_id = false
         self.imis_id = old_id
       end
 

data/lib/usps/imis/version.rb

@@ -2,6 +2,6 @@
 
 module Usps
   module Imis
-    VERSION = '0.5.0'
+    VERSION = '0.5.1'
   end
 end

data/spec/lib/usps/imis/api_spec.rb

@@ -82,6 +82,18 @@ describe Usps::Imis::Api do
     it 'uses a panel correctly' do
       expect(api.with(6374) { panels.vsc.get(1433) }).to be_a(Hash)
     end
+
+    it 'blocks calling imis_id=' do
+      expect do
+        api.with(31092) { self.imis_id = 31092 }
+      end.to raise_error(Usps::Imis::Error::ApiError, 'Cannot change iMIS ID while locked')
+    end
+
+    it 'blocks calling imis_id_for' do
+      expect do
+        api.with(31092) { imis_id_for('E231625') }
+      end.to raise_error(Usps::Imis::Error::ApiError, 'Cannot change iMIS ID while locked')
+    end
   end
 
   describe '#inspect' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: usps-imis-api
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Julian Fiander