usps-imis-api 0.3.3.pre.pre.1 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d71f733048ca34857ca8914e8591e44f5671d678e5644a67f877dac272712a0c
-  data.tar.gz: b960d8a2202168321cd1e9605bb5299c3fc21356ca299faf34b5799e44a8a53b
+  metadata.gz: 829f39c81242bde99b954d06710ba008290415eb765340be960bad36bd471e0c
+  data.tar.gz: f15146f633cd77744521b14bcd6d196cf05518f6455528a2b2362a4726debfd8
 SHA512:
-  metadata.gz: 128b52d227155ebc4e4807354e0668c0929221c05738efade63afb428dd88b331c7c8611d159fdbbeba6b379ea36724e6defc1c8fa8e1fe510fde4401a5a5545
-  data.tar.gz: 546813a0c7a339e2a958f539feafa46c280e825cc2d8dc2d066998e8980627ead2757bf4a3e5d448be9d003c0972c96c0065d986ac665038742652de85396fa8
+  metadata.gz: 87c7576a9be599cabc7968a5df6484d421b80e933c5dfb3719974584f2ad563b12e2b3294deaa73bd716e5b8ca270e99a95072673440a4b139b6bd358446d826
+  data.tar.gz: b844cc08b4c36ec3702a0e97ce4dd6ec000c2926b1440113624f0071e67689b6ef70e44833051a29091e77ea6cdefedce026f6cf4138f4bc76043b2f00559e72

data/.rubocop.yml

@@ -45,9 +45,9 @@ Metrics/MethodLength:
   Max: 15
 Metrics/ClassLength:
   Enabled: true
-  Max: 125
+  Max: 150
 Metrics/ModuleLength:
-  Max: 125
+  Max: 150
 Metrics/ParameterLists:
   Enabled: true
 Metrics/CyclomaticComplexity:

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    usps-imis-api (0.3.3.pre.pre.1)
+    usps-imis-api (0.3.3)
 
 GEM
   remote: https://rubygems.org/

data/lib/usps/imis/error/api.rb

@@ -15,12 +15,22 @@ module Usps
           super(message)
           @metadata = metadata
           @response = response
+
+          warn inspect if ENV.fetch('IMIS_ERROR_LOG_TO_STDERR', 'false') == 'true'
         end
 
         def bugsnag_meta_data
           { api: { status: status, body: body }.merge!(metadata) }
         end
 
+        def inspect
+          [
+            "#{self.class.name}: [#{status.to_s.upcase}] #{message}",
+            (metadata.inspect if metadata != {}),
+            body
+          ].compact.join("\n")
+        end
+
       private
 
         def status

data/lib/usps/imis/mapper.rb

@@ -14,8 +14,9 @@ module Usps
 
       attr_reader :api
 
-      def initialize(api = nil)
+      def initialize(api = nil, imis_id: nil)
         @api = api || Api.new
+        api.imis_id = imis_id if imis_id
       end
 
       # Update a member's data on multiple affected business objects by arbitrary field names

data/lib/usps/imis/version.rb

@@ -2,6 +2,6 @@
 
 module Usps
   module Imis
-    VERSION = '0.3.3-pre.1'
+    VERSION = '0.3.3'
   end
 end

data/spec/lib/usps/imis/error/api_spec.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+ApiResponseStub = Struct.new(:code, :body)
+
+describe Usps::Imis::Error::Api do
+  let(:warning_text) do
+    <<~WARNING.chomp
+      Usps::Imis::Error::Api: [INTERNAL_SERVER_ERROR] The iMIS API returned an error.
+      Body of the API response error
+    WARNING
+  end
+
+  it 'handles an API response correctly' do
+    response = ApiResponseStub.new('500', 'Body of the API response error')
+
+    expect(described_class.from(response).inspect).to eq(warning_text)
+  end
+end

data/spec/lib/usps/imis/panel/education_spec.rb

@@ -30,7 +30,7 @@ describe Usps::Imis::Panel::Education do
     new_record = education.create(details)
     expect(new_record).to be_a(Hash)
 
-    ordinal = new_record['Properties']['$values'][1]['Value']['$value']
+    ordinal = new_record['Identity']['IdentityElements']['$values'][1]
 
     update_result =
       education.update(details.merge(source: 'Online Exams System - Modified', ordinal: ordinal))

data/spec/lib/usps/imis/panel/vsc_spec.rb

@@ -26,7 +26,7 @@ describe Usps::Imis::Panel::Vsc do
     new_record = vsc.create(details)
     expect(new_record).to be_a(Hash)
 
-    ordinal = new_record['Properties']['$values'][1]['Value']['$value']
+    ordinal = new_record['Identity']['IdentityElements']['$values'][1]
 
     update_result = vsc.update(details.merge(count: 43, ordinal: ordinal))
     updated = update_result['Properties']['$values'].find { |v| v['Name'] == 'Quantity' }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: usps-imis-api
 version: !ruby/object:Gem::Version
-  version: 0.3.3.pre.pre.1
+  version: 0.3.3
 platform: ruby
 authors:
 - Julian Fiander
@@ -38,6 +38,7 @@ files:
 - lib/usps/imis/panel/vsc.rb
 - lib/usps/imis/version.rb
 - spec/lib/usps/imis/api_spec.rb
+- spec/lib/usps/imis/error/api_spec.rb
 - spec/lib/usps/imis/mapper_spec.rb
 - spec/lib/usps/imis/panel/education_spec.rb
 - spec/lib/usps/imis/panel/vsc_spec.rb