user_fullname 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 260ea022d47abe6fc815926edd9e8137ae722b60
-  data.tar.gz: b3b4208d2e38f59644e2eea0f3456d1c3b83dfa9
+  metadata.gz: 86de0bcc86a8cdcd01e14a91d1efc16871b729c5
+  data.tar.gz: 6242cc303e802634fad250bdfb26e1c3ebec7291
 SHA512:
-  metadata.gz: 6210752ed6b5253703fc1447d4e0c7c43442b4b6eac0074dcf617f6b02cf289f24f1c3512e3cb3a68ba567efc8711605b1971d600b0b6c314988fa00f4d7d480
-  data.tar.gz: b38bb182c5b02db3565975757a9cb91552839679b9e45178ea0f7419c88ee1a248afdd183b6fd042aa98e2fa11728e0cd550ce490c070f9812acc07482b3b944
+  metadata.gz: 60e796522b8c27a83ba1e53ced0e24ee273f11c378a240fdf99c650856fcb4abf7125fe744e24fcb64a8b7ceec05b0caa0bc3e50aea2660064c745b7ec74b577
+  data.tar.gz: 7bf74a9ac05c57cd80f8d4af06217b1b1a9c9c1af9d62709aa47155afaa3824bdf0fa9528949cbc792e629383bf7854d8eabd182c6bb3a4f94726da6881df0a9

data/.rubocop.yml

@@ -0,0 +1,3 @@
+LineLength:
+  Enabled: true
+  Max: 79

data/CHANGELOG.md

@@ -1,3 +1,12 @@
 ## v0.0.1
 
 * initial release
+
+## v0.0.2
+
+* added shortname
+
+## v0.0.3
+
+Nothing new. Updated rspec tests to v3.0.
+

data/Gemfile

@@ -4,10 +4,12 @@ source 'https://rubygems.org'
 gemspec
 
 group :development, :test do
+  gem 'codeclimate-test-reporter', require: nil
   gem 'coveralls', require: false
-  gem 'rspec'
+  gem 'rspec', '~> 3.0.0.beta1'
   gem 'reek'
   gem 'guard'
   gem 'guard-bundler'
   gem 'guard-rspec'
+  gem 'rb-readline', '~> 0.5.0', require: false
 end

data/README.md

@@ -1,4 +1,10 @@
-# UserFullname [![Gem Version](https://badge.fury.io/rb/user_fullname.png)](http://badge.fury.io/rb/user_fullname) [![Build Status](https://travis-ci.org/fractalsoft/user_fullname.png)](https://travis-ci.org/fractalsoft/user_fullname) [![Dependency Status](https://gemnasium.com/fractalsoft/user_fullname.png)](https://gemnasium.com/fractalsoft/user_fullname) [![Coverage Status](https://coveralls.io/repos/fractalsoft/user_fullname/badge.png)](https://coveralls.io/r/fractalsoft/user_fullname) [![Stories in Ready](https://badge.waffle.io/fractalsoft/user_fullname.png)](http://waffle.io/fractalsoft/user_fullname)
+# UserFullname 
+[![Gem Version](https://badge.fury.io/rb/user_fullname.png)](http://badge.fury.io/rb/user_fullname) 
+[![Build Status](https://travis-ci.org/fractalsoft/user_fullname.png?branch=master)](https://travis-ci.org/fractalsoft/user_fullname) 
+[![Dependency Status](https://gemnasium.com/fractalsoft/user_fullname.png)](https://gemnasium.com/fractalsoft/user_fullname) 
+[![Coverage Status](https://coveralls.io/repos/fractalsoft/user_fullname/badge.png?branch=master)](https://coveralls.io/r/fractalsoft/user_fullname?branch=master) 
+[![Code Climate](https://codeclimate.com/repos/52823cc489af7e26300298a5/badges/3783c14343942947903f/gpa.png)](https://codeclimate.com/repos/52823cc489af7e26300298a5/feed)
+[![Stories in Ready](https://badge.waffle.io/fractalsoft/user_fullname.png)](http://waffle.io/fractalsoft/user_fullname)
 [![endorse](https://api.coderwall.com/torrocus/endorsecount.png)](https://coderwall.com/torrocus)
 
 User fullname is a gem which support first name, last name and full name. You need only full name in Your database.
@@ -24,14 +30,16 @@ class User
   include UserFullname
 end
 
-user.fullname = "John Smith"
-user.firstname #=> "John"
-user.lastname #=> "Smith"
-user.fullname #=> "John Smith"
-user.firstname = "Bob"
-user.fullname #=> "Bob Smith"
-user.lastname = "Marley"
-user.fullname #=> "Bob Marley"
+user.fullname = 'John Smith'
+user.firstname #=> 'John'
+user.lastname #=> 'Smith'
+user.fullname #=> 'John Smith'
+user.shortname #=> 'J.Smith'
+user.firstname = 'Bob'
+user.fullname #=> 'Bob Smith'
+user.lastname = 'Marley'
+user.fullname #=> 'Bob Marley'
+user.shortname #=> 'B.Marley'
 ```
 
 ## Contributing

data/Rakefile

@@ -1,5 +1,5 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 
-task :default => :spec
-RSpec::Core::RakeTask.new
+task default: :spec
+RSpec::Core::RakeTask.new(:spec)

data/lib/user_fullname.rb

@@ -1,5 +1,2 @@
-require "user_fullname/model"
-require "user_fullname/version"
-
-module UserFullname
-end
+require 'user_fullname/model'
+require 'user_fullname/version'

data/lib/user_fullname/model.rb

@@ -1,4 +1,6 @@
 # encoding: utf-8
+
+# The most commonly used user's methods
 module UserFullname
   def fullname
     @fullname = super
@@ -34,14 +36,16 @@ module UserFullname
   end
 
   private
+
     def update_fullname
       send(:fullname=, [@firstname, @lastname].join(' '))
     end
 
     def parse(order)
       name = fullname
-      if name and array = name.split(/\s/)
+      if name
+        array = name.split(/\s/)
         array[order]
-      end or ""
+      end || ''
     end
 end

data/lib/user_fullname/version.rb

@@ -1,3 +1,4 @@
+# Gem version
 module UserFullname
-  VERSION = "0.0.2"
+  VERSION = '0.0.3'
 end

data/spec/spec_helper.rb

@@ -2,9 +2,10 @@ require 'user_fullname'
 require 'support/randomizer'
 require 'coveralls'
 Coveralls.wear!
+require 'codeclimate-test-reporter'
+CodeClimate::TestReporter.start
 
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
 end

data/spec/support/randomizer.rb

@@ -8,5 +8,5 @@ def rand_name
 end
 
 def rand_fullname
-  [rand_text, rand_text].map(&:capitalize).join
+  "#{rand_name} #{rand_name}"
 end

data/spec/user_fullname/model_spec.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
+# Testing class
 class DummyClass
   attr_accessor :fullname
 
@@ -12,7 +13,7 @@ class DummyClass
 end
 
 describe DummyClass do
-  context "set" do
+  context 'set' do
     let(:firstname) { rand_name }
     let(:lastname) { rand_name }
     subject { DummyClass.new(rand_fullname) }
@@ -22,40 +23,81 @@ describe DummyClass do
       @fullname = [firstname, lastname].join(' ')
     end
 
-    its(:fullname) do
-      subject.fullname = @fullname
-      should eq(@fullname)
+    describe '#fullname' do
+      it do
+        subject.fullname = @fullname
+        expect(subject.fullname).to eq(@fullname)
+      end
     end
 
-    its(:fullname) do
-      subject.firstname = firstname
-      should eq([firstname, @lastname].join(' '))
+    describe '#firstname' do
+      it do
+        subject.firstname = firstname
+        expect(subject.fullname).to eq([firstname, @lastname].join(' '))
+      end
     end
 
-    its(:fullname) do
-      subject.lastname = lastname
-      should eq([@firstname, lastname].join(' '))
+    describe '#lastname' do
+      it do
+        subject.lastname = lastname
+        expect(subject.fullname).to eq([@firstname, lastname].join(' '))
+      end
     end
   end
 
-  context "get" do
+  context 'get' do
     let(:firstname) { rand_name }
     let(:lastname) { rand_name }
     let(:fullname) { [firstname, lastname].join(' ') }
     let(:shortname) { "#{firstname[0]}.#{lastname}" }
     subject { DummyClass.new(fullname) }
 
-    # its(:fullname) { should eq(fullname) }
-    its(:firstname) { should eq(firstname) }
-    its(:lastname) { should eq(lastname) }
-    its(:firstname) do
-      subject.fullname = " #{lastname}"
-      should eq("")
+    describe '#fullname' do
+      it { expect(subject.fullname).to eq(fullname) }
     end
-    its(:lastname) do
-      subject.fullname = "#{firstname} "
-      should eq("")
+
+    describe '#firstname' do
+      it { expect(subject.firstname).to eq(firstname) }
+    end
+
+    describe '#lastname' do
+      it { expect(subject.lastname).to eq(lastname) }
+    end
+
+    describe '#shortname' do
+      it { expect(subject.shortname).to eq(shortname) }
+    end
+
+    describe '#firstname' do
+      it do
+        subject.fullname = " #{lastname}"
+        expect(subject.firstname).to eq('')
+      end
+    end
+
+    describe '#lastname' do
+      it do
+        subject.fullname = "#{firstname} "
+        expect(subject.lastname).to eq('')
+      end
+    end
+  end
+
+  describe 'long name' do
+    it 'double firstname' do
+      names = 'David Lee Roth'
+      subject.fullname = 'David Lee Roth'
+      # subject.firstname = 'David Lee'
+      # subject.lastname = 'Roth'
+      expect(subject.fullname).to eq(names)
+    end
+
+    it 'double lastname' do
+      names = 'Abraham Van Helsing'
+      subject.fullname = names
+      # subject.firstname = 'Abraham'
+      # subject.lastname = 'Van Helsing'
+      expect(subject.fullname).to eq(names)
     end
-    its(:shortname) { should eq(shortname) }
   end
 end

data/user_fullname.gemspec

@@ -4,19 +4,19 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'user_fullname/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "user_fullname"
+  spec.name          = 'user_fullname'
   spec.version       = UserFullname::VERSION
-  spec.authors       = ["Aleksander Malaszkiewicz"]
-  spec.email         = ["info@fractalsoft.org"]
+  spec.authors       = ['Aleksander Malaszkiewicz']
+  spec.email         = ['info@fractalsoft.org']
   spec.summary       = %q{Support user full name}
-  spec.homepage      = "https://github.com/fractalsoft/user_fullname"
-  spec.license       = "MIT"
+  spec.homepage      = 'https://github.com/fractalsoft/user_fullname'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'rake'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: user_fullname
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Aleksander Malaszkiewicz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-07 00:00:00.000000000 Z
+date: 2013-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -47,6 +47,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- .rubocop.yml
 - .ruby-gemset
 - .ruby-version
 - .travis.yml
@@ -83,7 +84,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.0.7
 signing_key: 
 specification_version: 4
 summary: Support user full name