usecasing 0.1.0 → 0.1.1

data/lib/usecasing/base.rb

@@ -20,14 +20,15 @@ module UseCase
       end
 
       def perform(ctx = { })
-        execution_order = build_execution_order(self, {})
+        any_ciclic, ciclic = CyclicFinder.new(self).cyclic?
+        raise StandardError.new("cyclic detected: #{ciclic}") if any_ciclic
+        execution_order = [] 
+        build_execution_order(self, execution_order)
         tx(execution_order, ctx) do |usecase, context| 
           usecase.new(context).perform 
         end
       end
 
-      private
-
       def tx(execution_order, context)
         ctx = Context.new(context)
         executed = []
@@ -47,20 +48,37 @@ module UseCase
         context
       end
 
-      def build_execution_order(start_point, visited)
-        raise StandardError.new("cyclic detected: #{start_point} in #{self}") if visited[start_point]
-        visited[start_point] = true
-        return [start_point] if start_point.dependencies.empty?
-
-        childrens = start_point.dependencies.each do |point|
-          build_execution_order(point, visited).unshift point
+      def build_execution_order(node, result)
+        return result.push(node) if node.dependencies.empty?
+        
+        node.dependencies.each do |item|
+          build_execution_order(item, result)
         end
-        childrens.push(start_point)
 
+        result.push(node)
       end
-    end
 
-  end
+      # def build_execution_order
+      #   stack = [self]
+      #   result  = []
+      #   visited = {}
+        
+      #   until stack.empty?
+      #     node = stack.last
+      #     if(node.dependencies.empty? || visited[node.name])
+      #       result.push(stack.pop)
+      #     else
+      #       stack.push(*(node.dependencies.reverse))
+      #       visited[node.name] = true
+      #     end
+      #   end
+
+      #   return result
+
+      # end
+
+    end #ClassMethods
+  end #BaseClassMethod
 
   class Base
 

data/lib/usecasing/cyclic_finder.rb

@@ -0,0 +1,44 @@
+require 'set'
+require 'tsort'
+
+module UseCase
+
+  class CyclicFinder
+    include TSort
+    
+    def initialize(start_point)
+      @start_point = start_point
+      @nodes = discover_nodes
+    end
+
+    def tsort_each_node(&block)
+      @nodes.each &block
+    end
+
+    def tsort_each_child(node, &block)
+      node.dependencies.each &block
+    end
+
+    def cyclic?
+      components = strongly_connected_components
+      result = components.any?{ |component| component.size != 1 }
+      [ result, components.select{|component| component.size != 1 } ]
+    end
+
+    private
+    def discover_nodes
+      visited = {}
+      stack = [@start_point]
+      result = Set.new
+      until stack.empty?
+        node = stack.pop
+        result.add node
+        stack.push(*(node.dependencies)) if not visited[node]
+        visited[node] = true
+      end
+
+      return result
+    end
+
+  end
+end

data/lib/usecasing/version.rb

@@ -1,3 +1,3 @@
 module Usecasing
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/usecasing.rb

@@ -1,6 +1,7 @@
 require "usecasing/version"
 
 module UseCase
-  autoload :Context,  'usecasing/context'
-  autoload :Base,     'usecasing/base'
+  autoload :Context,       'usecasing/context'
+  autoload :Base,          'usecasing/base'
+  autoload :CyclicFinder,  'usecasing/cyclic_finder'
 end

data/spec/usecase_base_spec.rb

@@ -226,28 +226,28 @@ describe UseCase::Base do
 
     it 'only rollbacks usecase that ran' do 
       
-      UseCaseFailRanThird = Class.new(UseCase::Base) do 
- 
+      UseCaseFailRanThird = Class.new(UseCase::Base) do
+
         def rollback
-          context.should_not_appear = 'true'
+          context.rollback_third = 'true'
         end
 
       end
 
       UseCaseFailRanSecond = Class.new(UseCase::Base) do 
         
-        def perform
-          failure(:rollback, 'error')
-        end
-
-
         def rollback
-          context.rollback_second 'true_2'
+          context.rollback_second = 'true_2'
         end
 
       end      
 
       UseCaseFailRanFirst = Class.new(UseCase::Base) do 
+        depends UseCaseFailRanSecond
+
+        def perform
+          failure(:rollback, 'error')
+        end
 
         def rollback
           context.rollback_first = 'true_1'
@@ -256,13 +256,16 @@ describe UseCase::Base do
       end
 
       UseCaseFailRan = Class.new(UseCase::Base) do
-        depends UseCaseFailRanFirst, UseCaseFailRanSecond, UseCaseFailRanThird
+        depends UseCaseFailRanFirst, UseCaseFailRanThird
       end
 
       context = UseCaseFailRan.perform
-      expect(context.should_not_appear).to be_nil
+      expect(context.rollback_third).to_not be
+      expect(context.rollback_second).to be
+      expect(context.rollback_first).to be
 
     end
+
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: usecasing
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-20 00:00:00.000000000 Z
+date: 2013-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -76,6 +76,7 @@ files:
 - lib/usecasing.rb
 - lib/usecasing/base.rb
 - lib/usecasing/context.rb
+- lib/usecasing/cyclic_finder.rb
 - lib/usecasing/version.rb
 - spec/context_spec.rb
 - spec/spec_helper.rb
@@ -95,7 +96,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2175319097785181606
+      hash: 1663280317763873983
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -104,7 +105,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2175319097785181606
+      hash: 1663280317763873983
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24