use_packwerk 0.61.0 → 0.63.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6c4a14c7a607d7c5778ec8dc79c199dbcb3dd5698db1e7d5f7c70e5b0deff5fa
-  data.tar.gz: 73022ab6fa41370d82ab39610528ba393bc3559de7a764832c7107ec6048f408
+  metadata.gz: ebe18edb1b17a40a2ad1815cc4482d6dfcfac0817e8900ff775cbcacc5c1bcd5
+  data.tar.gz: edcba665142d63a40373126b85d5bbcb92ca98123bd599f8eff7ed56accc8014
 SHA512:
-  metadata.gz: 98721b214ca79437c0dd5f4fa617df51cd2ea00d6373f01a28ee51a8799b281965d58aa68cc1c36100d79f639c30cb68e47acfbaebc3c8b57812a702c1ef798f
-  data.tar.gz: 38e8aafc4cbd3b0e38bfda5f24087efbc33185f2e787568088e8afb98e67441eb62ebaf42c27b0e4d489637949316a6834989d2f8d99e5fd7ee8e002ab580e64
+  metadata.gz: 2421e5530d6534eb6592bc04278afb9a0276bd0446081483ff346f9d30864970edb13f7b2a01ee38682a183b1cb4d498f6fe726081a4783200d5c8aa38946e64
+  data.tar.gz: 8723efa393e952179f670818b99dacedcfd0be341d49447d01906a4c512150d819967cc4b2b2a28edf124eeb59d491347b688f0525a95a327c8b4341207712f8

data/lib/use_packwerk/private/file_move_operation.rb

@@ -11,12 +11,12 @@ module UsePackwerk
 
       sig { returns(ParsePackwerk::Package) }
       def origin_pack
-        T.must(ParsePackwerk.package_from_path(origin_pathname))
+        ParsePackwerk.package_from_path(origin_pathname)
       end
 
       sig { params(origin_pathname: Pathname, new_package_root: Pathname).returns(Pathname) }
       def self.destination_pathname_for_package_move(origin_pathname, new_package_root)
-        origin_pack = T.must(ParsePackwerk.package_from_path(origin_pathname))
+        origin_pack = ParsePackwerk.package_from_path(origin_pathname)
 
         if origin_pack.name == ParsePackwerk::ROOT_PACKAGE_NAME
           new_package_root.join(origin_pathname).cleanpath
@@ -27,7 +27,7 @@ module UsePackwerk
 
       sig { params(origin_pathname: Pathname).returns(Pathname) }
       def self.destination_pathname_for_new_public_api(origin_pathname)
-        origin_pack = T.must(ParsePackwerk.package_from_path(origin_pathname))
+        origin_pack = ParsePackwerk.package_from_path(origin_pathname)
         if origin_pack.name == ParsePackwerk::ROOT_PACKAGE_NAME
           filepath_without_pack_name = origin_pathname.to_s
         else

data/lib/use_packwerk/private/pack_relationship_analyzer.rb

@@ -35,7 +35,7 @@ module UsePackwerk
 
         # TODO: This is a copy of the implementation below. We may want to refactor out this implementation detail before making changes that apply to both.
         all_packages.each do |client_package|
-          PackageProtections::ProtectedPackage.from(client_package).violations.select(&:privacy?).each do |violation|
+          client_package.violations.select(&:privacy?).each do |violation|
             next unless to_package_names.include?(violation.to_package_name)
 
             if pack_name.nil?
@@ -99,7 +99,7 @@ module UsePackwerk
 
         # TODO: This is a copy of the implementation above. We may want to refactor out this implementation detail before making changes that apply to both.
         all_packages.each do |client_package|
-          PackageProtections::ProtectedPackage.from(client_package).violations.select(&:dependency?).each do |violation|
+          client_package.violations.select(&:dependency?).each do |violation|
             next unless to_package_names.include?(violation.to_package_name)
 
             if pack_name.nil?

data/lib/use_packwerk/private/packwerk_wrapper.rb

@@ -64,7 +64,7 @@ module UsePackwerk
 
       sig { params(files: T::Array[String]).returns(T::Array[String]) }
       def self.package_names_for_files(files)
-        files.map { |f| ParsePackwerk.package_from_path(f)&.name }.compact.uniq
+        files.map { |f| ParsePackwerk.package_from_path(f).name }.compact.uniq
       end
     end
   end

data/lib/use_packwerk/private.rb

@@ -228,7 +228,7 @@ module UsePackwerk
           end
 
           file_move_operations = file_paths.map do |path|
-            package = T.must(ParsePackwerk.package_from_path(path))
+            package = ParsePackwerk.package_from_path(path)
             origin_pathname = Pathname.new(path).cleanpath
 
             FileMoveOperation.new(
@@ -361,8 +361,7 @@ module UsePackwerk
         )
 
         ParsePackwerk.write_package_yml!(package)
-        PackageProtections.set_defaults!([package], verbose: false)
-        package = rewrite_package_with_original_packwerk_values(package)
+        RuboCop::Packs.set_default_rubocop_yml(packs: [package])
 
         current_contents = package.yml.read
         new_contents = current_contents.gsub('MyTeam', 'MyTeam # specify your team here, or delete this key if this package is not owned by one team')
@@ -373,23 +372,6 @@ module UsePackwerk
       existing_package
     end
 
-    sig { params(original_package: ParsePackwerk::Package).returns(ParsePackwerk::Package) }
-    def self.rewrite_package_with_original_packwerk_values(original_package)
-      ParsePackwerk.bust_cache!
-      package_with_protection_defaults = T.must(ParsePackwerk.all.find { |p| p.name == original_package.name })
-      # PackageProtections also sets `enforce_privacy` and `enforce_dependency` to be true, so we set these back down to their original values
-      package = ParsePackwerk::Package.new(
-        enforce_dependencies: original_package.enforce_dependencies,
-        enforce_privacy: original_package.enforce_privacy,
-        dependencies: original_package.dependencies,
-        metadata: package_with_protection_defaults.metadata,
-        name: original_package.name
-      )
-
-      ParsePackwerk.write_package_yml!(package)
-      package
-    end
-
     sig { void }
     def self.load_client_configuration
       @loaded_client_configuration ||= T.let(false, T.nilable(T::Boolean))

data/lib/use_packwerk/user_event_logger.rb

@@ -122,7 +122,7 @@ module UsePackwerk
         Anything that is considered private should go in other folders.
 
         If another pack uses classes, constants, or modules that are not in your public folder, it will be considered a "privacy violation" by packwerk.
-        You can prevent other packs from using private API by using package_protections.
+        You can prevent other packs from using private API by using packwerk.
 
         Want to find how your private API is being used today?
         Try running: `bin/use_packwerk list_top_privacy_violations #{pack_name}`

data/lib/use_packwerk.rb

@@ -10,7 +10,7 @@ require 'colorized_string'
 require 'parse_packwerk'
 require 'code_teams'
 require 'code_ownership'
-require 'package_protections'
+require 'rubocop-packs'
 
 # Private implementation requires
 require 'use_packwerk/private'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: use_packwerk
 version: !ruby/object:Gem::Version
-  version: 0.61.0
+  version: 0.63.0
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-11-10 00:00:00.000000000 Z
+date: 2022-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_ownership
@@ -38,20 +38,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: package_protections
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: packwerk
   requirement: !ruby/object:Gem::Requirement