use_packwerk 0.60.1 → 0.62.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b89e9d11b71005c2908d2fd78c021fe0b9ea2d126558811ac0947c3d835e1c3d
-  data.tar.gz: 5102a8a031920ca3d8573ef3bad99033b22eadb0304baa3287c328e3ff6eb3fc
+  metadata.gz: 821209b6fb9f46c62a5e83f3bd0786566c681ddd5368fac0650ec09dc591c0ac
+  data.tar.gz: da79d2c1b40b423a53c9cc8d4342c865e0c1f9381a6f4c6170c8f6338af2e817
 SHA512:
-  metadata.gz: dd544d69805e4a771b15a4a4311a094d7957df495e9f8f197604916641e844dfab711019951513e6a9bda283e25886c91a8c5028d1b0f75085c7b23890268a2b
-  data.tar.gz: eae73ccc82d61a086e7cf88068c7710ac47e1259a64fb1ff4bf3e14e8f230fc98ffc8b80dd9d90bed3016198b75cd52d32f2dbb971a5566a274504b925205687
+  metadata.gz: 0d7a941489a3dd4f1cb6fe177bef70d98c28e1ad086c18c55473798ef267f92ab1302e7821c8ca8aadb49eecba32f07c69d1144e912719bd88a54e8696d308ab
+  data.tar.gz: abaee25e63f8361985c3bd3b628d5ea50e50b47d23f7cdc7746cf2598991415f4bbaba34b33af80914a3c17c921888fe2d696cd0647d5c2ba27050b7fc820a04

data/bin/rubocop

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rubocop' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile',
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path('bundle', __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require 'rubygems'
+require 'bundler/setup'
+
+load Gem.bin_path('rubocop', 'rubocop')

data/bin/tapioca

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'tapioca' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile',
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path('bundle', __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require 'rubygems'
+require 'bundler/setup'
+
+load Gem.bin_path('tapioca', 'tapioca')

data/lib/use_packwerk/private/file_move_operation.rb

@@ -11,12 +11,12 @@ module UsePackwerk
 
       sig { returns(ParsePackwerk::Package) }
       def origin_pack
-        T.must(ParsePackwerk.package_from_path(origin_pathname))
+        ParsePackwerk.package_from_path(origin_pathname)
       end
 
       sig { params(origin_pathname: Pathname, new_package_root: Pathname).returns(Pathname) }
       def self.destination_pathname_for_package_move(origin_pathname, new_package_root)
-        origin_pack = T.must(ParsePackwerk.package_from_path(origin_pathname))
+        origin_pack = ParsePackwerk.package_from_path(origin_pathname)
 
         if origin_pack.name == ParsePackwerk::ROOT_PACKAGE_NAME
           new_package_root.join(origin_pathname).cleanpath
@@ -27,7 +27,7 @@ module UsePackwerk
 
       sig { params(origin_pathname: Pathname).returns(Pathname) }
       def self.destination_pathname_for_new_public_api(origin_pathname)
-        origin_pack = T.must(ParsePackwerk.package_from_path(origin_pathname))
+        origin_pack = ParsePackwerk.package_from_path(origin_pathname)
         if origin_pack.name == ParsePackwerk::ROOT_PACKAGE_NAME
           filepath_without_pack_name = origin_pathname.to_s
         else

data/lib/use_packwerk/private/interactive_cli/use_cases/visualize.rb

@@ -0,0 +1,44 @@
+# typed: strict
+
+require 'visualize_packwerk'
+
+module UsePackwerk
+  module Private
+    module InteractiveCli
+      module UseCases
+        class Visualize
+          extend T::Sig
+          extend T::Helpers
+          include Interface
+
+          sig { override.params(prompt: TTY::Prompt).void }
+          def perform!(prompt)
+            teams_or_packs = prompt.select('Do you want the graph nodes to be teams or packs?', %w[Teams Packs])
+
+            if teams_or_packs == 'Teams'
+              teams = TeamSelector.multi_select(prompt)
+              VisualizePackwerk.team_graph!(teams)
+            else
+              by_name_or_by_owner = prompt.select('Do you select packs by name or by owner?', ['By name', 'By owner'])
+              if by_name_or_by_owner == 'By owner'
+                teams = TeamSelector.multi_select(prompt)
+                selected_packs = ParsePackwerk.all.select do |p|
+                  teams.map(&:name).include?(CodeOwnership.for_package(p)&.name)
+                end
+              else
+                selected_packs = PackSelector.single_or_all_pack_multi_select(prompt)
+              end
+
+              VisualizePackwerk.package_graph!(selected_packs)
+            end
+          end
+
+          sig { override.returns(String) }
+          def user_facing_name
+            'Visualize pack relationships'
+          end
+        end
+      end
+    end
+  end
+end

data/lib/use_packwerk/private/interactive_cli.rb

@@ -18,6 +18,7 @@ require 'use_packwerk/private/interactive_cli/use_cases/update_deprecations'
 require 'use_packwerk/private/interactive_cli/use_cases/validate'
 require 'use_packwerk/private/interactive_cli/use_cases/regenerate_rubocop_todo'
 require 'use_packwerk/private/interactive_cli/use_cases/lint_package_yml'
+require 'use_packwerk/private/interactive_cli/use_cases/visualize'
 
 module UsePackwerk
   module Private

data/lib/use_packwerk/private/pack_relationship_analyzer.rb

@@ -35,7 +35,7 @@ module UsePackwerk
 
         # TODO: This is a copy of the implementation below. We may want to refactor out this implementation detail before making changes that apply to both.
         all_packages.each do |client_package|
-          PackageProtections::ProtectedPackage.from(client_package).violations.select(&:privacy?).each do |violation|
+          client_package.violations.select(&:privacy?).each do |violation|
             next unless to_package_names.include?(violation.to_package_name)
 
             if pack_name.nil?
@@ -99,7 +99,7 @@ module UsePackwerk
 
         # TODO: This is a copy of the implementation above. We may want to refactor out this implementation detail before making changes that apply to both.
         all_packages.each do |client_package|
-          PackageProtections::ProtectedPackage.from(client_package).violations.select(&:dependency?).each do |violation|
+          client_package.violations.select(&:dependency?).each do |violation|
             next unless to_package_names.include?(violation.to_package_name)
 
             if pack_name.nil?

data/lib/use_packwerk/private/packwerk_wrapper.rb

@@ -64,7 +64,7 @@ module UsePackwerk
 
       sig { params(files: T::Array[String]).returns(T::Array[String]) }
       def self.package_names_for_files(files)
-        files.map { |f| ParsePackwerk.package_from_path(f)&.name }.compact.uniq
+        files.map { |f| ParsePackwerk.package_from_path(f).name }.compact.uniq
       end
     end
   end

data/lib/use_packwerk/private.rb

@@ -228,7 +228,7 @@ module UsePackwerk
           end
 
           file_move_operations = file_paths.map do |path|
-            package = T.must(ParsePackwerk.package_from_path(path))
+            package = ParsePackwerk.package_from_path(path)
             origin_pathname = Pathname.new(path).cleanpath
 
             FileMoveOperation.new(
@@ -361,8 +361,7 @@ module UsePackwerk
         )
 
         ParsePackwerk.write_package_yml!(package)
-        PackageProtections.set_defaults!([package], verbose: false)
-        package = rewrite_package_with_original_packwerk_values(package)
+        RuboCop::Packs.set_default_rubocop_yml(packs: [package])
 
         current_contents = package.yml.read
         new_contents = current_contents.gsub('MyTeam', 'MyTeam # specify your team here, or delete this key if this package is not owned by one team')
@@ -373,23 +372,6 @@ module UsePackwerk
       existing_package
     end
 
-    sig { params(original_package: ParsePackwerk::Package).returns(ParsePackwerk::Package) }
-    def self.rewrite_package_with_original_packwerk_values(original_package)
-      ParsePackwerk.bust_cache!
-      package_with_protection_defaults = T.must(ParsePackwerk.all.find { |p| p.name == original_package.name })
-      # PackageProtections also sets `enforce_privacy` and `enforce_dependency` to be true, so we set these back down to their original values
-      package = ParsePackwerk::Package.new(
-        enforce_dependencies: original_package.enforce_dependencies,
-        enforce_privacy: original_package.enforce_privacy,
-        dependencies: original_package.dependencies,
-        metadata: package_with_protection_defaults.metadata,
-        name: original_package.name
-      )
-
-      ParsePackwerk.write_package_yml!(package)
-      package
-    end
-
     sig { void }
     def self.load_client_configuration
       @loaded_client_configuration ||= T.let(false, T.nilable(T::Boolean))

data/lib/use_packwerk/user_event_logger.rb

@@ -122,7 +122,7 @@ module UsePackwerk
         Anything that is considered private should go in other folders.
 
         If another pack uses classes, constants, or modules that are not in your public folder, it will be considered a "privacy violation" by packwerk.
-        You can prevent other packs from using private API by using package_protections.
+        You can prevent other packs from using private API by using packwerk.
 
         Want to find how your private API is being used today?
         Try running: `bin/use_packwerk list_top_privacy_violations #{pack_name}`

data/lib/use_packwerk.rb

@@ -10,7 +10,7 @@ require 'colorized_string'
 require 'parse_packwerk'
 require 'code_teams'
 require 'code_ownership'
-require 'package_protections'
+require 'rubocop-packs'
 
 # Private implementation requires
 require 'use_packwerk/private'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: use_packwerk
 version: !ruby/object:Gem::Version
-  version: 0.60.1
+  version: 0.62.0
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-10-31 00:00:00.000000000 Z
+date: 2022-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_ownership
@@ -39,35 +39,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: package_protections
+  name: packwerk
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.2.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.2.1
 - !ruby/object:Gem::Dependency
-  name: packwerk
+  name: parse_packwerk
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.1
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.1
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: parse_packwerk
+  name: rubocop-packs
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop-packs
+  name: sorbet-runtime
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sorbet-runtime
+  name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +109,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: thor
+  name: tty-prompt
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -123,7 +123,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: tty-prompt
+  name: visualize_packwerk
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -288,6 +288,8 @@ extra_rdoc_files: []
 files:
 - README.md
 - bin/packs
+- bin/rubocop
+- bin/tapioca
 - bin/use_packwerk
 - lib/use_packwerk.rb
 - lib/use_packwerk/cli.rb
@@ -314,6 +316,7 @@ files:
 - lib/use_packwerk/private/interactive_cli/use_cases/rename.rb
 - lib/use_packwerk/private/interactive_cli/use_cases/update_deprecations.rb
 - lib/use_packwerk/private/interactive_cli/use_cases/validate.rb
+- lib/use_packwerk/private/interactive_cli/use_cases/visualize.rb
 - lib/use_packwerk/private/pack_relationship_analyzer.rb
 - lib/use_packwerk/private/packwerk_wrapper.rb
 - lib/use_packwerk/private/packwerk_wrapper/offenses_aggregator_formatter.rb