use_packs 0.0.16 → 0.0.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e985f265dd9fc9a580f8ebe329bb89a41b3445a67ca4b4416cb627c7adf3ce6e
-  data.tar.gz: 31da3a703da54e26119c1075fb27b24aed4dd0b76c93af12c8b8de827b229d2e
+  metadata.gz: 4fb20cd9cb35a011b3acb88be1b604f9057d7328d9d0c15b096490afa5f69a3e
+  data.tar.gz: 1501aefe2f6e0f4050c5f514cbcdeae591252102b6b06c45c417ff8a7e0b616f
 SHA512:
-  metadata.gz: 4ead72b2296e414cbc512c476ff11e0df9ac53b7407920534742d9039e917998d2e329758666c3a201a339b1c6359189303b8b5b1661265441246c67425d6ea1
-  data.tar.gz: e54e4771949e4d9ff229fd1c440e09a9ba042deebf1636a0e3bf1e8a2205078243dcb265d07f48357cb6e44babbd55dc1b6f8ce7013316eec7427f63ab8fb039
+  metadata.gz: a70a73019026886d08e0eadc22bf96cc2e27ca3d2f6213dd0f7f5996335f11bd0986de2ddf6874f772c8edc55e437c3750e854768a45d495528738ead07e0cf7
+  data.tar.gz: 3c93acc23b81dc09d3cdc8ce225f5db095d4887f6f9b231a9bddf8dc32457aa302ac87fea155b25ba9c81c0855fa535e8ed5cabbb67ea270c6cea1c50c91c1f0

data/lib/use_packs/private.rb

@@ -324,7 +324,9 @@ module UsePacks
       elsif !origin.exist? && destination.exist?
         Logging.print ColorizedString.new("[SKIP] Not moving #{origin}, does not exist, (#{destination} already exists)").red
       else
-        Logging.print ColorizedString.new("[SKIP] Not moving #{origin}, does not exist").red
+        # We could choose to print this in a `--verbose` mode. For now, we find that printing this text in red confuses folks more than it informs them.
+        # This is because it's perfectly common for a spec to not exist for a file, so at best it's a warning.
+        # Logging.print ColorizedString.new("[SKIP] Not moving #{origin}, does not exist").red
       end
     end
 
@@ -529,7 +531,7 @@ module UsePacks
 
       if diff == ''
         # No diff generated by `update-todo`
-        exit 0
+        safe_exit 0
       else
         output = <<~OUTPUT
           All `package_todo.yml` files must be up-to-date and that no diff is generated when running `bin/packwerk update-todo`.
@@ -551,8 +553,7 @@ module UsePacks
 
         puts output
         UsePacks.config.on_package_todo_lint_failure.call(output)
-
-        exit 1
+        safe_exit 1
       end
     end
 
@@ -577,6 +578,12 @@ module UsePacks
         5. Please let us know if anything is missing.
       WARNING
     end
+
+    # This function exists to give us something to stub in test
+    sig { params(code: Integer).void }
+    def self.safe_exit(code)
+      exit code
+    end
   end
 
   private_constant :Private

data/lib/use_packs/rubocop_post_processor.rb

@@ -7,6 +7,8 @@ module UsePacks
 
     sig { override.params(file_move_operation: Private::FileMoveOperation).void }
     def before_move_file!(file_move_operation)
+      return unless rubocop_enabled?
+
       relative_path_to_origin = file_move_operation.origin_pathname
       relative_path_to_destination = file_move_operation.destination_pathname
 
@@ -50,6 +52,8 @@ module UsePacks
 
     sig { params(file_move_operations: T::Array[Private::FileMoveOperation]).void }
     def after_move_files!(file_move_operations)
+      return unless rubocop_enabled?
+
       # There could also be no TODOs for this file, but moving it produced TODOs. This could happen if:
       # 1) The origin pack did not enforce a rubocop, such as typed public APIs
       # 2) The file satisfied the cop in the origin pack, such as the Packs/RootNamespaceIsPackName, but the desired
@@ -63,5 +67,10 @@ module UsePacks
 
       RuboCop::Packs.regenerate_todo(files: files)
     end
+
+    sig { returns(T::Boolean) }
+    def rubocop_enabled?
+      Pathname.new('.rubocop.yml').exist?
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: use_packs
 version: !ruby/object:Gem::Version
-  version: 0.0.16
+  version: 0.0.18
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-17 00:00:00.000000000 Z
+date: 2023-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_ownership