use_packs 0.0.12 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5f98eb76891cbb942fb3d546c0b8a8aa15be6a8cd6068b84717e808a66a7fc55
-  data.tar.gz: 967fe01ab77ca126919f70b92d578eb479a290c3d858bcfff502dd4c333a5c25
+  metadata.gz: fb4b5cfe33a3c5881971d27c78fefe591378e9728baf6513beffc14058ef23d6
+  data.tar.gz: 15144da46c38e628af6bfc3c5243d8d0c42a46b2fa739b66339fb120e31c6d36
 SHA512:
-  metadata.gz: c0997685aee1f0f5be74164cce68fe0517c73f3635619696ddd1e4a0bc1b4be1c5143882ba3888bd5661d767ebc5f856bc29de516f621fe0d45f5a4ab28d91a9
-  data.tar.gz: d6031d17ba30549dd813e240aa558330ad0e0233c6ec5437ecd215b26f9d09a1c79b658262fa74457e5b9985d8aa7bdf3c2f9065787e81d87ffd43b5006a12e1
+  metadata.gz: ce3dbd0c9c3b103887e0ff3e84421396cc3e711b4cac3626e34e622d403ab806eb63ec50e3bb4daf64b647d7f991d940e5973e60cd28e1a8b1a4880635be2525
+  data.tar.gz: 9f38e2e00c87dc857a279a726bd7539d5344a0a51dbd5acfeac4153194dcaef5bcab1e577c9a11417963602f652d7559e33a9dba5a77f6372bec066e8ac058c2

data/README.md

@@ -50,16 +50,16 @@ Releases happen automatically through github actions once a version update is co
 To keep things organized, here are some recommended homes:
 
 ### Issues:
-https://github.com/Gusto/use_packs/issues
+https://github.com/rubyatscale/use_packs/issues
 
 ### Questions:
-https://github.com/Gusto/use_packs/discussions/categories/q-a
+https://github.com/rubyatscale/use_packs/discussions/categories/q-a
 
 ### General discussions:
-https://github.com/Gusto/use_packs/discussions/categories/general
+https://github.com/rubyatscale/use_packs/discussions/categories/general
 
 ### Ideas, new features, requests for change:
-https://github.com/Gusto/use_packs/discussions/categories/ideas
+https://github.com/rubyatscale/use_packs/discussions/categories/ideas
 
 ### Showcasing your work:
-https://github.com/Gusto/use_packs/discussions/categories/show-and-tell
+https://github.com/rubyatscale/use_packs/discussions/categories/show-and-tell

data/lib/use_packs/cli.rb

@@ -118,9 +118,9 @@ module UsePacks
 
     # This is used by thor to know that these private methods are not intended to be CLI commands
     no_commands do
-      sig { params(pack_names: T::Array[String]).returns(T::Array[ParsePackwerk::Package]) }
+      sig { params(pack_names: T::Array[String]).returns(T::Array[Packs::Pack]) }
       def parse_pack_names(pack_names)
-        pack_names.empty? ? ParsePackwerk.all : pack_names.map { |p| ParsePackwerk.find(p.gsub(%r{/$}, '')) }.compact
+        pack_names.empty? ? Packs.all : pack_names.map { |p| Packs.find(p.gsub(%r{/$}, '')) }.compact
       end
     end
   end

data/lib/use_packs/code_ownership_post_processor.rb

@@ -17,14 +17,13 @@ module UsePacks
       relative_path_to_destination = file_move_operation.destination_pathname
 
       code_owners_allow_list_file = Pathname.new('config/code_ownership.yml')
+      return if !code_owners_allow_list_file.exist?
 
-      if code_owners_allow_list_file.exist?
-        UsePacks.replace_in_file(
-          file: code_owners_allow_list_file.to_s,
-          find: relative_path_to_origin,
-          replace_with: relative_path_to_destination
-        )
-      end
+      UsePacks.replace_in_file(
+        file: code_owners_allow_list_file.to_s,
+        find: relative_path_to_origin,
+        replace_with: relative_path_to_destination
+      )
 
       team = CodeOwnership.for_file(relative_path_to_origin.to_s)
 
@@ -34,7 +33,8 @@ module UsePacks
         @teams << 'Unknown'
       end
 
-      if !CodeOwnership.for_package(file_move_operation.destination_pack).nil?
+      pack = Packs.find(file_move_operation.destination_pack.name)
+      if pack && !CodeOwnership.for_package(pack).nil?
         CodeOwnership.remove_file_annotation!(relative_path_to_origin.to_s)
         @did_move_files = true
       end

data/lib/use_packs/private/interactive_cli/pack_selector.rb

@@ -6,9 +6,9 @@ module UsePacks
       class PackSelector
         extend T::Sig
 
-        sig { params(prompt: TTY::Prompt, question_text: String).returns(ParsePackwerk::Package) }
+        sig { params(prompt: TTY::Prompt, question_text: String).returns(Packs::Pack) }
         def self.single_pack_select(prompt, question_text: 'Please use space to select a pack')
-          packs = ParsePackwerk.all.to_h { |t| [t.name, t] }
+          packs = Packs.all.to_h { |t| [t.name, t] }
 
           pack_selection = T.let(prompt.select(
             question_text,
@@ -16,7 +16,7 @@ module UsePacks
             filter: true,
             per_page: 10,
             show_help: :always
-          ), T.nilable(ParsePackwerk::Package))
+          ), T.nilable(Packs::Pack))
 
           while pack_selection.nil?
             prompt.error(
@@ -29,15 +29,15 @@ module UsePacks
           pack_selection
         end
 
-        sig { params(prompt: TTY::Prompt, question_text: String).returns(T::Array[ParsePackwerk::Package]) }
+        sig { params(prompt: TTY::Prompt, question_text: String).returns(T::Array[Packs::Pack]) }
         def self.single_or_all_pack_multi_select(prompt, question_text: 'Please use space to select one or more packs')
           pack_selection = T.let(prompt.multi_select(
             question_text,
-            ParsePackwerk.all.to_h { |t| [t.name, t] },
+            Packs.all.to_h { |t| [t.name, t] },
             filter: true,
             per_page: 10,
             show_help: :always
-          ), T::Array[ParsePackwerk::Package])
+          ), T::Array[Packs::Pack])
 
           while pack_selection.empty?
             prompt.error(

data/lib/use_packs/private/interactive_cli/team_selector.rb

@@ -6,9 +6,10 @@ module UsePacks
       class TeamSelector
         extend T::Sig
 
-        sig { params(prompt: TTY::Prompt, question_text: String).returns(CodeTeams::Team) }
+        sig { params(prompt: TTY::Prompt, question_text: String).returns(T.nilable(CodeTeams::Team)) }
         def self.single_select(prompt, question_text: 'Please use space to select a team owner')
           teams = CodeTeams.all.sort_by(&:name).to_h { |t| [t.name, t] }
+          return nil if teams.count == 0
 
           team_selection = T.let(prompt.select(
             question_text,

data/lib/use_packs/private/interactive_cli/use_cases/get_info.rb

@@ -20,7 +20,7 @@ module UsePacks
 
             if team_or_pack == 'By team'
               teams = TeamSelector.multi_select(prompt)
-              selected_packs = ParsePackwerk.all.select do |p|
+              selected_packs = Packs.all.select do |p|
                 teams.map(&:name).include?(CodeOwnership.for_package(p)&.name)
               end
             else
@@ -51,12 +51,13 @@ module UsePacks
             puts "There are #{all_outbound.select(&:privacy?).sum { |v| v.files.count }} total outbound privacy violations"
             puts "There are #{all_outbound.select(&:dependency?).sum { |v| v.files.count }} total outbound dependency violations"
 
-            selected_packs.sort_by { |p| -p.directory.glob('**/*.rb').count }.each do |pack|
+            selected_packs.sort_by { |p| -p.relative_path.glob('**/*.rb').count }.each do |pack|
               puts "\n=========== Info about: #{pack.name}"
+
               owner = CodeOwnership.for_package(pack)
               puts "Owned by: #{owner.nil? ? 'No one' : owner.name}"
-              puts "Size: #{pack.directory.glob('**/*.rb').count} ruby files"
-              puts "Public API: #{pack.directory.join('app/public')}"
+              puts "Size: #{pack.relative_path.glob('**/*.rb').count} ruby files"
+              puts "Public API: #{pack.relative_path.join('app/public')}"
 
               inbound_for_pack = inbound_violations[pack.name] || []
               outbound_for_pack = outbound_violations[pack.name] || []

data/lib/use_packs/private/interactive_cli/use_cases/visualize.rb

@@ -22,14 +22,17 @@ module UsePacks
               by_name_or_by_owner = prompt.select('Do you select packs by name or by owner?', ['By name', 'By owner'])
               if by_name_or_by_owner == 'By owner'
                 teams = TeamSelector.multi_select(prompt)
-                selected_packs = ParsePackwerk.all.select do |p|
+                selected_packs = Packs.all.select do |p|
                   teams.map(&:name).include?(CodeOwnership.for_package(p)&.name)
                 end
               else
                 selected_packs = PackSelector.single_or_all_pack_multi_select(prompt)
               end
 
-              VisualizePackwerk.package_graph!(selected_packs)
+              packwerk_packages = selected_packs.map do |pack|
+                T.must(ParsePackwerk.find(pack.name))
+              end
+              VisualizePackwerk.package_graph!(packwerk_packages)
             end
           end
 

data/lib/use_packs/private.rb

@@ -366,19 +366,28 @@ module UsePacks
       if existing_package.nil?
         should_enforce_dependenceies = enforce_dependencies.nil? ? UsePacks.config.enforce_dependencies : enforce_dependencies
 
+        # TODO: This should probably be `if defined?(CodeOwnership) && CodeOwnership.configured?`
+        # but we'll need to add an API to CodeOwnership to do this
+        if Pathname.new('config/code_ownership.yml').exist?
+          metadata = {
+            'owner' => team.nil? ? 'MyTeam' : team.name
+          }
+        else
+          metadata = {}
+        end
+
         package = ParsePackwerk::Package.new(
           enforce_dependencies: should_enforce_dependenceies,
           enforce_privacy: enforce_privacy,
           dependencies: [],
-          metadata: {
-            'owner' => team.nil? ? 'MyTeam' : team.name
-          },
+          metadata: metadata,
           name: pack_name,
           config: {}
         )
 
         ParsePackwerk.write_package_yml!(package)
-        RuboCop::Packs.set_default_rubocop_yml(packs: [package])
+        pack = Packs.find(package.name)
+        RuboCop::Packs.set_default_rubocop_yml(packs: [pack].compact)
 
         current_contents = package.yml.read
         new_contents = current_contents.gsub('MyTeam', 'MyTeam # specify your team here, or delete this key if this package is not owned by one team')
@@ -452,6 +461,22 @@ module UsePacks
         temp_package_todo_yml.write(contents)
       end
     end
+
+    sig { params(packages: T::Array[ParsePackwerk::Package]).returns(T::Array[Packs::Pack]) }
+    def self.packwerk_packages_to_packs(packages)
+      packs = []
+      packages.each do |package|
+        pack = Packs.find(package.name)
+        packs << pack if !pack.nil?
+      end
+
+      packs
+    end
+
+    sig { params(package: ParsePackwerk::Package).returns(T.nilable(Packs::Pack)) }
+    def self.packwerk_package_to_pack(package)
+      Packs.find(package.name)
+    end
   end
 
   private_constant :Private

data/lib/use_packs.rb

@@ -282,16 +282,19 @@ module UsePacks
     end
   end
 
-  sig { params(packs: T::Array[ParsePackwerk::Package]).void }
+  sig { params(packs: T::Array[Packs::Pack]).void }
   def self.lint_package_yml_files!(packs)
     packs.each do |p|
+      packwerk_package = ParsePackwerk.find(p.name)
+      next if packwerk_package.nil?
+
       new_package = ParsePackwerk::Package.new(
-        name: p.name,
-        enforce_privacy: p.enforce_privacy,
-        enforce_dependencies: p.enforce_dependencies,
-        dependencies: p.dependencies.uniq.sort,
-        metadata: p.metadata,
-        config: p.config
+        name: packwerk_package.name,
+        enforce_privacy: packwerk_package.enforce_privacy,
+        enforce_dependencies: packwerk_package.enforce_dependencies,
+        dependencies: packwerk_package.dependencies.uniq.sort,
+        metadata: packwerk_package.metadata,
+        config: packwerk_package.config
       )
       ParsePackwerk.write_package_yml!(new_package)
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: use_packs
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.14
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-27 00:00:00.000000000 Z
+date: 2023-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_ownership
@@ -38,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: packs
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: packwerk
   requirement: !ruby/object:Gem::Requirement