use_packs 0.0.1 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 88d0834366bd3d1591029828eab623a5781f0ed44a3b8c0b35ab92f131236377
-  data.tar.gz: 8f3dd5181a41f8bd3ff2441fc58c73bac8ec712137a5967b7447d62b9014d653
+  metadata.gz: '006912f2bf892c63364fba8ae22cb6202df72e8fe9bd2a081c8cf5d3610d0fb2'
+  data.tar.gz: 3b4510070e1f6160d8814fe5fea8947481330f8ca05c4bb995bf075930a21454
 SHA512:
-  metadata.gz: 3cb7be9b2014cc3c065d700e19472821acda6b9a41fe73cdf695e52d2d96ee1552aabaf2e123c8f4d4b21c1b469cb26073e8eaa650874d6ded5fbdb63c3a401e
-  data.tar.gz: 6a6a15f8f010a10988eae52796bbbf55326c7a814bc1d0ec3a550edd860cc038fb7eb917860e7629cae1d6b2462901296b5bb163857b3cf955a7c93b6d9ffe21
+  metadata.gz: d685dbd8cc145544a1c5c1116f3ba39f23d9feda347701657eea97a7e44b44a57f778ad452d719d2442edf33c79a8211451a14367624c9a39f6be77d5af23e49
+  data.tar.gz: 25d3c0d781b77ba831ede9f7a01124fd2bdede9737e4d9b0645d2a5080c132d397dd5fcbdc60d2121a22cc556e4cb0256f38d3460e43b07ac2a12c1f09ad7ec9

data/README.md

@@ -43,12 +43,6 @@ If no pack name is passed in, this will list out violations across all packs.
 
 This can be used to quickly modify a `package.yml` file and add a dependency. It also cleans up the list of dependencies to sort the list and remove redundant entries.
 
-### Setting up Spring
-
-[Spring](https://github.com/rails/spring) is a preloader for Rails. Although `use_packs` itself does not use `Rails`, this can help speed up running commands like `bin/packs` by caching the bundle.
-Firstly, spring needs to know about the `bin/packs` command when spring is loading. To do that, add `require 'use_packs/spring_command'` to `config/spring.rb` in your application.
-Secondly, to enable Spring, first run `bin/spring binstub packs` which will "springify" the generated binstub.
-
 ### Releasing
 Releases happen automatically through github actions once a version update is committed to `main`.
 

data/lib/use_packs/private/interactive_cli/pack_selector.rb

@@ -7,26 +7,47 @@ module UsePacks
         extend T::Sig
 
         sig { params(prompt: TTY::Prompt, question_text: String).returns(ParsePackwerk::Package) }
-        def self.single_pack_select(prompt, question_text: 'Please select a pack')
+        def self.single_pack_select(prompt, question_text: 'Please use space to select a pack')
           packs = ParsePackwerk.all.to_h { |t| [t.name, t] }
-          prompt.select(
+
+          pack_selection = T.let(prompt.select(
             question_text,
             packs,
             filter: true,
             per_page: 10,
             show_help: :always
-          )
+          ), T.nilable(ParsePackwerk::Package))
+
+          while pack_selection.nil?
+            prompt.error(
+              'No packs were selected, please select a pack using the space key before pressing enter.'
+            )
+
+            pack_selection = single_pack_select(prompt, question_text: question_text)
+          end
+
+          pack_selection
         end
 
         sig { params(prompt: TTY::Prompt, question_text: String).returns(T::Array[ParsePackwerk::Package]) }
-        def self.single_or_all_pack_multi_select(prompt, question_text: 'Please select one or more packs')
-          prompt.multi_select(
+        def self.single_or_all_pack_multi_select(prompt, question_text: 'Please use space to select one or more packs')
+          pack_selection = T.let(prompt.multi_select(
             question_text,
             ParsePackwerk.all.to_h { |t| [t.name, t] },
             filter: true,
             per_page: 10,
             show_help: :always
-          )
+          ), T::Array[ParsePackwerk::Package])
+
+          while pack_selection.empty?
+            prompt.error(
+              'No packs were selected, please select one or more packs using the space key before pressing enter.'
+            )
+
+            pack_selection = single_or_all_pack_multi_select(prompt, question_text: question_text)
+          end
+
+          pack_selection
         end
       end
     end

data/lib/use_packs/private/interactive_cli/team_selector.rb

@@ -7,27 +7,49 @@ module UsePacks
         extend T::Sig
 
         sig { params(prompt: TTY::Prompt, question_text: String).returns(CodeTeams::Team) }
-        def self.single_select(prompt, question_text: 'Please select a team owner')
+        def self.single_select(prompt, question_text: 'Please use space to select a team owner')
           teams = CodeTeams.all.sort_by(&:name).to_h { |t| [t.name, t] }
-          prompt.select(
+
+          team_selection = T.let(prompt.select(
             question_text,
             teams,
             filter: true,
             per_page: 10,
             show_help: :always
-          )
+          ), T.nilable(CodeTeams::Team))
+
+          while team_selection.nil?
+            prompt.error(
+              'No owners were selected, please select an owner using the space key before pressing enter.'
+            )
+
+            team_selection = single_select(prompt, question_text: question_text)
+          end
+
+          team_selection
         end
 
         sig { params(prompt: TTY::Prompt, question_text: String).returns(T::Array[CodeTeams::Team]) }
-        def self.multi_select(prompt, question_text: 'Please select team owners')
+        def self.multi_select(prompt, question_text: 'Please use space to select team owners')
           teams = CodeTeams.all.to_h { |t| [t.name, t] }
-          prompt.multi_select(
+
+          team_selection = T.let(prompt.multi_select(
             question_text,
             teams,
             filter: true,
             per_page: 10,
             show_help: :always
-          )
+          ), T::Array[CodeTeams::Team])
+
+          while team_selection.empty?
+            prompt.error(
+              'No owners were selected, please select one or more owners using the space key before pressing enter.'
+            )
+
+            team_selection = multi_select(prompt, question_text: question_text)
+          end
+
+          team_selection
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: use_packs
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.3
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-09 00:00:00.000000000 Z
+date: 2022-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_ownership
@@ -319,7 +319,6 @@ files:
 - lib/use_packs/private/packwerk_wrapper.rb
 - lib/use_packs/private/packwerk_wrapper/offenses_aggregator_formatter.rb
 - lib/use_packs/rubocop_post_processor.rb
-- lib/use_packs/spring_command.rb
 - lib/use_packs/user_event_logger.rb
 homepage: https://github.com/rubyatscale/use_packs
 licenses:

data/lib/use_packs/spring_command.rb

@@ -1,28 +0,0 @@
-# typed: true
-# frozen_string_literal: true
-
-require 'spring/commands'
-
-module UsePacks
-  class SpringCommand
-    def env(*)
-      # Packwerk needs to run in a test environment, which has a set of autoload paths that are
-      # often a superset of the dev/prod paths (for example, test/support/helpers)
-      'test'
-    end
-
-    def exec_name
-      'packs'
-    end
-
-    def gem_name
-      'use_packs'
-    end
-
-    def call
-      load(Gem.bin_path(gem_name, exec_name))
-    end
-  end
-
-  Spring.register_command('packs', SpringCommand.new)
-end