us_bank_holidays 0.0.5 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: b60841173b3f8f7871352347c1182b85a23dc144
-  data.tar.gz: 0aaa072931196f5f0f6a342efb0f4ae831280097
+SHA256:
+  metadata.gz: 8db39160147df2816e65af1fd851ff2fdc9488bdc189101c7bc03e86395a0189
+  data.tar.gz: ad4e2585e1539f8d82e8f1b11dd1b10b9625c57f019e85944a1b961baf699af9
 SHA512:
-  metadata.gz: 4a523666e1a6f5b81383b8592c13de633e55a8101bbfc8e2fae9daa2acd651e172d2b45f6fa9897169394b6faed24de7ad3be0cea54118bbada2be319176a08f
-  data.tar.gz: c075e3c186c6420301a838125a6ba02cd993ac412ba269155ea42341450d6f00ca9f7d2d2fe68b5b8b6f457290f8c5ce5f097c9bbdb1c60fb0bf80961bf77e36
+  metadata.gz: 5f4933efb849b3df1673ccf858494d9ba183baa980193a980a15ccb0adf51d3527b42ce4a8c93a23bb402b0399f0510d14aaebf6c38f0a8b875a6172b7f43703
+  data.tar.gz: b78c5d1a86ae39a7307155580d8c33b15d0feb317fee9a680a1fbb7bcb20ee60a14b2e7444d11020937b2a5222bd1f31ec3cd2cdbf6c4028d18badd6ace3973f

data/.travis.yml

@@ -1,9 +1,9 @@
 language: ruby
 script: 'bundle exec rake spec'
 rvm:
-  - 1.9.3
-  - 2.0.0
-  - 2.1.0
+  - 2.3
+  - 2.4
+  - 2.5
   - jruby
   - rbx
 matrix:

data/README.md

@@ -12,8 +12,8 @@ Patches `Date` to make working with US bank holidays easier
 
 Tested against the following Ruby runtimes:
 
-* MRI 1.9.3, 2.0.0, 2.1.0
-* JRuby 1.7+
+* MRI 2.3, 2.4, 2.5
+* JRuby 9 
 * Rubinius (latest)
 
 ## Installation
@@ -46,6 +46,8 @@ date.bank_holiday?                        # Returns false
 date.weekend?                             # Returns false
 date.next_banking_day                     # Returns Monday, January 6, 2014
 date.banking_day?                         # Returns true
+date.first_banking_day_of_month?          # Returns false
+date.last_banking_day_of_month?           # Returns false
 
 Date.new(2014, 1, 16).add_banking_days(2) # Returns Tuesday, January 21, 2014
 Date.new(2014, 1, 5).previous_banking_day # Returns Friday, January 3, 2014

data/lib/us_bank_holidays/holiday_year.rb

@@ -9,6 +9,7 @@ module UsBankHolidays
                 :mlk_day,
                 :washingtons_birthday,
                 :memorial_day,
+                :juneteenth,
                 :independence_day,
                 :labor_day,
                 :columbus_day,
@@ -26,26 +27,27 @@ module UsBankHolidays
     end
 
     # Returns the federal holidays for the given year on the dates they will actually
-    # be observed. In the event that New Year's Day for the following year falls on a
-    # Saturday December 31 will also be included.
+    # be observed.
     def bank_holidays
       @bank_holidays ||= begin
-        holidays = [ new_years_day,
-          mlk_day,
-          washingtons_birthday,
-          memorial_day,
-          independence_day,
-          labor_day,
-          columbus_day,
-          veterans_day,
-          thanksgiving,
-          christmas
-        ]
-        if Date.new(year + 1, 1, 1).saturday?
-          holidays << Date.new(year, 12, 31)
-        end
-        holidays.freeze
-      end
+                           holidays = [
+                             new_years_day,
+                             mlk_day,
+                             washingtons_birthday,
+                             memorial_day,
+                             juneteenth,
+                             independence_day,
+                             labor_day,
+                             columbus_day,
+                             veterans_day,
+                             thanksgiving,
+                             christmas
+                           ].compact
+                           if Date.new(year + 1, 1, 1).saturday? && ::UsBankHolidays.saturday_holiday_date_rolling?
+                             holidays << Date.new(year, 12, 31)
+                           end
+                           holidays.freeze
+                         end
     end
 
     {
@@ -97,7 +99,10 @@ module UsBankHolidays
         # First of the year, rolls either forward or back.
         @new_years_day    = roll_nominal(Date.new(year, 1, 1))
 
-        # 4'th of July
+        # 19th of June
+        @juneteenth       = (year > 2020 ? roll_nominal(Date.new(year, 6, 19))  : nil )
+
+        # 4th of July
         @independence_day = roll_nominal(Date.new(year, 7, 4))
 
         # November 11
@@ -107,11 +112,12 @@ module UsBankHolidays
         @christmas        = roll_nominal(Date.new(year, 12, 25))
       end
 
-      # Figures out where to roll the given nominal date. If it's a Saturday, assumes
-      # it's the day before (Friday), if Sunday it's the date after (Monday), otherwise
+      # Figures out where to roll the given nominal date. If it's a Saturday and
+      # Saturday holiday date rolling is enabled (see UsBankHolidays#saturday_holiday_date_rolling?),
+      # assumes it's the day before (Friday), if Sunday it's the date after (Monday), otherwise
       # just returns self.
       def roll_nominal(nominal)
-        if nominal.saturday?
+        if nominal.saturday? && ::UsBankHolidays.saturday_holiday_date_rolling?
           nominal - 1
         elsif nominal.sunday?
           nominal + 1

data/lib/us_bank_holidays/version.rb

@@ -1,3 +1,3 @@
 module UsBankHolidays
-  VERSION = "0.0.5"
+  VERSION = "0.2.1"
 end

data/lib/us_bank_holidays.rb

@@ -14,6 +14,8 @@ module UsBankHolidays
   # Returns true if the given date is a bank holiday, false otherwise.
   # Pass the optional 'include_weekends' to control whether weekends should count as
   # bank holidays (default is true).
+  # If include_weekends is set to false but the date is a Federal bank holiday,
+  # returns true (Ex: 4th of July, 2015, Christmas Day 2016)
   def self.bank_holiday?(date, include_weekends = true)
     if include_weekends && weekend?(date)
       true
@@ -44,6 +46,12 @@ module UsBankHolidays
     end
   end
 
+  # If enabled (ENV["NO_FRIDAY_HOLIDAY_ACH"]), a Friday that falls a day before
+  # a Saturday that's a bank holiday is considered a bank holiday
+  def self.saturday_holiday_date_rolling?
+    !!ENV["NO_FRIDAY_HOLIDAY_ACH"]
+  end
+
   # Instance methods to be injected into the Date class
   module DateMethods
 
@@ -55,6 +63,8 @@ module UsBankHolidays
     # Returns true if the date is a bank holiday, false otherwise.
     # Pass the optional 'include_weekends' to control whether weekends should count as
     # bank holidays (default is true).
+    # If include_weekends is set to false but the date is a Federal bank holiday,
+    # returns true (Ex: 4th of July, 2015, Christmas Day 2016)
     def bank_holiday?(include_weekends = true)
       ::UsBankHolidays.bank_holiday? self, include_weekends
     end
@@ -87,6 +97,16 @@ module UsBankHolidays
     def banking_day?
       !bank_holiday?
     end
+
+    # Returns true if the date is the last banking day of the month, false otherwise.
+    def last_banking_day_of_month?
+      !bank_holiday? && next_banking_day.month != month
+    end
+
+    # Returns true if the date is the first banking day of the month, false otherwise.
+    def first_banking_day_of_month?
+      !bank_holiday? && previous_banking_day.month != month
+    end
   end
 
 end

data/spec/functional/holiday_year_spec.rb

@@ -1,24 +1,109 @@
 require 'spec_helper'
 
-describe UsBankHolidays::HolidayYear do
-
-  it 'should determine bank holidays' do
-    UsBankHolidays::HolidayYear.new(2017).bank_holidays.should == [
-      '2017-01-02', #New Year’s Day
-                                          '2017-01-16', #Birthday of Martin Luther King, Jr.
-                                          '2017-02-20', #Washington’s Birthday
-                                          '2017-05-29', #Memorial Day
-                                          '2017-07-04', #Independence Day
-                                          '2017-09-04', #Labor Day
-                                          '2017-10-09', #Columbus Day
-                                          '2017-11-10', #Veterans Day
-                                          '2017-11-23', #Thanksgiving Day
-                                          '2017-12-25' #Christmas Day
-    ].map{|d| Date.parse(d) }
-  end
+RSpec.describe UsBankHolidays::HolidayYear do
+
+  context "should determine bank holidays" do
+
+    context "Before 2021" do
+
+      context "Force Saturday date rolling" do
+        before :each do
+          allow(::UsBankHolidays).to receive(:saturday_holiday_date_rolling?).and_return(true)
+        end
+
+        it 'should determine bank holidays' do
+          expect(UsBankHolidays::HolidayYear.new(2017).bank_holidays).to eq([
+                                                                              '2017-01-02', #New Year’s Day
+                                                                              '2017-01-16', #Birthday of Martin Luther King, Jr.
+                                                                              '2017-02-20', #Washington’s Birthday
+                                                                              '2017-05-29', #Memorial Day
+                                                                              '2017-07-04', #Independence Day
+                                                                              '2017-09-04', #Labor Day
+                                                                              '2017-10-09', #Columbus Day
+                                                                              '2017-11-10', #Veterans Day
+                                                                              '2017-11-23', #Thanksgiving Day
+                                                                              '2017-12-25' #Christmas Day
+                                                                            ].map { |d| Date.parse(d) }
+                                                                         )
+        end
+
+      end
+
+      context "No Saturday date rolling" do
+        it 'should determine bank holidays' do
+          expect(UsBankHolidays::HolidayYear.new(2017).bank_holidays).to eq([
+                                                                              '2017-01-02', #New Year’s Day
+                                                                              '2017-01-16', #Birthday of Martin Luther King, Jr.
+                                                                              '2017-02-20', #Washington’s Birthday
+                                                                              '2017-05-29', #Memorial Day
+                                                                              '2017-07-04', #Independence Day
+                                                                              '2017-09-04', #Labor Day
+                                                                              '2017-10-09', #Columbus Day
+                                                                              '2017-11-11', #Veterans Day
+                                                                              '2017-11-23', #Thanksgiving Day
+                                                                              '2017-12-25' #Christmas Day
+                                                                            ].map { |d| Date.parse(d) }
+                                                                         )
+        end
+
+      end
+
+    end
+
+    context "2021 and later" do
+
+      context "Force Saturday date rolling" do
+
+        before :each do
+          allow(::UsBankHolidays).to receive(:saturday_holiday_date_rolling?).and_return(true)
+        end
+
+        it 'should determine bank holidays' do
+          expect(UsBankHolidays::HolidayYear.new(2021).bank_holidays).to eq([
+                                                                              '2021-01-01', #New Year’s Day
+                                                                              '2021-01-18', #Birthday of Martin Luther King, Jr.
+                                                                              '2021-02-15', #Washington’s Birthday
+                                                                              '2021-05-31', #Memorial Day
+                                                                              '2021-06-18', #Juneteenth
+                                                                              '2021-07-05', #Independence Day
+                                                                              '2021-09-06', #Labor Day
+                                                                              '2021-10-11', #Columbus Day
+                                                                              '2021-11-11', #Veterans Day
+                                                                              '2021-11-25', #Thanksgiving Day
+                                                                              '2021-12-24', #Christmas Day
+                                                                              '2021-12-31'  #New Year’s Day
+                                                                            ].map { |d| Date.parse(d) }
+                                                                         )
+        end
+
+      end
+
+      context "No Saturday date rolling" do
+        before :each do
+          allow(::UsBankHolidays).to receive(:saturday_holiday_date_rolling?).and_return(false)
+        end
+
+        it 'should determine bank holidays' do
+          expect(UsBankHolidays::HolidayYear.new(2021).bank_holidays).to eq([
+                                                                              '2021-01-01', #New Year’s Day
+                                                                              '2021-01-18', #Birthday of Martin Luther King, Jr.
+                                                                              '2021-02-15', #Washington’s Birthday
+                                                                              '2021-05-31', #Memorial Day
+                                                                              '2021-06-19', #Juneteenth
+                                                                              '2021-07-05', #Independence Day
+                                                                              '2021-09-06', #Labor Day
+                                                                              '2021-10-11', #Columbus Day
+                                                                              '2021-11-11', #Veterans Day
+                                                                              '2021-11-25', #Thanksgiving Day
+                                                                              '2021-12-25' #Christmas Day
+                                                                            ].map { |d| Date.parse(d) }
+                                                                         )
+        end
+
+      end
+
+    end
 
-  it 'should declare Dec. 31 a bank holiday if it falls on a Friday' do
-    UsBankHolidays::HolidayYear.new(2021).bank_holidays.last.should == Date.new(2021, 12, 31)
   end
 
   context 'Months' do
@@ -39,7 +124,7 @@ describe UsBankHolidays::HolidayYear do
       :december  => 12
     }.each do |month_name, month_index|
       it "should respond to '#{month_name}' and return the right month" do
-        year.respond_to?(month_name).should be_true
+        expect(year.respond_to?(month_name)).to eq(true)
         month = year.send(month_name)
         month.year.should  == 2014
         month.month.should == month_index

data/spec/functional/month_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe UsBankHolidays::Month do
+RSpec.describe UsBankHolidays::Month do
   let(:january) { UsBankHolidays::Month.new(2014, 1) }
 
   it 'should record the correct month' do
@@ -23,19 +23,19 @@ describe UsBankHolidays::Month do
 
     it 'should return true if the month contains the given date' do
       (1..31).each do |mday|
-        january.contains?(Date.new(january.year, january.month, mday)).should be_true
+        january.contains?(Date.new(january.year, january.month, mday)).should eq(true)
       end
     end
 
     it 'should return false if the month is not the same' do
       (1..31).each do |mday|
-        january.contains?(Date.new(2014, 8, mday)).should be_false
+        january.contains?(Date.new(2014, 8, mday)).should eq(false)
       end
     end
 
     it 'should return false if the year is not the same' do
       (1..31).each do |mday|
-        january.contains?(Date.new(2015, 1, mday)).should be_false
+        january.contains?(Date.new(2015, 1, mday)).should eq(false)
       end
     end
   end
@@ -113,4 +113,4 @@ Su Mo Tu We Th Fr Sa
 
     end
   end
-end
+end

data/spec/functional/us_bank_holidays_spec.rb

@@ -1,221 +1,282 @@
 require 'spec_helper'
 
-describe UsBankHolidays do
-  let(:sample_holidays) {
-    [
-      '2014-01-01', #New Year’s Day
-      '2014-01-20', #Birthday of Martin Luther King, Jr.
-      '2014-02-17', #Washington’s Birthday
-      '2014-05-26', #Memorial Day
-      '2014-07-04', #Independence Day
-      '2014-09-01', #Labor Day
-      '2014-10-13', #Columbus Day
-      '2014-11-11', #Veterans Day
-      '2014-11-27', #Thanksgiving Day
-      '2014-12-25', #Christmas Day
-
-      '2015-01-01', #New Year’s Day
-      '2015-01-19', #Birthday of Martin Luther King, Jr.
-      '2015-02-16', #Washington’s Birthday
-      '2015-05-25', #Memorial Day
-      '2015-07-03', #Independence Day
-      '2015-09-07', #Labor Day
-      '2015-10-12', #Columbus Day
-      '2015-11-11', #Veterans Day
-      '2015-11-26', #Thanksgiving Day
-      '2015-12-25', #Christmas Day
-
-      '2016-01-01', #New Year’s Day
-      '2016-01-18', #Birthday of Martin Luther King, Jr.
-      '2016-02-15', #Washington’s Birthday
-      '2016-05-30', #Memorial Day
-      '2016-07-04', #Independence Day
-      '2016-09-05', #Labor Day
-      '2016-10-10', #Columbus Day
-      '2016-11-11', #Veterans Day
-      '2016-11-24', #Thanksgiving Day
-      '2016-12-26', #Christmas Day
-
-      '2017-01-02', #New Year’s Day
-      '2017-01-16', #Birthday of Martin Luther King, Jr.
-      '2017-02-20', #Washington’s Birthday
-      '2017-05-29', #Memorial Day
-      '2017-07-04', #Independence Day
-      '2017-09-04', #Labor Day
-      '2017-10-09', #Columbus Day
-      '2017-11-10', #Veterans Day
-      '2017-11-23', #Thanksgiving Day
-      '2017-12-25', #Christmas Day
-
-      '2018-01-01', #New Year’s Day
-      '2018-01-15', #Birthday of Martin Luther King, Jr.
-      '2018-02-19', #Washington’s Birthday
-      '2018-05-28', #Memorial Day
-      '2018-07-04', #Independence Day
-      '2018-09-03', #Labor Day
-      '2018-10-08', #Columbus Day
-      '2018-11-12', #Veterans Day
-      '2018-11-22', #Thanksgiving Day
-      '2018-12-25', #Christmas Day
-
-      '2019-01-01', #New Year’s Day
-      '2019-01-21', #Birthday of Martin Luther King, Jr.
-      '2019-02-18', #Washington’s Birthday
-      '2019-05-27', #Memorial Day
-      '2019-07-04', #Independence Day
-      '2019-09-02', #Labor Day
-      '2019-10-14', #Columbus Day
-      '2019-11-11', #Veterans Day
-      '2019-11-28', #Thanksgiving Day
-      '2019-12-25', #Christmas Day
-
-      '2020-01-01', #New Year’s Day
-      '2020-01-20', #Birthday of Martin Luther King, Jr.
-      '2020-02-17', #Washington’s Birthday
-      '2020-05-25', #Memorial Day
-      '2020-07-03', #Independence Day
-      '2020-09-07', #Labor Day
-      '2020-10-12', #Columbus Day
-      '2020-11-11', #Veterans Day
-      '2020-11-26', #Thanksgiving Day
-      '2020-12-25'  #Christmas Day
-    ].map {|date_str| Date.parse(date_str) }
-  }
+RSpec.describe UsBankHolidays do
 
   let(:sample_weekends) { [Date.new(2014, 2, 1), Date.new(2014, 2, 2)] }
 
   let(:sample_weekdays) { [3,  4,  5,  6,  7].map{|d| Date.new(2014, 2, d) } }
 
-  describe '.bank_holiday?' do
-    it 'should determine bank holidays on the list' do
-      sample_holidays.each { |holiday|
-        UsBankHolidays.bank_holiday?(holiday).should be_true
-        UsBankHolidays.banking_day?(holiday).should be_false
-      }
-    end
-
-    it 'weekends should be bank holidays' do
-      sample_weekends.each { |weekend|
-        UsBankHolidays.bank_holiday?(weekend).should be_true
-        UsBankHolidays.banking_day?(weekend).should be_false
-      }
+  context "with saturday holiday date rolling" do
+
+    let(:sample_holidays) {
+      [
+        '2014-01-01', #New Year’s Day
+        '2014-01-20', #Birthday of Martin Luther King, Jr.
+        '2014-02-17', #Washington’s Birthday
+        '2014-05-26', #Memorial Day
+        '2014-07-04', #Independence Day
+        '2014-09-01', #Labor Day
+        '2014-10-13', #Columbus Day
+        '2014-11-11', #Veterans Day
+        '2014-11-27', #Thanksgiving Day
+        '2014-12-25', #Christmas Day
+
+        '2015-01-01', #New Year’s Day
+        '2015-01-19', #Birthday of Martin Luther King, Jr.
+        '2015-02-16', #Washington’s Birthday
+        '2015-05-25', #Memorial Day
+        '2015-07-03', #Independence Day
+        '2015-09-07', #Labor Day
+        '2015-10-12', #Columbus Day
+        '2015-11-11', #Veterans Day
+        '2015-11-26', #Thanksgiving Day
+        '2015-12-25', #Christmas Day
+
+        '2016-01-01', #New Year’s Day
+        '2016-01-18', #Birthday of Martin Luther King, Jr.
+        '2016-02-15', #Washington’s Birthday
+        '2016-05-30', #Memorial Day
+        '2016-07-04', #Independence Day
+        '2016-09-05', #Labor Day
+        '2016-10-10', #Columbus Day
+        '2016-11-11', #Veterans Day
+        '2016-11-24', #Thanksgiving Day
+        '2016-12-26', #Christmas Day
+
+        '2017-01-02', #New Year’s Day
+        '2017-01-16', #Birthday of Martin Luther King, Jr.
+        '2017-02-20', #Washington’s Birthday
+        '2017-05-29', #Memorial Day
+        '2017-07-04', #Independence Day
+        '2017-09-04', #Labor Day
+        '2017-10-09', #Columbus Day
+        '2017-11-10', #Veterans Day
+        '2017-11-23', #Thanksgiving Day
+        '2017-12-25', #Christmas Day
+
+        '2018-01-01', #New Year’s Day
+        '2018-01-15', #Birthday of Martin Luther King, Jr.
+        '2018-02-19', #Washington’s Birthday
+        '2018-05-28', #Memorial Day
+        '2018-07-04', #Independence Day
+        '2018-09-03', #Labor Day
+        '2018-10-08', #Columbus Day
+        '2018-11-12', #Veterans Day
+        '2018-11-22', #Thanksgiving Day
+        '2018-12-25', #Christmas Day
+
+        '2019-01-01', #New Year’s Day
+        '2019-01-21', #Birthday of Martin Luther King, Jr.
+        '2019-02-18', #Washington’s Birthday
+        '2019-05-27', #Memorial Day
+        '2019-07-04', #Independence Day
+        '2019-09-02', #Labor Day
+        '2019-10-14', #Columbus Day
+        '2019-11-11', #Veterans Day
+        '2019-11-28', #Thanksgiving Day
+        '2019-12-25', #Christmas Day
+
+        '2020-01-01', #New Year’s Day
+        '2020-01-20', #Birthday of Martin Luther King, Jr.
+        '2020-02-17', #Washington’s Birthday
+        '2020-05-25', #Memorial Day
+        '2020-07-03', #Independence Day
+        '2020-09-07', #Labor Day
+        '2020-10-12', #Columbus Day
+        '2020-11-11', #Veterans Day
+        '2020-11-26', #Thanksgiving Day
+        '2020-12-25', #Christmas Day
+
+        '2021-01-01',
+        '2021-01-18',
+        '2021-02-15',
+        '2021-05-31',
+        '2021-07-04',
+        '2021-09-06',
+        '2021-10-11',
+        '2021-11-11',
+        '2021-11-25',
+        '2021-12-25'
+
+      ].map {|date_str| Date.parse(date_str) }
+    }
+
+    before :each do
+      allow(::UsBankHolidays).to receive(:saturday_holiday_date_rolling?).and_return(true)
     end
 
-    it 'should exclude weekends if the appropriate flag is passed' do
-      sample_weekends.each { |weekend|
-        UsBankHolidays.bank_holiday?(weekend, false).should be_false
-      }
-    end
+    describe '.bank_holiday?' do
+      it 'should determine bank holidays on the list' do
+        sample_holidays.each { |holiday|
+          UsBankHolidays.bank_holiday?(holiday).should eq(true)
+          UsBankHolidays.banking_day?(holiday).should eq(false)
+        }
+      end
 
-    it 'regular days should not be bank holidays' do
-      sample_weekdays.each { |day|
-        UsBankHolidays.bank_holiday?(day).should be_false
-        UsBankHolidays.banking_day?(day).should be_true
-      }
-    end
-  end
+      it 'weekends should be bank holidays' do
+        sample_weekends.each { |weekend|
+          UsBankHolidays.bank_holiday?(weekend).should eq(true)
+          UsBankHolidays.banking_day?(weekend).should eq(false)
+        }
+      end
 
-  describe '.weekend?' do
-    it 'should recognize weekends' do
-      sample_weekends.each { |weekend|
-        UsBankHolidays.weekend?(weekend).should be_true
-        UsBankHolidays.banking_day?(weekend).should be_false
-      }
-    end
+      it 'should exclude weekends if the appropriate flag is passed' do
+        sample_weekends.each { |weekend|
+          UsBankHolidays.bank_holiday?(weekend, false).should eq(false)
+        }
+      end
 
-    it 'weekdays should not be considered weekends' do
-      sample_weekdays.each { |day| UsBankHolidays.weekend?(day).should be_false }
+      it 'regular days should not be bank holidays' do
+        sample_weekdays.each { |day|
+          UsBankHolidays.bank_holiday?(day).should eq(false)
+          UsBankHolidays.banking_day?(day).should eq(true)
+        }
+      end
     end
-  end
-
-  describe ::UsBankHolidays::DateMethods do
 
     describe '.weekend?' do
-
       it 'should recognize weekends' do
         sample_weekends.each { |weekend|
-          weekend.weekend?.should     be_true
-          weekend.banking_day?.should be_false
+          UsBankHolidays.weekend?(weekend).should eq(true)
+          UsBankHolidays.banking_day?(weekend).should eq(false)
         }
       end
 
       it 'weekdays should not be considered weekends' do
-        sample_weekdays.each { |day|
-          day.weekend?.should     be_false
-          day.banking_day?.should be_true
-        }
+        sample_weekdays.each { |day| UsBankHolidays.weekend?(day).should eq(false) }
       end
-
     end
 
-    describe '.bank_holiday?' do
+    describe ::UsBankHolidays::DateMethods do
 
-      it 'should recognize bank holidays' do
-        sample_holidays.each { |holiday|
-          holiday.bank_holiday?.should be_true
-          holiday.banking_day?.should be_false
-        }
-      end
+      describe '.weekend?' do
 
-      it 'should treat weekends as bank holidays' do
-        sample_weekends.each { |weekend| weekend.bank_holiday?.should be_true }
-      end
+        it 'should recognize weekends' do
+          sample_weekends.each { |weekend|
+            weekend.weekend?.should eq(true)
+            weekend.banking_day?.should eq(false)
+          }
+        end
 
-      it 'should exclude weekends if the appropriate flag is passed' do
-        sample_weekends.each { |weekend|
-          weekend.weekend?.should be_true
-          weekend.bank_holiday?(false).should be_false
-        }
-      end
+        it 'weekdays should not be considered weekends' do
+          sample_weekdays.each { |day|
+            day.weekend?.should eq(false)
+            day.banking_day?.should eq(true)
+          }
+        end
 
-      it 'should not treat regular weekdays as bank holidays' do
-        sample_weekdays.each { |day|
-          day.bank_holiday?.should be_false
-          day.banking_day?.should be_true
-        }
       end
 
-      it 'if Jan. 1 falls on a Saturday, Dec. 31 of the previous year should be a bank holiday' do
-        Date.new(2021, 12, 31).bank_holiday?.should be_true
+      describe '.bank_holiday?' do
+
+        it 'should recognize bank holidays' do
+          sample_holidays.each { |holiday|
+            holiday.bank_holiday?.should eq(true)
+            holiday.banking_day?.should eq(false)
+          }
+        end
+
+        it 'should treat weekends as bank holidays' do
+          sample_weekends.each { |weekend| weekend.bank_holiday?.should eq(true) }
+        end
+
+        it 'should exclude weekends if the appropriate flag is passed' do
+          sample_weekends.each { |weekend|
+            weekend.weekend?.should eq(true)
+            weekend.bank_holiday?(false).should eq(false)
+          }
+        end
+
+        it 'should not treat regular weekdays as bank holidays' do
+          sample_weekdays.each { |day|
+            day.bank_holiday?.should eq(false)
+            day.banking_day?.should eq(true)
+          }
+        end
+
+        it 'if Jan. 1 falls on a Saturday, Dec. 31 of the previous year should be a bank holiday' do
+          Date.new(2021, 12, 31).bank_holiday?.should eq(true)
+        end
       end
-    end
 
-    describe '.next_banking_day' do
-      it 'should determine the next banking day' do
-        Date.new(2014, 1, 1).next_banking_day.should == Date.new(2014, 1, 2)
-        Date.new(2014, 1, 2).next_banking_day.should == Date.new(2014, 1, 3)
-        Date.new(2014, 1, 3).next_banking_day.should == Date.new(2014, 1, 6)
-        Date.new(2014, 1, 4).next_banking_day.should == Date.new(2014, 1, 6)
-        Date.new(2014, 1, 5).next_banking_day.should == Date.new(2014, 1, 6)
+      describe '.next_banking_day' do
+        it 'should determine the next banking day' do
+          Date.new(2014, 1, 1).next_banking_day.should == Date.new(2014, 1, 2)
+          Date.new(2014, 1, 2).next_banking_day.should == Date.new(2014, 1, 3)
+          Date.new(2014, 1, 3).next_banking_day.should == Date.new(2014, 1, 6)
+          Date.new(2014, 1, 4).next_banking_day.should == Date.new(2014, 1, 6)
+          Date.new(2014, 1, 5).next_banking_day.should == Date.new(2014, 1, 6)
+        end
       end
-    end
 
-    describe '.previous_baking_day' do
-      it 'should determine the previous banking day' do
-        Date.new(2014, 1, 7).previous_banking_day.should == Date.new(2014, 1, 6)
-        Date.new(2014, 1, 6).previous_banking_day.should == Date.new(2014, 1, 3)
-        Date.new(2014, 1, 5).previous_banking_day.should == Date.new(2014, 1, 3)
-        Date.new(2014, 1, 4).previous_banking_day.should == Date.new(2014, 1, 3)
-        Date.new(2014, 1, 21).previous_banking_day.should == Date.new(2014, 1, 17)
+      describe '.previous_baking_day' do
+        it 'should determine the previous banking day' do
+          Date.new(2014, 1, 7).previous_banking_day.should == Date.new(2014, 1, 6)
+          Date.new(2014, 1, 6).previous_banking_day.should == Date.new(2014, 1, 3)
+          Date.new(2014, 1, 5).previous_banking_day.should == Date.new(2014, 1, 3)
+          Date.new(2014, 1, 4).previous_banking_day.should == Date.new(2014, 1, 3)
+          Date.new(2014, 1, 21).previous_banking_day.should == Date.new(2014, 1, 17)
+        end
       end
-    end
 
-    describe '.add_banking_days' do
-      it 'should return self if given 0' do
-        Date.new(2014, 1, 7).add_banking_days(0).should == Date.new(2014, 1, 7)
-      end
+      describe '.add_banking_days' do
+        it 'should return self if given 0' do
+          Date.new(2014, 1, 7).add_banking_days(0).should == Date.new(2014, 1, 7)
+        end
+
+        it 'should return self if given 0 even if self is a bank holiday' do
+          Date.new(2014, 1, 4).add_banking_days(0).should == Date.new(2014, 1, 4)
+        end
 
-      it 'should return self if given 0 even if self is a bank holiday' do
-        Date.new(2014, 1, 4).add_banking_days(0).should == Date.new(2014, 1, 4)
+        it 'if given a positive number, should add banking days, ignoring bank holidays' do
+          Date.new(2014, 1, 16).add_banking_days(2).should == Date.new(2014, 1, 21)
+        end
+
+        it 'if given a negative number, should subtract banking days, ignoring bank holidays' do
+          Date.new(2014, 1, 21).add_banking_days(-2).should == Date.new(2014, 1, 16)
+        end
       end
 
-      it 'if given a positive number, should add banking days, ignoring bank holidays' do
-        Date.new(2014, 1, 16).add_banking_days(2).should == Date.new(2014, 1, 21)
+      describe '.last_banking_day_of_month?' do
+        it 'should determine if a date is the last banking day of the month' do
+          Date.new(2014, 1, 31).last_banking_day_of_month?.should eq(true)
+          Date.new(2014, 1, 30).last_banking_day_of_month?.should eq(false)
+
+          Date.new(2014, 11, 30).last_banking_day_of_month?.should eq(false)
+          Date.new(2014, 11, 28).last_banking_day_of_month?.should eq(true)
+        end
       end
 
-      it 'if given a negative number, should subtract banking days, ignoring bank holidays' do
-        Date.new(2014, 1, 21).add_banking_days(-2).should == Date.new(2014, 1, 16)
+      describe '.first_banking_day_of_month?' do
+        it 'should determine if the date if the first banking day of the month' do
+          Date.new(2014, 4, 1).first_banking_day_of_month?.should eq(true)
+          Date.new(2014, 4, 2).first_banking_day_of_month?.should eq(false)
+
+          Date.new(2014, 6, 1).first_banking_day_of_month?.should eq(false)
+          Date.new(2014, 6, 2).first_banking_day_of_month?.should eq(true)
+        end
       end
     end
   end
+
+  context "no saturday holiday date rolling" do
+
+    before :each do
+      allow(::UsBankHolidays).to receive(:saturday_holiday_date_rolling?).and_return(false)
+    end
+
+    let(:banking_days) {
+      [
+        '2021-06-18',
+        '2021-12-31'
+      ].map {|date_str| Date.parse(date_str) }
+    }
+
+    specify 'banking days' do
+      banking_days.each { |date|
+        UsBankHolidays.bank_holiday?(date).should eq(false)
+        UsBankHolidays.banking_day?(date).should eq(true)
+      }
+    end
+  end
 end

data/us_bank_holidays.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'simplecov'

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: us_bank_holidays
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.2.1
 platform: ruby
 authors:
 - Arthur Shagall
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-24 00:00:00.000000000 Z
+date: 2021-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Simplify working with US bank holidays.
@@ -73,7 +73,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .travis.yml
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -97,17 +97,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: Patches Date to add methods to make dealing with US bank holidays simpler.