urbanopt-reporting 0.3.3 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e65d30b14cf3916be1251dd1092dd74f222e737a0c9d6e6278123f4c6101b503
-  data.tar.gz: 4fa5c62490c7dcc883c5308f8f31547090f1eef01914b0e3e54093e218f09bf9
+  metadata.gz: 75187e938a1cbfabd1d74eba912af03fcd2aade54955a490d68ea1b97b229dd2
+  data.tar.gz: 25b56a46e4569a71a7c01964bf64f2a14d8c30fdc9f6f5167fd61b40f272eb52
 SHA512:
-  metadata.gz: 0e0fdd09a89d58be74b9506fc9904253b0121f0d117041799baa500f3a0b1ab07f907609e0495486943751203c1f8683cc564ffcb038cb944721e1751e79c6f3
-  data.tar.gz: 067ab1a1d6506c22933a1e4e9e09dac96ecc925e4d3d931bfc51bd6853faf99e658c4b578f6689d9e34cc5ff5533c77dab1d8533ccef1384963ad7a85ac627e1
+  metadata.gz: 5a5f20c29cc1eec6aafeece4479a52c4c5a6a0ecfb0374a0b8f243551f9a7d49ecfbcf25b233ce7e19441551adcd87c5eb668ad509d4c87b0681ea1a187da6b2
+  data.tar.gz: bccc2ad11e97d3330f2706cb9a7d32c5c0209130af88738854e6d56fb6d34b5ccfcc8b51b42633d3f359bf4c03c34d4888108528bd38c558c96ec06569c92e9d

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # URBANopt Reporting Gem
 
+## Version 0.3.4
+
+Date Range: 01/14/21 - 01/15/21
+
+- Fixed [#53]( https://github.com/urbanopt/urbanopt-reporting-gem/issues/53 ), Make subfolders in feature saving if necessary
+- Fixed [#55]( https://github.com/urbanopt/urbanopt-reporting-gem/issues/55 ), Fix new measures
+
 ## Version 0.3.3
 
 Date Range: 12/09/20 - 01/13/21

data/lib/measures/default_feature_reports/measure.rb

@@ -505,18 +505,17 @@ class DefaultFeatureReports < OpenStudio::Measure::ReportingMeasure
     feature_report.program.roof_area_sqft[:total_roof_area_sqft] = total_roof_area_sqft
 
     # available_roof_area_sqft
-    # RK: a more robust method should be implemented to find the available_roof_area 
+    # RK: a more robust method should be implemented to find the available_roof_area
     # assign available roof area to be a percentage of the total roof area
 
     if building_types[0][:building_type].include? 'Single-Family Detached'
       feature_report.program.roof_area_sqft[:available_roof_area_sqft] = 0.45 * total_roof_area_sqft
-    else 
+    else
       feature_report.program.roof_area_sqft[:available_roof_area_sqft] = 0.75 * total_roof_area_sqft
     end
 
     # RK: Temporary solution: assign available roof area to be equal to total roof area
-    #feature_report.program.roof_area_sqft[:available_roof_area_sqft] = total_roof_area_sqft
-
+    # feature_report.program.roof_area_sqft[:available_roof_area_sqft] = total_roof_area_sqft
 
     # orientation
     # RK: a more robust method should be implemented to find orientation(finding main axis of the building using aspect ratio)

data/lib/measures/export_modelica_loads/measure.rb

@@ -82,37 +82,38 @@ class ExportModelicaLoads < OpenStudio::Measure::ReportingMeasure
       return false
     end
 
-    result << OpenStudio::IdfObject.load('Output:Variable,,Site Mains Water Temperature,hourly;').get
-    result << OpenStudio::IdfObject.load('Output:Variable,,Site Outdoor Air Drybulb Temperature,hourly;').get
-    result << OpenStudio::IdfObject.load('Output:Variable,,Site Outdoor Air Relative Humidity,hourly;').get
-    result << OpenStudio::IdfObject.load('Output:Meter,Cooling:Electricity,hourly;').get
-    result << OpenStudio::IdfObject.load('Output:Meter,Heating:Electricity,hourly;').get
-    result << OpenStudio::IdfObject.load('Output:Meter,Heating:Gas,hourly;').get
-    result << OpenStudio::IdfObject.load('Output:Meter,InteriorLights:Electricity,hourly;').get
-    result << OpenStudio::IdfObject.load('Output:Meter,Fans:Electricity,hourly;').get
-    result << OpenStudio::IdfObject.load('Output:Meter,InteriorEquipment:Electricity,hourly;').get # Joules
-    result << OpenStudio::IdfObject.load('Output:Meter,ExteriorLighting:Electricity,hourly;').get # Joules
-    result << OpenStudio::IdfObject.load('Output:Meter,Electricity:Facility,hourly;').get # Joules
-    result << OpenStudio::IdfObject.load('Output:Meter,Gas:Facility,hourly;').get # Joules
-    result << OpenStudio::IdfObject.load('Output:Meter,Heating:EnergyTransfer,hourly;').get  # Joules
-    result << OpenStudio::IdfObject.load('Output:Meter,WaterSystems:EnergyTransfer,hourly;').get  # Joules
+    result << OpenStudio::IdfObject.load('Output:Variable,,Site Mains Water Temperature,timestep;').get
+    result << OpenStudio::IdfObject.load('Output:Variable,,Site Outdoor Air Drybulb Temperature,timestep;').get
+    result << OpenStudio::IdfObject.load('Output:Variable,,Site Outdoor Air Relative Humidity,timestep;').get
+    result << OpenStudio::IdfObject.load('Output:Meter,Cooling:Electricity,timestep;').get
+    result << OpenStudio::IdfObject.load('Output:Meter,Heating:Electricity,timestep;').get
+    result << OpenStudio::IdfObject.load('Output:Meter,Heating:Gas,timestep;').get
+    result << OpenStudio::IdfObject.load('Output:Meter,InteriorLights:Electricity,timestep;').get
+    result << OpenStudio::IdfObject.load('Output:Meter,Fans:Electricity,timestep;').get
+    result << OpenStudio::IdfObject.load('Output:Meter,InteriorEquipment:Electricity,timestep;').get # Joules
+    result << OpenStudio::IdfObject.load('Output:Meter,ExteriorLighting:Electricity,timestep;').get # Joules
+    result << OpenStudio::IdfObject.load('Output:Meter,Electricity:Facility,timestep;').get # Joules
+    result << OpenStudio::IdfObject.load('Output:Meter,Electricity:Facility,timestep;').get ##Using this for data at timestep interval
+    result << OpenStudio::IdfObject.load('Output:Meter,Gas:Facility,timestep;').get # Joules
+    result << OpenStudio::IdfObject.load('Output:Meter,Heating:EnergyTransfer,timestep;').get # Joules
+    result << OpenStudio::IdfObject.load('Output:Meter,WaterSystems:EnergyTransfer,timestep;').get # Joules
     # these variables are used for the modelica export.
-    result << OpenStudio::IdfObject.load('Output:Variable,*,Zone Predicted Sensible Load to Setpoint Heat Transfer Rate,hourly;').get  # watts according to e+
-    result << OpenStudio::IdfObject.load('Output:Variable,*,Water Heater Total Demand Heat Transfer Rate,hourly;').get # Watts
+    result << OpenStudio::IdfObject.load('Output:Variable,*,Zone Predicted Sensible Load to Setpoint Heat Transfer Rate,timestep;').get # watts according to e+
+    result << OpenStudio::IdfObject.load('Output:Variable,*,Water Heater Total Demand Heat Transfer Rate,timestep;').get # Watts
 
     return result
   end
 
-  def extract_timeseries_into_matrix(sqlfile, data, variable_name, key_value = nil, default_if_empty=0)
+  def extract_timeseries_into_matrix(sqlfile, data, variable_name, key_value = nil, default_if_empty = 0, timestep)
     log "Executing query for #{variable_name}"
     column_name = variable_name
     if key_value
-      ts = sqlfile.timeSeries('RUN PERIOD 1', 'Hourly', variable_name, key_value)
-      # ts = sqlfile.timeSeries('RUN PERIOD 1', 'Zone Timestep', variable_name, key_value)
+      # ts = sqlfile.timeSeries('RUN PERIOD 1', 'Hourly', variable_name, key_value)
+      ts = sqlfile.timeSeries('RUN PERIOD 1', 'Zone Timestep', variable_name, key_value)
       column_name += "_#{key_value}"
     else
-      ts = sqlfile.timeSeries('RUN PERIOD 1', 'Hourly', variable_name)
-      # ts = sqlfile.timeSeries('RUN PERIOD 1', 'Zone Timestep', variable_name)
+      # ts = sqlfile.timeSeries('RUN PERIOD 1', 'Hourly', variable_name)
+      ts = sqlfile.timeSeries('RUN PERIOD 1', 'Zone Timestep', variable_name)
     end
     log 'Iterating over timeseries'
     column = [column_name.delete(':').delete(' ')] # Set the header of the data to the variable name, removing : and spaces
@@ -120,7 +121,7 @@ class ExportModelicaLoads < OpenStudio::Measure::ReportingMeasure
     if ts.empty?
       log "No time series for #{variable_name}:#{key_value}... defaulting to #{default_if_empty}"
       # needs to be data.size-1 since the column name is already stored above (+=)
-      column += [default_if_empty] * (data.size-1)
+      column += [default_if_empty] * (data.size - 1)
     else
       ts = ts.get if ts.respond_to?(:get)
       ts = ts.first if ts.respond_to?(:first)
@@ -154,10 +155,10 @@ class ExportModelicaLoads < OpenStudio::Measure::ReportingMeasure
     log "Finished extracting #{variable_name}"
   end
 
-  def create_new_variable_sum(data, new_var_name, include_str, options=nil)
+  def create_new_variable_sum(data, new_var_name, include_str, options = nil)
     var_info = {
-        name: new_var_name,
-        var_indexes: []
+      name: new_var_name,
+      var_indexes: []
     }
     data.each_with_index do |row, index|
       if index.zero?
@@ -212,6 +213,9 @@ class ExportModelicaLoads < OpenStudio::Measure::ReportingMeasure
     end
     model = model.get
 
+    timesteps_per_hour=model.getTimestep.numberOfTimestepsPerHour.to_i
+    timestep=60/timesteps_per_hour #timestep in minutes
+
     sqlFile = runner.lastEnergyPlusSqlFile
     if sqlFile.empty?
       runner.registerError('Cannot find last sql file.')
@@ -233,45 +237,47 @@ class ExportModelicaLoads < OpenStudio::Measure::ReportingMeasure
     ]
 
     # just grab one of the variables to get the date/time stamps
-    # ts = sqlFile.timeSeries('RUN PERIOD 1', 'Zone Timestep', 'Cooling:Electricity')
-    ts = sqlFile.timeSeries('RUN PERIOD 1', 'Hourly', 'Cooling:Electricity')
-    unless ts.empty?
+    attribute_name = 'Electricity:Facility'
+    ts = sqlFile.timeSeries('RUN PERIOD 1', 'Zone Timestep', attribute_name)
+    if ts.empty?
+      runner.registerError("This feature does not have the attribute '#{attribute_name}' to enable this measure to work." \
+      "To resolve, simulate a building with electricity or remove this measure from your workflow.")
+    else
       ts = ts.first
       dt_base = nil
       # Save off the date time values
       ts.dateTimes.each_with_index do |dt, index|
-        runner.registerInfo("My index is #{index}")
         dt_base = DateTime.parse(dt.to_s) if dt_base.nil?
         dt_current = DateTime.parse(dt.to_s)
         rows << [
           DateTime.parse(dt.to_s).strftime('%m/%d/%Y %H:%M'),
-            dt.date.monthOfYear.value,
-            dt.date.dayOfMonth,
-            dt.date.dayOfWeek.value,
-            dt.time.hours,
-            dt.time.minutes,
-            dt_current.to_time.to_i - dt_base.to_time.to_i
+          dt.date.monthOfYear.value,
+          dt.date.dayOfMonth,
+          dt.date.dayOfWeek.value,
+          dt.time.hours,
+          dt.time.minutes,
+          dt_current.to_time.to_i - dt_base.to_time.to_i + timestep*60
         ]
       end
     end
 
     # add in the other variables by columns -- should really pull this from the report variables defined above
-    extract_timeseries_into_matrix(sqlFile, rows, 'Site Outdoor Air Drybulb Temperature', 'Environment', 0)
-    extract_timeseries_into_matrix(sqlFile, rows, 'Site Outdoor Air Relative Humidity', 'Environment', 0)
-    extract_timeseries_into_matrix(sqlFile, rows, 'Heating:Electricity', nil, 0)
-    extract_timeseries_into_matrix(sqlFile, rows, 'Heating:Gas', nil, 0)
-    extract_timeseries_into_matrix(sqlFile, rows, 'Cooling:Electricity', nil, 0)
-    extract_timeseries_into_matrix(sqlFile, rows, 'Electricity:Facility', nil, 0)
-    extract_timeseries_into_matrix(sqlFile, rows, 'Gas:Facility', nil, 0)
-    extract_timeseries_into_matrix(sqlFile, rows, 'Heating:EnergyTransfer', nil, 0)
-    extract_timeseries_into_matrix(sqlFile, rows, 'WaterSystems:EnergyTransfer', nil, 0)
+    extract_timeseries_into_matrix(sqlFile, rows, 'Site Outdoor Air Drybulb Temperature', 'Environment', 0, timestep)
+    extract_timeseries_into_matrix(sqlFile, rows, 'Site Outdoor Air Relative Humidity', 'Environment', 0, timestep)
+    extract_timeseries_into_matrix(sqlFile, rows, 'Heating:Electricity', nil, 0, timestep)
+    extract_timeseries_into_matrix(sqlFile, rows, 'Heating:Gas', nil, 0, timestep)
+    extract_timeseries_into_matrix(sqlFile, rows, 'Cooling:Electricity', nil, 0, timestep)
+    extract_timeseries_into_matrix(sqlFile, rows, 'Electricity:Facility', nil, 0, timestep)
+    extract_timeseries_into_matrix(sqlFile, rows, 'Gas:Facility', nil, 0, timestep)
+    extract_timeseries_into_matrix(sqlFile, rows, 'Heating:EnergyTransfer', nil, 0, timestep)
+    extract_timeseries_into_matrix(sqlFile, rows, 'WaterSystems:EnergyTransfer', nil, 0, timestep)
 
     # get all zones and save the names for later use in aggregation.
     tz_names = []
     model.getThermalZones.each do |tz|
       tz_names << tz.name.get if tz.name.is_initialized
-      extract_timeseries_into_matrix(sqlFile, rows, 'Zone Predicted Sensible Load to Setpoint Heat Transfer Rate', tz_names.last, 0)
-      extract_timeseries_into_matrix(sqlFile, rows, 'Water Heater Heating Rate', tz_names.last, 0)
+      extract_timeseries_into_matrix(sqlFile, rows, 'Zone Predicted Sensible Load to Setpoint Heat Transfer Rate', tz_names.last, 0, timestep)
+      extract_timeseries_into_matrix(sqlFile, rows, 'Water Heater Heating Rate', tz_names.last, 0, timestep)
     end
 
     # sum up a couple of the columns and create a new columns
@@ -346,7 +352,7 @@ class ExportModelicaLoads < OpenStudio::Measure::ReportingMeasure
     # Find the total runtime for energyplus and save it into a registerValue
     total_time = -999
     location_of_file = ['../eplusout.end', './run/eplusout.end']
-    first_index = location_of_file.map {|f| File.exist?(f)}.index(true)
+    first_index = location_of_file.map { |f| File.exist?(f) }.index(true)
     if first_index
       match = File.read(location_of_file[first_index]).to_s.match(/Elapsed.Time=(.*)hr(.*)min(.*)sec/)
       total_time = match[1].to_i * 3600 + match[2].to_i * 60 + match[3].to_f

data/lib/measures/export_time_series_modelica/measure.rb

@@ -61,25 +61,25 @@ class ExportTimeSeriesLoadsCSV < OpenStudio::Measure::ReportingMeasure
     puts "#{Time.now}: #{str}"
   end
 
-  def arguments(_model) 
+  def arguments(_model)
     args = OpenStudio::Measure::OSArgumentVector.new
-	
+
     hhw_loop_name = OpenStudio::Measure::OSArgument.makeStringArgument('hhw_loop_name', true)
     hhw_loop_name.setDisplayName('Name or Partial Name of Heating Hot Water Loop, non-case-sensitive')
     hhw_loop_name.setDefaultValue('hot')
     args << hhw_loop_name
-	
-	chw_loop_name = OpenStudio::Measure::OSArgument.makeStringArgument('chw_loop_name', true)
+
+	  chw_loop_name = OpenStudio::Measure::OSArgument.makeStringArgument('chw_loop_name', true)
     chw_loop_name.setDisplayName('Name or Partial Name of Chilled Water Loop, non-case-sensitive')
     chw_loop_name.setDefaultValue('chilled')
     args << chw_loop_name
-	
-	dec_places_mass_flow = OpenStudio::Measure::OSArgument.makeIntegerArgument('dec_places_mass_flow', true)
+
+	  dec_places_mass_flow = OpenStudio::Measure::OSArgument.makeIntegerArgument('dec_places_mass_flow', true)
     dec_places_mass_flow.setDisplayName('Number of Decimal Places to Round Mass Flow Rate')
     dec_places_mass_flow.setDescription('Number of decimal places to which mass flow rate will be rounded')
     dec_places_mass_flow.setDefaultValue(3)
     args << dec_places_mass_flow
-	
+
     dec_places_temp = OpenStudio::Measure::OSArgument.makeIntegerArgument('dec_places_temp', true)
     dec_places_temp.setDisplayName('Number of Decimal Places to Round Temperature')
     dec_places_temp.setDescription('Number of decimal places to which temperature will be rounded')
@@ -94,7 +94,6 @@ class ExportTimeSeriesLoadsCSV < OpenStudio::Measure::ReportingMeasure
     super(runner, user_arguments)
 
     result = OpenStudio::IdfObjectVector.new
-	
 
     # To use the built-in error checking we need the model...
     # get the last model and sql file
@@ -107,51 +106,48 @@ class ExportTimeSeriesLoadsCSV < OpenStudio::Measure::ReportingMeasure
 
     # use the built-in error checking
     return false unless runner.validateUserArguments(arguments(model), user_arguments)
-	
-	##Read in argumetns related to variables for output requests 
-	hhw_loop_name = runner.getStringArgumentValue('hhw_loop_name', user_arguments)
-	chw_loop_name = runner.getStringArgumentValue('chw_loop_name', user_arguments)
-	
 
-	#Identify key names for output variables. 
-	plantloops = model.getPlantLoops
+    ##Read in argumetns related to variables for output requests
+    hhw_loop_name = runner.getStringArgumentValue('hhw_loop_name', user_arguments)
+    chw_loop_name = runner.getStringArgumentValue('chw_loop_name', user_arguments)
+
+    #Identify key names for output variables.
+    plantloops = model.getPlantLoops
 
     selected_plant_loops = []
     i = 0
-	
-	variable_name1 = 'System Node Mass Flow Rate'
-	variable_name2 = 'System Node Temperature'
-	reporting_frequency = 'timestep' 
 
-	
+    variable_name1 = 'System Node Mass Flow Rate'
+    variable_name2 = 'System Node Temperature'
+    reporting_frequency = 'timestep'
+
     plantloops.each do |plantLoop|
-	  log "plant loop name #{plantLoop.name.get.to_s}"
-	  if plantLoop.name.get.to_s.downcase.include? chw_loop_name.to_s
-	     #Extract plant loop information 
-         selected_plant_loops[0]=plantLoop
-		 key_value_chw_outlet = selected_plant_loops[0].demandOutletNode.name.to_s
-	     key_value_chw_inlet = selected_plant_loops[0].demandInletNode.name.to_s
-		 result << OpenStudio::IdfObject.load("Output:Variable,#{key_value_chw_outlet},#{variable_name2},timestep;").get 
-		 result << OpenStudio::IdfObject.load("Output:Variable,#{key_value_chw_inlet},#{variable_name2},timestep;").get 
-         result << OpenStudio::IdfObject.load("Output:Variable,#{key_value_chw_outlet},#{variable_name1},timestep;").get 
-      end 
-	  if plantLoop.name.get.to_s.downcase.include? hhw_loop_name.to_s and !plantLoop.name.get.to_s.downcase.include? "service" and !plantLoop.name.get.to_s.downcase.include? "domestic"
-	     #Extract plant loop information 
-		 selected_plant_loops[1]=plantLoop
-		 key_value_hhw_outlet = selected_plant_loops[1].demandOutletNode.name.to_s
-	     key_value_hhw_inlet = selected_plant_loops[1].demandInletNode.name.to_s
-		 result << OpenStudio::IdfObject.load("Output:Variable,#{key_value_hhw_outlet},#{variable_name2},timestep;").get 
-		 result << OpenStudio::IdfObject.load("Output:Variable,#{key_value_hhw_inlet},#{variable_name2},timestep;").get 
-         result << OpenStudio::IdfObject.load("Output:Variable,#{key_value_hhw_outlet},#{variable_name1},timestep;").get 
-     end 
-   end 
-   
+	    log "plant loop name #{plantLoop.name.get.to_s}"
+      if plantLoop.name.get.to_s.downcase.include? chw_loop_name.to_s
+        #Extract plant loop information
+        selected_plant_loops[0]=plantLoop
+        key_value_chw_outlet = selected_plant_loops[0].demandOutletNode.name.to_s
+        key_value_chw_inlet = selected_plant_loops[0].demandInletNode.name.to_s
+        result << OpenStudio::IdfObject.load("Output:Variable,#{key_value_chw_outlet},#{variable_name2},timestep;").get
+        result << OpenStudio::IdfObject.load("Output:Variable,#{key_value_chw_inlet},#{variable_name2},timestep;").get
+        result << OpenStudio::IdfObject.load("Output:Variable,#{key_value_chw_outlet},#{variable_name1},timestep;").get
+      end
+      if plantLoop.name.get.to_s.downcase.include? hhw_loop_name.to_s and !plantLoop.name.get.to_s.downcase.include? "service" and !plantLoop.name.get.to_s.downcase.include? "domestic"
+        #Extract plant loop information
+        selected_plant_loops[1]=plantLoop
+        key_value_hhw_outlet = selected_plant_loops[1].demandOutletNode.name.to_s
+        key_value_hhw_inlet = selected_plant_loops[1].demandInletNode.name.to_s
+        result << OpenStudio::IdfObject.load("Output:Variable,#{key_value_hhw_outlet},#{variable_name2},timestep;").get
+        result << OpenStudio::IdfObject.load("Output:Variable,#{key_value_hhw_inlet},#{variable_name2},timestep;").get
+        result << OpenStudio::IdfObject.load("Output:Variable,#{key_value_hhw_outlet},#{variable_name1},timestep;").get
+      end
+    end
 
     result << OpenStudio::IdfObject.load('Output:Variable,,Site Mains Water Temperature,hourly;').get
     result << OpenStudio::IdfObject.load('Output:Variable,,Site Outdoor Air Drybulb Temperature,hourly;').get
     result << OpenStudio::IdfObject.load('Output:Variable,,Site Outdoor Air Relative Humidity,hourly;').get
     result << OpenStudio::IdfObject.load('Output:Meter,Cooling:Electricity,hourly;').get
-	result << OpenStudio::IdfObject.load('Output:Meter,Cooling:Electricity,timestep;').get ##Using this for data at timestep interval 
+	  result << OpenStudio::IdfObject.load('Output:Meter,Electricity:Facility,timestep;').get ##Using this for data at timestep interval
     result << OpenStudio::IdfObject.load('Output:Meter,Heating:Electricity,hourly;').get
     result << OpenStudio::IdfObject.load('Output:Meter,Heating:Gas,hourly;').get
     result << OpenStudio::IdfObject.load('Output:Meter,InteriorLights:Electricity,hourly;').get
@@ -169,17 +165,16 @@ class ExportTimeSeriesLoadsCSV < OpenStudio::Measure::ReportingMeasure
     result
   end
 
-  def extract_timeseries_into_matrix(sqlfile, data, variable_name, str, key_value = nil, default_if_empty = 0,dec_places, timestep) 
+  def extract_timeseries_into_matrix(sqlfile, data, variable_name, str, key_value = nil, default_if_empty = 0,dec_places, timestep)
     log "Executing query for #{variable_name}"
     #column_name = variable_name
     if key_value
-      #ts = sqlfile.timeSeries('RUN PERIOD 1', 'Hourly', variable_name, key_value) 
-      ts = sqlfile.timeSeries('RUN PERIOD 1', 'Zone Timestep', variable_name, key_value) 
+      ts = sqlfile.timeSeries('RUN PERIOD 1', 'Zone Timestep', variable_name, key_value)
       #column_name += "_#{key_value}"
-	  column_name=str
+	    column_name=str
     else
       #ts = sqlfile.timeSeries('RUN PERIOD 1', 'Hourly', variable_name)
-      ts = sqlfile.timeSeries('RUN PERIOD 1', 'Zone Timestep', variable_name) 
+      ts = sqlfile.timeSeries('RUN PERIOD 1', 'Zone Timestep', variable_name)
     end
     log 'Iterating over timeseries'
     column = [column_name.delete(':').delete(' ')] # Set the header of the data to the variable name, removing : and spaces
@@ -191,7 +186,7 @@ class ExportTimeSeriesLoadsCSV < OpenStudio::Measure::ReportingMeasure
     else
       ts = ts.get if ts.respond_to?(:get)
       ts = ts.first if ts.respond_to?(:first)
-	  
+
       start = Time.now
       # Iterating in OpenStudio can take up to 60 seconds with 10min data. The quick_proc takes 0.03 seconds.
       # for i in 0..ts.values.size - 1
@@ -200,24 +195,21 @@ class ExportTimeSeriesLoadsCSV < OpenStudio::Measure::ReportingMeasure
       # end
 
       quick_proc = ts.values.to_s.split(',')
-	  quick_proc[0]=quick_proc[0].split('(', 2).last #cleanup necessary to remove opening paren 
-	  quick_proc=quick_proc.map(&:to_f) 
-	  x = 0
+      quick_proc[0]=quick_proc[0].split('(', 2).last #cleanup necessary to remove opening paren
+      quick_proc=quick_proc.map(&:to_f)
+      x = 0
       len = quick_proc.length
-	  log "quick proc #{quick_proc}" 
-      while(x < len) #Round to the # of decimal places specified 
+	    log "quick proc #{quick_proc}"
+      while(x < len) #Round to the # of decimal places specified
           quick_proc[x]=(quick_proc[x]).round(dec_places)
           x=x+1
-	  end 
-	  quick_proc=quick_proc.map(&:to_s)
+	      end
+	    quick_proc=quick_proc.map(&:to_s)
 
-	  
       # the first and last have some cleanup items because of the Vector method
-      quick_proc[0] = quick_proc[0].gsub(/^.*\(/, '') 
-      quick_proc[-1] = quick_proc[-1].delete(')') 
+      quick_proc[0] = quick_proc[0].gsub(/^.*\(/, '')
+      quick_proc[-1] = quick_proc[-1].delete(')')
       column += quick_proc
-	  
-	  
 
       log "Took #{Time.now - start} to iterate"
     end
@@ -279,9 +271,11 @@ class ExportTimeSeriesLoadsCSV < OpenStudio::Measure::ReportingMeasure
 
     # use the built-in error checking
     return false unless runner.validateUserArguments(arguments(model), user_arguments)
-	
-	args = OsLib_HelperMethods.createRunVariables(runner, model, user_arguments, arguments(model))
-	if !args then return false end
+
+    args = OsLib_HelperMethods.createRunVariables(runner, model, user_arguments, arguments(model))
+    if !args
+      return false
+    end
 
     # lookup and replace argument values from upstream measures
     if args['use_upstream_args'] == true
@@ -291,7 +285,7 @@ class ExportTimeSeriesLoadsCSV < OpenStudio::Measure::ReportingMeasure
         if !value_from_osw.empty?
           runner.registerInfo("Replacing argument named #{arg} from current measure with a value of #{value_from_osw[:value]} from #{value_from_osw[:measure_name]}.")
           new_val = value_from_osw[:value]
-          # todo - make code to handle non strings more robust. check_upstream_measure_for_arg could pass bakc the argument type
+          # TODO: make code to handle non strings more robust. check_upstream_measure_for_arg could pass back the argument type
           if arg == 'hhw_loop_name'
             args[arg] = new_val.to_s
           elsif arg == 'chw_loop_name'
@@ -303,9 +297,9 @@ class ExportTimeSeriesLoadsCSV < OpenStudio::Measure::ReportingMeasure
       end
     end
     hhw_loop_name = args['hhw_loop_name']
-	chw_loop_name = args['chw_loop_name']
-	dec_places_temp = args['dec_places_temp']
-	dec_places_mass_flow = args['dec_places_mass_flow']
+    chw_loop_name = args['chw_loop_name']
+    dec_places_temp = args['dec_places_temp']
+    dec_places_mass_flow = args['dec_places_mass_flow']
     # get the last model and sql file
     model = runner.lastOpenStudioModel
     if model.empty?
@@ -313,10 +307,9 @@ class ExportTimeSeriesLoadsCSV < OpenStudio::Measure::ReportingMeasure
       return false
     end
     model = model.get
-	
 
-	timesteps_per_hour=model.getTimestep.numberOfTimestepsPerHour.to_i
-	timestep=60/timesteps_per_hour #timestep in minutes 
+    timesteps_per_hour=model.getTimestep.numberOfTimestepsPerHour.to_i
+    timestep=60/timesteps_per_hour #timestep in minutes
 
     sqlFile = runner.lastEnergyPlusSqlFile
     if sqlFile.empty?
@@ -339,9 +332,12 @@ class ExportTimeSeriesLoadsCSV < OpenStudio::Measure::ReportingMeasure
     ]
 
     # just grab one of the variables to get the date/time stamps
-    ts = sqlFile.timeSeries('RUN PERIOD 1', 'Zone Timestep', 'Cooling:Electricity')
-	#ts = sqlFile.timeSeries('RUN PERIOD 1', 'Hourly', 'Cooling:Electricity')
-	unless ts.empty? 
+    attribute_name = 'Electricity:Facility'
+    ts = sqlFile.timeSeries('RUN PERIOD 1', 'Zone Timestep', attribute_name)
+    if ts.empty?
+      runner.registerError("This feature does not have the attribute '#{attribute_name}' to enable this measure to work." \
+      "To resolve, simulate a building with electricity or remove this measure from your workflow.")
+    else
       ts = ts.first
       dt_base = nil
       # Save off the date time values
@@ -355,7 +351,7 @@ class ExportTimeSeriesLoadsCSV < OpenStudio::Measure::ReportingMeasure
           dt.date.dayOfWeek.value,
           dt.time.hours,
           dt.time.minutes,
-          dt_current.to_time.to_i - dt_base.to_time.to_i + timestep*60 
+          dt_current.to_time.to_i - dt_base.to_time.to_i + timestep*60
         ]
       end
     end
@@ -364,69 +360,69 @@ class ExportTimeSeriesLoadsCSV < OpenStudio::Measure::ReportingMeasure
 
     selected_plant_loops = []
     i = 0
-	
-	key_var={}
+
+    key_var={}
 
     plantloops.each do |plantLoop|
-	  if plantLoop.name.get.to_s.downcase.include? chw_loop_name.to_str
-	     #Extract plant loop information 
-         selected_plant_loops[0]=plantLoop
-	  end 
-	  if plantLoop.name.get.to_s.downcase.include? hhw_loop_name.to_str
-         #Get plant loop information
-		 selected_plant_loops[1]=plantLoop
-	  end 
+      if plantLoop.name.get.to_s.downcase.include? chw_loop_name.to_str
+        #Extract plant loop information
+          selected_plant_loops[0]=plantLoop
+      end
+      if plantLoop.name.get.to_s.downcase.include? hhw_loop_name.to_str
+          #Get plant loop information
+      selected_plant_loops[1]=plantLoop
+      end
+    end
+
+    if !selected_plant_loops[1].nil?
+      #Set up variables for output
+      key_value_hhw_outlet = selected_plant_loops[1].demandOutletNode.name.to_s
+      key_value_hhw_inlet = selected_plant_loops[1].demandInletNode.name.to_s
+      key_var['hhw_outlet_massflow']='massFlowRateHeating'
+      key_var['hhw_outlet_temp']='heatingReturnTemperature[C]'
+      key_var['hhw_inlet_temp']='heatingSupplyTemperature[C]'
+      #Extract time series
+      extract_timeseries_into_matrix(sqlFile, rows, 'System Node Temperature', key_var['hhw_outlet_temp'], key_value_hhw_outlet, 0, dec_places_temp, timestep)
+      extract_timeseries_into_matrix(sqlFile, rows, 'System Node Temperature', key_var['hhw_inlet_temp'], key_value_hhw_inlet, 0, dec_places_temp, timestep)
+      extract_timeseries_into_matrix(sqlFile, rows, 'System Node Mass Flow Rate', key_var['hhw_outlet_massflow'], key_value_hhw_outlet, 0, dec_places_mass_flow, timestep)
+    else
+      runner.registerWarning("No hot water loop found. If one is expected, make sure the hot water loop name argument provides a string present in its name.")
     end
-	
-	if !selected_plant_loops[1].nil?
-	 #Set up variables for output 
-	 key_value_hhw_outlet = selected_plant_loops[1].demandOutletNode.name.to_s
-	 key_value_hhw_inlet = selected_plant_loops[1].demandInletNode.name.to_s
-	 key_var['hhw_outlet_massflow']='massFlowRateHeating'
-	 key_var['hhw_outlet_temp']='heatingReturnTemperature[C]'
-	 key_var['hhw_inlet_temp']='heatingSupplyTemperature[C]'
-	 #Extract time series 
-	 extract_timeseries_into_matrix(sqlFile, rows, 'System Node Temperature', key_var['hhw_outlet_temp'], key_value_hhw_outlet, 0, dec_places_temp, timestep) 
-	 extract_timeseries_into_matrix(sqlFile, rows, 'System Node Temperature', key_var['hhw_inlet_temp'], key_value_hhw_inlet, 0, dec_places_temp, timestep)
-	 extract_timeseries_into_matrix(sqlFile, rows, 'System Node Mass Flow Rate', key_var['hhw_outlet_massflow'], key_value_hhw_outlet, 0, dec_places_mass_flow, timestep) 
-	 else 
-		runner.registerWarning("No hot water loop found. If one is expected, make sure the hot water loop name argument provides a string present in its name.") 
-     end 
-	
-	if !selected_plant_loops[0].nil?
-	 #Set up variables for outputs 
-	 key_value_chw_outlet = selected_plant_loops[0].demandOutletNode.name.to_s
-	 key_value_chw_inlet = selected_plant_loops[0].demandInletNode.name.to_s
-	 key_var['chw_outlet_massflow']='massFlowRateCooling'
-	 key_var['chw_outlet_temp']='ChilledWaterReturnTemperature[C]'
-	 key_var['chw_inlet_temp']='ChilledWaterSupplyTemperature[C]'
-	 #Extract time series 
-	 extract_timeseries_into_matrix(sqlFile, rows, 'System Node Temperature', key_var['chw_outlet_temp'], key_value_chw_outlet, 0, dec_places_temp,timestep)
-	 extract_timeseries_into_matrix(sqlFile, rows, 'System Node Temperature', key_var['chw_inlet_temp'], key_value_chw_inlet, 0, dec_places_temp,timestep) 
-	 extract_timeseries_into_matrix(sqlFile, rows, 'System Node Mass Flow Rate', key_var['chw_outlet_massflow'], key_value_chw_outlet, 0, dec_places_mass_flow,timestep)
-	else 
-	     runner.registerWarning("No chilled water loop found. If one is expected, make sure the chilled water loop name argument provides a string present in its name.") 
-    end 
-	
-   
-   if selected_plant_loops[0].nil? and selected_plant_loops[1].nil?
-    runner.registerWarning("No HVAC plant loops found. If one or more plant loops are expected, make sure they follow the naming conventions mentioned in the previous warnings.") 
-   end 
-   
-   if !selected_plant_loops.nil?
-    # convert this to CSV object
-    File.open('./building_loads.csv', 'w') do |f|
-      rows.each do |row|
-        f << row.join(',') << "\n"
+
+    if !selected_plant_loops[0].nil?
+      #Set up variables for outputs
+      key_value_chw_outlet = selected_plant_loops[0].demandOutletNode.name.to_s
+      key_value_chw_inlet = selected_plant_loops[0].demandInletNode.name.to_s
+      key_var['chw_outlet_massflow']='massFlowRateCooling'
+      key_var['chw_outlet_temp']='ChilledWaterReturnTemperature[C]'
+      key_var['chw_inlet_temp']='ChilledWaterSupplyTemperature[C]'
+      #Extract time series
+      extract_timeseries_into_matrix(sqlFile, rows, 'System Node Temperature', key_var['chw_outlet_temp'], key_value_chw_outlet, 0, dec_places_temp,timestep)
+      extract_timeseries_into_matrix(sqlFile, rows, 'System Node Temperature', key_var['chw_inlet_temp'], key_value_chw_inlet, 0, dec_places_temp,timestep)
+      extract_timeseries_into_matrix(sqlFile, rows, 'System Node Mass Flow Rate', key_var['chw_outlet_massflow'], key_value_chw_outlet, 0, dec_places_mass_flow,timestep)
+    else
+      runner.registerWarning("No chilled water loop found. If one is expected, make sure the chilled water loop name argument provides a string present in its name.")
+    end
+
+
+    if selected_plant_loops[0].nil? and selected_plant_loops[1].nil?
+      runner.registerWarning("No HVAC plant loops found. If one or more plant loops are expected, make sure they follow the naming conventions mentioned in the previous warnings.")
+    end
+
+    if !selected_plant_loops.nil?
+      # convert this to CSV object
+      File.open('./building_loads.csv', 'w') do |f|
+        rows.each do |row|
+          f << row.join(',') << "\n"
+        end
       end
-	end 
-   end 
+    end
 
     true
   ensure
     sqlFile&.close
   end
-  end 
+end
 
 
 # register the measure to be used by the application

data/lib/measures/export_time_series_modelica/resources/os_lib_helper_methods.rb

@@ -396,4 +396,4 @@ module OsLib_HelperMethods
 
   # OpenStudio has built in helper for unit conversion. That can be done using OpenStudio::convert() as shown below.
   # OpenStudio::convert(double,"from unit string","to unit string").get
-end
+end

data/lib/urbanopt/reporting/default_reports/feature_report.rb

@@ -40,6 +40,7 @@ require_relative  'thermal_storage'
 
 require 'json-schema'
 require 'json'
+require 'fileutils'
 
 module URBANopt
   module Reporting
@@ -244,6 +245,7 @@ module URBANopt
           Dir.mkdir(results_dir_path) unless Dir.exist?(File.join(@directory_name, 'feature_reports'))
 
           @timeseries_csv.path = File.join(@directory_name, 'feature_reports', file_name + '.csv')
+          FileUtils.mkdir_p File.dirname(@timeseries_csv.path)
           @timeseries_csv.save_data
 
           ## save json rport
@@ -270,7 +272,7 @@ module URBANopt
 
           return true
         end
-        
+
         ##
         # Calls the individual functions to save 'default_feature_report.json' and 'default_feature_report.csv'
         # For backward compatibility and ease of use

data/lib/urbanopt/reporting/version.rb

@@ -30,6 +30,6 @@
 
 module URBANopt
   module Reporting
-    VERSION = '0.3.3'.freeze
+    VERSION = '0.3.4'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: urbanopt-reporting
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - Rawad El Kontar
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-01-13 00:00:00.000000000 Z
+date: 2021-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler