urbanopt-cli 0.4.1 → 0.5.0

data/example_files/resources/hpxml-measures/HPXMLtoOpenStudio/resources/airflow.rb

@@ -71,6 +71,9 @@ class Airflow
       end
     end
 
+    # Vented clothes dryers in conditioned space
+    vented_dryers = clothes_dryers.select { |cd| cd.is_vented && cd.vented_flow_rate.to_f > 0 && [HPXML::LocationLivingSpace, HPXML::LocationBasementConditioned].include?(cd.location) }
+
     # Initialization
     initialize_cfis(model, vent_fans_mech, hvac_map)
     model.getAirLoopHVACs.each do |air_loop|
@@ -90,7 +93,7 @@ class Airflow
 
     @wind_speed = set_wind_speed_correction(model, site_type, shelter_coef, min_neighbor_distance)
     apply_natural_ventilation_and_whole_house_fan(model, weather, vent_fans_whf, open_window_area, nv_clg_ssn_sensor)
-    apply_infiltration_and_ventilation_fans(model, weather, vent_fans_mech, vent_fans_kitchen, vent_fans_bath, clothes_dryers,
+    apply_infiltration_and_ventilation_fans(model, weather, vent_fans_mech, vent_fans_kitchen, vent_fans_bath, vented_dryers,
                                             has_flue_chimney, air_infils, vented_attic, vented_crawl, hvac_map, schedules_file)
   end
 
@@ -262,14 +265,14 @@ class Airflow
     nv_flow.setName(Constants.ObjectNameNaturalVentilation + ' flow')
     nv_flow.setSchedule(model.alwaysOnDiscreteSchedule)
     nv_flow.setSpace(@living_space)
-    nv_flow_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(nv_flow, 'Zone Infiltration', 'Air Exchange Flow Rate')
+    nv_flow_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(nv_flow, *EPlus::EMSActuatorZoneInfiltrationFlowRate)
     nv_flow_actuator.setName("#{nv_flow.name} act")
 
     whf_flow = OpenStudio::Model::SpaceInfiltrationDesignFlowRate.new(model)
     whf_flow.setName(Constants.ObjectNameWholeHouseFan + ' flow')
     whf_flow.setSchedule(model.alwaysOnDiscreteSchedule)
     whf_flow.setSpace(@living_space)
-    whf_flow_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(whf_flow, 'Zone Infiltration', 'Air Exchange Flow Rate')
+    whf_flow_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(whf_flow, *EPlus::EMSActuatorZoneInfiltrationFlowRate)
     whf_flow_actuator.setName("#{whf_flow.name} act")
 
     # Electric Equipment (for whole house fan electricity consumption)
@@ -283,7 +286,7 @@ class Airflow
     whf_equip_def.setFractionLost(1)
     whf_equip.setSchedule(model.alwaysOnDiscreteSchedule)
     whf_equip.setEndUseSubcategory(Constants.ObjectNameWholeHouseFan)
-    whf_elec_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(whf_equip, 'ElectricEquipment', 'Electric Power Level')
+    whf_elec_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(whf_equip, *EPlus::EMSActuatorElectricEquipmentPower)
     whf_elec_actuator.setName("#{whf_equip.name} act")
 
     # Assume located in attic floor if attic zone exists; otherwise assume it's through roof/wall.
@@ -298,7 +301,7 @@ class Airflow
       zone_mixing = OpenStudio::Model::ZoneMixing.new(whf_zone)
       zone_mixing.setName("#{Constants.ObjectNameWholeHouseFan} mix")
       zone_mixing.setSourceZone(@living_zone)
-      liv_to_zone_flow_rate_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(zone_mixing, 'ZoneMixing', 'Air Exchange Flow Rate')
+      liv_to_zone_flow_rate_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(zone_mixing, *EPlus::EMSActuatorZoneMixingFlowRate)
       liv_to_zone_flow_rate_actuator.setName("#{zone_mixing.name} act")
     end
 
@@ -431,7 +434,7 @@ class Airflow
     if hpxml_fuel_type.nil?
       other_equip.setFuelType('None')
     else
-      other_equip.setFuelType(EPlus.input_fuel_map(hpxml_fuel_type))
+      other_equip.setFuelType(EPlus.fuel_type(hpxml_fuel_type))
     end
     if not end_use.nil?
       other_equip.setEndUseSubcategory(end_use)
@@ -441,7 +444,7 @@ class Airflow
     other_equip_def.setFractionLost(frac_lost)
     other_equip_def.setFractionLatent(frac_lat)
     other_equip_def.setFractionRadiant(0.0)
-    actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(other_equip, 'OtherEquipment', 'Power Level')
+    actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(other_equip, *EPlus::EMSActuatorOtherEquipmentPower)
     actuator.setName("#{other_equip.name} act")
     if not is_duct_load_for_report.nil?
       other_equip.additionalProperties.setFeature(Constants.IsDuctLoadForReport, is_duct_load_for_report)
@@ -516,7 +519,7 @@ class Airflow
     @fan_rtf_var[air_loop] = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(model, "#{air_loop.name} Fan RTF".gsub(' ', '_'))
 
     # Supply fan maximum mass flow rate
-    @fan_mfr_max_var[air_loop] = OpenStudio::Model::EnergyManagementSystemInternalVariable.new(model, 'Fan Maximum Mass Flow Rate')
+    @fan_mfr_max_var[air_loop] = OpenStudio::Model::EnergyManagementSystemInternalVariable.new(model, EPlus::EMSIntVarFanMFR)
     @fan_mfr_max_var[air_loop].setName("#{air_loop.name} max sup fan mfr")
     @fan_mfr_max_var[air_loop].setInternalDataIndexKeyName(supply_fan.name.to_s)
 
@@ -546,7 +549,7 @@ class Airflow
     @fan_rtf_var[fan_coil] = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(model, "#{fan_coil.name} Fan RTF".gsub(' ', '_'))
 
     # Supply fan maximum mass flow rate
-    @fan_mfr_max_var[fan_coil] = OpenStudio::Model::EnergyManagementSystemInternalVariable.new(model, 'Fan Maximum Mass Flow Rate')
+    @fan_mfr_max_var[fan_coil] = OpenStudio::Model::EnergyManagementSystemInternalVariable.new(model, EPlus::EMSIntVarFanMFR)
     @fan_mfr_max_var[fan_coil].setName("#{fan_coil.name} max sup fan mfr")
     @fan_mfr_max_var[fan_coil].setInternalDataIndexKeyName(supply_fan.name.to_s)
 
@@ -866,7 +869,7 @@ class Airflow
           zone_mixing = OpenStudio::Model::ZoneMixing.new(dest_zone)
           zone_mixing.setName("#{object_name} mix")
           zone_mixing.setSourceZone(source_zone)
-          duct_actuators[var_name] = OpenStudio::Model::EnergyManagementSystemActuator.new(zone_mixing, 'ZoneMixing', 'Air Exchange Flow Rate')
+          duct_actuators[var_name] = OpenStudio::Model::EnergyManagementSystemActuator.new(zone_mixing, *EPlus::EMSActuatorZoneMixingFlowRate)
           duct_actuators[var_name].setName("#{zone_mixing.name} act")
         end
       end
@@ -1254,10 +1257,10 @@ class Airflow
     return obj_sch_sensors
   end
 
-  def self.apply_dryer_exhaust(model, dryer_object_array, schedules_file)
+  def self.apply_dryer_exhaust(model, vented_dryers, schedules_file)
     obj_sch_sensors = {}
     obj_type_name = Constants.ObjectNameClothesDryerExhaust
-    dryer_object_array.each_with_index do |dryer_object, index|
+    vented_dryers.each_with_index do |vented_dryer, index|
       obj_name = "#{obj_type_name} #{index}"
 
       if not schedules_file.nil?
@@ -1274,7 +1277,7 @@ class Airflow
       obj_sch_sensor = OpenStudio::Model::EnergyManagementSystemSensor.new(model, 'Schedule Value')
       obj_sch_sensor.setName("#{obj_name} sch s")
       obj_sch_sensor.setKeyName(obj_sch_name)
-      obj_sch_sensors[dryer_object.id] = obj_sch_sensor
+      obj_sch_sensors[vented_dryer.id] = obj_sch_sensor
     end
 
     return obj_sch_sensors
@@ -1436,7 +1439,7 @@ class Airflow
     vent_mech_fan_actuator = nil
     if is_cfis # actuate its power level in EMS
       equip_def.setFractionLost(0.0) # Fan heat does enter space
-      vent_mech_fan_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(equip, 'ElectricEquipment', 'Electric Power Level')
+      vent_mech_fan_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(equip, *EPlus::EMSActuatorElectricEquipmentPower)
       vent_mech_fan_actuator.setName("#{equip.name} act")
     else
       equip_def.setDesignLevel(pow)
@@ -1469,8 +1472,8 @@ class Airflow
     return fan_sens_load_actuator, fan_lat_load_actuator
   end
 
-  def self.apply_infiltration_adjustment(infil_program, vent_fans_kitchen, vent_fans_bath, clothes_dryers, sup_cfm_tot, exh_cfm_tot, bal_cfm_tot, erv_hrv_cfm_tot,
-                                         infil_flow_actuator, cd_flow_actuator, range_sch_sensors_map, bath_sch_sensors_map, dryer_exhaust_sch_sensors_map)
+  def self.apply_infiltration_adjustment(infil_program, vent_fans_kitchen, vent_fans_bath, vented_dryers, sup_cfm_tot, exh_cfm_tot, bal_cfm_tot, erv_hrv_cfm_tot,
+                                         infil_flow_actuator, range_sch_sensors_map, bath_sch_sensors_map, dryer_exhaust_sch_sensors_map)
     infil_program.addLine('Set Qrange = 0')
     vent_fans_kitchen.each do |vent_kitchen|
       infil_program.addLine("Set Qrange = Qrange + #{UnitConversions.convert(vent_kitchen.rated_flow_rate * vent_kitchen.quantity, 'cfm', 'm^3/s').round(4)} * #{range_sch_sensors_map[vent_kitchen.id].name}")
@@ -1482,10 +1485,8 @@ class Airflow
     end
 
     infil_program.addLine('Set Qdryer = 0')
-    clothes_dryers.each do |clothes_dryer|
-      next unless clothes_dryer.is_vented
-
-      infil_program.addLine("Set Qdryer = Qdryer + #{UnitConversions.convert(clothes_dryer.vented_flow_rate, 'cfm', 'm^3/s').round(4)} * #{dryer_exhaust_sch_sensors_map[clothes_dryer.id].name}")
+    vented_dryers.each do |vented_dryer|
+      infil_program.addLine("Set Qdryer = Qdryer + #{UnitConversions.convert(vented_dryer.vented_flow_rate, 'cfm', 'm^3/s').round(4)} * #{dryer_exhaust_sch_sensors_map[vented_dryer.id].name}")
     end
 
     infil_program.addLine("Set QWHV_sup = #{UnitConversions.convert(sup_cfm_tot, 'cfm', 'm^3/s').round(4)}")
@@ -1516,7 +1517,6 @@ class Airflow
       infil_program.addLine('Set Qinf_adj = Qtot - Qu - Qb')
     end
     infil_program.addLine("Set #{infil_flow_actuator.name} = Qinf_adj")
-    infil_program.addLine("Set #{cd_flow_actuator.name} = Qdryer")
   end
 
   def self.calculate_fan_loads(model, infil_program, vent_mech_erv_hrv_tot, hrv_erv_effectiveness_map, fan_sens_load_actuator, fan_lat_load_actuator, q_var, preconditioned = false)
@@ -1605,7 +1605,7 @@ class Airflow
     end
   end
 
-  def self.apply_mechanical_ventilation(model, vent_fans_mech, living_ach50, living_const_ach, weather, vent_fans_kitchen, vent_fans_bath, clothes_dryers,
+  def self.apply_mechanical_ventilation(model, vent_fans_mech, living_ach50, living_const_ach, weather, vent_fans_kitchen, vent_fans_bath, vented_dryers,
                                         range_sch_sensors_map, bath_sch_sensors_map, dryer_exhaust_sch_sensors_map, has_flue_chimney, hvac_map)
     # Categorize fans into different types
     vent_mech_preheat = vent_fans_mech.select { |vent_mech| (not vent_mech.preheating_efficiency_cop.nil?) }
@@ -1679,16 +1679,9 @@ class Airflow
     infil_flow.setName(Constants.ObjectNameInfiltration + ' flow')
     infil_flow.setSchedule(model.alwaysOnDiscreteSchedule)
     infil_flow.setSpace(@living_space)
-    infil_flow_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(infil_flow, 'Zone Infiltration', 'Air Exchange Flow Rate')
+    infil_flow_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(infil_flow, *EPlus::EMSActuatorZoneInfiltrationFlowRate)
     infil_flow_actuator.setName("#{infil_flow.name} act")
 
-    cd_flow = OpenStudio::Model::SpaceInfiltrationDesignFlowRate.new(model)
-    cd_flow.setName(Constants.ObjectNameClothesDryerExhaust + ' flow')
-    cd_flow.setSchedule(model.alwaysOnDiscreteSchedule)
-    cd_flow.setSpace(@living_space)
-    cd_flow_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(cd_flow, 'Zone Infiltration', 'Air Exchange Flow Rate')
-    cd_flow_actuator.setName("#{cd_flow.name} act")
-
     # Living Space Infiltration Calculation/Program
     infil_program = OpenStudio::Model::EnergyManagementSystemProgram.new(model)
     infil_program.setName(Constants.ObjectNameInfiltration + ' program')
@@ -1705,8 +1698,8 @@ class Airflow
 
     # Calculate Qfan, Qinf_adj
     # Calculate adjusted infiltration based on mechanical ventilation system
-    apply_infiltration_adjustment(infil_program, vent_fans_kitchen, vent_fans_bath, clothes_dryers, sup_cfm_tot, exh_cfm_tot, bal_cfm_tot, erv_hrv_cfm_tot,
-                                  infil_flow_actuator, cd_flow_actuator, range_sch_sensors_map, bath_sch_sensors_map, dryer_exhaust_sch_sensors_map)
+    apply_infiltration_adjustment(infil_program, vent_fans_kitchen, vent_fans_bath, vented_dryers, sup_cfm_tot, exh_cfm_tot, bal_cfm_tot, erv_hrv_cfm_tot,
+                                  infil_flow_actuator, range_sch_sensors_map, bath_sch_sensors_map, dryer_exhaust_sch_sensors_map)
 
     # Address load of Qfan (Qload)
     # Qload as variable for tracking outdoor air flow rate, excluding recirculation
@@ -1726,7 +1719,7 @@ class Airflow
     program_calling_manager.addProgram(infil_program)
   end
 
-  def self.apply_infiltration_and_ventilation_fans(model, weather, vent_fans_mech, vent_fans_kitchen, vent_fans_bath, clothes_dryers,
+  def self.apply_infiltration_and_ventilation_fans(model, weather, vent_fans_mech, vent_fans_kitchen, vent_fans_bath, vented_dryers,
                                                    has_flue_chimney, air_infils, vented_attic, vented_crawl, hvac_map, schedules_file)
     # Get living space infiltration
     living_ach50 = nil
@@ -1761,10 +1754,10 @@ class Airflow
     bath_sch_sensors_map = apply_local_ventilation(model, vent_fans_bath, Constants.ObjectNameMechanicalVentilationBathFan)
 
     # Clothes dryer exhaust
-    dryer_exhaust_sch_sensors_map = apply_dryer_exhaust(model, clothes_dryers, schedules_file)
+    dryer_exhaust_sch_sensors_map = apply_dryer_exhaust(model, vented_dryers, schedules_file)
 
     # Get mechanical ventilation
-    apply_mechanical_ventilation(model, vent_fans_mech, living_ach50, living_const_ach, weather, vent_fans_kitchen, vent_fans_bath, clothes_dryers,
+    apply_mechanical_ventilation(model, vent_fans_mech, living_ach50, living_const_ach, weather, vent_fans_kitchen, vent_fans_bath, vented_dryers,
                                  range_sch_sensors_map, bath_sch_sensors_map, dryer_exhaust_sch_sensors_map, has_flue_chimney, hvac_map)
   end
 

data/example_files/resources/hpxml-measures/HPXMLtoOpenStudio/resources/constants.rb

@@ -281,10 +281,6 @@ class Constants
     return 'mech vent range fan'
   end
 
-  def self.ObjectNameMechanicalVentilationAirflow
-    return 'Qfan'
-  end
-
   def self.ObjectNameMiniSplitHeatPump
     return 'mini split heat pump'
   end
@@ -449,6 +445,10 @@ class Constants
     return __method__.to_s
   end
 
+  def self.SizingInfoHVACFanWatts
+    return __method__.to_s
+  end
+
   def self.SizingInfoHVACFracHeatLoadServed
     return __method__.to_s
   end
@@ -509,18 +509,10 @@ class Constants
     return __method__.to_s
   end
 
-  def self.SizingInfoHVACCoolingCFMs
-    return __method__.to_s
-  end
-
   def self.SizingInfoHVACHeatingCapacityOffset
     return __method__.to_s
   end
 
-  def self.SizingInfoHVACHeatingCFMs
-    return __method__.to_s
-  end
-
   def self.SizingInfoHVACRatedCFMperTonHeating
     return __method__.to_s
   end

data/example_files/resources/hpxml-measures/HPXMLtoOpenStudio/resources/constructions.rb

@@ -839,11 +839,11 @@ class Constructions
     surface.createSurfacePropertyExposedFoundationPerimeter('TotalExposedPerimeter', UnitConversions.convert(exposed_perimeter, 'ft', 'm'))
   end
 
-  def self.apply_door(runner, model, subsurfaces, constr_name, ufactor)
+  def self.apply_door(runner, model, subsurfaces, constr_name, ufactor, inside_film, outside_film)
     return if subsurfaces.empty?
 
     # Define materials
-    door_Rvalue = 1.0 / ufactor - Material.AirFilmOutside.rvalue - Material.AirFilmVertical.rvalue
+    door_Rvalue = 1.0 / ufactor - inside_film.rvalue - outside_film.rvalue
     door_thickness = 1.75 # in
     fin_door_mat = Material.new(name = 'DoorMaterial', thick_in = door_thickness, mat_base = BaseMaterial.Wood, k_in = 1.0 / door_Rvalue * door_thickness)
 
@@ -858,18 +858,18 @@ class Constructions
     constr.create_and_assign_constructions(runner, subsurfaces, model)
   end
 
-  def self.apply_window(runner, model, subsurfaces, constr_name, weather,
-                        is_sch, ufactor, shgc, heat_shade_mult, cool_shade_mult)
+  def self.apply_window(runner, model, subsurface, constr_name, weather,
+                        heat_sch, cool_sch, ufactor, shgc, heat_shade_mult, cool_shade_mult)
 
-    apply_window_skylight(runner, model, 'Window', subsurfaces, constr_name, weather,
-                          is_sch, ufactor, shgc, heat_shade_mult, cool_shade_mult)
+    apply_window_skylight(runner, model, 'Window', subsurface, constr_name, weather,
+                          heat_sch, cool_sch, ufactor, shgc, heat_shade_mult, cool_shade_mult)
   end
 
-  def self.apply_skylight(runner, model, subsurfaces, constr_name, weather,
-                          is_sch, ufactor, shgc, heat_shade_mult, cool_shade_mult)
+  def self.apply_skylight(runner, model, subsurface, constr_name, weather,
+                          heat_sch, cool_sch, ufactor, shgc, heat_shade_mult, cool_shade_mult)
 
-    apply_window_skylight(runner, model, 'Skylight', subsurfaces, constr_name, weather,
-                          is_sch, ufactor, shgc, heat_shade_mult, cool_shade_mult)
+    apply_window_skylight(runner, model, 'Skylight', subsurface, constr_name, weather,
+                          heat_sch, cool_sch, ufactor, shgc, heat_shade_mult, cool_shade_mult)
   end
 
   def self.apply_partition_walls(runner, model, constr_name, drywall_thick_in, frac_of_ffa,
@@ -972,7 +972,8 @@ class Constructions
   end
 
   def self.create_os_int_mass_and_def(model, object_name, space, area)
-    # create internal mass objects
+    # EnergyPlus documentation: If both sides of the surface exchange energy with the zone
+    # then the user should input twice the area when defining the Internal Mass object.
     imdef = OpenStudio::Model::InternalMassDefinition.new(model)
     imdef.setName(object_name)
     imdef.setSurfaceArea(area)
@@ -1178,55 +1179,61 @@ class Constructions
     return mat
   end
 
-  def self.apply_window_skylight(runner, model, type, subsurfaces, constr_name, weather,
-                                 is_sch, ufactor, shgc, heat_shade_mult, cool_shade_mult)
-
-    return if subsurfaces.empty?
+  def self.apply_window_skylight(runner, model, type, subsurface, constr_name, weather,
+                                 heat_sch, cool_sch, ufactor, shgc, heat_shade_mult, cool_shade_mult)
 
     # Define shade and schedule
-    sc = nil
-    if (cool_shade_mult < 1) || (heat_shade_mult < 1)
-      # EnergyPlus doesn't like shades that absorb no heat, transmit no heat or reflect no heat.
-      if cool_shade_mult == 1
-        cool_shade_mult = 0.999
-      end
-      if heat_shade_mult == 1
-        heat_shade_mult = 0.999
+    { 'Cooling' => [cool_sch, cool_shade_mult],
+      'Heating' => [heat_sch, heat_shade_mult] }.each do |mode, values|
+      sch, shade_mult = values
+      next if shade_mult >= 1.0
+
+      shade_name = "#{type}#{mode}Shade"
+      sc_name = "#{type}#{mode}ShadingControl"
+
+      # Reuse existing Shade?
+      # Note: We still create a unique ShadingControl per subsurface in order to
+      # prevent the shading control from being used by subsurfaces in different
+      # zones, which is probably not a good idea.
+      sm = nil
+      model.getShades.each do |shade|
+        next unless (shade.solarTransmittance - shade_mult).abs < 0.0001
+        next unless shade.name.to_s.start_with? shade_name
+
+        sm = shade
+        break
       end
 
-      total_shade_trans = cool_shade_mult / heat_shade_mult * 0.999
-      total_shade_abs = 0.00001
-      total_shade_ref = 1 - total_shade_trans - total_shade_abs
-
-      # CoolingShade
-      sm = OpenStudio::Model::Shade.new(model)
-      sm.setName("#{type}CoolingShade")
-      sm.setSolarTransmittance(total_shade_trans)
-      sm.setSolarReflectance(total_shade_ref)
-      sm.setVisibleTransmittance(total_shade_trans)
-      sm.setVisibleReflectance(total_shade_ref)
-      sm.setThermalHemisphericalEmissivity(total_shade_abs)
-      sm.setThermalTransmittance(total_shade_trans)
-      sm.setThickness(0.0001)
-      sm.setConductivity(10000)
-      sm.setShadetoGlassDistance(0.001)
-      sm.setTopOpeningMultiplier(0)
-      sm.setBottomOpeningMultiplier(0)
-      sm.setLeftSideOpeningMultiplier(0)
-      sm.setRightSideOpeningMultiplier(0)
-      sm.setAirflowPermeability(0)
+      if sm.nil?
+        shade_abs = 0.00001
+        shade_ref = 1.0 - shade_mult - shade_abs
+
+        # Shade
+        sm = OpenStudio::Model::Shade.new(model)
+        sm.setName(shade_name)
+        sm.setSolarTransmittance(shade_mult)
+        sm.setSolarReflectance(shade_ref)
+        sm.setVisibleTransmittance(shade_mult)
+        sm.setVisibleReflectance(shade_ref)
+        sm.setThermalHemisphericalEmissivity(shade_abs)
+        sm.setThermalTransmittance(shade_mult)
+        sm.setThickness(0.0001)
+        sm.setConductivity(10000)
+        sm.setShadetoGlassDistance(0.001)
+        sm.setTopOpeningMultiplier(0)
+        sm.setBottomOpeningMultiplier(0)
+        sm.setLeftSideOpeningMultiplier(0)
+        sm.setRightSideOpeningMultiplier(0)
+        sm.setAirflowPermeability(0)
+      end
 
       # ShadingControl
       sc = OpenStudio::Model::ShadingControl.new(sm)
-      sc.setName("#{type}ShadingControl")
+      sc.setName(sc_name)
       sc.setShadingType('InteriorShade')
       sc.setShadingControlType('OnIfScheduleAllows')
-      sc.setSchedule(is_sch.schedule)
-
-      # Add shading controls
-      subsurfaces.each do |subsurface|
-        subsurface.setShadingControl(sc)
-      end
+      sc.setSchedule(sch.schedule)
+      subsurface.addShadingControl(sc)
     end
 
     # Define materials
@@ -1238,7 +1245,7 @@ class Constructions
       # by 1.20." Thus we divide by 1.2 to get the vertical position value.
       ufactor /= 1.2
     end
-    glaz_mat = GlazingMaterial.new("#{type}Material", ufactor, shgc * heat_shade_mult)
+    glaz_mat = GlazingMaterial.new("#{type}Material", ufactor, shgc)
 
     # Set paths
     path_fracs = [1]
@@ -1248,7 +1255,7 @@ class Constructions
     constr.add_layer(glaz_mat)
 
     # Create and assign construction to subsurfaces
-    constr.create_and_assign_constructions(runner, subsurfaces, model)
+    constr.create_and_assign_constructions(runner, [subsurface], model)
   end
 end
 

data/example_files/resources/hpxml-measures/HPXMLtoOpenStudio/resources/energyplus.rb

@@ -2,7 +2,16 @@
 
 class EPlus
   # Constants
-  FuelTypeElectricity = 'electricity'
+  EMSActuatorElectricEquipmentPower = 'ElectricEquipment', 'Electricity Rate'
+  EMSActuatorOtherEquipmentPower = 'OtherEquipment', 'Power Level'
+  EMSActuatorPumpMassFlowRate = 'Pump', 'Pump Mass Flow Rate'
+  EMSActuatorPumpPressureRise = 'Pump', 'Pump Pressure Rise'
+  EMSActuatorScheduleConstantValue = 'Schedule:Constant', 'Schedule Value'
+  EMSActuatorZoneInfiltrationFlowRate = 'Zone Infiltration', 'Air Exchange Flow Rate'
+  EMSActuatorZoneMixingFlowRate = 'ZoneMixing', 'Air Exchange Flow Rate'
+  EMSIntVarFanMFR = 'Fan Maximum Mass Flow Rate'
+  EMSIntVarPumpMFR = 'Pump Maximum Mass Flow Rate'
+  FuelTypeElectricity = 'Electricity'
   FuelTypeNaturalGas = 'NaturalGas'
   FuelTypeOil = 'FuelOilNo2'
   FuelTypePropane = 'Propane'
@@ -10,7 +19,7 @@ class EPlus
   FuelTypeWoodPellets = 'OtherFuel2'
   FuelTypeCoal = 'Coal'
 
-  def self.input_fuel_map(hpxml_fuel)
+  def self.fuel_type(hpxml_fuel)
     # Name of fuel used as inputs to E+ objects
     if [HPXML::FuelTypeElectricity].include? hpxml_fuel
       return FuelTypeElectricity
@@ -39,17 +48,4 @@ class EPlus
       fail "Unexpected HPXML fuel '#{hpxml_fuel}'."
     end
   end
-
-  def self.output_fuel_map(ep_fuel)
-    # Name of fuel used in E+ outputs
-    if ep_fuel == FuelTypeElectricity
-      return 'Electric'
-    elsif ep_fuel == FuelTypeNaturalGas
-      return 'Gas'
-    elsif ep_fuel == FuelTypeOil
-      return 'FuelOil#2'
-    else
-      return ep_fuel
-    end
-  end
 end