urbanopt-cli 0.10.0 → 0.11.1

data/example_files/resources/hpxml-measures/HPXMLtoOpenStudio/resources/lighting.rb

@@ -1,7 +1,13 @@
+# *********************************************************************************
+# URBANopt (tm), Copyright (c) Alliance for Sustainable Energy, LLC.
+# See also https://github.com/urbanopt/urbanopt-cli/blob/develop/LICENSE.md
+# *********************************************************************************
+
 # frozen_string_literal: true
 
 class Lighting
-  def self.apply(runner, model, epw_file, spaces, lighting_groups, lighting, eri_version, schedules_file, cfa, unavailable_periods)
+  def self.apply(runner, model, epw_file, spaces, lighting_groups, lighting, eri_version, schedules_file, cfa,
+                 unavailable_periods, unit_multiplier)
     ltg_locns = [HPXML::LocationInterior, HPXML::LocationExterior, HPXML::LocationGarage]
     ltg_types = [HPXML::LightingTypeCFL, HPXML::LightingTypeLFL, HPXML::LightingTypeLED]
 
@@ -21,10 +27,10 @@ class Lighting
       int_kwh = calc_interior_energy(eri_version, cfa,
                                      fractions[[HPXML::LocationInterior, HPXML::LightingTypeCFL]],
                                      fractions[[HPXML::LocationInterior, HPXML::LightingTypeLFL]],
-                                     fractions[[HPXML::LocationInterior, HPXML::LightingTypeLED]],
-                                     lighting.interior_usage_multiplier)
+                                     fractions[[HPXML::LocationInterior, HPXML::LightingTypeLED]])
     end
     int_kwh = 0.0 if int_kwh.nil?
+    int_kwh *= lighting.interior_usage_multiplier unless lighting.interior_usage_multiplier.nil?
 
     # Calculate exterior lighting kWh/yr
     ext_kwh = kwhs_per_year[HPXML::LocationExterior]
@@ -32,26 +38,29 @@ class Lighting
       ext_kwh = calc_exterior_energy(eri_version, cfa,
                                      fractions[[HPXML::LocationExterior, HPXML::LightingTypeCFL]],
                                      fractions[[HPXML::LocationExterior, HPXML::LightingTypeLFL]],
-                                     fractions[[HPXML::LocationExterior, HPXML::LightingTypeLED]],
-                                     lighting.exterior_usage_multiplier)
+                                     fractions[[HPXML::LocationExterior, HPXML::LightingTypeLED]])
     end
     ext_kwh = 0.0 if ext_kwh.nil?
+    ext_kwh *= lighting.exterior_usage_multiplier unless lighting.exterior_usage_multiplier.nil?
+    ext_kwh *= unit_multiplier # Not in a thermal zone, so needs to be explicitly multiplied
 
     # Calculate garage lighting kWh/yr
-    grg_kwh = kwhs_per_year[HPXML::LocationGarage]
-    if grg_kwh.nil?
-      gfa = 0 # Garage floor area
-      if spaces.keys.include? HPXML::LocationGarage
-        gfa = UnitConversions.convert(spaces[HPXML::LocationGarage].floorArea, 'm^2', 'ft^2')
+    gfa = 0 # Garage floor area
+    if spaces.keys.include? HPXML::LocationGarage
+      gfa = UnitConversions.convert(spaces[HPXML::LocationGarage].floorArea, 'm^2', 'ft^2')
+    end
+    if gfa > 0
+      grg_kwh = kwhs_per_year[HPXML::LocationGarage]
+      if grg_kwh.nil?
+
+        grg_kwh = calc_garage_energy(eri_version, gfa,
+                                     fractions[[HPXML::LocationGarage, HPXML::LightingTypeCFL]],
+                                     fractions[[HPXML::LocationGarage, HPXML::LightingTypeLFL]],
+                                     fractions[[HPXML::LocationGarage, HPXML::LightingTypeLED]])
       end
-
-      grg_kwh = calc_garage_energy(eri_version, gfa,
-                                   fractions[[HPXML::LocationGarage, HPXML::LightingTypeCFL]],
-                                   fractions[[HPXML::LocationGarage, HPXML::LightingTypeLFL]],
-                                   fractions[[HPXML::LocationGarage, HPXML::LightingTypeLED]],
-                                   lighting.garage_usage_multiplier)
     end
     grg_kwh = 0.0 if grg_kwh.nil?
+    grg_kwh *= lighting.garage_usage_multiplier unless lighting.garage_usage_multiplier.nil?
 
     # Add lighting to conditioned space
     if int_kwh > 0
@@ -59,14 +68,15 @@ class Lighting
       # Create schedule
       interior_sch = nil
       interior_col_name = SchedulesFile::ColumnLightingInterior
+      interior_obj_name = Constants.ObjectNameLightingInterior
       if not schedules_file.nil?
         design_level = schedules_file.calc_design_level_from_annual_kwh(col_name: interior_col_name, annual_kwh: int_kwh)
-        interior_sch = schedules_file.create_schedule_file(col_name: interior_col_name)
+        interior_sch = schedules_file.create_schedule_file(model, col_name: interior_col_name)
       end
       if interior_sch.nil?
         interior_unavailable_periods = Schedule.get_unavailable_periods(runner, interior_col_name, unavailable_periods)
         if not lighting.interior_weekday_fractions.nil?
-          interior_sch = MonthWeekdayWeekendSchedule.new(model, Constants.ObjectNameInteriorLighting + ' schedule', lighting.interior_weekday_fractions, lighting.interior_weekend_fractions, lighting.interior_monthly_multipliers, Constants.ScheduleTypeLimitsFraction, unavailable_periods: interior_unavailable_periods)
+          interior_sch = MonthWeekdayWeekendSchedule.new(model, interior_obj_name + ' schedule', lighting.interior_weekday_fractions, lighting.interior_weekend_fractions, lighting.interior_monthly_multipliers, Constants.ScheduleTypeLimitsFraction, unavailable_periods: interior_unavailable_periods)
         else
           lighting_sch = get_schedule(epw_file)
           interior_sch = HourlyByMonthSchedule.new(model, 'lighting schedule', lighting_sch, lighting_sch, Constants.ScheduleTypeLimitsFraction, unavailable_periods: interior_unavailable_periods)
@@ -87,10 +97,10 @@ class Lighting
       # Add lighting
       ltg_def = OpenStudio::Model::LightsDefinition.new(model)
       ltg = OpenStudio::Model::Lights.new(ltg_def)
-      ltg.setName(Constants.ObjectNameInteriorLighting)
-      ltg.setSpace(spaces[HPXML::LocationLivingSpace])
-      ltg.setEndUseSubcategory(Constants.ObjectNameInteriorLighting)
-      ltg_def.setName(Constants.ObjectNameInteriorLighting)
+      ltg.setName(interior_obj_name)
+      ltg.setSpace(spaces[HPXML::LocationConditionedSpace])
+      ltg.setEndUseSubcategory(interior_obj_name)
+      ltg_def.setName(interior_obj_name)
       ltg_def.setLightingLevel(design_level)
       ltg_def.setFractionRadiant(0.6)
       ltg_def.setFractionVisible(0.2)
@@ -104,13 +114,14 @@ class Lighting
       # Create schedule
       garage_sch = nil
       garage_col_name = SchedulesFile::ColumnLightingGarage
+      garage_obj_name = Constants.ObjectNameLightingGarage
       if not schedules_file.nil?
         design_level = schedules_file.calc_design_level_from_annual_kwh(col_name: garage_col_name, annual_kwh: grg_kwh)
-        garage_sch = schedules_file.create_schedule_file(col_name: garage_col_name)
+        garage_sch = schedules_file.create_schedule_file(model, col_name: garage_col_name)
       end
       if garage_sch.nil?
         garage_unavailable_periods = Schedule.get_unavailable_periods(runner, garage_col_name, unavailable_periods)
-        garage_sch = MonthWeekdayWeekendSchedule.new(model, Constants.ObjectNameGarageLighting + ' schedule', lighting.garage_weekday_fractions, lighting.garage_weekend_fractions, lighting.garage_monthly_multipliers, Constants.ScheduleTypeLimitsFraction, unavailable_periods: garage_unavailable_periods)
+        garage_sch = MonthWeekdayWeekendSchedule.new(model, garage_obj_name + ' schedule', lighting.garage_weekday_fractions, lighting.garage_weekend_fractions, lighting.garage_monthly_multipliers, Constants.ScheduleTypeLimitsFraction, unavailable_periods: garage_unavailable_periods)
         design_level = garage_sch.calc_design_level_from_daily_kwh(grg_kwh / 365.0)
         garage_sch = garage_sch.schedule
       else
@@ -122,10 +133,10 @@ class Lighting
       # Add lighting
       ltg_def = OpenStudio::Model::LightsDefinition.new(model)
       ltg = OpenStudio::Model::Lights.new(ltg_def)
-      ltg.setName(Constants.ObjectNameGarageLighting)
+      ltg.setName(garage_obj_name)
       ltg.setSpace(spaces[HPXML::LocationGarage])
-      ltg.setEndUseSubcategory(Constants.ObjectNameGarageLighting)
-      ltg_def.setName(Constants.ObjectNameGarageLighting)
+      ltg.setEndUseSubcategory(garage_obj_name)
+      ltg_def.setName(garage_obj_name)
       ltg_def.setLightingLevel(design_level)
       ltg_def.setFractionRadiant(0.6)
       ltg_def.setFractionVisible(0.2)
@@ -139,13 +150,14 @@ class Lighting
       # Create schedule
       exterior_sch = nil
       exterior_col_name = SchedulesFile::ColumnLightingExterior
+      exterior_obj_name = Constants.ObjectNameLightingExterior
       if not schedules_file.nil?
         design_level = schedules_file.calc_design_level_from_annual_kwh(col_name: exterior_col_name, annual_kwh: ext_kwh)
-        exterior_sch = schedules_file.create_schedule_file(col_name: exterior_col_name)
+        exterior_sch = schedules_file.create_schedule_file(model, col_name: exterior_col_name)
       end
       if exterior_sch.nil?
         exterior_unavailable_periods = Schedule.get_unavailable_periods(runner, exterior_col_name, unavailable_periods)
-        exterior_sch = MonthWeekdayWeekendSchedule.new(model, Constants.ObjectNameExteriorLighting + ' schedule', lighting.exterior_weekday_fractions, lighting.exterior_weekend_fractions, lighting.exterior_monthly_multipliers, Constants.ScheduleTypeLimitsFraction, unavailable_periods: exterior_unavailable_periods)
+        exterior_sch = MonthWeekdayWeekendSchedule.new(model, exterior_obj_name + ' schedule', lighting.exterior_weekday_fractions, lighting.exterior_weekend_fractions, lighting.exterior_monthly_multipliers, Constants.ScheduleTypeLimitsFraction, unavailable_periods: exterior_unavailable_periods)
         design_level = exterior_sch.calc_design_level_from_daily_kwh(ext_kwh / 365.0)
         exterior_sch = exterior_sch.schedule
       else
@@ -157,9 +169,9 @@ class Lighting
       # Add exterior lighting
       ltg_def = OpenStudio::Model::ExteriorLightsDefinition.new(model)
       ltg = OpenStudio::Model::ExteriorLights.new(ltg_def)
-      ltg.setName(Constants.ObjectNameExteriorLighting)
-      ltg.setEndUseSubcategory(Constants.ObjectNameExteriorLighting)
-      ltg_def.setName(Constants.ObjectNameExteriorLighting)
+      ltg.setName(exterior_obj_name)
+      ltg.setEndUseSubcategory(exterior_obj_name)
+      ltg_def.setName(exterior_obj_name)
       ltg_def.setDesignLevel(design_level)
       ltg.setSchedule(exterior_sch)
     end
@@ -170,14 +182,16 @@ class Lighting
       # Create schedule
       exterior_holiday_sch = nil
       exterior_holiday_col_name = SchedulesFile::ColumnLightingExteriorHoliday
+      exterior_holiday_obj_name = Constants.ObjectNameLightingExteriorHoliday
+      exterior_holiday_kwh_per_day = lighting.holiday_kwh_per_day * unit_multiplier
       if not schedules_file.nil?
-        design_level = schedules_file.calc_design_level_from_daily_kwh(col_name: exterior_holiday_col_name, daily_kwh: lighting.holiday_kwh_per_day)
-        exterior_holiday_sch = schedules_file.create_schedule_file(col_name: exterior_holiday_col_name)
+        design_level = schedules_file.calc_design_level_from_daily_kwh(col_name: exterior_holiday_col_name, daily_kwh: exterior_holiday_kwh_per_day)
+        exterior_holiday_sch = schedules_file.create_schedule_file(model, col_name: exterior_holiday_col_name)
       end
       if exterior_holiday_sch.nil?
         exterior_holiday_unavailable_periods = Schedule.get_unavailable_periods(runner, exterior_holiday_col_name, unavailable_periods)
-        exterior_holiday_sch = MonthWeekdayWeekendSchedule.new(model, Constants.ObjectNameLightingExteriorHoliday + ' schedule', lighting.holiday_weekday_fractions, lighting.holiday_weekend_fractions, lighting.exterior_monthly_multipliers, Constants.ScheduleTypeLimitsFraction, true, lighting.holiday_period_begin_month, lighting.holiday_period_begin_day, lighting.holiday_period_end_month, lighting.holiday_period_end_day, unavailable_periods: exterior_holiday_unavailable_periods)
-        design_level = exterior_holiday_sch.calc_design_level_from_daily_kwh(lighting.holiday_kwh_per_day)
+        exterior_holiday_sch = MonthWeekdayWeekendSchedule.new(model, exterior_holiday_obj_name + ' schedule', lighting.holiday_weekday_fractions, lighting.holiday_weekend_fractions, lighting.exterior_monthly_multipliers, Constants.ScheduleTypeLimitsFraction, true, lighting.holiday_period_begin_month, lighting.holiday_period_begin_day, lighting.holiday_period_end_month, lighting.holiday_period_end_day, unavailable_periods: exterior_holiday_unavailable_periods)
+        design_level = exterior_holiday_sch.calc_design_level_from_daily_kwh(exterior_holiday_kwh_per_day)
         exterior_holiday_sch = exterior_holiday_sch.schedule
       else
         runner.registerWarning("Both '#{exterior_holiday_col_name}' schedule file and weekday fractions provided; the latter will be ignored.") if !lighting.holiday_weekday_fractions.nil?
@@ -188,9 +202,9 @@ class Lighting
       # Add exterior holiday lighting
       ltg_def = OpenStudio::Model::ExteriorLightsDefinition.new(model)
       ltg = OpenStudio::Model::ExteriorLights.new(ltg_def)
-      ltg.setName(Constants.ObjectNameLightingExteriorHoliday)
-      ltg.setEndUseSubcategory(Constants.ObjectNameLightingExteriorHoliday)
-      ltg_def.setName(Constants.ObjectNameLightingExteriorHoliday)
+      ltg.setName(exterior_holiday_obj_name)
+      ltg.setEndUseSubcategory(exterior_holiday_obj_name)
+      ltg_def.setName(exterior_holiday_obj_name)
       ltg_def.setDesignLevel(design_level)
       ltg.setSchedule(exterior_holiday_sch)
     end
@@ -212,7 +226,7 @@ class Lighting
 
   private
 
-  def self.calc_interior_energy(eri_version, cfa, f_int_cfl, f_int_lfl, f_int_led, interior_usage_multiplier = 1.0)
+  def self.calc_interior_energy(eri_version, cfa, f_int_cfl, f_int_lfl, f_int_led)
     return if f_int_cfl.nil? || f_int_lfl.nil? || f_int_led.nil?
 
     if Constants.ERIVersions.index(eri_version) >= Constants.ERIVersions.index('2014AEG')
@@ -245,12 +259,10 @@ class Lighting
       int_kwh = 0.8 * ((4.0 - 3.0 * fF_int) / 3.7) * (455.0 + 0.8 * cfa) + 0.2 * (455.0 + 0.8 * cfa)
     end
 
-    int_kwh *= interior_usage_multiplier
-
     return int_kwh
   end
 
-  def self.calc_exterior_energy(eri_version, cfa, f_ext_cfl, f_ext_lfl, f_ext_led, exterior_usage_multiplier = 1.0)
+  def self.calc_exterior_energy(eri_version, cfa, f_ext_cfl, f_ext_lfl, f_ext_led)
     return if f_ext_cfl.nil? || f_ext_lfl.nil? || f_ext_led.nil?
 
     if Constants.ERIVersions.index(eri_version) >= Constants.ERIVersions.index('2014AEG')
@@ -283,12 +295,10 @@ class Lighting
       ext_kwh = (100.0 + 0.05 * cfa) * (1.0 - fF_ext) + 0.25 * (100.0 + 0.05 * cfa) * fF_ext
     end
 
-    ext_kwh *= exterior_usage_multiplier
-
     return ext_kwh
   end
 
-  def self.calc_garage_energy(eri_version, gfa, f_grg_cfl, f_grg_lfl, f_grg_led, garage_usage_multiplier = 1.0)
+  def self.calc_garage_energy(eri_version, gfa, f_grg_cfl, f_grg_lfl, f_grg_led)
     return if f_grg_cfl.nil? || f_grg_lfl.nil? || f_grg_led.nil?
 
     if Constants.ERIVersions.index(eri_version) >= Constants.ERIVersions.index('2014AEG')
@@ -327,8 +337,6 @@ class Lighting
       end
     end
 
-    grg_kwh *= garage_usage_multiplier
-
     return grg_kwh
   end
 

data/example_files/resources/hpxml-measures/HPXMLtoOpenStudio/resources/location.rb

@@ -1,17 +1,16 @@
+# *********************************************************************************
+# URBANopt (tm), Copyright (c) Alliance for Sustainable Energy, LLC.
+# See also https://github.com/urbanopt/urbanopt-cli/blob/develop/LICENSE.md
+# *********************************************************************************
+
 # frozen_string_literal: true
 
 class Location
-  def self.apply(model, weather, epw_file, hpxml)
-    apply_year(model, hpxml, epw_file)
+  def self.apply(model, weather, epw_file, hpxml_header, hpxml_bldg)
+    apply_year(model, hpxml_header, epw_file)
     apply_site(model, epw_file)
-    apply_dst(model, hpxml)
-    apply_ground_temps(model, weather)
-  end
-
-  def self.apply_weather_file(model, epw_path)
-    epw_file = OpenStudio::EpwFile.new(epw_path)
-    OpenStudio::Model::WeatherFile.setWeatherFile(model, epw_file)
-    return epw_file
+    apply_dst(model, hpxml_bldg)
+    apply_ground_temps(model, weather, hpxml_bldg)
   end
 
   private
@@ -25,40 +24,42 @@ class Location
     site.setElevation(epw_file.elevation)
   end
 
-  def self.apply_year(model, hpxml, epw_file)
-    if Date.leap?(hpxml.header.sim_calendar_year)
+  def self.apply_year(model, hpxml_header, epw_file)
+    if Date.leap?(hpxml_header.sim_calendar_year)
       n_hours = epw_file.data.size
       if n_hours != 8784
-        fail "Specified a leap year (#{hpxml.header.sim_calendar_year}) but weather data has #{n_hours} hours."
+        fail "Specified a leap year (#{hpxml_header.sim_calendar_year}) but weather data has #{n_hours} hours."
       end
     end
 
     year_description = model.getYearDescription
-    year_description.setCalendarYear(hpxml.header.sim_calendar_year)
+    year_description.setCalendarYear(hpxml_header.sim_calendar_year)
   end
 
-  def self.apply_dst(model, hpxml)
-    return unless hpxml.header.dst_enabled
+  def self.apply_dst(model, hpxml_bldg)
+    return unless hpxml_bldg.dst_enabled
 
     month_names = ['Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec']
-    dst_start_date = "#{month_names[hpxml.header.dst_begin_month - 1]} #{hpxml.header.dst_begin_day}"
-    dst_end_date = "#{month_names[hpxml.header.dst_end_month - 1]} #{hpxml.header.dst_end_day}"
+    dst_start_date = "#{month_names[hpxml_bldg.dst_begin_month - 1]} #{hpxml_bldg.dst_begin_day}"
+    dst_end_date = "#{month_names[hpxml_bldg.dst_end_month - 1]} #{hpxml_bldg.dst_end_day}"
 
     run_period_control_daylight_saving_time = model.getRunPeriodControlDaylightSavingTime
     run_period_control_daylight_saving_time.setStartDate(dst_start_date)
     run_period_control_daylight_saving_time.setEndDate(dst_end_date)
   end
 
-  def self.apply_ground_temps(model, weather)
+  def self.apply_ground_temps(model, weather, hpxml_bldg)
     # Shallow ground temperatures only currently used for ducts located under slab
     sgts = model.getSiteGroundTemperatureShallow
     sgts.resetAllMonths
-    sgts.setAllMonthlyTemperatures(weather.data.GroundMonthlyTemps.map { |t| UnitConversions.convert(t, 'F', 'C') })
+    sgts.setAllMonthlyTemperatures(weather.data.ShallowGroundMonthlyTemps.map { |t| UnitConversions.convert(t, 'F', 'C') })
 
-    # Deep ground temperatures used by GSHP setpoint manager
-    dgts = model.getSiteGroundTemperatureDeep
-    dgts.resetAllMonths
-    dgts.setAllMonthlyTemperatures([UnitConversions.convert(weather.data.AnnualAvgDrybulb, 'F', 'C')] * 12)
+    if hpxml_bldg.heat_pumps.select { |h| h.heat_pump_type == HPXML::HVACTypeHeatPumpGroundToAir }.size > 0
+      # Deep ground temperatures used by GSHP setpoint manager
+      dgts = model.getSiteGroundTemperatureDeep
+      dgts.resetAllMonths
+      dgts.setAllMonthlyTemperatures([UnitConversions.convert(weather.data.DeepGroundAnnualTemp, 'F', 'C')] * 12)
+    end
   end
 
   def self.get_climate_zones
@@ -81,25 +82,35 @@ class Location
     return
   end
 
-  def self.get_epw_path(hpxml, hpxml_path)
-    epw_path = hpxml.climate_and_risk_zones.weather_station_epw_filepath
+  def self.get_epw_path(hpxml_bldg, hpxml_path)
+    epw_filepath = hpxml_bldg.climate_and_risk_zones.weather_station_epw_filepath
+    abs_epw_path = File.absolute_path(epw_filepath)
 
-    if not File.exist? epw_path
-      test_epw_path = File.join(File.dirname(hpxml_path), epw_path)
-      epw_path = test_epw_path if File.exist? test_epw_path
+    if not File.exist? abs_epw_path
+      # Check path relative to HPXML file
+      abs_epw_path = File.absolute_path(File.join(File.dirname(hpxml_path), epw_filepath))
     end
-    for level_deep in 1..3
-      next unless not File.exist? epw_path
-
-      level = (['..'] * level_deep).join('/')
-      test_epw_path = File.join(File.dirname(__FILE__), level, 'weather', epw_path)
-      epw_path = test_epw_path if File.exist? test_epw_path
+    if not File.exist? abs_epw_path
+      # Check for weather path relative to the HPXML file
+      for level_deep in 1..3
+        level = (['..'] * level_deep).join('/')
+        abs_epw_path = File.absolute_path(File.join(File.dirname(hpxml_path), level, 'weather', epw_filepath))
+        break if File.exist? abs_epw_path
+      end
+    end
+    if not File.exist? abs_epw_path
+      # Check for weather path relative to this file
+      for level_deep in 1..3
+        level = (['..'] * level_deep).join('/')
+        abs_epw_path = File.absolute_path(File.join(File.dirname(__FILE__), level, 'weather', epw_filepath))
+        break if File.exist? abs_epw_path
+      end
     end
-    if not File.exist?(epw_path)
-      fail "'#{epw_path}' could not be found."
+    if not File.exist? abs_epw_path
+      fail "'#{epw_filepath}' could not be found."
     end
 
-    return epw_path
+    return abs_epw_path
   end
 
   def self.get_sim_calendar_year(sim_calendar_year, epw_file)

data/example_files/resources/hpxml-measures/HPXMLtoOpenStudio/resources/materials.rb

@@ -1,3 +1,8 @@
+# *********************************************************************************
+# URBANopt (tm), Copyright (c) Alliance for Sustainable Energy, LLC.
+# See also https://github.com/urbanopt/urbanopt-cli/blob/develop/LICENSE.md
+# *********************************************************************************
+
 # frozen_string_literal: true
 
 class Material

data/example_files/resources/hpxml-measures/HPXMLtoOpenStudio/resources/meta_measure.rb

@@ -1,3 +1,8 @@
+# *********************************************************************************
+# URBANopt (tm), Copyright (c) Alliance for Sustainable Energy, LLC.
+# See also https://github.com/urbanopt/urbanopt-cli/blob/develop/LICENSE.md
+# *********************************************************************************
+
 # frozen_string_literal: true
 
 require 'fileutils'
@@ -59,6 +64,11 @@ def run_hpxml_workflow(rundir, measures, measures_dir, debug: false, output_vars
   if model.alwaysOffDiscreteSchedule.directUseCount == 0
     remove_objects << ['Schedule:Constant', model.alwaysOffDiscreteSchedule.name.to_s]
   end
+  model.getScheduleConstants.each do |sch|
+    next unless sch.directUseCount == 0
+
+    remove_objects << ['Schedule:Constant', sch.name.to_s]
+  end
 
   # Translate model to workspace
   forward_translator = OpenStudio::EnergyPlus::ForwardTranslator.new
@@ -67,7 +77,7 @@ def run_hpxml_workflow(rundir, measures, measures_dir, debug: false, output_vars
   success = report_ft_errors_warnings(forward_translator, rundir)
 
   # Remove objects
-  remove_objects.each do |remove_object|
+  remove_objects.uniq.each do |remove_object|
     workspace.getObjectByTypeAndName(remove_object[0].to_IddObjectType, remove_object[1]).get.remove
   end
 
@@ -96,6 +106,12 @@ def run_hpxml_workflow(rundir, measures, measures_dir, debug: false, output_vars
     return { success: success, runner: runner }
   end
 
+  if not model.getWeatherFile.path.is_initialized
+    print "#{print_prefix}Creating input unsuccessful.\n"
+    print "#{print_prefix}See #{File.join(rundir, 'run.log')} for details.\n"
+    return { success: false, runner: runner }
+  end
+
   # Run simulation
   print "#{print_prefix}Running simulation...\n" unless suppress_print
   ep_path = File.absolute_path(File.join(OpenStudio.getOpenStudioCLI.to_s, '..', '..', 'EnergyPlus', 'energyplus')) # getEnergyPlusDirectory can be unreliable, using getOpenStudioCLI instead

data/example_files/resources/hpxml-measures/HPXMLtoOpenStudio/resources/minitest_helper.rb

@@ -1,3 +1,8 @@
+# *********************************************************************************
+# URBANopt (tm), Copyright (c) Alliance for Sustainable Energy, LLC.
+# See also https://github.com/urbanopt/urbanopt-cli/blob/develop/LICENSE.md
+# *********************************************************************************
+
 # frozen_string_literal: true
 
 called_from_cli = true