uqam_grade_notification 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d9e1f1a5c003b5f71c81c10f79096dabb6448898
-  data.tar.gz: c9885635447fe35996a2a55689a72fdab0400ef2
+  metadata.gz: dd36bd57e50e12a03c26f0e7221e5dd8187fe2aa
+  data.tar.gz: 82ed74a72b629fc08b1d25c2d999b72c0da1efef
 SHA512:
-  metadata.gz: 0d0bce3c4ebe50f302b5672cb766bd2b1823c1fb5adf3c6b6b0899948ee65ba3631b4bb372d960abf5d8a49081a275176dc0ae011a8b10549ee4061883a6a1ca
-  data.tar.gz: 6c8041bc2a95ee3304b302ac549c95872814a7936b3bfa739f44229bf06c48fac92dc85a55af848f53e4e23f49a116f8e48872a0235c2d5be03b73b1e00dd947
+  metadata.gz: 95294dd71d5fb727c0e95ec80f294c9f884eadd82dc7cf0edd55dc6b37c7eed0c36d7edc76d0b97815e9cfcb85cf291bd6d5d49a1f01be3b0608195394889108
+  data.tar.gz: 9a37c6e87eb46e0140dc7a85b1d26c03d71dbab59c5cd2e4c167302d26ba60463a0ec7ff06d4cdbaf4053407661ea9e243132365956cc0d55ce2841004135029

data/exe/uqam_grade_notification

@@ -29,7 +29,7 @@ configuration =
   if File.exist?(UqamGradeNotification::CONFIG_FILE)
     JSON.parse(File.open(UqamGradeNotification::CONFIG_FILE).read)
   else
-    configuration_cli
+    UqamGradeNotification.configuration_cli
   end
 
 student = UqamGradeNotification::Student.new(configuration)

data/lib/uqam_grade_notification.rb

@@ -2,6 +2,7 @@ require 'fileutils'
 require 'json'
 require 'highline'
 require 'digest'
+require 'active_support/hash_with_indifferent_access'
 require 'uqam_grade_notification/version'
 require 'uqam_grade_notification/student'
 require 'uqam_grade_notification/notifier'

data/lib/uqam_grade_notification/client.rb

@@ -9,7 +9,6 @@ module UqamGradeNotification
     end
 
     def notify_of_changes
-      current_grades = student.grades.to_json
       if grades_have_changed?
         p "Grades have not changed since last checked."
       else

data/lib/uqam_grade_notification/notifier.rb

@@ -4,11 +4,12 @@ module UqamGradeNotification
   class Notifier
     attr_reader :phone
 
-    def initialize user_info
-      @phone = user_info.fetch("phone")
-      @twilio_account_id = user_info.fetch("twilio_account_id")
-      @twilio_token = user_info.fetch("twilio_token")
-      @twilio_phone = user_info.fetch("twilio_phone")
+    def initialize args
+      args = HashWithIndifferentAccess.new(args)
+      @phone = args.fetch("phone")
+      @twilio_account_id = args.fetch("twilio_account_id")
+      @twilio_token = args.fetch("twilio_token")
+      @twilio_phone = args.fetch("twilio_phone")
     end
 
     def sms(message)

data/lib/uqam_grade_notification/student.rb

@@ -6,9 +6,10 @@ module UqamGradeNotification
   class Student
     attr_reader :code, :password
 
-    def initialize user_info
-      @code = user_info.fetch("code")
-      @password = user_info.fetch("password")
+    def initialize args
+      args = HashWithIndifferentAccess.new(args)
+      @code = args.fetch("code")
+      @password = args.fetch("password")
     end
 
     def grades
@@ -60,17 +61,17 @@ module UqamGradeNotification
     end
 
     def token
-      @token ||= login.body["token"]
+      @token ||= get_token
     end
 
-    def login
+    def get_token
       connection.post do |req|
         req.url "/authentification"
         req.headers['Content-Type'] = 'application/json;charset=UTF-8'
         req.headers['Origin'] = 'https://portailetudiant.uqam.ca'
         req.headers['Referer'] = 'https://portailetudiant.uqam.ca'
-        req.body = {identifiant: code, motDePasse: password}.to_json
-      end
+        req.body = {identifiant: code, motDePasse: password}
+      end.body["token"]
     end
   end
 end

data/lib/uqam_grade_notification/version.rb

@@ -1,3 +1,3 @@
 module UqamGradeNotification
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/uqam_grade_notification.gemspec

@@ -18,8 +18,9 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib", "lib/uqam_grade_notification"]
 
   spec.add_development_dependency "bundler", "~> 1.9"
+  spec.add_development_dependency "rspec"
   spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_dependency "nokogiri"
+  spec.add_dependency "activesupport"
   spec.add_dependency "faraday"
   spec.add_dependency "faraday_middleware"
   spec.add_dependency "faraday-cookie_jar"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: uqam_grade_notification
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Alexandre Croteau-Pothier
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.9'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -39,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
-  name: nokogiri
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="