uploadable 0.0.1 → 0.0.2

data/.gitignore

@@ -1,2 +1,22 @@
+*.gem
+*.rbc
+.bundle
+.config
+.yardoc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp
+.idea
+.idea/**
 .rvmrc
+.rvmrcbk
 tags

data/.todo

@@ -5,3 +5,5 @@
 3. Travis CI
 4. header_converters to pick from en.yml rather than symbolize
 5. Add default columns & computed columns from given set of columns
+6. Add documentation to README.md
+7. To add method upload from file by giving file params coming from controller action

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    uploadable (0.0.1)
+    uploadable (0.0.2)
       fastercsv
 
 GEM

data/lib/uploadable.rb

@@ -17,10 +17,21 @@ module Uploadable
     end
 
     define_method :upload_from_csv do |contents|
-      raise NoMethodError.new("Method only aviable for uploadable models") if @upload_processor.blank?
+      raise NoMethodError.new("Method only available for uploadable models") if @upload_processor.blank?
       records = @upload_processor.transform_csv contents
       create records
     end
 
+    define_method :upload_from_csv! do |contents, options = {}|
+      raise NoMethodError.new("Method only aviable for uploadable models") if @upload_processor.blank?
+      objects = []
+      failed = false
+      ActiveRecord::Base.transaction do
+        records = @upload_processor.transform_csv contents
+        objects = create records
+        raise ActiveRecord::Rollback if objects.any? {|obj| !obj.errors.full_messages.blank?}
+      end
+      return objects
+    end
   end
 end

data/lib/uploadable/version.rb

@@ -1,3 +1,3 @@
 module Uploadable
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/support/sample_app/app/models/album.rb

@@ -2,5 +2,11 @@ class Album < ActiveRecord::Base
   uploadable :mandatory_fields => [:title], :optional_fields => [:artist]
   attr_accessible :artist, :title
 
+  validates_presence_of :title
+
   has_many :tracks
+
+  def test_method
+    "booga"
+  end
 end

data/spec/uploadable_spec.rb

@@ -32,5 +32,31 @@ describe "Uploadable" do
       Album.where(:artist => "John Denver", :title => "All Aboard!").count.should == 1
       Album.where(:artist => "Usher", :title => "Looking 4 Myself").count.should == 1
     end
+
+    it "should partially upload records id error exists" do
+      records = Album.upload_from_csv("Artist,Title,Extra\n\"John Denver\",\"All Aboard!\",1\n\"Usher\",,2")
+      Album.count.should == 1
+      records.first.errors.full_messages.should be_empty
+      records.last.errors.full_messages.should_not be_empty
+    end
+  end
+
+  describe "upload_from_csv!" do
+    it "should raise NoMethodError for non uploadable models" do
+      lambda { User.upload_from_csv!("") }.should raise_error(NoMethodError)
+    end
+
+    it "should upload to an uploadable model" do
+      lambda { Album.upload_from_csv!("Artist,Title,Extra\n\"John Denver\",\"All Aboard!\",1\n\"Usher\",\"Looking 4 Myself\",2")}.
+        should change(Album, :count).by(2)
+      Album.where(:artist => "John Denver", :title => "All Aboard!").count.should == 1
+      Album.where(:artist => "Usher", :title => "Looking 4 Myself").count.should == 1
+    end
+
+    it "should rollback all upload records id error exists" do
+      objects = Album.upload_from_csv!("Artist,Title,Extra\n\"John Denver\",\"All Aboard!\",1\n\"Usher\",,2")
+      objects.collect(&:id).should == [nil, nil]
+      Album.count.should == 0
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: uploadable
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-01 00:00:00.000000000 Z
+date: 2012-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastercsv