updateable_views_inheritance 1.3.0 → 1.4.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 45e09cc4af2cc4db1bc1f2e6e0e239a776f52225
+  data.tar.gz: 6b94ebf43678c1b6460b51593ac58996f1c321d7
+SHA512:
+  metadata.gz: 7ad853ebd983df228e8899adcc559fcbc8915a8173baf8f494355bba958cf772273474fff9c660799b419371a83f08c62c34de3ae2b58f39404a21dd880827e1
+  data.tar.gz: 1dd0fa4ef83a31709cdb87e1d2e61dd6c712428d258ca79523412aee819c0f166ddebdd059452c94813724d665220e48d1ed98d7e82cd7c3a8f058fb48106bec

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.4.0 (2 Feburary 2017)
+
+Upgrade to Rails 4
+
 ## 1.3.0 (20 August 2015)
 
 Features:

data/README.rdoc

@@ -9,9 +9,9 @@ Wilger}[http://web.archive.org/web/20060408145717/johnwilger.com/articles/2005/0
 
 ==Requirements
 
-Rails: 3.2.x
+Rails: 4.x
 
-Ruby: tested with 1.8.7 and 1.9.3
+Ruby: 1.9.3+
 
 Database: PostgreSQL 8.1+ only. Patches for other DBMS are welcome. Note that you are not required to use updateable views, children relations can be tables (with some triggers involved) or materialized views.
 

data/lib/generators/updateable_views_inheritance/install_generator.rb

@@ -6,12 +6,16 @@ module UpdateableViewsInheritance
   module Generators
     class InstallGenerator < Rails::Generators::Base
       include Rails::Generators::Migration
-      extend ActiveRecord::Generators::Migration
-      
-      desc "Creates a migration that creates a special table used by the updateable_views_inheritance gem."
+
+      desc "Creates a migration for a special table used by the updateable_views_inheritance gem"
       source_root File.expand_path('../templates', __FILE__)
-      
-      def create_migration
+
+      # Implement the required interface for Rails::Generators::Migration
+      def self.next_migration_number(dirname)
+        ActiveRecord::Generators::Base.next_migration_number(dirname)
+      end
+
+      def install
         migration_file = "create_updateable_views_inheritance.rb"
         migration_template migration_file, "db/migrate/#{migration_file}"
       end

data/lib/updateable_views_inheritance/active_record.rb

@@ -2,12 +2,12 @@ module ActiveRecord #:nodoc:
   class Base #:nodoc:
     class << self
       private
-      def instantiate_with_updateable_views_inheritance_support( record )
-        object = instantiate_without_updateable_views_inheritance_support( record )
+      def instantiate_with_updateable_views_inheritance_support(attributes, column_types = {})
+        object = instantiate_without_updateable_views_inheritance_support(attributes, column_types = {})
         if object.class.name == self.name
           object
         else
-          object.class.find( object.id )
+          object.class.find(attributes.with_indifferent_access[:id])
         end
       end
       alias_method_chain :instantiate, :updateable_views_inheritance_support

data/lib/updateable_views_inheritance/postgresql_adapter.rb

@@ -125,7 +125,7 @@ module ActiveRecord #:nodoc:
 
       # Return the list of all views in the schema search path.
       def views(name=nil)
-        schemas = schema_search_path.split(/,/).map { |p| quote(p) }.join(',')
+        schemas = schema_search_path.split(/,\s*/).map { |p| quote(p) }.join(',')
         query(<<-SQL, name).map { |row| row[0] }
           SELECT viewname
             FROM pg_views

data/lib/updateable_views_inheritance/version.rb

@@ -1,3 +1,3 @@
 module UpdateableViewsInheritance
-  VERSION = "1.3.0"
+  VERSION = "1.4.0"
 end

data/test/content_test.rb

@@ -6,11 +6,11 @@ class UpdateableViewsInheritanceContentTest < ActiveSupport::TestCase
   end
 
   def teardown
-    ActiveRecord::Fixtures.reset_cache
+    ActiveRecord::FixtureSet.reset_cache
   end
 
   def test_find
-    ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
+    ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
     locomotive =  Locomotive.find(1)
     assert locomotive.kind_of?(SteamLocomotive)
     assert_equal %w(coal_consumption id max_speed name type water_consumption),
@@ -19,8 +19,8 @@ class UpdateableViewsInheritanceContentTest < ActiveSupport::TestCase
 
   def test_exec_query
     # order of fixtures is important for the test - last loaded should not be with max(id)
-    ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :electric_locomotives)
-    ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
+    ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :electric_locomotives)
+    ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
 
     res = ActiveRecord::Base.connection.exec_query(<<-SQL)
       INSERT INTO electric_locomotives (electricity_consumption, max_speed, name, type)
@@ -32,8 +32,8 @@ class UpdateableViewsInheritanceContentTest < ActiveSupport::TestCase
 
   def test_exec_query_with_prepared_statement
     # order of fixtures is important for the test - last loaded should not be with max(id)
-    ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :electric_locomotives)
-    ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
+    ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :electric_locomotives)
+    ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
 
     binds = [[ElectricLocomotive.columns.find { |c| c.name == 'electricity_consumption'}, 40],
              [ElectricLocomotive.columns.find { |c| c.name == 'max_speed'},              120],
@@ -54,8 +54,8 @@ class UpdateableViewsInheritanceContentTest < ActiveSupport::TestCase
 
   def test_reset_sequence_after_loading_fixture
     # order of fixtures is important for the test - last loaded should not be with max(id)
-    ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :electric_locomotives)
-    ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
+    ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :electric_locomotives)
+    ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
     steam_locomotive = SteamLocomotive.new(:name => 'Mogul', :max_speed => 120, :water_consumption => 12.3, :coal_consumption => 54.6)
     assert steam_locomotive.save
     mogul = Locomotive.find(steam_locomotive.id)
@@ -63,7 +63,7 @@ class UpdateableViewsInheritanceContentTest < ActiveSupport::TestCase
   end
 
   def test_update
-    ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
+    ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
     steam_locomotive = Locomotive.find(1)
     steam_locomotive.update_attributes( :name => 'Rocket')
     steam_locomotive.reload
@@ -71,7 +71,7 @@ class UpdateableViewsInheritanceContentTest < ActiveSupport::TestCase
   end
 
   def test_delete_from_parent_relation
-    ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
+    ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
     num_locomotives = Locomotive.count
     num_steam_locomotives = SteamLocomotive.count
     Locomotive.find(1).destroy
@@ -80,7 +80,7 @@ class UpdateableViewsInheritanceContentTest < ActiveSupport::TestCase
   end
 
   def test_delete_from_child_relation
-    ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
+    ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
     num_locomotives = Locomotive.count
     num_steam_locomotives = SteamLocomotive.count
     SteamLocomotive.find(1).destroy

data/test/deep_hierarchy_test.rb

@@ -5,13 +5,13 @@ class DeepHierarchyTest < ActiveSupport::TestCase
     ActiveRecord::Migrator.up(File.dirname(__FILE__) + '/fixtures/migrations/', 8)
     # order of fixtures is important for the test - last loaded should not be with max(id)
     %w(boats electric_trains rack_trains steam_trains cars maglev_trains bicycles).each do |f|
-      ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', f)
+      ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', f)
     end
     @connection = ActiveRecord::Base.connection
   end
 
   def teardown
-    ActiveRecord::Fixtures.reset_cache
+    ActiveRecord::FixtureSet.reset_cache
   end
 
   def test_deeper_hierarchy
@@ -42,7 +42,7 @@ class DeepHierarchyTest < ActiveSupport::TestCase
   end
 
   def test_single_table_inheritance_deeper_hierarchy_contents
-    mag = MaglevTrain.find(:first)
+    mag = MaglevTrain.first
     assert_equal [mag.id.to_s, mag.name, mag.number_of_rails.to_s, mag.max_speed.to_s, mag.magnetic_field.to_s, (sprintf("%.2f",mag.electricity_consumption))], (@connection.query("SELECT id, name, number_of_rails, max_speed, magnetic_field, electricity_consumption FROM all_vehicles WHERE id=#{mag.id}").first)
   end
 

data/test/dummy/config/application.rb

@@ -43,12 +43,6 @@ module Dummy
     # like if you have constraints or database-specific column types
     # config.active_record.schema_format = :sql
 
-    # Enforce whitelist mode for mass assignment.
-    # This will create an empty whitelist of attributes available for mass-assignment for all models
-    # in your app. As such, your models will need to explicitly whitelist or blacklist accessible
-    # parameters by using an attr_accessible or attr_protected declaration.
-    config.active_record.whitelist_attributes = false
-
     # Enable the asset pipeline
     config.assets.enabled = true
 

data/test/dummy/config/environments/development.rb

@@ -6,9 +6,6 @@ Dummy::Application.configure do
   # since you don't have to restart the web server when you make code changes.
   config.cache_classes = false
 
-  # Log error messages when you accidentally call methods on nil.
-  config.whiny_nils = true
-
   # Show full error reports and disable caching
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
@@ -22,9 +19,6 @@ Dummy::Application.configure do
   # Only use best-standards-support built into browsers
   config.action_dispatch.best_standards_support = :builtin
 
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
-
   # Log the query plan for queries taking more than this (works
   # with SQLite, MySQL, and PostgreSQL)
   config.active_record.auto_explain_threshold_in_seconds = 0.5
@@ -34,4 +28,6 @@ Dummy::Application.configure do
 
   # Expands the lines which load the assets
   config.assets.debug = true
+
+  config.eager_load = false
 end

data/test/dummy/config/environments/production.rb

@@ -9,7 +9,7 @@ Dummy::Application.configure do
   config.action_controller.perform_caching = true
 
   # Disable Rails's static asset server (Apache or nginx will already do this)
-  config.serve_static_assets = false
+  config.serve_static_files = false
 
   # Compress JavaScripts and CSS
   config.assets.compress = true
@@ -64,4 +64,6 @@ Dummy::Application.configure do
   # Log the query plan for queries taking more than this (works
   # with SQLite, MySQL, and PostgreSQL)
   # config.active_record.auto_explain_threshold_in_seconds = 0.5
+
+  config.eager_load = false
 end

data/test/dummy/config/environments/test.rb

@@ -8,12 +8,9 @@ Dummy::Application.configure do
   config.cache_classes = true
 
   # Configure static asset server for tests with Cache-Control for performance
-  config.serve_static_assets = true
+  config.serve_static_files = true
   config.static_cache_control = "public, max-age=3600"
 
-  # Log error messages when you accidentally call methods on nil
-  config.whiny_nils = true
-
   # Show full error reports and disable caching
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
@@ -29,9 +26,8 @@ Dummy::Application.configure do
   # ActionMailer::Base.deliveries array.
   config.action_mailer.delivery_method = :test
 
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
-
   # Print deprecation notices to the stderr
-  config.active_support.deprecation = :stderr
+  config.active_support.deprecation = :stderr;
+
+  config.eager_load = false
 end

data/test/schema_test.rb

@@ -124,9 +124,9 @@ class UpdateableViewsInheritanceSchemaTest < ActiveSupport::TestCase
 
   class RenameColumnInParentTable < ActiveRecord::Migration
     def self.up
-      ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :electric_locomotives)
-      ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :maglev_locomotives)
-      ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
+      ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :electric_locomotives)
+      ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :maglev_locomotives)
+      ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', :steam_locomotives)
       remove_parent_and_children_views(:locomotives)
       rename_column(:locomotives, :max_speed, :maximal_speed)
       rebuild_parent_and_children_views(:locomotives)

data/test/single_table_inheritance.rb

@@ -5,7 +5,7 @@ class SingleTableInheritanceAggregateViewTest < ActiveSupport::TestCase
     ActiveRecord::Migrator.up(File.dirname(__FILE__) + '/fixtures/migrations/', 6)
     # order of fixtures is important for the test - last loaded should not be with max(id)
     %w(electric_locomotives maglev_locomotives steam_locomotives).each do |f|
-      ActiveRecord::Fixtures.create_fixtures(File.dirname(__FILE__) + '/fixtures/', f)
+      ActiveRecord::FixtureSet.create_fixtures(File.dirname(__FILE__) + '/fixtures/', f)
     end
     @connection = ActiveRecord::Base.connection
   end
@@ -129,8 +129,8 @@ class SingleTableInheritanceAggregateViewTest < ActiveSupport::TestCase
     assert_equal %w(coal_consumption id max_speed name type water_consumption electricity_consumption bidirectional narrow_gauge magnetic_field rail_system number_of_engines).sort,
                  @connection.columns(:all_locomotives).map{ |c| c.name }.sort
     assert_equal 'text', @connection.columns(:all_locomotives).detect{|c| c.name == "number_of_engines"}.sql_type
-    assert_equal 'one', @connection.query("SELECT number_of_engines FROM all_locomotives WHERE id=#{SteamLocomotive.find(:first).id}").first.first
-    assert_equal '2', @connection.query("SELECT number_of_engines FROM all_locomotives WHERE id=#{ElectricLocomotive.find(:first).id}").first.first
+    assert_equal 'one', @connection.query("SELECT number_of_engines FROM all_locomotives WHERE id=#{SteamLocomotive.first.id}").first.first
+    assert_equal '2', @connection.query("SELECT number_of_engines FROM all_locomotives WHERE id=#{ElectricLocomotive.first.id}").first.first
   end
 
   def test_respond_to_missing_attributes

data/test/test_helper.rb

@@ -5,6 +5,10 @@ require File.expand_path("../dummy/config/environment.rb",  __FILE__)
 require 'rails/test_help'
 require 'updateable_views_inheritance'
 
+# get full stack trace on errors
+require "minitest/reporters"
+Minitest::Reporters.use!
+
 begin
   if RUBY_VERSION > "2"
     require 'byebug'

data/updateable_views_inheritance.gemspec

@@ -18,10 +18,12 @@ Gem::Specification.new do |s|
   s.test_files    = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths = ["lib"]
 
-  s.add_dependency "activerecord", "~>3.2.12"
+  s.add_dependency "activerecord", "~> 4.0.13"
   s.add_dependency "pg"
 
-  s.add_development_dependency "rails", "~>3.2.12"
-  s.add_development_dependency "bundler", "~>1.3"
+  s.add_development_dependency 'minitest'
+  s.add_development_dependency 'minitest-reporters'
+  s.add_development_dependency "rails", "~> 4.0.13"
+  s.add_development_dependency "bundler", "~> 1.3"
   s.add_development_dependency "rake"
 end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: updateable_views_inheritance
 version: !ruby/object:Gem::Version
-  version: 1.3.0
-  prerelease: 
+  version: 1.4.0
 platform: ruby
 authors:
 - Sava Chankov
@@ -10,86 +9,104 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-20 00:00:00.000000000 Z
+date: 2017-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.12
+        version: 4.0.13
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.12
+        version: 4.0.13
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest-reporters
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.12
+        version: 4.0.13
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.12
+        version: 4.0.13
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Class table inheritance for ActiveRecord based on updatable views in
@@ -101,7 +118,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - CHANGELOG.md
 - Gemfile
 - MIT-LICENSE
@@ -191,27 +208,26 @@ files:
 homepage: http://github.com/tutuf/updateable_views_inheritance
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.4.5.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Class table inheritance for ActiveRecord
 test_files:
 - test/content_test.rb