update_hints 1.0.1 → 1.0.2

data/History.txt

@@ -1,3 +1,7 @@
+=== 1.0.2 / 2011-05-25
+
+* Use the Gem::Version for version comparisons
+
 === 1.0.1 / 2011-05-25
 
 * End the last line of output with a newline (doh!)

data/lib/update_hints.rb

@@ -2,9 +2,10 @@ require "net/http"
 require "open-uri"
 require "timeout"
 require "rexml/document"
+require "rubygems"
 
 module UpdateHints
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
   GEMCUTTER_URI = "http://rubygems.org/api/v1/gems/%s.xml"
   
   # Checks whether rubygems.org has a new version of this specific gem
@@ -22,7 +23,9 @@ module UpdateHints
   
   def self.version_check_without_exception_suppression(gem_name, present_version_str, destination)
     latest_version = extract_version_from_xml(open(GEMCUTTER_URI % gem_name))
-    int_present, int_available = Version.new(present_version_str), Version.new(latest_version)
+    # Gem::Version was known to throw when a frozen string is passed to the constructor, see
+    # https://github.com/rubygems/rubygems/commit/48f1d869510dcd325d6566df7d0147a086905380
+    int_present, int_available = Gem::Version.new(present_version_str.dup), Gem::Version.new(latest_version.dup)
     if int_available > int_present
       destination << "Your version of #{gem_name} is probably out of date\n"
       destination << "(the current version is #{latest_version}, but you have #{present_version_str}).\n"
@@ -35,24 +38,6 @@ module UpdateHints
     super
   end
   
-  #:nodoc:
-  class Version
-    include Comparable
-    
-    attr_reader :major, :minor, :tiny
-    def initialize(version_str)
-      @major, @minor, @tiny = version_str.split(".").map{|e| e.to_i }
-    end
-    
-    def <=>(other)
-      [:major, :minor, :tiny].each do | ver_part |
-        mine, theirs = send(ver_part), other.send(ver_part)
-        return mine <=> theirs unless mine == theirs
-      end
-      return 0
-    end
-  end
-  
   def self.extract_version_from_xml(io)
     doc = REXML::Document.new(io)
     version_text = doc.elements["rubygem/version"].text

metadata

@@ -2,7 +2,7 @@
 name: update_hints
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors: 
 - Julik Tarkhanov
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-07-28 00:00:00 Z
+date: 2011-09-14 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: flexmock