update_cardinals_by 0.1.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0f0c9aa2f3667c4925560e59e838b79a294b918f48dda0f7092b01e476ad0c40
-  data.tar.gz: cdd625ca542d8d09e7d4ac17a03e48862f569d42a1694bfb94751780b4ed37c0
+  metadata.gz: e9273872a9585f3f525899cdb65003d32d67cf3657802b572a33d4075d7b32d0
+  data.tar.gz: e53d5fcc13195c30497c4e640a616adc49ab6dab0d72a76c2dffc6cfed0edada
 SHA512:
-  metadata.gz: 6ff4b4a4137503a08368116b1b0f213bb41fe08a0d3ca06c8ba44694ca3d00d62e0ee54072efb418737b15af9f987022e9427a0a418e498f2816c5692b83e258
-  data.tar.gz: 382d155ff8ddc7b3aae7bc9936ee6d6186ac1f55e27dc444249fb23fda69c52c7cf0aa6c28f4c5fed2ae762cc29d6dc85b9faee7f4d704b08b537b2c28cbcd4f
+  metadata.gz: ecd5355aa0a352beef84e88fd7a68d96a6d32688f2543bd9c56324d63b686e983a583a1e0f5f319a133278262bccd768b47df40ffd4cfb8d30b3f9b0e7396748
+  data.tar.gz: b270748217ecd8f60d3374ce9a9afbba14a5862dd1cb4b6f3f93bd96773cc79f04aff1206ff4521a21a03c7380957a68b876334f7778b0f43a03c8295d92db35

data/README.md

@@ -37,6 +37,10 @@ end
 
 ## Changelog
 
+0.3.0 changed activerecord support to 6.1 and 7.0
+
+0.2.0 changed activerecord support to 5.2 and 6.0
+
 0.1.0 changed activerecord support from 4.2 to 5.0 and 5.1
 
 ## Developing

data/lib/update_cardinals_by/version.rb

@@ -1,3 +1,3 @@
 module UpdateCardinalsBy
-  VERSION = "0.1.0"
+  VERSION = "0.3.0"
 end

data/lib/update_cardinals_by.rb

@@ -11,7 +11,7 @@ module UpdateCardinalsBy
   def update_cardinals_by!(attributes, &block)
     db_attributes = attributes.map { |k, v| [self.class.connection.quote_column_name(k), v] }
     updates = db_attributes.map.with_index { |(k, v), i| "#{k} = #{k} + $#{i+1}" }
-    binds = attributes.map { |k, v| [column_for_attribute(k), v] }
+    binds = attributes.map { |k, v| self.class.attribute_types[k].serialize(v) }
 
     transaction do
       res = self.class.connection.exec_query(
@@ -21,12 +21,15 @@ module UpdateCardinalsBy
         "returning #{db_attributes.map(&:first).join(', ')}",
         'SQL', binds
       ).first
-       .map { |k, v| [k, type_for_attribute(k).cast(v)] }
+       .map { |k, v| [k, self.class.attribute_types[k].deserialize(v)] }
       res = HashWithIndifferentAccess[ res ]
 
       yield res if block_given?
 
-      res.each { |attr, v| raw_write_attribute attr, v }
+      res.each do |attr, v|
+        write_attribute attr, v
+        clear_attribute_change attr
+      end
     end
   end
 end

data/spec/concerns/update_cardinals_by_spec.rb

@@ -15,23 +15,26 @@ class Account < ActiveRecord::Base
 end
 
 describe UpdateCardinalsBy do
-  let(:account) { Account.create credits: 100, money: BigDecimal(12, 34) }
+  let(:account) { Account.create credits: 100, money: BigDecimal("12.34") }
 
   describe 'update_cardinals_by!' do
     it 'accepts positive change' do
-      account.update_by!(credits: 20, money: BigDecimal(3, 16))
+      account.update_by!(credits: 20, money: BigDecimal("3.16"))
       expect(account.credits).to eq 120
-      expect(account.money).to eq BigDecimal(15, 50)
+      expect(account.money).to eq BigDecimal("15.50")
+      account.reload
+      expect(account.credits).to eq 120
+      expect(account.money).to eq BigDecimal("15.50")
     end
 
     it 'accepts negative change' do
-      account.update_by!(credits: -20, money: -BigDecimal(1, 24))
+      account.update_by!(credits: -20, money: -BigDecimal("1.24"))
       expect(account.credits).to eq 80
-      expect(account.money).to eq BigDecimal(11, 10)
+      expect(account.money).to eq BigDecimal("11.10")
     end
 
-    it 'leaves leaves the instance in a saved state' do
-      account.update_by!(credits: 20, money: BigDecimal(3, 16))
+    it 'leaves the instance in a saved state' do
+      account.update_by!(credits: 20, money: BigDecimal("3.16"))
       expect(account.changed?).to be_falsy
     end
 
@@ -42,10 +45,10 @@ describe UpdateCardinalsBy do
     end
 
     it 'passes the right types to the block' do
-      account.update_cardinals_by!(credits: 20, money: BigDecimal(3, 16)) do |res|
+      account.update_cardinals_by!(credits: 20, money: BigDecimal("3.16")) do |res|
         expect(res[:credits]).to be_a Integer
         expect(res[:money]).to be_a BigDecimal
       end
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: update_cardinals_by
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Hampei
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-05-02 00:00:00.000000000 Z
+date: 2023-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,20 +16,20 @@ dependencies:
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -114,7 +114,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email:
 - henk.van.der.veen@gmail.com
 executables: []
@@ -132,7 +132,7 @@ homepage: https://github.com/hampei/update_cardinals_by
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -147,8 +147,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
-signing_key: 
+rubygems_version: 3.4.6
+signing_key:
 specification_version: 4
 summary: postgres database extension to increment/decrement values safely and get
   back result.