upc 1.0.0 → 1.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 135f75ca08f67bb5b5921f3639a5f4100c959f3f
+  data.tar.gz: 51642467ce7afd5a201a733a93e148fd1f5ac3a6
+SHA512:
+  metadata.gz: 4234e9ab8c67dd52e4252b22c905d947cfdf4068f14f323e51321f8eaeb82aca37e3e14e33872ae75ede85f4e19b0c911e02b2198995f5724fd79ca4779f50e4
+  data.tar.gz: 9330871134ac4a13c6fe28ba2ca70d9f911b1e3e0ebf00252bca02c9a2b925135fc54af1c34ed2f64f72f315c2b4bac88631ec86c623f829f4a82f0f7eb5032d

data/CHANGELOG

@@ -1,2 +1,5 @@
+v1.1 (15th July 2017)
+- Adjust to work on all rubies from 1.9 to 2.4 (Todd Baur)
+
 v1.0 (26th September 2008)
 - Initial Release

data/README.markdown

@@ -0,0 +1,33 @@
+A small class for generating and validating Universal Product Codes (UPCs),
+the 12 digit codes found on many older US products.
+[![Build Status](https://travis-ci.org/yob/upc.svg?branch=master)](https://travis-ci.org/yob/upc)
+
+# Installation
+
+    gem install upc
+
+# Usage
+
+    UPC.new("632737715836").valid?
+    => true
+
+    UPC.valid?("632737715836")
+    => true
+
+    UPC.valid?("632737715837")
+    => false
+
+    UPC.complete("63273771583")
+    => "632737715836"
+
+    UPC.new("632737715836").to_ean
+    => "0632737715836"
+
+# Further Reader
+
+* http://en.wikipedia.org/wiki/Universal_Product_Code
+
+# Contributing
+
+Source code is publicly available @ http://github.com/yob/upc. Patches
+welcome, preferably via a git repo I can pull from.

data/lib/upc.rb

@@ -1,11 +1,11 @@
 class UPC
 
   class Version #:nodoc:
-    Major = 1
-    Minor = 0
-    Tiny  = 0
+    MAJOR = 1
+    MINOR = 1
+    TINY  = 0
 
-    String = [Major, Minor, Tiny].join('.')
+    String = [MAJOR, MINOR, TINY].join('.')
   end
 
   def initialize(str)
@@ -18,7 +18,7 @@ class UPC
 
   def self.valid?(upc)
     upc = upc.to_s
-    upc.length == 12 && upc == UPC.complete(upc[0,11])
+    upc.length == 12 && upc == UPC.complete(upc[0, 11])
   end
 
   # Purely for generating new UPC numbers
@@ -35,17 +35,13 @@ class UPC
     end
     sum = arr.inject { |sum, n| sum + n }
     remainder = sum % 10
-    if remainder == 0
-      check = 0
-    else
-      check = 10 - remainder
-    end
+    (remainder == 0) ? check = 0 : check = 10 - remainder
 
     eleven + check.to_s
   end
 
   def to_ean
-    return nil unless self.valid?
+    return nil unless valid?
     "0#{@number}"
   end
 end

data/spec/upc_spec.rb

@@ -1,36 +1,35 @@
 $LOAD_PATH << File.dirname(__FILE__) + "/../lib"
 
-require 'spec'
 require 'upc'
 
-describe "The UPC class" do
+RSpec.describe UPC do
   it "should identify a valid UPC" do
-    UPC.new("632737715836").valid?.should be_true
+    expect(UPC.new("632737715836").valid?).to be true
   end
 
   it "should identify a valid UPC" do
-    UPC.valid?("632737715836").should be_true
-    UPC.valid?(632737715836).should   be_true
+    expect(UPC.valid?("632737715836")).to be true
+    expect(UPC.valid?(632737715836)).to be true
   end
-  
+
   it "should identify an invalid UPC" do
-    UPC.valid?(nil).should       be_false
-    UPC.valid?("902865").should  be_false
-    UPC.valid?(Array).should     be_false
-    UPC.valid?(Array.new).should be_false
-    UPC.valid?("632737715837").should  be_false
-    UPC.valid?("63273771583").should   be_false
+    expect(UPC.valid?(nil)).to be false
+    expect(UPC.valid?("902865")).to be false
+    expect(UPC.valid?(Array)).to be false
+    expect(UPC.valid?(Array.new)).to be false
+    expect(UPC.valid?("632737715837")).to be false
+    expect(UPC.valid?("63273771583")).to be false
   end
 
   it "should calculate a UPC check digit correctly" do
-    UPC.complete("63273771583").should eql("632737715836")
-    UPC.complete(63273771583).should   eql("632737715836")
-    UPC.complete("63273720503").should eql("632737205030")
-    UPC.complete("63273712223").should eql("632737122238")
+    expect(UPC.complete("63273771583")).to eql("632737715836")
+    expect(UPC.complete(63273771583)).to eql("632737715836")
+    expect(UPC.complete("63273720503")).to eql("632737205030")
+    expect(UPC.complete("63273712223")).to eql("632737122238")
   end
 
   it "should convert to an EAN correctly" do
-    UPC.new("632737715836").to_ean.should eql("0632737715836")
-    UPC.new(632737715836).to_ean.should   eql("0632737715836")
+    expect(UPC.new("632737715836").to_ean).to eql("0632737715836")
+    expect(UPC.new(632737715836).to_ean).to eql("0632737715836")
   end
 end

metadata

@@ -1,58 +1,80 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: upc
-version: !ruby/object:Gem::Version 
-  version: 1.0.0
+version: !ruby/object:Gem::Version
+  version: 1.1.0
 platform: ruby
-authors: 
+authors:
 - James Healy
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2008-09-26 00:00:00 +10:00
-default_executable: 
-dependencies: []
-
+date: 2017-07-15 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 description: a (very) small library for working with Universal Product Codes
 email: jimmy@deefa.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
-- lib/upc.rb
-- MIT-LICENSE
-- README.rdoc
+files:
 - CHANGELOG
-has_rdoc: true
-homepage: http://github.com/yob/upc/tree/master
+- MIT-LICENSE
+- README.markdown
+- lib/upc.rb
+- spec/upc_spec.rb
+homepage: http://github.com/yob/upc
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
-rdoc_options: 
-- --title
+rdoc_options:
+- "--title"
 - UPC
-- --line-numbers
-require_paths: 
+- "--line-numbers"
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-  version: 
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  requirements: 
+    - !ruby/object:Gem::Version
+      version: 1.9.3
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-  version: 
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
-rubyforge_project: yob-projects
-rubygems_version: 1.2.0
+rubyforge_project: 
+rubygems_version: 2.6.11
 signing_key: 
-specification_version: 2
+specification_version: 4
 summary: a (very) small library for working with Universal Product Codes
-test_files: 
+test_files:
 - spec/upc_spec.rb

data/README.rdoc

@@ -1,23 +0,0 @@
-A small class for generating and validating Universal Product Codes (UPCs),
-the 12 digit codes found on many older US products.
-
-= Usage
-
-  UPC.new("632737715836").valid?
-  => true
-
-  UPC.valid?("632737715836")
-  => true
-
-  UPC.valid?("632737715837")
-  => false
-
-  UPC.complete("63273771583")
-  => "632737715836"
-
-  UPC.new("632737715836").to_ean
-  => "0632737715836"
-
-= Further Reader
-
-- http://en.wikipedia.org/wiki/Universal_Product_Code