unveil-rails 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 11ac877c26c44d8716fcd650f8539357e06f94a3
-  data.tar.gz: 803b516ad64838c23968b555167e01d90830c81a
+  metadata.gz: 54f93550291407b2f15222f3ae4dd458d2f726c8
+  data.tar.gz: fdc41bff5a571597264d1af293201f637e0594ac
 SHA512:
-  metadata.gz: 68f73d490a9ad2603714f43a39274d5a53f07e2cb6db0d16f337cc782bd6da229890fa6ecc6dc867aff0054364813ce36931ff0541c692224ce08653af99591b
-  data.tar.gz: 1ada1b0cdb1497d1c196723253f817c356c026b7bcde1a330bc209981b0e2c9d2394b3b2e2f6b4412b6758c02c90d80fc5483a27ce855db5f690320447ed38b2
+  metadata.gz: a82c646a4272422ccfecd354e8ad57449588d122e3220958dd6075dcf9b738d4bf1a393ae621cfae148ac50fe3e43608b264701c1f5ab06919fd7be3411c7704
+  data.tar.gz: 9762a3d277cd0d1c4383922aaa9f1b6c798df033a3aa1b56925c61820021f4305354ecc3d508c0acc00c2d3cd7951bbbb0d4a12da295ca2b551189057fb38550

data/README.md

@@ -1,28 +1,32 @@
 # Unveil.js for Rails
 
-This gem will help you get started with unveil.js rather quickly.
+Lazy loaded images on rails. If you want a quick start using
+[unveil.js][unveil-github] with rails there is now a gem for that.
+
+By loading your images as they appear in the viewport rather than on load you
+can improve your rails application's page speed.
 
 ## Installation
 
-Add the gem:
+Add the unveil-rails gem into your `Gemfile`:
 
 ``` ruby
 gem 'unveil-rails', '~> 0.1.0'
 ```
 
-Install the assets:
+Install unveil.js and initializer into your rails app:
 
 ```
 bin/rails g unveil:rails:install
 ```
 
-Include the asset in your JS:
+Include the unveil.js initializer in `app/assets/javascripts/application.js`:
 
 ``` js
 //= require unveil_init
 ```
 
-Now use the helper method whereever you want lazy images:
+Now use the helper method where ever you want lazy images:
 
 ```erb
 <%= lazy_image_tag('an-image.png') %>
@@ -66,6 +70,8 @@ Developed and maintained by [Made Tech][made]. Key contributions:
 
  * [Luke Morton](https://github.com/DrPheltRight)
 
+And of course [Luís Almeida][luis-github] creator of [unveil.js][unveil-github].
+
 ## License
 
 Copyright © 2014 Made Tech Ltd. It is free software, and may be
@@ -75,3 +81,4 @@ redistributed under the terms specified in the [LICENSE][license] file.
 [license]: https://github.com/madebymade/cf-deploy/blob/master/LICENSE
 [unveil-github]: https://github.com/luis-almeida/unveil
 [unveil-docs]: http://luis-almeida.github.io/unveil/
+[luis-github]: https://github.com/luis-almeida

data/lib/unveil/rails/version.rb

@@ -1,5 +1,5 @@
 module Unveil
   class Rails
-    VERSION='0.1.0'
+    VERSION='0.2.0'
   end
 end

data/lib/unveil/rails/view_helper.rb

@@ -3,9 +3,9 @@ module Unveil
     module ViewHelper
       def lazy_image_tag(source, options = {})
         placeholder_source = options[:placeholder] || Unveil::Rails.config.default_placeholder
+        options[:alt] = options[:alt] || image_alt(source)
 
-        lazy_options = options.merge('data-src' => image_path(source),
-                                     alt: image_alt(source))
+        lazy_options = options.merge('data-src' => image_path(source))
 
         if options.has_key?(:retina)
           lazy_options['data-src-retina'] = image_path(options[:retina])

data/spec/helpers/view_helper_spec.rb

@@ -18,9 +18,9 @@ describe Unveil::Rails::ViewHelper do
 
       let(:expected_html) do
         <<-HTML
-<img src="/blank.gif" data-src="/my-image.png" />
+<img src="/blank.gif" alt="my-image.png" data-src="/my-image.png" />
 <noscript>
-<img src="/my-image.png" />
+<img src="/my-image.png" alt="my-image.png" />
 </noscript>
         HTML
       end
@@ -33,9 +33,9 @@ describe Unveil::Rails::ViewHelper do
 
       let(:expected_html) do
         <<-HTML
-<img src="/place.gif" data-src="/my-image.png" />
+<img src="/place.gif" alt="my-image.png" data-src="/my-image.png" />
 <noscript>
-<img src="/my-image.png" />
+<img src="/my-image.png" alt="my-image.png" />
 </noscript>
         HTML
       end
@@ -48,9 +48,24 @@ describe Unveil::Rails::ViewHelper do
 
       let(:expected_html) do
         <<-HTML
-<img src="/blank.gif" data-src="/my-image.png" data-src-retina="/my-retina-image.png" />
+<img src="/blank.gif" alt="my-image.png" data-src="/my-image.png" data-src-retina="/my-retina-image.png" />
 <noscript>
-<img src="/my-image.png" />
+<img src="/my-image.png" alt="my-image.png" />
+</noscript>
+        HTML
+      end
+
+      it { is_expected.to eq(expected_html.strip) }
+    end
+
+    context 'when alt text provided' do
+      let(:options) { { alt: 'Alt text' } }
+
+      let(:expected_html) do
+        <<-HTML
+<img src="/blank.gif" alt="Alt text" data-src="/my-image.png" />
+<noscript>
+<img src="/my-image.png" alt="Alt text" />
 </noscript>
         HTML
       end

data/spec/mocks/context_mock.rb

@@ -11,6 +11,7 @@ class ContextMock
 
   def image_tag(source, options = {})
     options_html = ''
+    options_html << " alt=\"#{options[:alt]}\"" if options[:alt]
     options_html << " data-src=\"#{options['data-src']}\"" if options['data-src']
     options_html << " data-src-retina=\"#{options['data-src-retina']}\"" if options['data-src-retina']
     "<img src=\"#{image_path(source)}\"#{options_html} />"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unveil-rails
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Luke Morton
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-04 00:00:00.000000000 Z
+date: 2015-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -91,9 +91,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Lazy loaded images for rails
 test_files: []
-has_rdoc: