unused_view 0.0.2 → 0.0.4

data/README.md

@@ -23,6 +23,8 @@ $ bundle exec rake 'unused_views[users]'
 /Users/toqoz/Projects/ppp/app/views/articles/new.html.erb
 /Users/toqoz/Projects/ppp/app/views/users/create.html.erb
 /Users/toqoz/Projects/ppp/app/views/users/edit.html.erb
+/Users/toqoz/Projects/ppp/app/views/users/_form.html.erb
+/Users/toqoz/Projects/ppp/app/views/shared/_header.html.erb
 
 ```
 
@@ -35,6 +37,8 @@ irb(main):001:0> show_unused_views
 /Users/toqoz/Projects/ppp/app/views/articles/new.html.erb
 /Users/toqoz/Projects/ppp/app/views/users/create.html.erb
 /Users/toqoz/Projects/ppp/app/views/users/edit.html.erb
+/Users/toqoz/Projects/ppp/app/views/users/_form.html.erb
+/Users/toqoz/Projects/ppp/app/views/shared/_header.html.erb
 
 # if you use pry-rails
 [1] pry(main)> show-unused-views
@@ -42,8 +46,17 @@ irb(main):001:0> show_unused_views
 /Users/toqoz/Projects/ppp/app/views/articles/new.html.erb
 /Users/toqoz/Projects/ppp/app/views/users/create.html.erb
 /Users/toqoz/Projects/ppp/app/views/users/edit.html.erb
+/Users/toqoz/Projects/ppp/app/views/users/_form.html.erb
+/Users/toqoz/Projects/ppp/app/views/shared/_header.html.erb
 ```
 
 then see list of unused views.
 
-Now this is not support partial view.
+
+## Testing
+
+```sh
+$ cd path-to-unused-view
+$ bundle install
+$ rspec
+```

data/lib/unused_view.rb

@@ -1,43 +1,15 @@
 require 'unused_view/railtie'
+require 'unused_view/view'
+require 'unused_view/layout'
+require 'unused_view/partial_view'
+require 'unused_view/target_files'
 
 module UnusedView
   extend self
 
   def find_all(base_path)
-    Rails.application.instance_eval do
-      used_views = ApplicationController.descendants.reduce([]) do |views, controller_class|
-        controller = controller_class.new
-        views + UnusedView.find_views(controller).compact + [ UnusedView.find_layout(controller) ].compact
-      end.map(&:identifier).uniq
-
-      ApplicationController.view_paths.reduce([]) do |unused_views, view_path|
-        unused_views + Dir.glob(File.join(view_path, '**/[a-zA-Z]*')).select do |f|
-          File.file?(f) && used_views.exclude?(f) && f[%r{^#{base_path}}]
-        end
-      end
-    end
-  end
-
-  def find_views(controller)
-    controller.action_methods.map do |action|
-      controller.lookup_context.find(action, controller._prefixes) rescue nil
-    end
-  end
-
-  def find_layout(controller)
-    name = layout_name(controller)
-    if name
-      controller.lookup_context.find(name, 'layouts') rescue nil
-    end
-  end
-
-  def layout_name(controller)
-    name = controller.send(:_layout) rescue nil
-    case name
-    when String
-      name
-    when ActionView::Template
-      File.basename(name.identifier).split('.').first
-    end
+    controllers = ApplicationController.descendants.map(&:new)
+    views = View.new(controllers).find_all + Layout.new(controllers).find_all
+    TargetFiles.new(base_path).all - views - PartialView.new(views).find_all
   end
 end

data/lib/unused_view/layout.rb

@@ -0,0 +1,33 @@
+# -*- coding: utf-8 -*-
+
+module UnusedView
+  class Layout
+    def initialize(controllers)
+      @controllers = controllers
+    end
+
+    def find_all
+      @controllers.reduce([]) do |layouts, controller|
+        if _name = name(controller)
+          begin
+            layouts << controller.lookup_context.find(_name, 'layouts')
+          rescue
+            layouts
+          end
+        else
+          layouts
+        end
+      end.uniq.compact.map(&:identifier)
+    end
+
+    def name(controller)
+      _name = controller.send(:_layout) rescue nil
+      case _name
+      when String
+        _name
+      when ActionView::Template
+        File.basename(_name.identifier).split('.').first
+      end
+    end
+  end
+end

data/lib/unused_view/partial_view.rb

@@ -0,0 +1,39 @@
+# -*- coding: utf-8 -*-
+
+module UnusedView
+  class PartialView
+    PATTERN = {
+      render: %r{\brender\s*(?:\(\s*)?},
+      partial: %r{:partial\s*=>\s*|partial:\s*},
+      filename: %r{[\w/]+?},
+      extention: %r{\.\w+}
+    }
+
+    def initialize(views)
+      @views = views
+    end
+
+    def find_all
+      @views.reduce([]) do |sum, view|
+        used_partials_by_view = File.open(view) { |f| f.read.split("\n") }.map do |line|
+          if line =~ %r[(?:#{PATTERN[:partial]}|#{PATTERN[:render]})(['"])/?(#{PATTERN[:filename]})#{PATTERN[:extention]}*\1]
+            $2 # virtual path. e.g. articles/form
+          end
+        end.compact.map do |vpath|
+          File.class_eval do
+            if vpath.index('/')
+              path = ApplicationController.view_paths.map do |view_path|
+                File.join(view_path.to_s, vpath)
+              end.select { |f| File.exists?(File.dirname(f)) }.first || vpath
+            else
+              path = view
+            end
+            filename = "_#{basename(vpath)}.#{basename(view).split('.')[1..-1].join('.')}"
+            expand_path(join(dirname(path), filename)).to_s
+          end
+        end
+        sum + used_partials_by_view
+      end.uniq
+    end
+  end
+end

data/lib/unused_view/target_files.rb

@@ -0,0 +1,25 @@
+# -*- coding: utf-8 -*-
+
+module UnusedView
+  class TargetFiles
+    def initialize(path)
+      @path = path
+    end
+
+    def all
+      views + partial_views
+    end
+
+    def views
+      ApplicationController.view_paths.reduce([]) do |sum, view_path|
+        sum + Dir[File.join(view_path, '**/[a-zA-Z]*')].select { |f| File.file?(f) && f[%r{^#{@path}}] }
+      end
+    end
+
+    def partial_views
+      ApplicationController.view_paths.reduce([]) do |sum, view_path|
+        sum + Dir[File.join(view_path, '**/_*')].select { |f| File.file?(f) && f[%r{^#{@path}}] }
+      end
+    end
+  end
+end

data/lib/unused_view/version.rb

@@ -1,3 +1,3 @@
 module UnusedView
-  VERSION = "0.0.2"
+  VERSION = "0.0.4"
 end

data/lib/unused_view/view.rb

@@ -0,0 +1,17 @@
+# -*- coding: utf-8 -*-
+
+module UnusedView
+  class View
+    def initialize(controllers)
+      @controllers = controllers
+    end
+
+    def find_all
+      @controllers.reduce([]) do |views, controller|
+        views + controller.action_methods.map do |action|
+          controller.lookup_context.find(action, controller._prefixes) rescue nil
+        end
+      end.uniq.compact.map(&:identifier)
+    end
+  end
+end

metadata

@@ -2,14 +2,14 @@
 name: unused_view
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 0.0.2
+  version: 0.0.4
 platform: ruby
 authors:
 - Takatoshi Matsumoto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-25 00:00:00.000000000 Z
+date: 2012-12-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   type: :runtime
@@ -84,9 +84,13 @@ extra_rdoc_files: []
 files:
 - lib/unused_view/commands/show_unused_views.rb
 - lib/unused_view/commands.rb
+- lib/unused_view/layout.rb
+- lib/unused_view/partial_view.rb
 - lib/unused_view/railtie.rb
+- lib/unused_view/target_files.rb
 - lib/unused_view/tasks.rake
 - lib/unused_view/version.rb
+- lib/unused_view/view.rb
 - lib/unused_view.rb
 - MIT-LICENSE
 - Rakefile
@@ -104,7 +108,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       segments:
       - 0
-      hash: 2644683764795231228
+      hash: 2956511099555490744
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
@@ -113,7 +117,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       segments:
       - 0
-      hash: 2644683764795231228
+      hash: 2956511099555490744
       version: '0'
 requirements: []
 rubyforge_project: