unreliable 0.1.3 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0081b3f189f7e459a112514a5c35d69bd903fbdc771b6eccd22bb53add828671'
-  data.tar.gz: 0a5c663105b2f774cb64eb464340e36d8c63d393234e0cb855955487800d501f
+  metadata.gz: 9b11225a3c1dad62d2a283c3eb36fef7b69fda61815df13a860ce9c1970016eb
+  data.tar.gz: 1994dd9ea21ba01dc839c56cc08ca91742465dc9b850c0b6a5eebbc81c7558a2
 SHA512:
-  metadata.gz: 798bef481aad072fa47730866506a6e040d5b99dea6b71f0af5ca86921380f42713b98182c813f7da2a9a152215e9a2a35a730923f10e3e35c389a5ffa78dd68
-  data.tar.gz: 41d0546cf89f4bb0a2c66e98042fb6f27b4a57391ef7e0e25392a1b0a6eaa14064c6f9bd6e12915a05f8425656a62f794d48ab2ab45f08045b2ad3bfa4e79794
+  metadata.gz: 145d5bbe8790fe4ee33bf4f0ea874350edf9655c2ebed35bfb3f18acb123d03efbe86c826dd0d9d4ca7ff12938c368e5cc4ebdc7afba224e0a8c12669a92e816
+  data.tar.gz: 2a3ca2dfa53cbf67a0f8a6b7128df829874409a698586c15d10746624a71a18eddc77914768ec5da361541aa54706bd1899f473aa1f6093ec839f689428b36ed

data/CHANGELOG.md

@@ -1,3 +1,18 @@
+## Unreliable 0.9.1 (November 21, 2022) ##
+
+### Changed
+
+* Improve efficiency by using ActiveRecord's SchemaCache.
+
+## Unreliable 0.9.0 (November 20, 2022) ##
+
+### Changed
+
+* Minor README, gemspec, and rubocop changes.
+* More tests, including queries generated by ActiveRecord associations.
+* Don't randomize order from ar\_internal\_metadata.
+* When a single-table query or subquery has an existing ORDER that includes all columns of that table's primary key, this is one of the few cases where we know we don't need to randomize order, so don't bother.
+
 ## Unreliable 0.1.3 (August 21, 2022) ##
 
 * README and minor gemspec changes.

data/README.md

@@ -81,7 +81,7 @@ The problem in this example is easy to see because many books are published each
 
 `unreliable` is tested to support Ruby 2.6 through 3.1, and Rails 5.0 through 7.0.
 
-As of August 2022, this is all released versions of both that are currently supported, plus several older releases.
+As of November 2022, this is all released versions of both that are currently supported, plus several older releases.
 
 `unreliable` depends only on ActiveRecord and Railties. If you have a non-Rails app that uses ActiveRecord, you can still use it.
 
@@ -89,7 +89,7 @@ As of August 2022, this is all released versions of both that are currently supp
 
 `unreliable` does exactly nothing outside of test environments. There is intentionally no way to enable `unreliable` in production, and there never will be.
 
-In a Rails test environment, `unreliable` patches ActiveRecord to always append a final `ORDER BY` clause that returns results in a random order.
+In a Rails test environment, `unreliable` patches ActiveRecord to append a final `ORDER BY` clause, when necessary, that returns results in a random order.
 
 Because it's appended, the existing ordering is not affected unless it is ambiguous.
 
@@ -101,6 +101,10 @@ This means that the `ORDER BY` applies to not just `SELECT` but e.g. `delete_all
 
 The patch is only applied when `Rails.env.test?`, and that boolean is also checked on every invocation, just to make certain it has no effect in any other environment.
 
+### No dual-purpose environment please
+
+Your test environment is just for running your test suite. If you've overloaded the test environment to do any actual work, you'd be frustrated when `unreliable` slows it down and changes its behavior, so don't install it (yet).
+
 ## Contributing
 
 Thoughts and suggestions are welcome. Please read the code of conduct, then create an issue or pull request on GitHub. If you just have questions, go ahead and open an issue, I'm pretty friendly.
@@ -131,7 +135,7 @@ Appraisal ensures the tests run against every compatible minor version of Active
 
 The GitHub CI workflow in `.github/` ensures those tests are also run against against every compatible minor version of Ruby. Your PR won't trigger my GitHub project's workflow, but you're welcome to run your own, or ask me to run mine manually.
 
-Testing against ActiveRecord is done with [Combustion](https://github.com/pat/combustion), which stands up a local single-table SQLite database and an ActiveRecord-based model for it. This gives more reliable coverage than mocking unit tests within ActiveRecord itself.
+Testing against ActiveRecord is done with [Combustion](https://github.com/pat/combustion), which stands up a local SQLite database and ActiveRecord-based models for it. This gives more reliable coverage than mocking unit tests within ActiveRecord itself, though I do some of that too.
 
 ### Experiment
 
@@ -165,7 +169,7 @@ But there are other ways you can order a relation but still have your query be a
 * ORDER BY a column with values that differ only by [character case](https://dev.mysql.com/doc/refman/8.0/en/sorting-rows.html)
 * ORDER BY values that are identical within the [prefix length limit](https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_max_sort_length) examined for sorting
 
-`unreliable` correctly tests these because the random order is always appended.
+`unreliable` ensures correct testing because it appends a random order to each of these cases.
 
 ## References
 

data/lib/unreliable/build_order.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# Override ActiveRecord::QueryMethods.build_order to always append a final ORDER(RAND())
+# Override ActiveRecord::QueryMethods.build_order to append a final ORDER(RAND()) when necessary
 
 require "active_record/connection_adapters/abstract_adapter"
 
@@ -10,6 +10,8 @@ module Unreliable
       super(arel)
 
       return unless Unreliable::Config.enabled?
+      return if from_only_internal_metadata?(arel)
+      return if from_one_table_with_ordered_pk?(arel)
 
       case Arel::Table.engine.connection.adapter_name
       when "Mysql2"
@@ -26,5 +28,40 @@ module Unreliable
 
       end
     end
+
+    def from_only_internal_metadata?(arel)
+      # No need to randomize queries on ar_internal_metadata
+      arel.froms.map(&:name) == [ActiveRecord::Base.internal_metadata_table_name]
+    end
+
+    def from_one_table_with_ordered_pk?(arel)
+      # This gem isn't (yet) capable of determining if ordering is reliable when two or
+      # more tables are being joined.
+      return false if arel.ast.cores.first.source.is_a?(Arel::Nodes::JoinSource) &&
+        arel.ast.cores.first.source.right.present?
+      return false if arel.froms.count > 1
+
+      # If the single table's primary key's column(s) are covered by the order columns,
+      # return true and don't randomize the order.
+      (primary_key_columns(arel) - order_columns(arel)).empty?
+    end
+
+    def primary_key_columns(arel)
+      # primary_keys returns a String if it's one column, an Array if two or more.
+      # Using the SchemaCache minimizes the number of times we have to, e.g. in MySQL,
+      # SELECT column_name FROM information_schema.statistics
+      # (or in Rails < 6, SELECT column_name FROM information_schema.key_column_usage)
+      [ActiveRecord::Base.connection.schema_cache.primary_keys(arel.froms.first.name)].flatten
+    end
+
+    def order_columns(arel)
+      from_table_name = arel.froms.first.name
+      arel.orders
+        .select { |order| order.is_a? Arel::Nodes::Ordering } # Don't try to parse textual orders
+        .map(&:expr)
+        .select { |expr| expr.relation.name == from_table_name }
+        .map(&:name)
+        .map(&:to_s) # In Rails < 5.2, the order column names are symbols; >= 5.2, strings
+    end
   end
 end

data/lib/unreliable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Unreliable
-  VERSION = "0.1.3"
+  VERSION = "0.9.1"
 end

data/spec/env_spec.rb

@@ -3,14 +3,14 @@
 RSpec.describe Unreliable do
   it "does nothing in prod" do
     Rails.env = "production"
-    expect(Thing.where(word: "foo").to_sql).to end_with(%q(WHERE "things"."word" = 'foo'))
+    expect(Cat.where(word: "foo").to_sql).to end_with(%q(WHERE "cats"."word" = 'foo'))
   ensure
     Rails.env = "test"
   end
 
   it "does nothing in dev" do
     Rails.env = "development"
-    expect(Thing.where(word: "foo").to_sql).to end_with(%q(WHERE "things"."word" = 'foo'))
+    expect(Cat.where(word: "foo").to_sql).to end_with(%q(WHERE "cats"."word" = 'foo'))
   ensure
     Rails.env = "test"
   end

data/spec/examples.txt

@@ -1,14 +1,39 @@
-example_id                         | status | run_time        |
----------------------------------- | ------ | --------------- |
-./spec/env_spec.rb[1:1]            | passed | 0.00261 seconds |
-./spec/env_spec.rb[1:2]            | passed | 0.00042 seconds |
-./spec/model_select_spec.rb[1:1]   | passed | 0.00033 seconds |
-./spec/model_select_spec.rb[1:2]   | passed | 0.0005 seconds  |
-./spec/model_select_spec.rb[1:3]   | passed | 0.00042 seconds |
-./spec/model_select_spec.rb[1:4]   | passed | 0.00064 seconds |
-./spec/model_subquery_spec.rb[1:1] | passed | 0.00135 seconds |
-./spec/model_update_spec.rb[1:1]   | passed | 0.00011 seconds |
-./spec/railtie_spec.rb[1:1]        | passed | 0.00064 seconds |
-./spec/railtie_spec.rb[1:2]        | passed | 0.00014 seconds |
-./spec/version_spec.rb[1:1]        | passed | 0.00116 seconds |
-./spec/version_spec.rb[1:2]        | passed | 0.00016 seconds |
+example_id                                 | status | run_time        |
+------------------------------------------ | ------ | --------------- |
+./spec/env_spec.rb[1:1]                    | passed | 0.00346 seconds |
+./spec/env_spec.rb[1:2]                    | passed | 0.00049 seconds |
+./spec/model_cache_versioning_spec.rb[1:1] | passed | 0.03983 seconds |
+./spec/model_indexes_books_spec.rb[1:1]    | passed | 0.00152 seconds |
+./spec/model_indexes_books_spec.rb[1:2]    | passed | 0.00132 seconds |
+./spec/model_indexes_books_spec.rb[1:3]    | passed | 0.00108 seconds |
+./spec/model_indexes_cats_spec.rb[1:1]     | passed | 0.00105 seconds |
+./spec/model_indexes_cats_spec.rb[1:2]     | passed | 0.0015 seconds  |
+./spec/model_indexes_dreams_spec.rb[1:1]   | passed | 0.00313 seconds |
+./spec/model_indexes_dreams_spec.rb[1:2]   | passed | 0.00129 seconds |
+./spec/model_indexes_shelves_spec.rb[1:1]  | passed | 0.00178 seconds |
+./spec/model_indexes_shelves_spec.rb[1:2]  | passed | 0.00174 seconds |
+./spec/model_indexes_shelves_spec.rb[1:3]  | passed | 0.00076 seconds |
+./spec/model_indexes_shelves_spec.rb[1:4]  | passed | 0.00087 seconds |
+./spec/model_indexes_shelves_spec.rb[1:5]  | passed | 0.00079 seconds |
+./spec/model_indexes_shelves_spec.rb[1:6]  | passed | 0.00101 seconds |
+./spec/model_joins_spec.rb[1:1]            | passed | 0.01262 seconds |
+./spec/model_joins_spec.rb[1:2]            | passed | 0.00359 seconds |
+./spec/model_joins_spec.rb[1:3]            | passed | 0.01319 seconds |
+./spec/model_joins_spec.rb[1:4]            | passed | 0.00217 seconds |
+./spec/model_select_spec.rb[1:1]           | passed | 0.0007 seconds  |
+./spec/model_select_spec.rb[1:2]           | passed | 0.00093 seconds |
+./spec/model_select_spec.rb[1:3]           | passed | 0.00091 seconds |
+./spec/model_select_spec.rb[1:4]           | passed | 0.00127 seconds |
+./spec/model_subquery_spec.rb[1:1]         | passed | 0.00155 seconds |
+./spec/model_update_arel_10_spec.rb[1:1]   | passed | 0.00536 seconds |
+./spec/railtie_spec.rb[1:1]                | passed | 0.00013 seconds |
+./spec/railtie_spec.rb[1:2]                | passed | 0.00008 seconds |
+./spec/textual_order_spec.rb[1:1]          | passed | 0.00108 seconds |
+./spec/textual_order_spec.rb[1:2]          | passed | 0.00067 seconds |
+./spec/textual_order_spec.rb[1:3]          | passed | 0.00078 seconds |
+./spec/textual_order_spec.rb[1:4]          | passed | 0.00087 seconds |
+./spec/textual_order_spec.rb[1:5]          | passed | 0.00069 seconds |
+./spec/textual_order_spec.rb[1:6]          | passed | 0.00079 seconds |
+./spec/textual_order_spec.rb[1:7]          | passed | 0.00088 seconds |
+./spec/version_spec.rb[1:1]                | passed | 0.00151 seconds |
+./spec/version_spec.rb[1:2]                | passed | 0.0002 seconds  |

data/spec/model_cache_versioning_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+# collection_cache_versioning was added in Rails 6.0. It performs a
+# SELECT COUNT(*), MAX(updated_at) which will have an unnecessary ORDER BY RANDOM()
+# applied to it. That shouldn't hurt anything. This is a simple way to both
+# cover that important code and ensure Unreliable works correctly with
+# aggregate SELECTs.
+
+RSpec.describe Cat do
+  it "in ActiveRecord >= 6, calculates cache versions",
+    skip: ((ActiveRecord::VERSION::MAJOR < 6) ? "test is for ActiveRecord >= 6 only" : false) do
+    old_setting = ActiveRecord::Base.collection_cache_versioning
+    ActiveRecord::Base.collection_cache_versioning = true
+    Cat.new(name: "spot").save!
+    Cat.new(name: "sadie").save!
+    expect(Cat.where("name LIKE 's%'").cache_version).to start_with("2-")
+    expect(Cat.where(name: "foo").cache_version).to eq("0")
+  ensure
+    Cat.delete_all
+    ActiveRecord::Base.collection_cache_versioning = old_setting
+  end
+end

data/spec/model_indexes_books_spec.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+RSpec.describe "model_indexes_books" do
+  it "randomly selects from books with no order" do
+    expect(Book.all.to_sql).to end_with("ORDER BY RANDOM()")
+  end
+
+  it "randomly selects from books ordered by nonindexed column" do
+    expect(Book.all.order(:subject).to_sql).to end_with('ORDER BY "books"."subject" ASC, RANDOM()')
+  end
+
+  it "randomly selects from books ordered by unique column" do
+    expect(Book.all.order(:isbn).to_sql).to end_with('ORDER BY "books"."isbn" ASC, RANDOM()')
+  end
+end

data/spec/model_indexes_cats_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+RSpec.describe "model_indexes_cats" do
+  it "randomly selects from cats" do
+    expect(Cat.all.to_sql).to end_with("ORDER BY RANDOM()")
+  end
+
+  it "nonrandomly selects from cats by implied primary key descending" do
+    expect(Cat.all.order(id: :desc).to_sql).to end_with('ORDER BY "cats"."id" DESC')
+  end
+end

data/spec/model_indexes_dreams_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+RSpec.describe "model_indexes_dreams" do
+  it "randomly selects from dreams ordered by nonindexed column" do
+    expect(Dream.all.order(:subject).to_sql).to end_with('ORDER BY "dreams"."subject" ASC, RANDOM()')
+  end
+
+  it "nonrandomly selects from dreams by explicit primary key" do
+    expect(Dream.all.order(:dream_id).to_sql).to end_with('ORDER BY "dreams"."dream_id" ASC')
+  end
+end

data/spec/model_indexes_shelves_spec.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+RSpec.describe "model_indexes_shelves" do
+  it "randomly selects from shelves" do
+    expect(Shelf.all.to_sql).to end_with("ORDER BY RANDOM()")
+  end
+
+  it "randomly selects from some shelves" do
+    expect(Shelf.where(contents: "foo").to_sql).to end_with("ORDER BY RANDOM()")
+  end
+
+  it "randomly selects from shelves ordered by id" do
+    expect(Shelf.order(:shelf_id).to_sql).to end_with('ORDER BY "shelves"."shelf_id" ASC, RANDOM()')
+  end
+
+  it "randomly selects from shelves ordered by position" do
+    expect(Shelf.order(:shelf_position).to_sql).to end_with(
+      'ORDER BY "shelves"."shelf_position" ASC, RANDOM()'
+    )
+  end
+
+  it "nonrandomly selects from shelves ordered by id and position" do
+    expect(Shelf.order(:shelf_id, :shelf_position).to_sql).to end_with(
+      'ORDER BY "shelves"."shelf_id" ASC, "shelves"."shelf_position" ASC'
+    )
+  end
+
+  it "nonrandomly selects from some shelves ordered by id and position" do
+    expect(Shelf.where(contents: "bar").order(:shelf_id, :shelf_position).to_sql).to end_with(
+      'ORDER BY "shelves"."shelf_id" ASC, "shelves"."shelf_position" ASC'
+    )
+  end
+end

data/spec/model_joins_spec.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+# So far, unreliable does not try to know when it can omit the ORDER BY RANDOM()
+# when joining tables. It's unnecessary in some of the below tests and a future
+# version that's smart about joins might be able to omit it.
+
+RSpec.describe "model_indexes_joins" do
+  it "randomly selects from owner has_many cats" do
+    expect(Owner.joins(:cats).all.to_sql).to end_with("ORDER BY RANDOM()")
+  end
+
+  it "randomly selects from owner has_many ordered cats" do
+    expect(Owner.joins(:cats).order("owners.id": :asc).all.to_sql).to end_with(", RANDOM()")
+    expect(Owner.joins(:cats).order(:"cats.id").all.to_sql).to end_with(", RANDOM()")
+    expect(Owner.joins(:cats).order(:"owners.id", "cats.id": :desc).all.to_sql).to end_with(", RANDOM()")
+    expect(Owner.joins(:cats).order(:"owners.id", :"cats.name").all.to_sql).to end_with(", RANDOM()")
+  end
+
+  it "randomly selects from dreamer has_one dream" do
+    expect(Dreamer.joins(:dream).all.to_sql).to end_with("ORDER BY RANDOM()")
+  end
+
+  it "randomly selects from dreamer has_one ordered dream" do
+    expect(Dreamer.joins(:dream).order("dreamers.id": :desc).all.to_sql).to end_with(", RANDOM()")
+    expect(Dreamer.joins(:dream).order(:"dreams.id").all.to_sql).to end_with(", RANDOM()")
+  end
+end

data/spec/model_select_spec.rb

@@ -1,22 +1,22 @@
 # frozen_string_literal: true
 
-RSpec.describe Thing do
+RSpec.describe Cat do
   it "randomly selects from all" do
-    expect(Thing.all.to_sql).to end_with("ORDER BY RANDOM()")
+    expect(Cat.all.to_sql).to end_with("ORDER BY RANDOM()")
   end
 
   it "randomly selects from some" do
-    expect(Thing.where(word: "foo").to_sql).to end_with("ORDER BY RANDOM()")
+    expect(Cat.where(name: "foo").to_sql).to end_with("ORDER BY RANDOM()")
   end
 
   it "adds randomness to existing order" do
-    expect(Thing.order(:word).to_sql).to end_with('ORDER BY "things"."word" ASC, RANDOM()')
+    expect(Cat.order(:name).to_sql).to end_with('ORDER BY "cats"."name" ASC, RANDOM()')
   end
 
   it "respects a disable block" do
     Unreliable::Config.disable do
-      expect(Thing.where(word: "foo").to_sql).to_not end_with("ORDER BY RANDOM()")
-      expect(Thing.where(word: "foo").to_sql).to end_with(%q("things"."word" = 'foo'))
+      expect(Cat.where(name: "foo").to_sql).to_not end_with("ORDER BY RANDOM()")
+      expect(Cat.where(name: "foo").to_sql).to end_with(%q("cats"."name" = 'foo'))
     end
   end
 end

data/spec/model_subquery_spec.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-RSpec.describe Thing do
+RSpec.describe Cat do
   it "randomly selects in main query and subquery" do
     # rubocop:disable Layout/SpaceInsideParens,Layout/DotPosition
-    expect( Thing.where(word: Thing.where(word: "foo")).to_sql ).
-      to end_with( %q[WHERE "things"."word" = 'foo' ORDER BY RANDOM()) ORDER BY RANDOM()] )
+    expect( Cat.where(name: Cat.where(name: "foo")).to_sql ).
+      to end_with( %q[WHERE "cats"."name" = 'foo' ORDER BY RANDOM()) ORDER BY RANDOM()] )
     # rubocop:enable Layout/SpaceInsideParens,Layout/DotPosition
   end
 end

data/spec/model_update_arel_10_spec.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+# ActiveRecord's update_all invokes compile_update for the Arel::SelectManager returned
+# by build_arel. It returns an Arel::UpdateManager. This makes sure that internal call
+# assembles the update query correctly.
+
+module Unreliable
+  class SqlTestingData
+    class_attribute :update_manager_sql
+  end
+end
+
+RSpec.describe "update_manager" do
+  it "in ActiveRecord >= 7, updates by subquery with select in random order",
+    skip: ((ActiveRecord::VERSION::MAJOR < 7) ? "test is for ActiveRecord >= 7 only" : false) do
+    module Arel
+      class SelectManager
+        def testing_compile_update(*args)
+          um = old_compile_update(*args)
+          Unreliable::SqlTestingData.update_manager_sql = um.to_sql
+          um
+        end
+        alias_method :old_compile_update, :compile_update
+        alias_method :compile_update, :testing_compile_update
+      end
+    end
+    Cat.update_all(name: "bar")
+    expect(Unreliable::SqlTestingData.update_manager_sql).to end_with("ORDER BY RANDOM())")
+    Cat.where(name: "foo").update_all(name: "bar")
+    expect(Unreliable::SqlTestingData.update_manager_sql).to end_with("ORDER BY RANDOM())")
+    Cat.where(name: "bar").order(:id).update_all(name: "baz")
+    expect(Unreliable::SqlTestingData.update_manager_sql).to end_with("ORDER BY \"cats\".\"id\" ASC)")
+  ensure
+    module Arel
+      class SelectManager
+        alias_method :compile_update, :old_compile_update
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -4,6 +4,13 @@ require "bundler"
 
 Bundler.require :default, :development
 
+if ActiveRecord.gem_version >= Gem::Version.new("5.2") && ActiveRecord.gem_version < Gem::Version.new("6.0")
+  # This setting was introduced in Rails 5.2, made the default in Rails 6.0, and
+  # removed in Rails 6.1.
+  require "active_record/connection_adapters/sqlite3_adapter"
+  ActiveRecord::ConnectionAdapters::SQLite3Adapter.represent_boolean_as_integer = true
+end
+
 Combustion.initialize! :active_record
 
 RSpec.configure do |config|

data/spec/textual_order_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+RSpec.describe "textual order" do
+  it "randomly selects from shelves ordered by textual id asc" do
+    expect(Shelf.order("shelf_id ASC").to_sql).to end_with("ORDER BY shelf_id ASC, RANDOM()")
+  end
+
+  it "randomly selects from shelves ordered by fully qualified textual id asc" do
+    expect(Shelf.order('"shelves"."shelf_id"').to_sql).to end_with('ORDER BY "shelves"."shelf_id", RANDOM()')
+  end
+
+  it "randomly selects from shelves ordered by textual position asc" do
+    expect(Shelf.order("shelf_position ASC").to_sql).to end_with("ORDER BY shelf_position ASC, RANDOM()")
+  end
+
+  it "randomly selects from shelves ordered by textual id desc" do
+    expect(Shelf.order("shelf_id DESC").to_sql).to end_with("ORDER BY shelf_id DESC, RANDOM()")
+  end
+
+  it "randomly selects from shelves ordered by textual position desc" do
+    expect(Shelf.order("shelf_position DESC").to_sql).to end_with("ORDER BY shelf_position DESC, RANDOM()")
+  end
+
+  it "randomly selects from shelves ordered by textual id and position asc" do
+    expect(Shelf.order("shelf_id ASC, shelf_position ASC").to_sql).to end_with(
+      "ORDER BY shelf_id ASC, shelf_position ASC, RANDOM()"
+    )
+  end
+
+  it "randomly selects from shelves ordered by textual id and position desc" do
+    expect(Shelf.order("shelf_id DESC, shelf_position DESC").to_sql).to end_with(
+      "ORDER BY shelf_id DESC, shelf_position DESC, RANDOM()"
+    )
+  end
+end

data/spec/version_spec.rb

@@ -8,6 +8,6 @@ RSpec.describe Unreliable, "version" do
   end
 
   it "is correct" do
-    expect(Unreliable::VERSION).to start_with "0.1."
+    expect(Unreliable::VERSION).to start_with "0."
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unreliable
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.9.1
 platform: ruby
 authors:
 - James McCarthy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-08-21 00:00:00.000000000 Z
+date: 2022-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -140,14 +140,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '1.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '1.17'
 description: |
   Unreliable helps uncover bugs in Rails apps that rely on ambiguous database ordering.
   Installing it makes both your app and your test suite more robust.
@@ -169,11 +169,18 @@ files:
 - lib/unreliable/version.rb
 - spec/env_spec.rb
 - spec/examples.txt
+- spec/model_cache_versioning_spec.rb
+- spec/model_indexes_books_spec.rb
+- spec/model_indexes_cats_spec.rb
+- spec/model_indexes_dreams_spec.rb
+- spec/model_indexes_shelves_spec.rb
+- spec/model_joins_spec.rb
 - spec/model_select_spec.rb
 - spec/model_subquery_spec.rb
-- spec/model_update_spec.rb
+- spec/model_update_arel_10_spec.rb
 - spec/railtie_spec.rb
 - spec/spec_helper.rb
+- spec/textual_order_spec.rb
 - spec/version_spec.rb
 homepage: https://github.com/jamiemccarthy/unreliable
 licenses:

data/spec/model_update_spec.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Thing do
-  it "updates in random order tktk" do
-    # TODO
-  end
-end