unreliable 0.1.2 → 0.9.0

data/spec/model_update_arel_10_spec.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+# ActiveRecord's update_all invokes compile_update for the Arel::SelectManager returned
+# by build_arel. It returns an Arel::UpdateManager. This makes sure that internal call
+# assembles the update query correctly.
+
+module Unreliable
+  class SqlTestingData
+    class_attribute :update_manager_sql
+  end
+end
+
+RSpec.describe "update_manager" do
+  it "in ActiveRecord >= 7, updates by subquery with select in random order",
+    skip: ((ActiveRecord::VERSION::MAJOR < 7) ? "test is for ActiveRecord >= 7 only" : false) do
+    module Arel
+      class SelectManager
+        def testing_compile_update(*args)
+          um = old_compile_update(*args)
+          Unreliable::SqlTestingData.update_manager_sql = um.to_sql
+          um
+        end
+        alias_method :old_compile_update, :compile_update
+        alias_method :compile_update, :testing_compile_update
+      end
+    end
+    Cat.update_all(name: "bar")
+    expect(Unreliable::SqlTestingData.update_manager_sql).to end_with("ORDER BY RANDOM())")
+    Cat.where(name: "foo").update_all(name: "bar")
+    expect(Unreliable::SqlTestingData.update_manager_sql).to end_with("ORDER BY RANDOM())")
+    Cat.where(name: "bar").order(:id).update_all(name: "baz")
+    expect(Unreliable::SqlTestingData.update_manager_sql).to end_with("ORDER BY \"cats\".\"id\" ASC)")
+  ensure
+    module Arel
+      class SelectManager
+        alias_method :compile_update, :old_compile_update
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -4,6 +4,13 @@ require "bundler"
 
 Bundler.require :default, :development
 
+if ActiveRecord.gem_version >= Gem::Version.new("5.2") && ActiveRecord.gem_version < Gem::Version.new("6.0")
+  # This setting was introduced in Rails 5.2, made the default in Rails 6.0, and
+  # removed in Rails 6.1.
+  require "active_record/connection_adapters/sqlite3_adapter"
+  ActiveRecord::ConnectionAdapters::SQLite3Adapter.represent_boolean_as_integer = true
+end
+
 Combustion.initialize! :active_record
 
 RSpec.configure do |config|

data/spec/textual_order_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+RSpec.describe "textual order" do
+  it "randomly selects from shelves ordered by textual id asc" do
+    expect(Shelf.order("shelf_id ASC").to_sql).to end_with("ORDER BY shelf_id ASC, RANDOM()")
+  end
+
+  it "randomly selects from shelves ordered by fully qualified textual id asc" do
+    expect(Shelf.order('"shelves"."shelf_id"').to_sql).to end_with('ORDER BY "shelves"."shelf_id", RANDOM()')
+  end
+
+  it "randomly selects from shelves ordered by textual position asc" do
+    expect(Shelf.order("shelf_position ASC").to_sql).to end_with("ORDER BY shelf_position ASC, RANDOM()")
+  end
+
+  it "randomly selects from shelves ordered by textual id desc" do
+    expect(Shelf.order("shelf_id DESC").to_sql).to end_with("ORDER BY shelf_id DESC, RANDOM()")
+  end
+
+  it "randomly selects from shelves ordered by textual position desc" do
+    expect(Shelf.order("shelf_position DESC").to_sql).to end_with("ORDER BY shelf_position DESC, RANDOM()")
+  end
+
+  it "randomly selects from shelves ordered by textual id and position asc" do
+    expect(Shelf.order("shelf_id ASC, shelf_position ASC").to_sql).to end_with(
+      "ORDER BY shelf_id ASC, shelf_position ASC, RANDOM()"
+    )
+  end
+
+  it "randomly selects from shelves ordered by textual id and position desc" do
+    expect(Shelf.order("shelf_id DESC, shelf_position DESC").to_sql).to end_with(
+      "ORDER BY shelf_id DESC, shelf_position DESC, RANDOM()"
+    )
+  end
+end

data/spec/version_spec.rb

@@ -8,6 +8,6 @@ RSpec.describe Unreliable, "version" do
   end
 
   it "is correct" do
-    expect(Unreliable::VERSION).to start_with "0.1."
+    expect(Unreliable::VERSION).to start_with "0."
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unreliable
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.9.0
 platform: ruby
 authors:
 - James McCarthy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-04-27 00:00:00.000000000 Z
+date: 2022-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -140,41 +140,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '1.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '1.17'
 description: |
   Unreliable helps uncover bugs in Rails apps that rely on ambiguous database ordering.
-  With it installed, a test suite is less likely to accidentally succeed.
+  Installing it makes both your app and your test suite more robust.
 email: jamie@mccarthy.vg
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- Appraisals
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
-- gemfiles/activerecord_5.0.gemfile
-- gemfiles/activerecord_5.0.gemfile.lock
-- gemfiles/activerecord_5.1.gemfile
-- gemfiles/activerecord_5.1.gemfile.lock
-- gemfiles/activerecord_5.2.gemfile
-- gemfiles/activerecord_5.2.gemfile.lock
-- gemfiles/activerecord_6.0.gemfile
-- gemfiles/activerecord_6.0.gemfile.lock
-- gemfiles/activerecord_6.1.gemfile
-- gemfiles/activerecord_6.1.gemfile.lock
-- gemfiles/activerecord_7.0.gemfile
-- gemfiles/activerecord_7.0.gemfile.lock
 - lib/unreliable.rb
 - lib/unreliable/build_order.rb
 - lib/unreliable/config.rb
@@ -182,11 +169,18 @@ files:
 - lib/unreliable/version.rb
 - spec/env_spec.rb
 - spec/examples.txt
+- spec/model_cache_versioning_spec.rb
+- spec/model_indexes_books_spec.rb
+- spec/model_indexes_cats_spec.rb
+- spec/model_indexes_dreams_spec.rb
+- spec/model_indexes_shelves_spec.rb
+- spec/model_joins_spec.rb
 - spec/model_select_spec.rb
 - spec/model_subquery_spec.rb
-- spec/model_update_spec.rb
+- spec/model_update_arel_10_spec.rb
 - spec/railtie_spec.rb
 - spec/spec_helper.rb
+- spec/textual_order_spec.rb
 - spec/version_spec.rb
 homepage: https://github.com/jamiemccarthy/unreliable
 licenses:
@@ -212,5 +206,5 @@ requirements: []
 rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
-summary: Randomize relation final order for tests
+summary: For ActiveRecord tests, surface ambiguous-ordering bugs
 test_files: []

data/Appraisals

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-# The appraisal gem seems to be a convenient way to use this small config file to
-# build the gemfiles/* for the GitHub CI matrix.
-# Any `bundle update/install` should be accompanied by `bundle exec appraisal update/install`
-
-appraise "activerecord-5.0" do
-  gem "activerecord", "~> 5.0.0"
-  gem "sqlite3", "~> 1.3.6"
-end
-
-appraise "activerecord-5.1" do
-  gem "activerecord", "~> 5.1.0"
-  gem "sqlite3", "~> 1.3.6"
-end
-
-appraise "activerecord-5.2" do
-  gem "activerecord", "~> 5.2.0"
-  gem "sqlite3", "~> 1.3.6"
-end
-
-appraise "activerecord-6.0" do
-  gem "activerecord", "~> 6.0.0"
-end
-
-appraise "activerecord-6.1" do
-  gem "activerecord", "~> 6.1.0"
-end
-
-appraise "activerecord-7.0" do
-  gem "activerecord", "~> 7.0.0"
-end

data/gemfiles/activerecord_5.0.gemfile

@@ -1,8 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activerecord", "~> 5.0.0"
-gem "sqlite3", "~> 1.3.6"
-
-gemspec path: "../"

data/gemfiles/activerecord_5.0.gemfile.lock

@@ -1,134 +0,0 @@
-PATH
-  remote: ..
-  specs:
-    unreliable (0.1.2)
-      activerecord (>= 5.0, < 8.0)
-      railties (>= 5.0, < 8.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    actionpack (5.0.7.2)
-      actionview (= 5.0.7.2)
-      activesupport (= 5.0.7.2)
-      rack (~> 2.0)
-      rack-test (~> 0.6.3)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.0.7.2)
-      activesupport (= 5.0.7.2)
-      builder (~> 3.1)
-      erubis (~> 2.7.0)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activemodel (5.0.7.2)
-      activesupport (= 5.0.7.2)
-    activerecord (5.0.7.2)
-      activemodel (= 5.0.7.2)
-      activesupport (= 5.0.7.2)
-      arel (~> 7.0)
-    activesupport (5.0.7.2)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    appraisal (2.4.1)
-      bundler
-      rake
-      thor (>= 0.14.0)
-    arel (7.1.4)
-    ast (2.4.2)
-    builder (3.2.4)
-    combustion (1.3.5)
-      activesupport (>= 3.0.0)
-      railties (>= 3.0.0)
-      thor (>= 0.14.6)
-    concurrent-ruby (1.1.10)
-    crass (1.0.6)
-    diff-lcs (1.5.0)
-    erubis (2.7.0)
-    i18n (1.10.0)
-      concurrent-ruby (~> 1.0)
-    loofah (2.16.0)
-      crass (~> 1.0.2)
-      nokogiri (>= 1.5.9)
-    method_source (1.0.0)
-    minitest (5.15.0)
-    nokogiri (1.13.4-x86_64-linux)
-      racc (~> 1.4)
-    parallel (1.22.1)
-    parser (3.1.2.0)
-      ast (~> 2.4.1)
-    racc (1.6.0)
-    rack (2.2.3)
-    rack-test (0.6.3)
-      rack (>= 1.0)
-    rails-dom-testing (2.0.3)
-      activesupport (>= 4.2.0)
-      nokogiri (>= 1.6)
-    rails-html-sanitizer (1.4.2)
-      loofah (~> 2.3)
-    railties (5.0.7.2)
-      actionpack (= 5.0.7.2)
-      activesupport (= 5.0.7.2)
-      method_source
-      rake (>= 0.8.7)
-      thor (>= 0.18.1, < 2.0)
-    rainbow (3.1.1)
-    rake (13.0.6)
-    regexp_parser (2.3.1)
-    rexml (3.2.5)
-    rspec (3.11.0)
-      rspec-core (~> 3.11.0)
-      rspec-expectations (~> 3.11.0)
-      rspec-mocks (~> 3.11.0)
-    rspec-core (3.11.0)
-      rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-mocks (3.11.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-support (3.11.0)
-    rubocop (1.28.2)
-      parallel (~> 1.10)
-      parser (>= 3.1.0.0)
-      rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.17.0, < 2.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.17.0)
-      parser (>= 3.1.1.0)
-    rubocop-performance (1.13.3)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    ruby-progressbar (1.11.0)
-    sqlite3 (1.3.13)
-    standard (1.11.0)
-      rubocop (= 1.28.2)
-      rubocop-performance (= 1.13.3)
-    thor (1.2.1)
-    thread_safe (0.3.6)
-    tzinfo (1.2.9)
-      thread_safe (~> 0.1)
-    unicode-display_width (2.1.0)
-
-PLATFORMS
-  x86_64-linux
-
-DEPENDENCIES
-  activerecord (~> 5.0.0)
-  appraisal (~> 2.4)
-  bundler (~> 2.1)
-  combustion (~> 1.3)
-  rake (~> 13.0)
-  rspec (~> 3.0)
-  sqlite3 (~> 1.3.6)
-  standard (~> 1.11)
-  unreliable!
-
-BUNDLED WITH
-   2.3.8

data/gemfiles/activerecord_5.1.gemfile

@@ -1,8 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activerecord", "~> 5.1.0"
-gem "sqlite3", "~> 1.3.6"
-
-gemspec path: "../"

data/gemfiles/activerecord_5.1.gemfile.lock

@@ -1,134 +0,0 @@
-PATH
-  remote: ..
-  specs:
-    unreliable (0.1.2)
-      activerecord (>= 5.0, < 8.0)
-      railties (>= 5.0, < 8.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    actionpack (5.1.7)
-      actionview (= 5.1.7)
-      activesupport (= 5.1.7)
-      rack (~> 2.0)
-      rack-test (>= 0.6.3)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.1.7)
-      activesupport (= 5.1.7)
-      builder (~> 3.1)
-      erubi (~> 1.4)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activemodel (5.1.7)
-      activesupport (= 5.1.7)
-    activerecord (5.1.7)
-      activemodel (= 5.1.7)
-      activesupport (= 5.1.7)
-      arel (~> 8.0)
-    activesupport (5.1.7)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    appraisal (2.4.1)
-      bundler
-      rake
-      thor (>= 0.14.0)
-    arel (8.0.0)
-    ast (2.4.2)
-    builder (3.2.4)
-    combustion (1.3.5)
-      activesupport (>= 3.0.0)
-      railties (>= 3.0.0)
-      thor (>= 0.14.6)
-    concurrent-ruby (1.1.10)
-    crass (1.0.6)
-    diff-lcs (1.5.0)
-    erubi (1.10.0)
-    i18n (1.10.0)
-      concurrent-ruby (~> 1.0)
-    loofah (2.16.0)
-      crass (~> 1.0.2)
-      nokogiri (>= 1.5.9)
-    method_source (1.0.0)
-    minitest (5.15.0)
-    nokogiri (1.13.4-x86_64-linux)
-      racc (~> 1.4)
-    parallel (1.22.1)
-    parser (3.1.2.0)
-      ast (~> 2.4.1)
-    racc (1.6.0)
-    rack (2.2.3)
-    rack-test (1.1.0)
-      rack (>= 1.0, < 3)
-    rails-dom-testing (2.0.3)
-      activesupport (>= 4.2.0)
-      nokogiri (>= 1.6)
-    rails-html-sanitizer (1.4.2)
-      loofah (~> 2.3)
-    railties (5.1.7)
-      actionpack (= 5.1.7)
-      activesupport (= 5.1.7)
-      method_source
-      rake (>= 0.8.7)
-      thor (>= 0.18.1, < 2.0)
-    rainbow (3.1.1)
-    rake (13.0.6)
-    regexp_parser (2.3.1)
-    rexml (3.2.5)
-    rspec (3.11.0)
-      rspec-core (~> 3.11.0)
-      rspec-expectations (~> 3.11.0)
-      rspec-mocks (~> 3.11.0)
-    rspec-core (3.11.0)
-      rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-mocks (3.11.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-support (3.11.0)
-    rubocop (1.28.2)
-      parallel (~> 1.10)
-      parser (>= 3.1.0.0)
-      rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.17.0, < 2.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.17.0)
-      parser (>= 3.1.1.0)
-    rubocop-performance (1.13.3)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    ruby-progressbar (1.11.0)
-    sqlite3 (1.3.13)
-    standard (1.11.0)
-      rubocop (= 1.28.2)
-      rubocop-performance (= 1.13.3)
-    thor (1.2.1)
-    thread_safe (0.3.6)
-    tzinfo (1.2.9)
-      thread_safe (~> 0.1)
-    unicode-display_width (2.1.0)
-
-PLATFORMS
-  x86_64-linux
-
-DEPENDENCIES
-  activerecord (~> 5.1.0)
-  appraisal (~> 2.4)
-  bundler (~> 2.1)
-  combustion (~> 1.3)
-  rake (~> 13.0)
-  rspec (~> 3.0)
-  sqlite3 (~> 1.3.6)
-  standard (~> 1.11)
-  unreliable!
-
-BUNDLED WITH
-   2.3.8

data/gemfiles/activerecord_5.2.gemfile

@@ -1,8 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activerecord", "~> 5.2.0"
-gem "sqlite3", "~> 1.3.6"
-
-gemspec path: "../"

data/gemfiles/activerecord_5.2.gemfile.lock

@@ -1,134 +0,0 @@
-PATH
-  remote: ..
-  specs:
-    unreliable (0.1.2)
-      activerecord (>= 5.0, < 8.0)
-      railties (>= 5.0, < 8.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    actionpack (5.2.7)
-      actionview (= 5.2.7)
-      activesupport (= 5.2.7)
-      rack (~> 2.0, >= 2.0.8)
-      rack-test (>= 0.6.3)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.2.7)
-      activesupport (= 5.2.7)
-      builder (~> 3.1)
-      erubi (~> 1.4)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activemodel (5.2.7)
-      activesupport (= 5.2.7)
-    activerecord (5.2.7)
-      activemodel (= 5.2.7)
-      activesupport (= 5.2.7)
-      arel (>= 9.0)
-    activesupport (5.2.7)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    appraisal (2.4.1)
-      bundler
-      rake
-      thor (>= 0.14.0)
-    arel (9.0.0)
-    ast (2.4.2)
-    builder (3.2.4)
-    combustion (1.3.5)
-      activesupport (>= 3.0.0)
-      railties (>= 3.0.0)
-      thor (>= 0.14.6)
-    concurrent-ruby (1.1.10)
-    crass (1.0.6)
-    diff-lcs (1.5.0)
-    erubi (1.10.0)
-    i18n (1.10.0)
-      concurrent-ruby (~> 1.0)
-    loofah (2.16.0)
-      crass (~> 1.0.2)
-      nokogiri (>= 1.5.9)
-    method_source (1.0.0)
-    minitest (5.15.0)
-    nokogiri (1.13.4-x86_64-linux)
-      racc (~> 1.4)
-    parallel (1.22.1)
-    parser (3.1.2.0)
-      ast (~> 2.4.1)
-    racc (1.6.0)
-    rack (2.2.3)
-    rack-test (1.1.0)
-      rack (>= 1.0, < 3)
-    rails-dom-testing (2.0.3)
-      activesupport (>= 4.2.0)
-      nokogiri (>= 1.6)
-    rails-html-sanitizer (1.4.2)
-      loofah (~> 2.3)
-    railties (5.2.7)
-      actionpack (= 5.2.7)
-      activesupport (= 5.2.7)
-      method_source
-      rake (>= 0.8.7)
-      thor (>= 0.19.0, < 2.0)
-    rainbow (3.1.1)
-    rake (13.0.6)
-    regexp_parser (2.3.1)
-    rexml (3.2.5)
-    rspec (3.11.0)
-      rspec-core (~> 3.11.0)
-      rspec-expectations (~> 3.11.0)
-      rspec-mocks (~> 3.11.0)
-    rspec-core (3.11.0)
-      rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-mocks (3.11.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-support (3.11.0)
-    rubocop (1.28.2)
-      parallel (~> 1.10)
-      parser (>= 3.1.0.0)
-      rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.17.0, < 2.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.17.0)
-      parser (>= 3.1.1.0)
-    rubocop-performance (1.13.3)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    ruby-progressbar (1.11.0)
-    sqlite3 (1.3.13)
-    standard (1.11.0)
-      rubocop (= 1.28.2)
-      rubocop-performance (= 1.13.3)
-    thor (1.2.1)
-    thread_safe (0.3.6)
-    tzinfo (1.2.9)
-      thread_safe (~> 0.1)
-    unicode-display_width (2.1.0)
-
-PLATFORMS
-  x86_64-linux
-
-DEPENDENCIES
-  activerecord (~> 5.2.0)
-  appraisal (~> 2.4)
-  bundler (~> 2.1)
-  combustion (~> 1.3)
-  rake (~> 13.0)
-  rspec (~> 3.0)
-  sqlite3 (~> 1.3.6)
-  standard (~> 1.11)
-  unreliable!
-
-BUNDLED WITH
-   2.3.8

data/gemfiles/activerecord_6.0.gemfile

@@ -1,7 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activerecord", "~> 6.0.0"
-
-gemspec path: "../"