unread 0.8.2 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 302efc346d484f76d5346d27288d5e095062df99
-  data.tar.gz: 81d1a2fa58f5b4a6a7a78c3bede1d812033a1882
+  metadata.gz: 48716668ad0d7a2e9cd493656fb8c10f71903ff9
+  data.tar.gz: 2fcd8322339fa2e05381e1dc90889f0460a4c094
 SHA512:
-  metadata.gz: 7d79c07ac3de9d382349db73507e078156ed7731664cef4d0475b46a147299ab10037b12d874bbccb98b177d379eecc628c9cd4691c23f41bf9a91adff382db9
-  data.tar.gz: 5f4863448e71c179e30f61751d7849fee31d7bd6c1419db43c3f57d0d410683dbe9d7d8b069e902f54f4a1c3535c2040526254ecdcad23d3e6f5082ba742a832
+  metadata.gz: 4c5bb97e17fc71c5516b8099be065c4c68bdc578aa2286e95a2ff10627d43771f395b7f96e65be1e7c3f1d94db1d25e81942ff3de4ed9d43e54a517703427a4d
+  data.tar.gz: 73c4a144f14a95b4aa043b3ce3fda6704d8de7016e2a77127e5f07148ed8df76309898a6054e39aa69cb37d26d0fda06a5f0ded3478ff229e447a4ae802235ac

data/lib/unread/base.rb

@@ -5,36 +5,40 @@ module Unread
 
   module Base
     def acts_as_reader
-      unless ReadMark.reflections.include?(:reader)
+      ReadMark.reader_classes ||= []
+
+      unless ReadMark.reader_classes.include?(self)
         ReadMark.belongs_to :reader, :polymorphic => true, inverse_of: :read_marks
-      end
 
-      has_many :read_marks, :dependent => :delete_all, as: :reader, :inverse_of => :reader
+        has_many :read_marks, :dependent => :delete_all, as: :reader, :inverse_of => :reader
 
-      after_create :setup_new_reader
+        after_create :setup_new_reader
 
-      ReadMark.reader_classes ||= []
-      ReadMark.reader_classes << self
+        ReadMark.reader_classes << self
 
-      include Reader::InstanceMethods
-      extend Reader::ClassMethods
-      extend Reader::Scopes
+        include Reader::InstanceMethods
+        extend Reader::ClassMethods
+        extend Reader::Scopes
+      end
     end
 
     def acts_as_readable(options={})
-      class_attribute :readable_options
+      ReadMark.readable_classes ||= []
 
-      options.reverse_merge!(:on => :updated_at)
-      self.readable_options = options
+      unless ReadMark.readable_classes.include?(self)
+        class_attribute :readable_options
 
-      has_many :read_marks, :as => :readable, :dependent => :delete_all, inverse_of: :readable
+        options.reverse_merge!(:on => :updated_at)
+        self.readable_options = options
 
-      ReadMark.readable_classes ||= []
-      ReadMark.readable_classes << self unless ReadMark.readable_classes.include?(self)
+        has_many :read_marks, :as => :readable, :dependent => :delete_all, inverse_of: :readable
 
-      include Readable::InstanceMethods
-      extend Readable::ClassMethods
-      extend Readable::Scopes
+        ReadMark.readable_classes << self
+
+        include Readable::InstanceMethods
+        extend Readable::ClassMethods
+        extend Readable::Scopes
+      end
     end
 
     def using_postgresql?

data/lib/unread/version.rb

@@ -1,3 +1,3 @@
 module Unread
-  VERSION = '0.8.2'
+  VERSION = '0.8.3'
 end

data/spec/unread/base_spec.rb

@@ -27,6 +27,14 @@ describe Unread::Base do
         rm2 = @reader.read_mark_global(Email)
       }.to perform_queries(1)
     end
+
+    it "should be idempotent" do
+      expect {
+        Reader.acts_as_reader
+        Reader.acts_as_reader
+        Reader.acts_as_reader
+      }.to_not change { ReadMark.reader_classes }
+    end
   end
 
   describe :acts_as_readable do
@@ -41,5 +49,13 @@ describe Unread::Base do
     it "should use default options" do
       expect(Email.readable_options).to eq({ :on => :updated_at })
     end
+
+    it "should be idempotent" do
+      expect {
+        Document.acts_as_readable
+        Document.acts_as_readable
+        Document.acts_as_readable
+      }.to_not change { ReadMark.readable_classes }
+    end
   end
 end

data/unread.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'mysql2'
   s.add_development_dependency 'pg'
   s.add_development_dependency 'rspec'
-  s.add_development_dependency 'simplecov', '~> 0.11.0'
+  s.add_development_dependency 'simplecov', RUBY_VERSION < '2' ? '~> 0.11.2' : '>= 0.11.2'
   s.add_development_dependency 'coveralls'
   s.add_development_dependency 'appraisal'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unread
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - Georg Ledermann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-22 00:00:00.000000000 Z
+date: 2016-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -112,16 +112,16 @@ dependencies:
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.11.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.11.2
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -227,7 +227,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: unread
-rubygems_version: 2.6.6
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Manages read/unread status of ActiveRecord objects