unread 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 22da2f765c42c94461c4bf67560a057ed1f76d8f
-  data.tar.gz: 3d45b07e1d0fc2a3af20b81a8a8fa0b1ff2bf9de
+  metadata.gz: 62f6d5dbe191941fe9f5b358318fefbf93ad0c20
+  data.tar.gz: 80e1d361fc919f39f33142283b2dfe8d1d9376a1
 SHA512:
-  metadata.gz: c51a5ad38b6a49467f3f3d542e06177c9ea3226cadd1001b66f407bea2f1edf65d7f45bad871184697b526938e62a08905e1e44cb154288eb37a886396d5f53a
-  data.tar.gz: 53b3e25c4723f78121aa3a1f066a68c91b462cbc3a56f5489ac416ba58cb7bb4ea917bc3c174c4b25a852dee4228c10e90c7c054da2f16ceb73b1e5044e79b1b
+  metadata.gz: 8808316873efd20db90cb45b9bbf14e4bc6fb3336f69d3f2480bfe8feaee04a21c39a44672d28c892e6365ceb26440525c36283e27d6508baec32f8e2aa72246
+  data.tar.gz: a55db92bee6d0b5969cb244655137e08afc7438a8abedbcb65f92a44d05c77ce60dad18d677e64c745b3b831063e08a5076773d717773d30a1685f74d2735f1e

data/.gitignore

@@ -2,3 +2,4 @@
 .bundle
 Gemfile.lock
 pkg/*
+coverage/*

data/.travis.yml

@@ -2,8 +2,11 @@ language: ruby
 rvm:
   - 1.9.3
   - 2.0.0
+  - 2.1.1
 gemfile:
   - ci/Gemfile-rails-3-0
   - ci/Gemfile-rails-3-1
   - ci/Gemfile-rails-3-2
   - ci/Gemfile-rails-4-0
+  - ci/Gemfile-rails-4-1
+before_install: gem update bundler

data/MIT-LICENSE

@@ -1,4 +1,6 @@
-Copyright (c) 2010,2013 Georg Ledermann
+The MIT License (MIT)
+
+Copyright (c) 2010-2014 Georg Ledermann
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -5,6 +5,8 @@ Ruby gem to manage read/unread status of ActiveRecord objects - and it's fast.
 
 [![Build Status](https://travis-ci.org/ledermann/unread.png?branch=master)](https://travis-ci.org/ledermann/unread)
 [![Code Climate](https://codeclimate.com/github/ledermann/unread.png)](https://codeclimate.com/github/ledermann/unread)
+[![Coverage Status](https://coveralls.io/repos/ledermann/unread/badge.png)](https://coveralls.io/r/ledermann/unread)
+
 
 ## Features
 
@@ -18,11 +20,16 @@ Ruby gem to manage read/unread status of ActiveRecord objects - and it's fast.
 
 ## Requirements
 
-* Ruby 1.9.3 or 2.0.0
+* Ruby 1.9.3 or newer
 * Rails 3 (including 3.0, 3.1, 3.2) and Rails 4. For use with Rails 2.3 there is a branch named "rails2"
 * Needs a timestamp field in your models (like created_at or updated_at) with a database index on it
 
 
+## Changelog
+
+https://github.com/ledermann/unread/releases
+
+
 ## Installation
 
 Step 1: Add this to your Gemfile:
@@ -133,4 +140,4 @@ There are two other gems/plugins doing a similar job:
 Unfortunately, both of them have a lack of performance, because they calculate the unread records doing a `find(:all)`, which should be avoided for a large amount of records. This gem is based on a timestamp algorithm and therefore it's very fast.
 
 
-Copyright (c) 2010-2013 [Georg Ledermann](http://www.georg-ledermann.de), released under the MIT license
+Copyright (c) 2010-2014 [Georg Ledermann](http://www.georg-ledermann.de), released under the MIT license

data/Rakefile

@@ -1,15 +1,6 @@
 require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
-require 'rake'
-require 'rake/testtask'
+RSpec::Core::RakeTask.new(:spec)
 
-desc 'Default: run unit tests.'
-task :default => :test
-
-desc 'Test the unread plugin.'
-Rake::TestTask.new(:test) do |t|
-  t.libs << 'lib'
-  t.libs << 'test'
-  t.pattern = 'test/**/*_test.rb'
-  t.verbose = true
-end
+task :default => :spec

data/ci/Gemfile-rails-3-0

@@ -1,6 +1,9 @@
 source 'https://rubygems.org'
 
-gem 'activerecord', '~> 3.0.10'
+gem 'activerecord', '~> 3.0.20'
 gem 'sqlite3'
 gem 'timecop'
 gem 'rake'
+gem 'rspec'
+gem 'simplecov'
+gem 'coveralls'

data/ci/Gemfile-rails-3-1

@@ -1,6 +1,9 @@
 source 'https://rubygems.org'
 
-gem 'activerecord', '~> 3.1.1'
+gem 'activerecord', '~> 3.1.12'
 gem 'sqlite3'
 gem 'timecop'
 gem 'rake'
+gem 'rspec'
+gem 'simplecov'
+gem 'coveralls'

data/ci/Gemfile-rails-3-2

@@ -1,6 +1,9 @@
 source 'https://rubygems.org'
 
-gem 'activerecord', '~> 3.2.1'
+gem 'activerecord', '~> 3.2.17'
 gem 'sqlite3'
 gem 'timecop'
 gem 'rake'
+gem 'rspec'
+gem 'simplecov'
+gem 'coveralls'

data/ci/Gemfile-rails-4-0

@@ -1,6 +1,9 @@
 source 'https://rubygems.org'
 
-gem 'activerecord', '4.0.0.rc1'
+gem 'activerecord', '~> 4.0.4'
 gem 'sqlite3'
 gem 'timecop'
 gem 'rake'
+gem 'rspec'
+gem 'simplecov'
+gem 'coveralls'

data/ci/Gemfile-rails-4-1

@@ -0,0 +1,9 @@
+source 'https://rubygems.org'
+
+gem 'activerecord', '~> 4.1.0'
+gem 'sqlite3'
+gem 'timecop'
+gem 'rake'
+gem 'rspec'
+gem 'simplecov'
+gem 'coveralls'

data/lib/generators/unread/migration/migration_generator.rb

@@ -9,7 +9,7 @@ module Unread
     source_root File.expand_path('../templates', __FILE__)
 
     def create_migration_file
-      migration_template 'migration.rb', 'db/migrate/unread_migration'
+      migration_template 'migration.rb', 'db/migrate/unread_migration.rb'
     end
 
     def self.next_migration_number(dirname)

data/lib/unread/readable.rb

@@ -2,6 +2,8 @@ module Unread
   module Readable
     module ClassMethods
       def mark_as_read!(target, options)
+        raise ArgumentError unless options.is_a?(Hash)
+
         user = options[:for]
         assert_reader(user)
 
@@ -70,7 +72,7 @@ module Unread
         ReadMark.transaction do
           ReadMark.delete_all :readable_type => self.base_class.name
           ReadMark.connection.execute <<-EOT
-            INSERT INTO read_marks (user_id, readable_type, timestamp)
+            INSERT INTO #{ReadMark.table_name} (user_id, readable_type, timestamp)
             SELECT #{ReadMark.reader_class.primary_key}, '#{self.base_class.name}', '#{Time.current.to_s(:db)}'
             FROM #{ReadMark.reader_class.table_name}
           EOT

data/lib/unread/scopes.rb

@@ -4,7 +4,7 @@ module Unread
       def join_read_marks(user)
         assert_reader(user)
 
-        joins "LEFT JOIN read_marks ON read_marks.readable_type  = '#{base_class.name}'
+        joins "LEFT JOIN #{ReadMark.table_name} as read_marks ON read_marks.readable_type  = '#{base_class.name}'
                                    AND read_marks.readable_id    = #{table_name}.#{primary_key}
                                    AND read_marks.user_id        = #{user.id}
                                    AND read_marks.timestamp     >= #{table_name}.#{readable_options[:on]}"

data/lib/unread/version.rb

@@ -1,3 +1,3 @@
 module Unread
-  VERSION = '0.3.1'
+  VERSION = '0.4.0'
 end

data/spec/base_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe Unread::Base do
+  before :each do
+    @email = Email.create!
+    wait
+    @reader = Reader.create! :name => 'John'
+  end
+
+  describe :acts_as_reader do
+    it "should create global read mark" do
+      expect(@reader.read_marks.count).to eq 1
+      expect(@reader.read_marks.global.count).to eq 1
+    end
+
+    it "should define association for ReadMark" do
+      expect(@reader.read_marks.first.user).to eq(@reader)
+    end
+
+    it "should reset read_marks for created reader" do
+      expect(Email.unread_by(@reader)).to be_empty
+    end
+  end
+
+  describe :acts_as_readable do
+    it "should define association" do
+      expect(@email.read_marks.count).to eq 0
+    end
+
+    it "should add class to ReadMark.readable_classes" do
+      expect(ReadMark.readable_classes).to eq [ Email ]
+    end
+
+    it "should use default options" do
+      expect(Email.readable_options).to eq({ :on => :updated_at })
+    end
+  end
+end

data/spec/model/email.rb

@@ -0,0 +1,4 @@
+class Email < ActiveRecord::Base
+  self.primary_key = 'messageid'
+  acts_as_readable :on => :updated_at
+end

data/spec/model/reader.rb

@@ -0,0 +1,4 @@
+class Reader < ActiveRecord::Base
+  self.primary_key = 'number'
+  acts_as_reader
+end

data/spec/read_mark_spec.rb

@@ -0,0 +1,7 @@
+require 'spec_helper'
+
+describe ReadMark do
+  it "should have reader_class" do
+    expect(ReadMark.reader_class).to eq Reader
+  end
+end

data/spec/readable_spec.rb

@@ -0,0 +1,206 @@
+require 'spec_helper'
+
+describe Unread::Readable do
+  before :each do
+    @reader = Reader.create! :name => 'David'
+    @other_reader = Reader.create :name => 'Matz'
+    wait
+    @email1 = Email.create!
+    wait
+    @email2 = Email.create!
+  end
+
+  describe :unread_by do
+    it "should return all objects" do
+      expect(Email.unread_by(@reader)).to eq [@email1, @email2]
+      expect(Email.unread_by(@other_reader)).to eq [@email1, @email2]
+    end
+
+    it "should return unread records" do
+      @email1.mark_as_read! :for => @reader
+
+      expect(Email.unread_by(@reader)).to eq [@email2]
+      expect(Email.unread_by(@reader).count).to eq 1
+    end
+
+    it "should not allow invalid parameter" do
+      [ 42, nil, 'foo', :foo, {} ].each do |not_a_reader|
+        expect {
+          Email.unread_by(not_a_reader)
+        }.to raise_error(ArgumentError)
+      end
+    end
+
+    it "should not allow unsaved reader" do
+      unsaved_reader = Reader.new
+
+      expect {
+        Email.unread_by(unsaved_reader)
+      }.to raise_error(ArgumentError)
+    end
+  end
+
+  describe :with_read_marks_for do
+    it "should return readables" do
+      expect(Email.with_read_marks_for(@reader).to_a).to eq([@email1, @email2])
+    end
+
+    it "should be countable" do
+      expect(Email.with_read_marks_for(@reader).count(:messageid)).to eq(2)
+    end
+
+    it "should not allow invalid parameter" do
+      [ 42, nil, 'foo', :foo, {} ].each do |not_a_reader|
+        expect {
+          Email.with_read_marks_for(not_a_reader)
+        }.to raise_error(ArgumentError)
+      end
+    end
+
+    it "should not allow unsaved reader" do
+      unsaved_reader = Reader.new
+
+      expect {
+        Email.with_read_marks_for(unsaved_reader)
+      }.to raise_error(ArgumentError)
+    end
+  end
+
+  describe :unread? do
+    it "should recognize unread object" do
+      expect(@email1.unread?(@reader)).to be_truthy
+      expect(@email1.unread?(@other_reader)).to be_truthy
+    end
+
+    it "should handle updating object" do
+      @email1.mark_as_read! :for => @reader
+      wait
+      expect(@email1.unread?(@reader)).to be_falsey
+
+      @email1.update_attributes! :subject => 'changed'
+      expect(@email1.unread?(@reader)).to be_truthy
+    end
+
+    it "should raise error for invalid argument" do
+      expect {
+        @email1.unread?(42)
+      }.to raise_error(ArgumentError)
+    end
+
+    it "should work with eager-loaded read marks" do
+      @email1.mark_as_read! :for => @reader
+
+      expect {
+        emails = Email.with_read_marks_for(@reader).to_a
+
+        expect(emails[0].unread?(@reader)).to be_falsey
+        expect(emails[1].unread?(@reader)).to be_truthy
+      }.to perform_queries(1)
+    end
+  end
+
+  describe '#mark_as_read!' do
+    it "should mark a single object as read" do
+      @email1.mark_as_read! :for => @reader
+
+      expect(@email1.unread?(@reader)).to be_falsey
+      expect(Email.unread_by(@reader)).to eq [@email2]
+
+      expect(@email1.unread?(@other_reader)).to be_truthy
+      expect(Email.unread_by(@other_reader)).to eq [@email1, @email2]
+
+      expect(@reader.read_marks.single.count).to eq 1
+      expect(@reader.read_marks.single.first.readable).to eq @email1
+    end
+
+    it "should be idempotent" do
+      @email1.mark_as_read! :for => @reader
+      @email1.mark_as_read! :for => @reader
+
+      expect(@reader.read_marks.single.count).to eq 1
+    end
+  end
+
+  describe '.mark_as_read!' do
+    it "should mark multi objects as read" do
+      expect(@email1.unread?(@reader)).to be_truthy
+      expect(@email2.unread?(@reader)).to be_truthy
+
+      Email.mark_as_read! [ @email1, @email2 ], :for => @reader
+
+      expect(@email1.unread?(@reader)).to be_falsey
+      expect(@email2.unread?(@reader)).to be_falsey
+    end
+
+    it "should mark all objects as read" do
+      Email.mark_as_read! :all, :for => @reader
+
+      expect(@reader.read_mark_global(Email).timestamp).to eq Time.current
+      expect(@reader.read_marks.single).to eq []
+      expect(ReadMark.single.count).to eq 0
+      expect(ReadMark.global.count).to eq 2
+    end
+
+    it "should mark all objects as read with existing read objects" do
+      wait
+
+      Email.mark_as_read! :all, :for => @reader
+      @email1.mark_as_read! :for => @reader
+
+      expect(@reader.read_marks.single).to eq []
+    end
+
+    it "should not allow invalid arguments" do
+      expect {
+        Email.mark_as_read! :foo, :for => @reader
+      }.to raise_error(ArgumentError)
+
+      expect {
+        Email.mark_as_read! :foo, :bar
+      }.to raise_error(ArgumentError)
+    end
+  end
+
+  describe :reset_read_marks_for_all do
+    it "should reset read marks" do
+      Email.reset_read_marks_for_all
+
+      expect(ReadMark.single.count).to eq 0
+      expect(ReadMark.global.count).to eq 2
+    end
+  end
+
+  describe :cleanup_read_marks! do
+    it "should delete all single read marks" do
+      expect(@reader.read_marks.single.count).to eq 0
+
+      @email1.mark_as_read! :for => @reader
+
+      expect(Email.unread_by(@reader)).to eq [@email2]
+      expect(@reader.read_marks.single.count).to eq 1
+
+      Email.cleanup_read_marks!
+
+      @reader.reload
+      expect(@reader.read_marks.single.count).to eq 0
+    end
+
+    it "should reset if all objects are read" do
+      @email1.mark_as_read! :for => @reader
+      @email2.mark_as_read! :for => @reader
+
+      expect(@reader.read_marks.single.count).to eq 2
+
+      Email.cleanup_read_marks!
+
+      expect(@reader.read_marks.single.count).to eq 0
+    end
+
+    it "should not delete read marks from other readables" do
+      other_read_mark = @reader.read_marks.create! :readable_type => 'Foo', :readable_id => 42, :timestamp => 5.years.ago
+      Email.cleanup_read_marks!
+
+      expect(ReadMark.exists?(other_read_mark.id)).to be_truthy
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,78 @@
+require 'simplecov'
+require 'coveralls'
+
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+SimpleCov.start do
+  add_filter '/spec/'
+end
+
+require 'active_record'
+require 'timecop'
+require 'unread'
+
+require 'model/reader'
+require 'model/email'
+
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
+Dir[File.expand_path(File.join(File.dirname(__FILE__),'support','**','*.rb'))].each {|f| require f}
+
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# Require this file using `require "spec_helper"` to ensure that it is only
+# loaded once.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  #  config.order = 'random'
+
+  config.before :each do
+    clear_db
+  end
+
+  config.after :each do
+    Timecop.return
+  end
+end
+
+if I18n.respond_to?(:enforce_available_locales=)
+  I18n.enforce_available_locales = false
+end
+
+def setup_db
+  puts "Testing with ActiveRecord #{ActiveRecord::VERSION::STRING}"
+
+  ActiveRecord::Base.establish_connection :adapter => 'sqlite3', :database => ':memory:'
+  ActiveRecord::Migration.verbose = false
+
+  require File.expand_path('../../lib/generators/unread/migration/templates/migration.rb', __FILE__)
+  UnreadMigration.migrate(:up)
+
+  ActiveRecord::Schema.define(:version => 1) do
+    create_table :readers, :primary_key => 'number', :force => true do |t|
+      t.string :name
+    end
+
+    create_table :emails, :primary_key => 'messageid', :force => true do |t|
+      t.string :subject
+      t.text :content
+      t.datetime :created_at
+      t.datetime :updated_at
+    end
+  end
+end
+
+def clear_db
+  Reader.delete_all
+  Email.delete_all
+  ReadMark.delete_all
+end
+
+setup_db

data/spec/support/matchers/perform_queries.rb

@@ -0,0 +1,22 @@
+RSpec::Matchers.define :perform_queries do |expected|
+  match do |block|
+    query_count(&block) == expected
+  end
+
+  failure_message do |actual|
+    "Expected to run #{expected} queries, got #{@counter.query_count}"
+  end
+
+  def query_count(&block)
+    @counter = ActiveRecord::QueryCounter.new
+    ActiveSupport::Notifications.subscribe('sql.active_record', @counter.to_proc)
+    yield
+    ActiveSupport::Notifications.unsubscribe(@counter.to_proc)
+
+    @counter.query_count
+  end
+
+  def supports_block_expectations?
+    true
+  end
+end

data/spec/support/query_counter.rb

@@ -0,0 +1,17 @@
+module ActiveRecord
+  class QueryCounter
+    attr_reader :query_count
+
+    def initialize
+      @query_count = 0
+    end
+
+    def to_proc
+      lambda(&method(:callback))
+    end
+
+    def callback(name, start, finish, message_id, values)
+      @query_count += 1 unless %w(CACHE SCHEMA).include?(values[:name]) || values[:sql] =~ /^begin/i || values[:sql] =~ /^commit/i
+    end
+  end
+end

data/spec/support/timecop.rb

@@ -0,0 +1,3 @@
+def wait
+  Timecop.freeze(1.minute.from_now.change(:usec => 0))
+end

data/unread.gemspec

@@ -23,4 +23,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rake'
   s.add_development_dependency 'timecop'
   s.add_development_dependency 'sqlite3'
+  s.add_development_dependency 'rspec'
+  s.add_development_dependency 'simplecov'
+  s.add_development_dependency 'coveralls'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unread
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Georg Ledermann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-04 00:00:00.000000000 Z
+date: 2014-06-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -66,6 +66,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 'This gem creates a scope for unread objects and adds methods to mark
   objects as read '
 email:
@@ -80,11 +122,11 @@ files:
 - MIT-LICENSE
 - README.md
 - Rakefile
-- changelog.md
 - ci/Gemfile-rails-3-0
 - ci/Gemfile-rails-3-1
 - ci/Gemfile-rails-3-2
 - ci/Gemfile-rails-4-0
+- ci/Gemfile-rails-4-1
 - lib/generators/unread/migration/migration_generator.rb
 - lib/generators/unread/migration/templates/migration.rb
 - lib/unread.rb
@@ -94,10 +136,15 @@ files:
 - lib/unread/reader.rb
 - lib/unread/scopes.rb
 - lib/unread/version.rb
-- test/database.yml
-- test/schema.rb
-- test/test_helper.rb
-- test/unread_test.rb
+- spec/base_spec.rb
+- spec/model/email.rb
+- spec/model/reader.rb
+- spec/read_mark_spec.rb
+- spec/readable_spec.rb
+- spec/spec_helper.rb
+- spec/support/matchers/perform_queries.rb
+- spec/support/query_counter.rb
+- spec/support/timecop.rb
 - unread.gemspec
 homepage: ''
 licenses: []
@@ -118,12 +165,17 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: unread
-rubygems_version: 2.0.14
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Manages read/unread status of ActiveRecord objects
 test_files:
-- test/database.yml
-- test/schema.rb
-- test/test_helper.rb
-- test/unread_test.rb
+- spec/base_spec.rb
+- spec/model/email.rb
+- spec/model/reader.rb
+- spec/read_mark_spec.rb
+- spec/readable_spec.rb
+- spec/spec_helper.rb
+- spec/support/matchers/perform_queries.rb
+- spec/support/query_counter.rb
+- spec/support/timecop.rb

data/changelog.md

@@ -1,75 +0,0 @@
-# Changelog
-
-## 0.3.1 - 2013-12-04
-
-* Use Time.current instead of Time.now to avoid time zone trouble. Issue #18 (thanks to @henrythe9th)
-* Handle primary keys other than "id". Issue #29 (thanks to @bcavileer)
-
-
-## 0.3.0 - 2013-03-17
-
-* Support for Rails 4 (beta1)
-
-
-## 0.2.0 - 2013-02-18
-
-* Support for Rails 2 dropped
-* Refactoring
-* Added migration generator
-
-
-## 0.1.2 - 2013-01-27
-
-* Scopes: Improved parameter check
-
-
-## 0.1.1 - 2012-05-01
-
-* Fixed handling namespaced classes. Closes #10 (thanks to @stanislaw)
-
-
-## 0.1.0 - 2012-04-21
-
-* Added scope "with_read_marks_for"
-* Fixed #7: Added attr_accessible to all ReadMark attributes (thanks to @negative)
-
-
-## 0.0.7 - 2012-02-29
-
-* Cleanup files
-* acts_as_reader: Using inverse_of (available since Rails 2.3.6)
-
-
-## 0.0.6 - 2011-11-11
-
-* Fixed #5: Gemspec dependency fix (thanks to @bricker88)
-* Fixed #6: Removed hard coded dependency on a class named "User" (thanks to @mixandgo)
-* Some cleanup
-
-
-## 0.0.5 - 2011-09-09
-
-* Fixed class loading issue in development environment
-
-
-## 0.0.4 - 2011-08-31
-
-* Ignore multiple calls of acts_as_*
-* Improved error messages
-* Tested with Rails 3.1
-
-
-## 0.0.3 - 2011-08-01
-
-* Fixed gemspec by adding development dependencies
-* Testing with Travis CI
-
-
-## 0.0.2 - 2011-06-23
-
-* Fixed scoping for ActiveRecord 2.x
-
-
-## 0.0.1 - 2011-06-23
-
-* Released as Gem

data/test/database.yml

@@ -1,3 +0,0 @@
-sqlite:
-  adapter: sqlite3
-  database: ":memory:"

data/test/schema.rb

@@ -1,20 +0,0 @@
-ActiveRecord::Schema.define(:version => 0) do
-  create_table :readers, :primary_key => 'number', :force => true do |t|
-    t.string :name
-  end
-
-  create_table :emails, :primary_key => 'messageid', :force => true do |t|
-    t.string :subject
-    t.text :content
-    t.datetime :created_at
-    t.datetime :updated_at
-  end
-
-  create_table :read_marks, :force => true do |t|
-    t.integer  :readable_id
-    t.integer  :user_id,       :null => false
-    t.string   :readable_type, :null => false
-    t.datetime :timestamp
-  end
-  add_index :read_marks, [:user_id, :readable_type, :readable_id]
-end

data/test/test_helper.rb

@@ -1,27 +0,0 @@
-require 'test/unit'
-require 'active_support'
-require 'active_support/test_case'
-require 'active_record'
-require 'timecop'
-
-configs = YAML.load_file(File.dirname(__FILE__) + '/database.yml')
-ActiveRecord::Base.configurations = configs
-
-ActiveRecord::Base.establish_connection('sqlite')
-ActiveRecord::Migration.verbose = false
-load(File.dirname(__FILE__) + "/schema.rb")
-
-require 'unread'
-
-class Reader < ActiveRecord::Base
-  self.primary_key = 'number'
-  acts_as_reader
-end
-
-class Email < ActiveRecord::Base
-  self.primary_key = 'messageid'
-
-  acts_as_readable :on => :updated_at
-end
-
-puts "Testing with ActiveRecord #{ActiveRecord::VERSION::STRING}"

data/test/unread_test.rb

@@ -1,166 +0,0 @@
-require 'test_helper'
-
-class UnreadTest < ActiveSupport::TestCase
-  def setup
-    @reader = Reader.create! :name => 'David'
-    @other_reader = Reader.create :name => 'Matz'
-    wait
-    @email1 = Email.create!
-    wait
-    @email2 = Email.create!
-  end
-
-  def teardown
-    Reader.delete_all
-    Email.delete_all
-    ReadMark.delete_all
-    Timecop.return
-  end
-
-  def test_schema_has_loaded_correctly
-    assert_equal [@email1, @email2], Email.all
-  end
-
-  def test_readable_classes
-    assert_equal [ Email ], ReadMark.readable_classes
-  end
-
-  def test_reader_class
-    assert_equal Reader, ReadMark.reader_class
-  end
-
-  def test_scope
-    assert_equal [@email1, @email2], Email.unread_by(@reader)
-    assert_equal [@email1, @email2], Email.unread_by(@other_reader)
-
-    assert_equal 2, Email.unread_by(@reader).count
-    assert_equal 2, Email.unread_by(@other_reader).count
-  end
-
-  def test_with_read_marks_for
-    @email1.mark_as_read! :for => @reader
-
-    emails = Email.with_read_marks_for(@reader).to_a
-
-    assert emails[0].read_mark_id.present?
-    assert emails[1].read_mark_id.nil?
-
-    assert_equal false, emails[0].unread?(@reader)
-    assert_equal true, emails[1].unread?(@reader)
-  end
-
-  def test_scope_param_check
-    [ 42, nil, 'foo', :foo, {} ].each do |not_a_reader|
-      assert_raise(ArgumentError) { Email.unread_by(not_a_reader)}
-      assert_raise(ArgumentError) { Email.with_read_marks_for(not_a_reader)}
-    end
-
-    unsaved_reader = Reader.new
-    assert_raise(ArgumentError) { Email.unread_by(unsaved_reader)}
-    assert_raise(ArgumentError) { Email.with_read_marks_for(unsaved_reader)}
-  end
-
-  def test_scope_after_reset
-    @email1.mark_as_read! :for => @reader
-
-    assert_equal [@email2], Email.unread_by(@reader)
-    assert_equal 1, Email.unread_by(@reader).count
-  end
-
-  def test_unread_after_create
-    assert_equal true, @email1.unread?(@reader)
-    assert_equal true, @email1.unread?(@other_reader)
-
-    assert_raise(ArgumentError) {
-      @email1.unread?(42)
-    }
-  end
-
-  def test_unread_after_update
-    @email1.mark_as_read! :for => @reader
-    wait
-    @email1.update_attributes! :subject => 'changed'
-
-    assert_equal true, @email1.unread?(@reader)
-  end
-
-  def test_mark_as_read
-    @email1.mark_as_read! :for => @reader
-
-    assert_equal false, @email1.unread?(@reader)
-    assert_equal [@email2], Email.unread_by(@reader)
-
-    assert_equal true, @email1.unread?(@other_reader)
-    assert_equal [@email1, @email2], Email.unread_by(@other_reader)
-
-    assert_equal 1, @reader.read_marks.single.count
-    assert_equal @email1, @reader.read_marks.single.first.readable
-  end
-
-  def test_mark_as_read_multiple
-    assert_equal true, @email1.unread?(@reader)
-    assert_equal true, @email2.unread?(@reader)
-
-    Email.mark_as_read! [ @email1, @email2 ], :for => @reader
-
-    assert_equal false, @email1.unread?(@reader)
-    assert_equal false, @email2.unread?(@reader)
-  end
-
-  def test_mark_as_read_with_marked_all
-    wait
-
-    Email.mark_as_read! :all, :for => @reader
-    @email1.mark_as_read! :for => @reader
-
-    assert_equal [], @reader.read_marks.single
-  end
-
-  def test_mark_as_read_twice
-    @email1.mark_as_read! :for => @reader
-    @email1.mark_as_read! :for => @reader
-
-    assert_equal 1, @reader.read_marks.single.count
-  end
-
-  def test_mark_all_as_read
-    Email.mark_as_read! :all, :for => @reader
-
-    assert_equal Time.current, @reader.read_mark_global(Email).timestamp
-    assert_equal [], @reader.read_marks.single
-    assert_equal 0, ReadMark.single.count
-    assert_equal 2, ReadMark.global.count
-  end
-
-  def test_cleanup_read_marks
-    assert_equal 0, @reader.read_marks.single.count
-
-    @email1.mark_as_read! :for => @reader
-
-    assert_equal [@email2], Email.unread_by(@reader)
-    assert_equal 1, @reader.read_marks.single.count
-
-    Email.cleanup_read_marks!
-
-    @reader.reload
-    assert_equal 0, @reader.read_marks.single.count
-  end
-
-  def test_cleanup_read_marks_not_delete_from_other_readables
-    other_read_mark = @reader.read_marks.create! :readable_type => 'Foo', :readable_id => 42, :timestamp => 5.years.ago
-    Email.cleanup_read_marks!
-    assert_equal true, !!ReadMark.exists?(other_read_mark.id) # Rails4 does not return true, but count instead.
-  end
-
-  def test_reset_read_marks_for_all
-    Email.reset_read_marks_for_all
-
-    assert_equal 0, ReadMark.single.count
-    assert_equal 2, ReadMark.global.count
-  end
-
-private
-  def wait
-    Timecop.freeze(1.minute.from_now.change(:usec => 0))
-  end
-end