unpoly-rails 0.61.0 → 0.61.1

data/lib/assets/javascripts/unpoly/fragment.coffee.erb

@@ -74,7 +74,7 @@ up.fragment = do ->
 
   \#\#\# Example
 
-  Let's say your curent HTML looks like this:
+  Let's say your current HTML looks like this:
 
       <div class="one">old one</div>
       <div class="two">old two</div>
@@ -314,7 +314,7 @@ up.fragment = do ->
 
   \#\#\# Example
 
-  Let's say your curent HTML looks like this:
+  Let's say your current HTML looks like this:
 
       <div class="one">old one</div>
       <div class="two">old two</div>
@@ -826,7 +826,10 @@ up.fragment = do ->
     wipe = ->
       parent = element.parentNode
       up.syntax.clean(element)
-      e.remove(element)
+      if up.browser.canJQuery()
+        jQuery(element).remove()
+      else
+        e.remove(element)
       emitFragmentDestroyed(element, { parent: parent, log: options.log })
 
     animate().then(wipe)

data/lib/assets/javascripts/unpoly/link.coffee.erb

@@ -16,7 +16,7 @@ This makes for an unfriendly experience:
 - State changes caused by AJAX updates get lost during the page transition.
 - Unsaved form changes get lost during the page transition.
 - The JavaScript VM is reset during the page transition.
-- If the page layout is composed from multiple srollable containers
+- If the page layout is composed from multiple scrollable containers
   (e.g. a pane view), the scroll positions get lost during the page transition.
 - The user sees a "flash" as the browser loads and renders the new page,
   even if large portions of the old and new page are the same (navigation, layout, etc.).

data/lib/assets/javascripts/unpoly/modal.coffee.erb

@@ -288,7 +288,7 @@ up.modal = do ->
       var link = document.querySelector('a')
       up.modal.follow(link)
 
-  Any option attributes for [`a[up-modal]`](/a.up-modal) will be honored.
+  Any option attributes for [`a[up-modal]`](/a-up-modal) will be honored.
 
   Emits events [`up:modal:open`](/up:modal:open) and [`up:modal:opened`](/up:modal:opened).
 
@@ -650,7 +650,7 @@ up.modal = do ->
 
   Clicking would request the path `/blog` and select `.blog-list` from
   the HTML response. Unpoly will dim the page
-  and place the matching `.blog-list` tag will be placed in
+  and place the matching `.blog-list` tag in
   a modal dialog.
 
   @selector a[up-modal]

data/lib/assets/javascripts/unpoly/syntax.coffee.erb

@@ -215,7 +215,7 @@ up.syntax = do ->
   ###**
   Registers a [compiler](/up.compiler) that is run before all other compilers.
 
-  Use `up.macro()` to register a compiler that sets multiply Unpoly attributes.
+  Use `up.macro()` to register a compiler that sets multiple Unpoly attributes.
 
   \#\#\# Example
 

data/lib/assets/javascripts/unpoly/viewport.coffee.erb

@@ -506,13 +506,37 @@ up.viewport = do ->
 
   The scroll positions will be associated with the current URL.
   They can later be restored by calling [`up.viewport.restoreScroll()`](/up.viewport.restoreScroll)
-  at the same URL.
+  at the same URL, or by following a link with an [`[up-restore-scroll]`](/a-up-follow#up-restore-scroll)
+  attribute.
 
-  Unpoly automatically saves scroll positions whenever a fragment was updated on the page.
+  Unpoly automatically saves scroll positions before a [fragment update](/up.replace)
+  you will rarely need to call this function yourself.
+
+  \#\#\# Examples
+
+  Should you need to save the current scroll positions outside of a [fragment update](/up.replace),
+  you may call:
+
+      up.viewport.saveScroll()
+
+  Instead of saving the current scroll positions for the current URL, you may also pass another
+  url or vertical scroll positionsfor each viewport:
+
+      up.viewport.saveScroll({
+        url: '/inbox',
+        tops: {
+          'body': 0,
+          '.sidebar', 100,
+          '.main', 320
+        }
+      })
 
   @function up.viewport.saveScroll
   @param {string} [options.url]
+    The URL for which to save scroll positions.
+    If omitted, the current browser location is used.
   @param {Object<string, number>} [options.tops]
+    An object mapping viewport selectors to vertical scroll positions in pixels.
   @experimental
   ###
   saveScroll = (options = {}) ->

data/lib/unpoly/rails/version.rb

@@ -4,6 +4,6 @@ module Unpoly
     # The current version of the unpoly-rails gem.
     # This version number is also used for releases of the Unpoly
     # frontend code.
-    VERSION = '0.61.0'
+    VERSION = '0.61.1'
   end
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "unpoly",
-  "version": "0.61.0",
+  "version": "0.61.1",
   "description": "Unobtrusive JavaScript framework",
   "main": "dist/unpoly.js",
   "files": [

data/spec_app/Gemfile

@@ -14,11 +14,9 @@ gem 'bower-rails'
 gem 'bootstrap-sass', '~> 3.3'
 gem 'rake', '< 11'
 
-# Jasmine spec runner won't boot with a more modern version of sprockets.
-# It crashes with an "asset not precompiled" error.
 gem 'tilt', '=1.4.1'
-gem 'sprockets-rails', '=2.2.4'
-gem 'sprockets', '=2.12.3'
+gem 'sprockets-rails', '~> 3.2.1'
+gem 'sprockets', '~> 3.7.2'
 
 group :development, :test do
   gem 'byebug'

data/spec_app/Gemfile.lock

@@ -62,7 +62,7 @@ GEM
       autoprefixer-rails (>= 5.2.1)
       sass (>= 3.3.4)
     bower-rails (0.9.2)
-    builder (3.2.3)
+    builder (3.2.4)
     byebug (3.5.1)
       columnize (~> 0.8)
       debugger-linecache (~> 1.2)
@@ -75,8 +75,8 @@ GEM
       execjs
     coffee-script-source (1.12.2)
     columnize (0.9.0)
-    concurrent-ruby (1.1.4)
-    crass (1.0.4)
+    concurrent-ruby (1.1.6)
+    crass (1.0.6)
     debug_inspector (0.0.2)
     debugger-linecache (1.2.0)
     diff-lcs (1.2.5)
@@ -92,7 +92,6 @@ GEM
       haml (>= 3.1, < 5.0)
       html2haml (>= 1.0.1)
       railties (>= 4.0.1)
-    hike (1.2.3)
     hpricot (0.8.6)
     html2haml (1.0.1)
       erubis (~> 2.7.0)
@@ -102,25 +101,24 @@ GEM
     i18n (0.9.5)
       concurrent-ruby (~> 1.0)
     jasmine-core (2.99.2)
-    jquery-rails (4.3.1)
+    jquery-rails (4.3.5)
       rails-dom-testing (>= 1, < 3)
       railties (>= 4.2.0)
       thor (>= 0.14, < 2.0)
     json (1.8.6)
     libv8 (3.16.14.3)
-    loofah (2.2.3)
+    loofah (2.4.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
     mail (2.6.3)
       mime-types (>= 1.16, < 3)
     mime-types (2.99)
     mini_portile2 (2.4.0)
-    minitest (5.11.3)
-    multi_json (1.13.1)
-    nokogiri (1.9.1)
+    minitest (5.14.0)
+    nokogiri (1.10.9)
       mini_portile2 (~> 2.4.0)
     phantomjs (2.1.1.0)
-    rack (1.6.11)
+    rack (1.6.13)
     rack-test (0.6.3)
       rack (>= 1.0)
     rails (4.2.0)
@@ -140,8 +138,8 @@ GEM
       activesupport (>= 4.2.0, < 5.0)
       nokogiri (~> 1.6)
       rails-deprecated_sanitizer (>= 1.0.1)
-    rails-html-sanitizer (1.0.4)
-      loofah (~> 2.2, >= 2.2.2)
+    rails-html-sanitizer (1.3.0)
+      loofah (~> 2.3)
     railties (4.2.0)
       actionpack (= 4.2.0)
       activesupport (= 4.2.0)
@@ -177,23 +175,21 @@ GEM
       tilt (>= 1.1, < 3)
     sexp_processor (4.4.4)
     slop (3.6.0)
-    sprockets (2.12.3)
-      hike (~> 1.2)
-      multi_json (~> 1.0)
-      rack (~> 1.0)
-      tilt (~> 1.1, != 1.3.0)
-    sprockets-rails (2.2.4)
-      actionpack (>= 3.0)
-      activesupport (>= 3.0)
-      sprockets (>= 2.8, < 4.0)
+    sprockets (3.7.2)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.1)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
     sqlite3 (1.3.10)
     therubyracer (0.12.1)
       libv8 (~> 3.16.14.0)
       ref
-    thor (0.20.3)
+    thor (1.0.1)
     thread_safe (0.3.6)
     tilt (1.4.1)
-    tzinfo (1.2.5)
+    tzinfo (1.2.7)
       thread_safe (~> 0.1)
     uglifier (2.6.0)
       execjs (>= 0.3.0)
@@ -220,8 +216,8 @@ DEPENDENCIES
   rake (< 11)
   rspec-rails
   sass-rails (~> 5.0)
-  sprockets (= 2.12.3)
-  sprockets-rails (= 2.2.4)
+  sprockets (~> 3.7.2)
+  sprockets-rails (~> 3.2.1)
   sqlite3
   therubyracer
   tilt (= 1.4.1)
@@ -230,4 +226,4 @@ DEPENDENCIES
   web-console (~> 2.0)
 
 BUNDLED WITH
-   1.16.4
+   1.17.3

data/spec_app/spec/javascripts/up/form_spec.js.coffee

@@ -25,6 +25,28 @@ describe 'up.form', ->
         results = up.form.fields(textArea)
         expect(results).toMatchList([textArea])
 
+      it 'ignores fields outside the given form', ->
+        form1 = fixture('form')
+        form1Field = e.affix(form1, 'input[type=text]')
+        form2 = fixture('form')
+        form2Field = e.affix(form2, 'input[type=text]')
+        results = up.form.fields(form1)
+        expect(results).toMatchList([form1Field])
+
+      it "includes fields outside the form with a [form] attribute matching the given form's ID", ->
+        form = fixture('form#form-id')
+        insideField = e.affix(form, 'input[type=text]')
+        outsideField = fixture('input[type=text][form=form-id]')
+        results = up.form.fields(form)
+        expect(results).toMatchList([insideField, outsideField])
+
+      it "does not return duplicate fields if a field with a matching [form] attribute is also a child of the form", ->
+        form = fixture('form#form-id')
+        field = e.affix(form, 'input[type=text][form=form-id]')
+        results = up.form.fields(form)
+        expect(results).toMatchList([field])
+
+
     describe 'up.observe', ->
 
       beforeEach ->
@@ -877,6 +899,23 @@ describe 'up.form', ->
         Trigger.change($field)
         next => expect(submitSpy).toHaveBeenCalled()
 
+      it 'submits the form when a change is observed on a container for a radio button group', asyncSpec (next) ->
+        form = fixture('form')
+        group = e.affix(form, '.group[up-autosubmit][up-delay=0]')
+        radio1 = e.affix(group, 'input[type=radio][name=foo][value=1]')
+        radio2 = e.affix(group, 'input[type=radio][name=foo][value=2]')
+        up.hello(form)
+        submitSpy = up.form.knife.mock('submit').and.returnValue(Promise.reject())
+        Trigger.clickSequence(radio1)
+        next =>
+          expect(submitSpy.calls.count()).toBe(1)
+          Trigger.clickSequence(radio2)
+        next =>
+          expect(submitSpy.calls.count()).toBe(2)
+          Trigger.clickSequence(radio1)
+        next =>
+          expect(submitSpy.calls.count()).toBe(3)
+
     describe 'form[up-autosubmit]', ->
 
       it 'submits the form when a change is observed in any of its fields', asyncSpec (next) ->

data/spec_app/spec/javascripts/up/fragment_spec.js.coffee

@@ -2533,6 +2533,15 @@ describe 'up.fragment', ->
           )
           expect($element).toBeDetached()
 
+      it 'removes element-related data from the global jQuery cache (bugfix)', asyncSpec (next) ->
+        $element = $fixture('.element')
+        $element.data('foo', { foo: '1' })
+        expect($element.data('foo')).toEqual({ foo: '1'})
+        up.destroy($element)
+
+        next ->
+          expect($element.data('foo')).toBeMissing()
+
     describe 'up.reload', ->
 
       describeCapability 'canPushState', ->

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unpoly-rails
 version: !ruby/object:Gem::Version
-  version: 0.61.0
+  version: 0.61.1
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-20 00:00:00.000000000 Z
+date: 2020-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -400,8 +400,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Rails bindings for Unpoly, the unobtrusive JavaScript framework