unpoly-rails 0.60.3 → 1.0.0

data/spec_app/spec/javascripts/up/form_spec.js.coffee

@@ -6,6 +6,47 @@ describe 'up.form', ->
 
   describe 'JavaScript functions', ->
 
+    describe 'up.form.fields', ->
+
+      it 'returns a list of form fields within the given element', ->
+        form = fixture('form')
+        textField = e.affix(form, 'input[type=text]')
+        select = e.affix(form, 'select')
+        results = up.form.fields(form)
+        expect(results).toMatchList([textField, select])
+
+      it 'returns an empty list if the given element contains no form fields', ->
+        form = fixture('form')
+        results = up.form.fields(form)
+        expect(results).toMatchList([])
+
+      it 'returns a list of the given element if the element is itself a form field', ->
+        textArea = fixture('textarea')
+        results = up.form.fields(textArea)
+        expect(results).toMatchList([textArea])
+
+      it 'ignores fields outside the given form', ->
+        form1 = fixture('form')
+        form1Field = e.affix(form1, 'input[type=text]')
+        form2 = fixture('form')
+        form2Field = e.affix(form2, 'input[type=text]')
+        results = up.form.fields(form1)
+        expect(results).toMatchList([form1Field])
+
+      it "includes fields outside the form with a [form] attribute matching the given form's ID", ->
+        form = fixture('form#form-id')
+        insideField = e.affix(form, 'input[type=text]')
+        outsideField = fixture('input[type=text][form=form-id]')
+        results = up.form.fields(form)
+        expect(results).toMatchList([insideField, outsideField])
+
+      it "does not return duplicate fields if a field with a matching [form] attribute is also a child of the form", ->
+        form = fixture('form#form-id')
+        field = e.affix(form, 'input[type=text][form=form-id]')
+        results = up.form.fields(form)
+        expect(results).toMatchList([field])
+
+
     describe 'up.observe', ->
 
       beforeEach ->
@@ -858,6 +899,23 @@ describe 'up.form', ->
         Trigger.change($field)
         next => expect(submitSpy).toHaveBeenCalled()
 
+      it 'submits the form when a change is observed on a container for a radio button group', asyncSpec (next) ->
+        form = fixture('form')
+        group = e.affix(form, '.group[up-autosubmit][up-delay=0]')
+        radio1 = e.affix(group, 'input[type=radio][name=foo][value=1]')
+        radio2 = e.affix(group, 'input[type=radio][name=foo][value=2]')
+        up.hello(form)
+        submitSpy = up.form.knife.mock('submit').and.returnValue(Promise.reject())
+        Trigger.clickSequence(radio1)
+        next =>
+          expect(submitSpy.calls.count()).toBe(1)
+          Trigger.clickSequence(radio2)
+        next =>
+          expect(submitSpy.calls.count()).toBe(2)
+          Trigger.clickSequence(radio1)
+        next =>
+          expect(submitSpy.calls.count()).toBe(3)
+
     describe 'form[up-autosubmit]', ->
 
       it 'submits the form when a change is observed in any of its fields', asyncSpec (next) ->
@@ -1023,6 +1081,7 @@ describe 'up.form', ->
 
             </form>
           """
+          up.hello(container)
 
           Trigger.change $('#registration input[name=password]')
 
@@ -1048,6 +1107,75 @@ describe 'up.form', ->
             expect($labels[0]).not.toHaveText('Validation message')
             expect($labels[1]).toHaveText('Validation message')
 
+    describe 'form[up-validate]', ->
+
+      # it 'prints an error saying that this form is not yet supported', ->
+
+      it 'performs server-side validation for all fieldsets contained within the form', asyncSpec (next) ->
+        container = fixture('.container')
+        container.innerHTML = """
+          <form action="/users" id="registration" up-validate>
+
+            <div up-fieldset>
+              <input type="text" name="email">
+            </div>
+
+            <div up-fieldset>
+              <input type="password" name="password">
+            </div>
+
+          </form>
+        """
+        up.hello(container)
+
+        Trigger.change $('#registration input[name=password]')
+
+        next =>
+          expect(jasmine.Ajax.requests.count()).toEqual(1)
+          expect(@lastRequest().requestHeaders['X-Up-Validate']).toEqual('password')
+          expect(@lastRequest().requestHeaders['X-Up-Target']).toEqual('[up-fieldset]:has(input[name="password"])')
+
+
+          @respondWith """
+            <form action="/users" id="registration" up-validate>
+
+              <div up-fieldset>
+                Validation message
+                <input type="text" name="email">
+              </div>
+
+              <div up-fieldset>
+                Validation message
+                <input type="password" name="password">
+              </div>
+
+            </form>
+          """
+
+        next =>
+          $labels = $('#registration [up-fieldset]')
+          expect($labels[0]).not.toHaveText('Validation message')
+          expect($labels[1]).toHaveText('Validation message')
+
+      it 'only sends a single request when a radio button group changes', asyncSpec (next) ->
+        container = fixture('.container')
+        container.innerHTML = """
+          <form action="/users" id="registration" up-validate>
+
+            <div up-fieldset>
+              <input type="radio" name="foo" value="1" checked>
+              <input type="radio" name="foo" value="2">
+            </div>
+
+          </form>
+        """
+        up.hello(container)
+
+        Trigger.change $('#registration input[value="2"]')
+
+        next =>
+          expect(jasmine.Ajax.requests.count()).toEqual(1)
+
     describe '[up-switch]', ->
 
       describe 'on a select', ->

data/spec_app/spec/javascripts/up/fragment_spec.js.coffee

@@ -2432,13 +2432,26 @@ describe 'up.fragment', ->
           expect($element).toBeDetached()
 
       it 'calls destructors for custom elements', (done) ->
-        up.$compiler('.element', ($element) -> destructor)
         destructor = jasmine.createSpy('destructor')
+        up.$compiler('.element', ($element) -> destructor)
         up.hello(fixture('.element'))
         up.destroy('.element').then ->
           expect(destructor).toHaveBeenCalled()
           done()
 
+      it 'does not call destructors twice if up.destroy() is called twice on the same fragment', asyncSpec (next) ->
+        destructor = jasmine.createSpy('destructor')
+        up.compiler('.element', (element) -> destructor)
+
+        element = fixture('.element')
+        up.hello(element)
+
+        up.destroy(element, animation: 'fade-out', duration: 10)
+        up.destroy(element, animation: 'fade-out', duration: 10)
+
+        next.after 60, ->
+          expect(destructor.calls.count()).toBe(1)
+
       it 'marks the old element as .up-destroying before destructors', (done) ->
         destructor = jasmine.createSpy('destructor')
         up.$compiler '.container', ($element) ->
@@ -2452,6 +2465,19 @@ describe 'up.fragment', ->
           expect(destructor).toHaveBeenCalledWith('old text', true)
           done()
 
+      it 'marks the old element as [aria-hidden=true] before destructors', (done) ->
+        destructor = jasmine.createSpy('destructor')
+        up.$compiler '.container', ($element) ->
+          -> destructor($element.text(), $element.is('[aria-hidden=true]'))
+        $container = $fixture('.container').text('old text')
+        up.hello($container)
+
+        destroyDone = up.destroy('.container')
+
+        destroyDone.then ->
+          expect(destructor).toHaveBeenCalledWith('old text', true)
+          done()
+
       it 'marks the old element as .up-destroying before destructors after an { animation }', (done) ->
         destructor = jasmine.createSpy('destructor')
         up.$compiler '.container', ($element) ->
@@ -2533,6 +2559,15 @@ describe 'up.fragment', ->
           )
           expect($element).toBeDetached()
 
+      it 'removes element-related data from the global jQuery cache (bugfix)', asyncSpec (next) ->
+        $element = $fixture('.element')
+        $element.data('foo', { foo: '1' })
+        expect($element.data('foo')).toEqual({ foo: '1'})
+        up.destroy($element)
+
+        next ->
+          expect($element.data('foo')).toBeMissing()
+
     describe 'up.reload', ->
 
       describeCapability 'canPushState', ->

data/spec_app/spec/javascripts/up/link_spec.js.coffee

@@ -928,9 +928,14 @@ describe 'up.link', ->
           Trigger.mouseup(@$link)
           next => expect(@followSpy).not.toHaveBeenCalled()
 
-        it 'does nothing on click', asyncSpec (next)->
+        it 'does nothing on click if there was an earlier mousedown event', asyncSpec (next)->
+          Trigger.mousedown(@$link)
           Trigger.click(@$link)
-          next => expect(@followSpy).not.toHaveBeenCalled()
+          next => expect(@followSpy.calls.count()).toBe(1)
+
+        it 'does follow a link on click if there was never a mousedown event (e.g. if the user pressed enter)', asyncSpec (next) ->
+          Trigger.click(@$link)
+          next => expect(@followSpy.calls.mostRecent().args[0]).toEqual(@$link[0])
 
         # IE does not call JavaScript and always performs the default action on right clicks
         unless AgentDetector.isIE() || AgentDetector.isEdge()

data/spec_app/spec/javascripts/up/modal_spec.js.coffee

@@ -532,8 +532,9 @@ describe 'up.modal', ->
           next => expect(@followSpy).not.toHaveBeenCalled()
 
         it 'does nothing on click', asyncSpec (next) ->
+          Trigger.mousedown(@$link)
           Trigger.click(@$link)
-          next => expect(@followSpy).not.toHaveBeenCalled()
+          next => expect(@followSpy.calls.count()).toBe(1)
 
         # IE does not call JavaScript and always performs the default action on right clicks
         unless AgentDetector.isIE() || AgentDetector.isEdge()
@@ -562,6 +563,27 @@ describe 'up.modal', ->
           next =>
             expect(@lastRequest().method).toEqual 'POST'
 
+      describe 'with [up-cache] modifier', ->
+        it 'honours the given setting', asyncSpec (next) ->
+          $link = $fixture('a[href="/path"][up-modal=".target"][up-cache="false"]')
+          Trigger.clickSequence($link)
+
+          next =>
+            @respondWith('<div class="target">modal content 1</div>')
+
+          next =>
+            expect('.up-modal .target').toHaveText('modal content 1')
+            history.back()
+
+          next =>
+            Trigger.clickSequence($link)
+
+          next =>
+            @respondWith('<div class="target">modal content 2</div>')
+
+          next =>
+            expect('.up-modal .target').toHaveText('modal content 2')
+
       it 'adds a history entry and allows the user to use the back button', asyncSpec (next) ->
         up.motion.config.enabled = false
         up.history.config.enabled = true

data/spec_app/spec/javascripts/up/popup_spec.js.coffee

@@ -232,8 +232,9 @@ describe 'up.popup', ->
           next => expect(@attachSpy).not.toHaveBeenCalled()
 
         it 'does nothing on click', asyncSpec (next) ->
+          Trigger.mousedown(@$link)
           Trigger.click(@$link)
-          next => expect(@attachSpy).not.toHaveBeenCalled()
+          next => expect(@attachSpy.calls.count()).toBe(1)
 
         # IE does not call JavaScript and always performs the default action on right clicks
         unless AgentDetector.isIE() || AgentDetector.isEdge()

data/spec_app/spec/javascripts/up/util_spec.js.coffee

@@ -1404,3 +1404,31 @@ describe 'up.util', ->
       it 'returns false for NaN', ->
         value = NaN
         expect(up.util.isList(value)).toBe(false)
+
+    describe 'up.util.isJQuery', ->
+
+      it 'returns true for a jQuery collection', ->
+        value = $('body')
+        expect(up.util.isJQuery(value)).toBe(true)
+
+      it 'returns false for a native element', ->
+        value = document.body
+        expect(up.util.isJQuery(value)).toBe(false)
+
+      it 'returns false (and does not crash) for undefined', ->
+        value = undefined
+        expect(up.util.isJQuery(value)).toBe(false)
+
+    describe 'up.util.escapeHtml', ->
+
+      it 'escapes double quotes', ->
+        result = up.util.escapeHtml('before"after')
+        expect(result).toEqual('before"after')
+
+      it 'escapes single quotes', ->
+        result = up.util.escapeHtml("before'after")
+        expect(result).toEqual('before'after')
+
+      it 'escapes angle brackets', ->
+        result = up.util.escapeHtml('before<script>after')
+        expect(result).toEqual('before&lt;script&gt;after')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unpoly-rails
 version: !ruby/object:Gem::Version
-  version: 0.60.3
+  version: 1.0.0
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-03 00:00:00.000000000 Z
+date: 2021-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -232,6 +232,7 @@ files:
 - spec_app/app/views/replace_test/_nav.erb
 - spec_app/app/views/replace_test/page1.erb
 - spec_app/app/views/replace_test/page2.erb
+- spec_app/app/views/replace_test/table.erb
 - spec_app/app/views/reveal_test/long1.erb
 - spec_app/app/views/reveal_test/long2.erb
 - spec_app/app/views/reveal_test/within_document_viewport.erb
@@ -399,8 +400,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.2.16
 signing_key: 
 specification_version: 4
 summary: Rails bindings for Unpoly, the unobtrusive JavaScript framework