unpoly-rails 0.60.2 → 0.62.1

data/spec_app/spec/javascripts/up/fragment_spec.js.coffee

@@ -2432,13 +2432,26 @@ describe 'up.fragment', ->
           expect($element).toBeDetached()
 
       it 'calls destructors for custom elements', (done) ->
-        up.$compiler('.element', ($element) -> destructor)
         destructor = jasmine.createSpy('destructor')
+        up.$compiler('.element', ($element) -> destructor)
         up.hello(fixture('.element'))
         up.destroy('.element').then ->
           expect(destructor).toHaveBeenCalled()
           done()
 
+      it 'does not call destructors twice if up.destroy() is called twice on the same fragment', asyncSpec (next) ->
+        destructor = jasmine.createSpy('destructor')
+        up.compiler('.element', (element) -> destructor)
+
+        element = fixture('.element')
+        up.hello(element)
+
+        up.destroy(element, animation: 'fade-out', duration: 10)
+        up.destroy(element, animation: 'fade-out', duration: 10)
+
+        next.after 60, ->
+          expect(destructor.calls.count()).toBe(1)
+
       it 'marks the old element as .up-destroying before destructors', (done) ->
         destructor = jasmine.createSpy('destructor')
         up.$compiler '.container', ($element) ->
@@ -2452,6 +2465,19 @@ describe 'up.fragment', ->
           expect(destructor).toHaveBeenCalledWith('old text', true)
           done()
 
+      it 'marks the old element as [aria-hidden=true] before destructors', (done) ->
+        destructor = jasmine.createSpy('destructor')
+        up.$compiler '.container', ($element) ->
+          -> destructor($element.text(), $element.is('[aria-hidden=true]'))
+        $container = $fixture('.container').text('old text')
+        up.hello($container)
+
+        destroyDone = up.destroy('.container')
+
+        destroyDone.then ->
+          expect(destructor).toHaveBeenCalledWith('old text', true)
+          done()
+
       it 'marks the old element as .up-destroying before destructors after an { animation }', (done) ->
         destructor = jasmine.createSpy('destructor')
         up.$compiler '.container', ($element) ->
@@ -2533,6 +2559,15 @@ describe 'up.fragment', ->
           )
           expect($element).toBeDetached()
 
+      it 'removes element-related data from the global jQuery cache (bugfix)', asyncSpec (next) ->
+        $element = $fixture('.element')
+        $element.data('foo', { foo: '1' })
+        expect($element.data('foo')).toEqual({ foo: '1'})
+        up.destroy($element)
+
+        next ->
+          expect($element.data('foo')).toBeMissing()
+
     describe 'up.reload', ->
 
       describeCapability 'canPushState', ->

data/spec_app/spec/javascripts/up/link_spec.js.coffee

@@ -928,9 +928,14 @@ describe 'up.link', ->
           Trigger.mouseup(@$link)
           next => expect(@followSpy).not.toHaveBeenCalled()
 
-        it 'does nothing on click', asyncSpec (next)->
+        it 'does nothing on click if there was an earlier mousedown event', asyncSpec (next)->
+          Trigger.mousedown(@$link)
           Trigger.click(@$link)
-          next => expect(@followSpy).not.toHaveBeenCalled()
+          next => expect(@followSpy.calls.count()).toBe(1)
+
+        it 'does follow a link on click if there was never a mousedown event (e.g. if the user pressed enter)', asyncSpec (next) ->
+          Trigger.click(@$link)
+          next => expect(@followSpy.calls.mostRecent().args[0]).toEqual(@$link[0])
 
         # IE does not call JavaScript and always performs the default action on right clicks
         unless AgentDetector.isIE() || AgentDetector.isEdge()

data/spec_app/spec/javascripts/up/modal_spec.js.coffee

@@ -532,8 +532,9 @@ describe 'up.modal', ->
           next => expect(@followSpy).not.toHaveBeenCalled()
 
         it 'does nothing on click', asyncSpec (next) ->
+          Trigger.mousedown(@$link)
           Trigger.click(@$link)
-          next => expect(@followSpy).not.toHaveBeenCalled()
+          next => expect(@followSpy.calls.count()).toBe(1)
 
         # IE does not call JavaScript and always performs the default action on right clicks
         unless AgentDetector.isIE() || AgentDetector.isEdge()
@@ -562,6 +563,27 @@ describe 'up.modal', ->
           next =>
             expect(@lastRequest().method).toEqual 'POST'
 
+      describe 'with [up-cache] modifier', ->
+        it 'honours the given setting', asyncSpec (next) ->
+          $link = $fixture('a[href="/path"][up-modal=".target"][up-cache="false"]')
+          Trigger.clickSequence($link)
+
+          next =>
+            @respondWith('<div class="target">modal content 1</div>')
+
+          next =>
+            expect('.up-modal .target').toHaveText('modal content 1')
+            history.back()
+
+          next =>
+            Trigger.clickSequence($link)
+
+          next =>
+            @respondWith('<div class="target">modal content 2</div>')
+
+          next =>
+            expect('.up-modal .target').toHaveText('modal content 2')
+
       it 'adds a history entry and allows the user to use the back button', asyncSpec (next) ->
         up.motion.config.enabled = false
         up.history.config.enabled = true

data/spec_app/spec/javascripts/up/popup_spec.js.coffee

@@ -232,8 +232,9 @@ describe 'up.popup', ->
           next => expect(@attachSpy).not.toHaveBeenCalled()
 
         it 'does nothing on click', asyncSpec (next) ->
+          Trigger.mousedown(@$link)
           Trigger.click(@$link)
-          next => expect(@attachSpy).not.toHaveBeenCalled()
+          next => expect(@attachSpy.calls.count()).toBe(1)
 
         # IE does not call JavaScript and always performs the default action on right clicks
         unless AgentDetector.isIE() || AgentDetector.isEdge()

data/spec_app/spec/javascripts/up/util_spec.js.coffee

@@ -1404,3 +1404,17 @@ describe 'up.util', ->
       it 'returns false for NaN', ->
         value = NaN
         expect(up.util.isList(value)).toBe(false)
+
+    describe 'up.util.isJQuery', ->
+
+      it 'returns true for a jQuery collection', ->
+        value = $('body')
+        expect(up.util.isJQuery(value)).toBe(true)
+
+      it 'returns false for a native element', ->
+        value = document.body
+        expect(up.util.isJQuery(value)).toBe(false)
+
+      it 'returns false (and does not crash) for undefined', ->
+        value = undefined
+        expect(up.util.isJQuery(value)).toBe(false)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unpoly-rails
 version: !ruby/object:Gem::Version
-  version: 0.60.2
+  version: 0.62.1
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-03 00:00:00.000000000 Z
+date: 2020-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -232,6 +232,7 @@ files:
 - spec_app/app/views/replace_test/_nav.erb
 - spec_app/app/views/replace_test/page1.erb
 - spec_app/app/views/replace_test/page2.erb
+- spec_app/app/views/replace_test/table.erb
 - spec_app/app/views/reveal_test/long1.erb
 - spec_app/app/views/reveal_test/long2.erb
 - spec_app/app/views/reveal_test/within_document_viewport.erb
@@ -399,8 +400,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: Rails bindings for Unpoly, the unobtrusive JavaScript framework