unpoly-rails 0.60.0 → 0.60.1

data/lib/assets/javascripts/unpoly/motion.coffee.erb

@@ -372,7 +372,7 @@ up.motion = do ->
 
     scrollNew = ->
       # Don't animate the scrolling.
-      scrollOptions = u.merge(options, behavior: 'instant')
+      scrollOptions = u.merge(options, scrollBehavior: 'auto')
       # Scroll newElement into position before we start the enter animation.
       up.viewport.scrollAfterInsertFragment(newElement, scrollOptions)
 

data/lib/assets/javascripts/unpoly/protocol.coffee

@@ -154,7 +154,7 @@ This fixes two edge cases you might or might not care about:
 2. Some browsers have a bug where the initial request method is used for all
    subsequently pushed states. That means if the user reloads the page on a later
    GET state, the browser will wrongly attempt a POST request.
-   This issue affects Safari 9 and 10 (last tested in 2017-08).
+   This issue affects Safari 9-12 (last tested in 2019-03).
    Modern Firefoxes, Chromes and IE10+ don't have this behavior.
 
 In order to allow Unpoly to detect the HTTP method of the initial page load,

data/lib/assets/javascripts/unpoly/proxy.coffee

@@ -158,7 +158,7 @@ up.proxy = do ->
 
   \#\#\# Example
 
-      up.request('/search', params: { query: 'sunshine' }).then(function(response) {
+      up.request('/search', { params: { query: 'sunshine' } }).then(function(response) {
         console.log('The response text is %o', response.text)
       }).catch(function() {
         console.error('The request failed')
@@ -266,7 +266,7 @@ up.proxy = do ->
 
   \#\#\# Example
 
-      up.request('/search', params: { query: 'sunshine' }).then(function(text) {
+      up.request('/search', { params: { query: 'sunshine' } }).then(function(text) {
         console.log('The response text is %o', text)
       }).catch(function() {
         console.error('The request failed')

data/lib/assets/javascripts/unpoly/syntax.coffee.erb

@@ -82,7 +82,7 @@ up.syntax = do ->
   \#\#\# Cleaning up after yourself
 
   If your compiler returns a function, Unpoly will use this as a *destructor* to
-  clean up if the element leaves the DOM. Note that in Unpoly the same DOM ad JavaScript environment
+  clean up if the element leaves the DOM. Note that in Unpoly the same DOM and JavaScript environment
   will persist through many page loads, so it's important to not create
   [memory leaks](https://makandracards.com/makandra/31325-how-to-create-memory-leaks-in-jquery).
 
@@ -126,7 +126,7 @@ up.syntax = do ->
         { "lat": 48.75, "lng": 11.45, "title": "Ingolstadt" }
       ]'></div>
 
-  The JSON will parsed and handed to your compiler as a second argument:
+  The JSON will be parsed and handed to your compiler as a second argument:
 
       up.compiler('.google-map', function(element, pins) {
         var map = new google.maps.Map(element)
@@ -416,7 +416,7 @@ up.syntax = do ->
         { "lat": 48.75, "lng": 11.45, "title": "Ingolstadt" }
       ]'></div>
 
-  The JSON will parsed and handed to your compiler as a second argument:
+  The JSON will be parsed and handed to your compiler as a second argument:
 
       up.compiler('.google-map', function(element, pins) {
         var map = new google.maps.Map(element)

data/lib/assets/javascripts/unpoly/viewport.coffee.erb

@@ -18,7 +18,7 @@ layout, such as navigation bars or headers. Unpoly will respect these sticky
 elements when [revealing updated fragments](/up.reveal).
 
 You should also [tell Unpoly](/up.viewport.config#config.viewports) when your application has more than one viewport,
-you should so Unpoly can pick the right viewport to scroll for each fragment update.
+so Unpoly can pick the right viewport to scroll for each fragment update.
 
 
 \#\#\# Bootstrap integration

data/lib/unpoly/rails/version.rb

@@ -4,6 +4,6 @@ module Unpoly
     # The current version of the unpoly-rails gem.
     # This version number is also used for releases of the Unpoly
     # frontend code.
-    VERSION = '0.60.0'
+    VERSION = '0.60.1'
   end
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "unpoly",
-  "version": "0.60.0",
+  "version": "0.60.1",
   "description": "Unobtrusive JavaScript framework",
   "main": "dist/unpoly.js",
   "files": [

data/spec_app/app/controllers/compiler_test_controller.rb

@@ -0,0 +1,5 @@
+class CompilerTestController < ApplicationController
+
+  layout 'integration_test'
+
+end

data/spec_app/app/views/compiler_test/timestamp.erb

@@ -0,0 +1,9 @@
+<script>
+  up.compiler('.timestamp', (element) => {
+    var now = new Date()
+    element.innerText = now
+  })
+</script>
+
+<div class="timestamp">
+  Uncompiled

data/spec_app/app/views/pages/start.erb

@@ -72,6 +72,7 @@
     <li><%= link_to 'Scrolling behavior', '/scroll_test/long1' %></li>
     <li><%= link_to 'Animations', '/motion_test/animations' %></li>
     <li><%= link_to 'Transitions', '/motion_test/transitions' %></li>
+    <li><%= link_to 'Compilers', '/compiler_test/timestamp' %></li>
   </ul>
 
 </div>

data/spec_app/config/routes.rb

@@ -15,6 +15,7 @@ Rails.application.routes.draw do
   get 'reveal_test/:action', controller: 'reveal_test'
   get 'scroll_test/:action', controller: 'scroll_test'
   get 'motion_test/:action', controller: 'motion_test'
+  get 'compiler_test/:action', controller: 'compiler_test'
 
   namespace :form_test do
     resource :basic, only: [:new, :create]

data/spec_app/spec/javascripts/up/feedback_spec.js.coffee

@@ -347,6 +347,15 @@ describe 'up.feedback', ->
           next =>
             expect($area).not.toHaveClass('up-active')
 
+        it 'removes .up-active when a link with [up-confirm] was not confirmed', asyncSpec (next) ->
+          $link = $fixture('a[href="/foo"][up-modal=".main"][up-confirm="Really follow?"]')
+          spyOn(up.browser, 'whenConfirmed').and.returnValue(Promise.reject('User aborted'))
+
+          Trigger.clickSequence($link)
+
+          next =>
+            expect($link).not.toHaveClass('up-active')
+
         it 'marks clicked modal openers as .up-active while the modal is loading', asyncSpec (next) ->
           $link = $fixture('a[href="/foo"][up-modal=".main"]')
           fixture('.main')

data/spec_app/spec/javascripts/up/fragment_spec.js.coffee

@@ -1965,6 +1965,30 @@ describe 'up.fragment', ->
             next =>
               expect(swapDirectlySpy).toHaveBeenCalled()
 
+      describe 'with { scrollBehavior } option', ->
+
+        beforeEach ->
+          up.viewport.knife.mock('reveal').and.callFake (element, options) =>
+            @revealScrollBehavior = options.behavior ? options.scrollBehavior
+
+        it 'animates the revealing when prepending an element', asyncSpec (next) ->
+          fixture('.element', text: 'version 1')
+          up.extract('.element:before', '<div class="element">version 2</div>', reveal: true, scrollBehavior: 'smooth')
+          next =>
+            expect(@revealScrollBehavior).toEqual('smooth')
+
+        it 'animates the revealing when appending an element', asyncSpec (next) ->
+          fixture('.element', text: 'version 1')
+          up.extract('.element:after', '<div class="element">version 2</div>', reveal: true, scrollBehavior: 'smooth')
+          next =>
+            expect(@revealScrollBehavior).toEqual('smooth')
+
+        it 'does not animate the revealing when swapping out an element', asyncSpec (next) ->
+          fixture('.element', text: 'version 1')
+          up.extract('.element', '<div class="element">version 2</div>', reveal: true, scrollBehavior: 'smooth')
+          next =>
+            expect(@revealScrollBehavior).toEqual('auto')
+
       describe 'handling of [up-keep] elements', ->
 
         squish = (string) ->

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unpoly-rails
 version: !ruby/object:Gem::Version
-  version: 0.60.0
+  version: 0.60.1
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-24 00:00:00.000000000 Z
+date: 2019-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -84,7 +84,6 @@ files:
 - design/positioning.txt
 - design/rename.txt
 - design/test_rejected_promise.txt
-- design/todo_jquery.txt
 - design/unpoly errors.txt
 - dist/unpoly-bootstrap3.css
 - dist/unpoly-bootstrap3.js
@@ -189,6 +188,7 @@ files:
 - spec_app/app/assets/stylesheets/jasmine_specs.sass
 - spec_app/app/controllers/application_controller.rb
 - spec_app/app/controllers/binding_test_controller.rb
+- spec_app/app/controllers/compiler_test_controller.rb
 - spec_app/app/controllers/css_test_controller.rb
 - spec_app/app/controllers/error_test_controller.rb
 - spec_app/app/controllers/form_test/basics_controller.rb
@@ -204,6 +204,7 @@ files:
 - spec_app/app/helpers/application_helper.rb
 - spec_app/app/mailers/.keep
 - spec_app/app/models/concerns/.keep
+- spec_app/app/views/compiler_test/timestamp.erb
 - spec_app/app/views/css_test/modal.erb
 - spec_app/app/views/css_test/modal_contents.erb
 - spec_app/app/views/css_test/modal_contents_wide.erb

data/design/todo_jquery.txt

@@ -1,13 +0,0 @@
-- PUBLISH
-
-- deploy cards with new version
-
-- deploy unpoly-guide
-
-- upgrade roca-style.org PR
-  - better claim
-  - no jquery
-
-- Update card with https://unpoly.com/up.util.parseUrl
-  - https://makandracards.com/makandra/29377-the-easiest-way-to-parse-urls-with-javascript
-