unpoly-rails 0.53.1 → 0.53.2

data/lib/unpoly/rails/version.rb

@@ -4,6 +4,6 @@ module Unpoly
     # The current version of the unpoly-rails gem.
     # This version number is also used for releases of the Unpoly
     # frontend code.
-    VERSION = '0.53.1'
+    VERSION = '0.53.2'
   end
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "unpoly",
-  "version": "0.53.1",
+  "version": "0.53.2",
   "description": "Unobtrusive JavaScript framework",
   "main": "dist/unpoly.js",
   "files": [

data/spec_app/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    unpoly-rails (0.53.0)
+    unpoly-rails (0.53.1)
       rails (>= 3)
 
 GEM

data/spec_app/app/controllers/form_test/basics_controller.rb

@@ -7,7 +7,7 @@ module FormTest
     end
 
     def create
-      render 'form_test/submission_result'
+      render 'form_test/submission_result', status: 500
     end
 
   end

data/spec_app/app/views/reveal_test/long1.erb

@@ -1,8 +1,13 @@
+<script>
+  up.motion.config.duration = 2000
+  up.layout.config.duration = 2000
+</script>
+
 <div class="long-page" style="height: 2000px; background-color: rgba(0, 0, 255, 0.3)">
 
   <h2>Long page 1</h2>
 
-  <ul>
+  <ul style="margin-top: 200px">
     <li><a up-target=".long-page" href="long2" up-reveal="true"  up-transition="false"     >Go to long page 2 (with reveal,    without animation)</a></li>
     <li><a up-target=".long-page" href="long2" up-reveal="true"  up-transition="cross-fade">Go to long page 2 (with reveal,    with animation)   </a></li>
     <li><a up-target=".long-page" href="long2" up-reveal="false" up-transition="false"     >Go to long page 2 (without reveal, without animation)</a></li>

data/spec_app/app/views/reveal_test/long2.erb

@@ -1,8 +1,13 @@
+<script>
+  up.motion.config.duration = 2000
+  up.layout.config.duration = 2000
+</script>
+
 <div class="long-page" style="height: 2000px; background-color: rgba(255, 0, 0, 0.3)">
 
   <h2>Long page 2</h2>
 
-  <ul>
+  <ul style="margin-top: 200px">
     <li><a up-target=".long-page" href="long1" up-reveal="true"  up-transition="false"     >Go to long page 1 (with reveal,    without animation)</a></li>
     <li><a up-target=".long-page" href="long1" up-reveal="true"  up-transition="cross-fade">Go to long page 1 (with reveal,    with animation)   </a></li>
     <li><a up-target=".long-page" href="long1" up-reveal="false" up-transition="false"     >Go to long page 1 (without reveal, without animation)</a></li>

data/spec_app/spec/javascripts/helpers/to_have_unhandled_rejections.coffee

@@ -0,0 +1,36 @@
+UNHANDLED_REJECTIONS = []
+
+beforeAll ->
+  window.addEventListener 'unhandledrejection', (event) ->
+    UNHANDLED_REJECTIONS.push(event)
+
+beforeEach ->
+  UNHANDLED_REJECTIONS = []
+
+  jasmine.addMatchers
+    toHaveUnhandledRejections: (util, customEqualityTesters) ->
+      compare: (actual) ->
+        # It doesn't really matter what's in actual.
+        # A good way to call this is e.g. `expect(window).not.toHaveUnhandledRejections()
+        pass: UNHANDLED_REJECTIONS.length > 0
+
+#UnhandledRejectionTracker = do ->
+#
+#
+#
+#
+#
+##beforeEach (done) ->
+##  @unhandledRejections = []
+##  @trackUnhandledRejections = (event) =>
+##    @unhandledRejections.push(event)
+##  window.addEventListener('unhandledrejection', @trackUnhandledRejections)
+##  done()
+##
+##afterEach (done) ->
+##  hadUnhandledRejections = @unhandledRejections.length > 0
+##  @unhandledRejections = []
+##  if hadUnhandledRejections
+##    done.fail('There were rejected promises without a rejection handler')
+##  else
+##    done()

data/spec_app/spec/javascripts/helpers/trigger.js.coffee

@@ -7,11 +7,26 @@
     event = createMouseEvent('mouseover', options)
     dispatch($element, event)
 
+  mouseenter = (element, options) ->
+    $element = $(element)
+    event = createMouseEvent('mouseenter', options)
+    dispatch($element, event)
+
   mousedown = (element, options) ->
     $element = $(element)
     event = createMouseEvent('mousedown', options)
     dispatch($element, event)
 
+  mouseout = (element, options) ->
+    $element = $(element)
+    event = createMouseEvent('mouseout', options)
+    dispatch($element, event)
+
+  mouseleave = (element, options) ->
+    $element = $(element)
+    event = createMouseEvent('mouseleave', options)
+    dispatch($element, event)
+
   mouseup = (element, options) ->
     $element = $(element)
     event = createMouseEvent('mouseup', options)
@@ -34,6 +49,16 @@
     mouseup($element, options)
     click($element, options)
 
+  hoverSequence = (element, options) ->
+    $element = $(element)
+    mouseover($element, options)
+    mouseenter($element, options)
+
+  unhoverSequence = (element, options) ->
+    $element = $(element)
+    mouseout($element, options)
+    mouseleave($element, options)
+
   # Can't use the new MouseEvent constructor in IE11 because computer.
   # http://www.codeproject.com/Tips/893254/JavaScript-Triggering-Event-Manually-in-Internet-E
   createMouseEvent = (type, options) ->
@@ -77,10 +102,15 @@
       this.dispatchEvent(event)
 
   mouseover: mouseover
+  mouseenter: mouseenter
   mousedown: mousedown
   mouseup: mouseup
+  mouseout: mouseout
+  mouseleave: mouseleave
   click: click
   clickSequence: clickSequence
+  hoverSequence: hoverSequence
+  unhoverSequence: unhoverSequence
   createMouseEvent: createMouseEvent
   
 )()

data/spec_app/spec/javascripts/up/dom_spec.js.coffee

@@ -940,7 +940,7 @@ describe 'up.dom', ->
 
               next =>
                 expect(@revealedHTML).toEqual ['<div id="three">three</div>']
-                expect(@revealOptions).toEqual { top: true }
+                expect(@revealOptions).toEqual jasmine.objectContaining(top: true)
 
             it "reveals the entire element if it has no child with the ID of that #hash", asyncSpec (next) ->
               up.replace('.middle', '/path#four', reveal: true)

data/spec_app/spec/javascripts/up/form_spec.js.coffee

@@ -355,6 +355,8 @@ describe 'up.form', ->
             expect('.before').not.toHaveText('old-before')
             expect('.after').not.toHaveText('old-after')
 
+            expect(window).toHaveUnhandledRejections()
+
         it 'respects X-Up-Method and X-Up-Location response headers so the server can show that it redirected to a GET URL', asyncSpec (next) ->
           up.submit(@$form)
 
@@ -529,7 +531,70 @@ describe 'up.form', ->
 
     describe 'form[up-target]', ->
 
-      it 'rigs the form to use up.submit instead of a standard submit'
+      it 'submits the form with AJAX and replaces the [up-target] selector', asyncSpec (next) ->
+        up.history.config.enabled = true
+
+        affix('.response').text('old text')
+
+        $form = affix('form[action="/form-target"][method="put"][up-target=".response"]')
+        $form.append('<input name="field1" value="value1">')
+        $form.append('<input name="field2" value="value2">')
+        $submitButton = $form.affix('input[type="submit"][name="submit-button"][value="submit-button-value"]')
+        up.hello($form)
+
+        Trigger.clickSequence($submitButton)
+
+        next =>
+          params = @lastRequest().data()
+          expect(params['field1']).toEqual(['value1'])
+          expect(params['field2']).toEqual(['value2'])
+
+        next =>
+          @respondWith """
+            <div class="response">
+              new text
+            </div>
+          """
+
+        next =>
+          expect('.response').toHaveText('new text')
+
+      describe 'when the server responds with an error code', ->
+
+        it 'replaces the form instead of the [up-target] selector', asyncSpec (next) ->
+          up.history.config.enabled = true
+
+          affix('.response').text('old text')
+
+          $form = affix('form.test-form[action="/form-target"][method="put"][up-target=".response"]')
+          $form.append('<input name="field1" value="value1">')
+          $form.append('<input name="field2" value="value2">')
+          $submitButton = $form.affix('input[type="submit"][name="submit-button"][value="submit-button-value"]')
+          up.hello($form)
+
+          Trigger.clickSequence($submitButton)
+
+          next =>
+            params = @lastRequest().data()
+            expect(params['field1']).toEqual(['value1'])
+            expect(params['field2']).toEqual(['value2'])
+
+          next =>
+            @respondWith
+              status: 500
+              responseText: """
+                <form class="test-form">
+                  validation errors
+                </form>
+              """
+
+          next =>
+            expect('.response').toHaveText('old text')
+            expect('form.test-form').toHaveText('validation errors')
+
+            # Since there isn't anyone who could handle the rejection inside
+            # the event handler, our handler mutes the rejection.
+            expect(window).not.toHaveUnhandledRejections()
 
       describe 'submit buttons', ->
 
@@ -711,12 +776,14 @@ describe 'up.form', ->
             expect(request.requestHeaders['X-Up-Validate']).toEqual('user')
             expect(request.requestHeaders['X-Up-Target']).toEqual('.field-group:has(input[name="user"])')
 
-            @respondWith """
-              <div class="field-group has-error">
-                <div class='error'>Username has already been taken</div>
-                <input name="user" value="judy" up-validate=".field-group:has(&)">
-              </div>
-            """
+            @respondWith
+              status: 500
+              responseText: """
+                <div class="field-group has-error">
+                  <div class='error'>Username has already been taken</div>
+                  <input name="user" value="judy" up-validate=".field-group:has(&)">
+                </div>
+              """
 
           next =>
             $group = $('.field-group')
@@ -724,6 +791,10 @@ describe 'up.form', ->
             expect($group).toHaveClass('has-error')
             expect($group).toHaveText('Username has already been taken')
 
+            # Since there isn't anyone who could handle the rejection inside
+            # the event handler, our handler mutes the rejection.
+            expect(window).not.toHaveUnhandledRejections()
+
         it 'does not reveal the updated fragment (bugfix)', asyncSpec (next) ->
           revealSpy = up.layout.knife.mock('reveal').and.returnValue(Promise.resolve())
 

data/spec_app/spec/javascripts/up/link_spec.js.coffee

@@ -654,6 +654,18 @@ describe 'up.link', ->
 
       describeCapability 'canPushState', ->
 
+        it 'requests the [href] with AJAX and replaces the [up-target] selector', asyncSpec (next) ->
+          affix('.target')
+          $link = affix('a[href="/path"][up-target=".target"]')
+          Trigger.clickSequence($link)
+
+          next =>
+            @respondWith('<div class="target">new text</div>')
+
+          next =>
+            expect($('.target')).toHaveText('new text')
+
+
         it 'adds a history entry', asyncSpec (next) ->
           up.history.config.enabled = true
 
@@ -784,6 +796,11 @@ describe 'up.link', ->
               expect($('.success-target')).toHaveText('old success text')
               expect($('.failure-target')).toHaveText('new failure text')
 
+              # Since there isn't anyone who could handle the rejection inside
+              # the event handler, our handler mutes the rejection.
+              expect(window).not.toHaveUnhandledRejections()
+
+
           it 'uses the [up-target] selector for a successful response', asyncSpec (next) ->
             Trigger.clickSequence(@$link)
 

data/spec_app/spec/javascripts/up/proxy_spec.js.coffee

@@ -973,25 +973,119 @@ describe 'up.proxy', ->
 
     describe '[up-preload]', ->
 
-      it 'preloads the link destination on mouseover, after a delay'
+      it 'preloads the link destination when hovering, after a delay', asyncSpec (next) ->
+        up.proxy.config.preloadDelay = 100
+
+        affix('.target').text('old text')
+
+        $link = affix('a[href="/foo"][up-target=".target"][up-preload]')
+        up.hello($link)
+
+        Trigger.hoverSequence($link)
+
+        next.after 50, =>
+          # It's still too early
+          expect(jasmine.Ajax.requests.count()).toEqual(0)
+
+        next.after 75, =>
+          expect(jasmine.Ajax.requests.count()).toEqual(1)
+          expect(@lastRequest().url).toMatchUrl('/foo')
+          expect(@lastRequest()).toHaveRequestMethod('GET')
+          expect(@lastRequest().requestHeaders['X-Up-Target']).toEqual('.target')
+
+          @respondWith """
+            <div class="target">
+              new text
+            </div>
+            """
+
+        next =>
+          # We only preloaded, so the target isn't replaced yet.
+          expect('.target').toHaveText('old text')
+
+          Trigger.clickSequence($link)
+
+        next =>
+          # No additional request has been sent since we already preloaded
+          expect(jasmine.Ajax.requests.count()).toEqual(1)
+
+          # The target is replaced instantly
+          expect('.target').toHaveText('new text')
+
+      it 'does not send a request if the user stops hovering before the delay is over', asyncSpec (next) ->
+        up.proxy.config.preloadDelay = 100
+
+        affix('.target').text('old text')
+
+        $link = affix('a[href="/foo"][up-target=".target"][up-preload]')
+        up.hello($link)
+
+        Trigger.hoverSequence($link)
+
+        next.after 40, =>
+          # It's still too early
+          expect(jasmine.Ajax.requests.count()).toEqual(0)
+
+          Trigger.unhoverSequence($link)
+
+        next.after 90, =>
+          expect(jasmine.Ajax.requests.count()).toEqual(0)
+
+      it 'does not cache a failed response', asyncSpec (next) ->
+        up.proxy.config.preloadDelay = 0
+
+        affix('.target').text('old text')
+
+        $link = affix('a[href="/foo"][up-target=".target"][up-preload]')
+        up.hello($link)
+
+        Trigger.hoverSequence($link)
+
+        next.after 2, =>
+          expect(jasmine.Ajax.requests.count()).toEqual(1)
+
+          @respondWith
+            status: 500
+            responseText: """
+              <div class="target">
+                new text
+              </div>
+              """
+
+        next =>
+          # We only preloaded, so the target isn't replaced yet.
+          expect('.target').toHaveText('old text')
+
+          Trigger.click($link)
+
+        next =>
+          # Since the preloading failed, we send another request
+          expect(jasmine.Ajax.requests.count()).toEqual(2)
+
+          # Since there isn't anyone who could handle the rejection inside
+          # the event handler, our handler mutes the rejection.
+          expect(window).not.toHaveUnhandledRejections()
 
       it 'triggers a separate AJAX request when hovered multiple times and the cache expires between hovers', asyncSpec (next)  ->
         up.proxy.config.cacheExpiry = 50
         up.proxy.config.preloadDelay = 0
+
         $element = affix('a[href="/foo"][up-preload]')
-        Trigger.mouseover($element)
+        up.hello($element)
+
+        Trigger.hoverSequence($element)
 
         next.after 1, =>
           expect(jasmine.Ajax.requests.count()).toEqual(1)
 
         next.after 1, =>
-          Trigger.mouseover($element)
+          Trigger.hoverSequence($element)
 
         next.after 1, =>
           expect(jasmine.Ajax.requests.count()).toEqual(1)
 
         next.after 60, =>
-          Trigger.mouseover($element)
+          Trigger.hoverSequence($element)
 
         next.after 1, =>
           expect(jasmine.Ajax.requests.count()).toEqual(2)

data/spec_app/spec/javascripts/up/radio_spec.js.coffee

@@ -1,5 +1,7 @@
 describe 'up.radio', ->
 
+  u = up.util
+
   describe 'JavaScript functions', ->
 
   describe 'unobtrusive behavior', ->