unpoly-rails 0.52.0 → 0.53.0

data/spec_app/spec/javascripts/up/link_spec.js.coffee

@@ -336,11 +336,129 @@ describe 'up.link', ->
             next =>
               expect($viewport.scrollTop()).toEqual(65)
 
-        describe "when the browser is already on the link's destination", ->
 
-          it "doesn't make a request and reveals the target container"
+        describe 'revealing', ->
 
-          it "doesn't make a request and reveals the target of a #hash in the URL"
+          it 'reaveals the target fragment', asyncSpec (next) ->
+            $link = affix('a[href="/action"][up-target=".target"]')
+            $target = affix('.target')
+
+            revealStub = up.layout.knife.mock('reveal')
+
+            up.follow($link)
+
+            next =>
+              @respondWith('<div class="target">new text</div>')
+
+            next =>
+              expect(revealStub).toHaveBeenCalled()
+              expect(revealStub.calls.mostRecent().args[0]).toBeMatchedBy('.target')
+
+          it 'reveals the { failTarget } if the server responds with an error', asyncSpec (next) ->
+            $link = affix('a[href="/action"][up-target=".target"][up-fail-target=".fail-target"]')
+            $target = affix('.target')
+            $failTarget = affix('.fail-target')
+
+            revealStub = up.layout.knife.mock('reveal')
+
+            up.follow($link)
+
+            next =>
+              @respondWith
+                status: 500,
+                responseText: """
+                  <div class="fail-target">
+                    Errors here
+                  </div>
+                  """
+
+            next =>
+              expect(revealStub).toHaveBeenCalled()
+              expect(revealStub.calls.mostRecent().args[0]).toBeMatchedBy('.fail-target')
+
+
+          describe 'with { reveal } option', ->
+
+            it 'allows to reveal a different selector', asyncSpec (next) ->
+              $link = affix('a[href="/action"][up-target=".target"]')
+              $target = affix('.target')
+              $other = affix('.other')
+
+              revealStub = up.layout.knife.mock('reveal')
+
+              up.follow($link, reveal: '.other')
+
+              next =>
+                @respondWith """
+                  <div class="target">
+                    new text
+                  </div>
+                  <div class="other">
+                    new other
+                  </div>
+                """
+
+              next =>
+                expect(revealStub).toHaveBeenCalled()
+                expect(revealStub.calls.mostRecent().args[0]).toBeMatchedBy('.other')
+
+            it 'still reveals the { failTarget } for a failed submission', asyncSpec (next) ->
+              $link = affix('a[href="/action"][up-target=".target"][up-fail-target=".fail-target"]')
+              $target = affix('.target')
+              $failTarget = affix('.fail-target')
+              $other = affix('.other')
+
+              revealStub = up.layout.knife.mock('reveal')
+
+              up.submit($link, reveal: '.other', failTarget: '.fail-target')
+
+              next =>
+                @respondWith
+                  status: 500,
+                  responseText: """
+                    <div class="fail-target">
+                      Errors here
+                    </div>
+                    """
+
+              next =>
+                expect(revealStub).toHaveBeenCalled()
+                expect(revealStub.calls.mostRecent().args[0]).toBeMatchedBy('.fail-target')
+
+          describe 'with { failReveal } option', ->
+
+            it 'reveals the given selector when the server responds with an error', asyncSpec (next) ->
+              $link = affix('a[href="/action"][up-target=".target"][up-fail-target=".fail-target"]')
+              $target = affix('.target')
+              $failTarget = affix('.fail-target')
+              $other = affix('.other')
+              $failOther = affix('.fail-other')
+
+              revealStub = up.layout.knife.mock('reveal')
+
+              up.follow($link, reveal: '.other', failReveal: '.fail-other')
+
+              next =>
+                @respondWith
+                  status: 500,
+                  responseText: """
+                    <div class="fail-target">
+                      Errors here
+                    </div>
+                    <div class="fail-other">
+                      Fail other here
+                    </div>
+                    """
+
+              next =>
+                expect(revealStub).toHaveBeenCalled()
+                expect(revealStub.calls.mostRecent().args[0]).toBeMatchedBy('.fail-other')
+
+          describe "when the browser is already on the link's destination", ->
+
+            it "doesn't make a request and reveals the target container"
+
+            it "doesn't make a request and reveals the target of a #hash in the URL"
 
         describe 'with { confirm } option', ->
 
@@ -609,7 +727,7 @@ describe 'up.link', ->
                 expect($('.document .target')).toHaveText('new text from modal link')
                 expect($('.up-modal .target')).toHaveText('old modal text')
 
-            it 'ignores [up-layer] if the server responds with a non-200 status code', asyncSpec (next) ->
+            it 'ignores [up-layer] if the server responds with an error', asyncSpec (next) ->
               affix('.document').affix('.target').text('old document text')
               up.modal.extract('.target', "<div class='target'>old modal text</div>", sticky: true)
 

data/spec_app/spec/javascripts/up/radio_spec.js.coffee

@@ -0,0 +1,75 @@
+describe 'up.radio', ->
+
+  describe 'JavaScript functions', ->
+
+  describe 'unobtrusive behavior', ->
+
+    describe '[up-hungry]', ->
+
+      it "replaces the element when it is found in a response, even when the element wasn't targeted", asyncSpec (next) ->
+        affix('.hungry[up-hungry]').text('old hungry')
+        affix('.target').text('old target')
+
+        up.replace('.target', '/path')
+
+        next =>
+          @respondWith """
+            <div class="target">
+              new target
+            </div>
+            <div class="between">
+              new between
+            </div>
+            <div class="hungry">
+              new hungry
+            </div>
+          """
+
+        next =>
+          expect('.target').toHaveText('new target')
+          expect('.hungry').toHaveText('new hungry')
+
+      it "does not impede replacements when the element is not part of a response", asyncSpec (next) ->
+        affix('.hungry[up-hungry]').text('old hungry')
+        affix('.target').text('old target')
+
+        promise = up.replace('.target', '/path')
+
+        next =>
+          @respondWith """
+            <div class="target">
+              new target
+            </div>
+          """
+
+        next =>
+          expect('.target').toHaveText('new target')
+          expect('.hungry').toHaveText('old hungry')
+
+          promiseState(promise).then (result) ->
+            expect(result.state).toEqual('fulfilled')
+
+      it 'does not replace the element when the server responds with an error', asyncSpec (next) ->
+        affix('.hungry[up-hungry]').text('old hungry')
+        affix('.target').text('old target')
+
+        up.replace('.target', '/path', failTarget: '.target')
+
+        next =>
+          @respondWith
+            status: 500
+            responseText: """
+              <div class="target">
+                new target
+              </div>
+              <div class="between">
+                new between
+              </div>
+              <div class="hungry">
+                new hungry
+              </div>
+              """
+
+        next =>
+          expect('.target').toHaveText('new target')
+          expect('.hungry').toHaveText('old hungry')

data/spec_app/spec/javascripts/up/util_spec.js.coffee

@@ -278,24 +278,49 @@ describe 'up.util', ->
 
       it "prefers using the element's 'up-id' attribute to using the element's ID", ->
         $element = affix('div[up-id=up-id-value]#id-value')
-        expect(up.util.selectorForElement($element)).toBe("[up-id='up-id-value']")
+        expect(up.util.selectorForElement($element)).toBe('[up-id="up-id-value"]')
 
       it "prefers using the element's ID to using the element's name", ->
         $element = affix('div#id-value[name=name-value]')
         expect(up.util.selectorForElement($element)).toBe("#id-value")
 
-      it "prefers using the element's name to using the element's classes", ->
-        $element = affix('div[name=name-value].class1.class2')
-        expect(up.util.selectorForElement($element)).toBe("[name='name-value']")
+      it "selects the ID with an attribute selector if the ID contains a slash", ->
+        $element = affix('div').attr(id: 'foo/bar')
+        expect(up.util.selectorForElement($element)).toBe('[id="foo/bar"]')
 
-      it "prefers using the element's classes to using the element's tag name", ->
+      it "selects the ID with an attribute selector if the ID contains a space", ->
+        $element = affix('div').attr(id: 'foo bar')
+        expect(up.util.selectorForElement($element)).toBe('[id="foo bar"]')
+
+      it "selects the ID with an attribute selector if the ID contains a dot", ->
+        $element = affix('div').attr(id: 'foo.bar')
+        expect(up.util.selectorForElement($element)).toBe('[id="foo.bar"]')
+
+      it "selects the ID with an attribute selector if the ID contains a quote", ->
+        $element = affix('div').attr(id: 'foo"bar')
+        expect(up.util.selectorForElement($element)).toBe('[id="foo\\"bar"]')
+
+      it "prefers using the element's tagName + [name] to using the element's classes", ->
+        $element = affix('input[name=name-value].class1.class2')
+        expect(up.util.selectorForElement($element)).toBe('input[name="name-value"]')
+
+      it "prefers using the element's classes to using the element's ARIA label", ->
         $element = affix('div.class1.class2')
         expect(up.util.selectorForElement($element)).toBe(".class1.class2")
 
+      it "prefers using the element's ARIA label to using the element's tag name", ->
+        $element = affix('div[aria-label="ARIA label value"]')
+        expect(up.util.selectorForElement($element)).toBe('[aria-label="ARIA label value"]')
+
       it "uses the element's tag name if no better description is available", ->
         $element = affix('div')
         expect(up.util.selectorForElement($element)).toBe("div")
 
+      it 'escapes quotes in attribute selector values', ->
+        $element = affix('div')
+        $element.attr('aria-label', 'foo"bar')
+        expect(up.util.selectorForElement($element)).toBe('[aria-label="foo\\"bar"]')
+
 
     describe 'up.util.castedAttr', ->
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unpoly-rails
 version: !ruby/object:Gem::Version
-  version: 0.52.0
+  version: 0.53.0
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-08 00:00:00.000000000 Z
+date: 2018-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -118,6 +118,7 @@ files:
 - lib/assets/javascripts/unpoly/popup.coffee
 - lib/assets/javascripts/unpoly/protocol.coffee
 - lib/assets/javascripts/unpoly/proxy.coffee
+- lib/assets/javascripts/unpoly/radio.coffee
 - lib/assets/javascripts/unpoly/rails.coffee
 - lib/assets/javascripts/unpoly/syntax.coffee
 - lib/assets/javascripts/unpoly/toast.coffee
@@ -164,6 +165,7 @@ files:
 - spec_app/app/controllers/form_test/basics_controller.rb
 - spec_app/app/controllers/form_test/redirects_controller.rb
 - spec_app/app/controllers/form_test/uploads_controller.rb
+- spec_app/app/controllers/hash_test_controller.rb
 - spec_app/app/controllers/method_test_controller.rb
 - spec_app/app/controllers/pages_controller.rb
 - spec_app/app/controllers/replace_test_controller.rb
@@ -183,6 +185,7 @@ files:
 - spec_app/app/views/form_test/redirects/target.erb
 - spec_app/app/views/form_test/submission_result.erb
 - spec_app/app/views/form_test/uploads/new.erb
+- spec_app/app/views/hash_test/vanilla.erb
 - spec_app/app/views/layouts/integration_test.erb
 - spec_app/app/views/layouts/jasmine_rails/spec_runner.html.erb
 - spec_app/app/views/method_test/form_target.erb
@@ -282,6 +285,7 @@ files:
 - spec_app/spec/javascripts/up/popup_spec.js.coffee
 - spec_app/spec/javascripts/up/protocol_spec.js.coffee
 - spec_app/spec/javascripts/up/proxy_spec.js.coffee
+- spec_app/spec/javascripts/up/radio_spec.js.coffee
 - spec_app/spec/javascripts/up/rails_spec.js.coffee
 - spec_app/spec/javascripts/up/syntax_spec.js.coffee
 - spec_app/spec/javascripts/up/tooltip_spec.js.coffee