RubyGems - unpoly-rails - Versions diffs - 0.34.2 → 0.35.0 - Mend

unpoly-rails 0.34.2 → 0.35.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Potentially problematic release.

This version of unpoly-rails might be problematic. Click here for more details.

Files changed (21) hide show

checksums.yaml +4 -4
data/CHANGELOG.md +18 -2
data/lib/assets/javascripts/unpoly/browser.coffee +41 -48
data/lib/assets/javascripts/unpoly/bus.coffee +2 -1
data/lib/assets/javascripts/unpoly/dom.coffee +2 -1
data/lib/assets/javascripts/unpoly/form.coffee +4 -18
data/lib/assets/javascripts/unpoly/motion.coffee +2 -4
data/lib/assets/javascripts/unpoly/protocol.coffee +15 -8
data/lib/assets/javascripts/unpoly/util.coffee +21 -40
data/lib/unpoly/rails/version.rb +1 -1
data/spec_app/Gemfile.lock +1 -1
data/spec_app/spec/javascripts/helpers/to_have_request_method.js.coffee +9 -1
data/spec_app/spec/javascripts/up/dom_spec.js.coffee +109 -92
data/spec_app/spec/javascripts/up/form_spec.js.coffee +7 -23
data/spec_app/spec/javascripts/up/link_spec.js.coffee +16 -18
data/spec_app/spec/javascripts/up/modal_spec.js.coffee +42 -46
data/spec_app/spec/javascripts/up/motion_spec.js.coffee +249 -295
data/spec_app/spec/javascripts/up/popup_spec.js.coffee +27 -29
data/spec_app/spec/javascripts/up/proxy_spec.js.coffee +3 -5
data/spec_app/spec/javascripts/up/util_spec.js.coffee +1 -0
metadata +2 -2

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e934641210c49c58e3d1e30abd25c4fc73a4d24f
-  data.tar.gz: cf11eb89f6e8ce701827e30c36c167e9a8fbd903
+  metadata.gz: f765b71ac71515b46543844c603128f24a494056
+  data.tar.gz: e69ba489c3e0307680d05ace76eaa64216271f7f
 SHA512:
-  metadata.gz: d62be4725349846015549ab1bbe41ed1a8fe6bb14d290ba87638ce73ce48ccf1a42a6ff58766a4b4a1a9522529700c0b4135c767b4e75d25a4c611aae2ff5e96
-  data.tar.gz: c33629c9950fd851ed88a0fd2fb99bd159a29b183d2a210a09b80a2238c22b4a55184754bb784e52e82ad7055fc32c07ac21189e319b712a4562184f8cf8e5b6
+  metadata.gz: 5b1593da8cf468285b2f3d7041890f8900f94caac29c88bd30a51a99accb1ee7a3a2d002ec2f14c3a2fcc86c96cae00f51252424e3a2b160d5c1ee485c0e67c4
+  data.tar.gz: 150c3aafcc1cd83e2d66d7222bfdf570aef1b56645f4c1d0aabb6d7e2965fb9ed2d59041ff2d71d324546411462ee60feab3f3cb8de10471ec300ec57de1410f

data/CHANGELOG.md CHANGED Viewed

@@ -6,16 +6,32 @@ All notable changes to this project will be documented in this file.
 This project mostly adheres to [Semantic Versioning](http://semver.org/).
+Unreleased
+----------
+### Compatible changes
+- Remove a use of global `$` that prevented Unpoly from being used with with [`jQuery.noConflict()`](https://api.jquery.com/jquery.noconflict/).
+- Fix a bug where replacing the `<body>` element would lose the body class and other attributes
+- Fix a bug where Unpoly would set the document title to a `<title>` tag of an inline SVG image.
+### Incompatible changes
+- Drop support for IE 9, which hasn't been supported on any platform since January 2016.
+- Drop support for IE 10, which hasn't been supported since January 2016 on any platform except
+  Windows Vista, and Vista is end-of-life in April 2017.
 0.34.2
 ------
-## Compatible changes
+### Compatible changes
 - The scroll positions of two [viewports](/up-viewport) with the same selector is now restored correctly when going back in history.
 - Fix a bug where new modals and popups would sometime flash at full opacity before starting their opening animation.
 0.34.1
 ------

data/lib/assets/javascripts/unpoly/browser.coffee CHANGED Viewed

@@ -4,13 +4,10 @@ Browser support
 Unpoly supports all modern browsers. It degrades gracefully with old versions of Internet Explorer:
-IE 10, IE11, Edge
+IE11, Edge
 : Full support
-IE 9
-: Page updates that change browser history fall back to a classic page load.
-IE 8
+IE 10 or lower
 : Unpoly prevents itself from booting itself, leaving you with a classic server-side application.
@@ -78,12 +75,7 @@ up.browser = (($) ->
   @internal
   ###
   puts = (stream, args...) ->
-    if canLogSubstitution()
-      console[stream](args...)
-    else
-      # IE <= 9 cannot pass varargs to console.log using Function#apply because IE
-      message = sprintf(args...)
-      console[stream](message)
+    console[stream](args...)
   CONSOLE_PLACEHOLDERS = /\%[odisf]/g
@@ -149,22 +141,19 @@ up.browser = (($) ->
   url = ->
     location.href
-  isIE8OrWorse = u.memoize ->
-    # This is the most concise way to exclude IE8 and lower
-    # while keeping all relevant desktop and mobile browsers.
-    u.isUndefined(document.addEventListener)
-  isIE9OrWorse = u.memoize ->
-    isIE8OrWorse() || navigator.appVersion.indexOf('MSIE 9.') != -1
+  isIE10OrWorse = u.memoize ->
+    !window.atob
   ###*
   Returns whether this browser supports manipulation of the current URL
   via [`history.pushState`](https://developer.mozilla.org/en-US/docs/Web/API/History/pushState).
-  When Unpoly is asked to change history on a browser that doesn't support
-  `pushState` (e.g. through [`up.follow()`](/up.follow)), it will gracefully
+  When `pushState`  (e.g. through [`up.follow()`](/up.follow)), it will gracefully
   fall back to a full page load.
+  Note that Unpoly will not use `pushState` if the initial page was loaded with
+  a request method other than GET.
   @function up.browser.canPushState
   @return {Boolean}
   @experimental
@@ -179,8 +168,7 @@ up.browser = (($) ->
     # 2. Some browsers have a bug where the initial request method is used for all
     #    subsequently pushed states. That means if the user reloads the page on a later
     #    GET state, the browser will wrongly attempt a POST request.
-    #    Modern Firefoxes, Chromes and IE10+ don't seem to be affected by this,
-    #    but we saw this behavior with Safari 8 and IE9 (IE9 can't do pushState anyway).
+    #    Modern Firefoxes, Chromes and IE10+ don't seem to be affected by this.
     #
     # The way that we work around this is that we don't support pushState if the
     # initial request method was anything other than GET (but allow the rest of the
@@ -198,7 +186,7 @@ up.browser = (($) ->
   @function up.browser.canCssTransition
   @return {Boolean}
-  @experimental
+  @internal
   ###
   canCssTransition = u.memoize ->
     'transition' of document.documentElement.style
@@ -208,7 +196,7 @@ up.browser = (($) ->
   @function up.browser.canInputEvent
   @return {Boolean}
-  @experimental
+  @internal
   ###
   canInputEvent = u.memoize ->
     'oninput' of document.createElement('input')
@@ -225,20 +213,32 @@ up.browser = (($) ->
     !!window.FormData
   ###*
-  Returns whether this browser supports
-  [string substitution](https://developer.mozilla.org/en-US/docs/Web/API/console#Using_string_substitutions)
-  in `console` functions.
+  Returns whether this browser supports the [`DOMParser`](https://developer.mozilla.org/en-US/docs/Web/API/DOMParser)
+  interface.
-  \#\#\# Example for string substition
+  @function up.browser.canDomParser
+  @return {Boolean}
+  @internal
+  ###
+  canDomParser = u.memoize ->
+    !!window.DOMParser
-      console.log("Hello %o!", "Judy");
+  ###*
+  Returns whether this browser supports the [`debugging console`](https://developer.mozilla.org/en-US/docs/Web/API/Console).
-  @function up.browser.canLogSubstitution
+  @function up.browser.canConsole
   @return {Boolean}
   @internal
   ###
-  canLogSubstitution = u.memoize ->
-    !isIE9OrWorse()
+  canConsole = u.memoize ->
+    window.console &&
+      console.debug &&
+      console.info &&
+      console.warn &&
+      console.error &&
+      console.group &&
+      console.groupCollapsed &&
+      console.groupEnd
   isRecentJQuery = u.memoize ->
     version = $.fn.jquery
@@ -293,16 +293,14 @@ up.browser = (($) ->
   @stable
   ###
   isSupported = ->
-    (!isIE8OrWorse()) && isRecentJQuery()
-  ###*
-  @internal
-  ###
-  installPolyfills = ->
-    window.console ?= {} # Missing in IE9 with DevTools closed
-    for method in ['debug', 'info', 'warn', 'error', 'group', 'groupCollapsed', 'groupEnd']
-      console[method] ?= (args...) -> puts('log', args...)
-    console.log ?= u.noop # Cannot be faked
+    !isIE10OrWorse() &&
+      isRecentJQuery() &&
+      canConsole() &&
+      canPushState() &&
+      canDomParser() &&
+      canFormData() &&
+      canCssTransition() &&
+      canInputEvent()
   ###*
   @internal
@@ -328,14 +326,9 @@ up.browser = (($) ->
   knife: eval(Knife?.point)
   url: url
   loadPage: loadPage
-  whenConfirmed: whenConfirmed
   canPushState: canPushState
-  canCssTransition: canCssTransition
-  canInputEvent: canInputEvent
-  canFormData: canFormData
-  canLogSubstitution: canLogSubstitution
+  whenConfirmed: whenConfirmed
   isSupported: isSupported
-  installPolyfills: installPolyfills
   puts: puts
   sprintf: sprintf
   sprintfWithFormattedArgs: sprintfWithFormattedArgs

data/lib/assets/javascripts/unpoly/bus.coffee CHANGED Viewed

@@ -437,7 +437,6 @@ up.bus = (($) ->
     if up.browser.isSupported()
       # Can't decouple this via the event bus, since up.bus would require
       # up.browser.isSupported() and up.browser would require up.on()
-      up.browser.installPolyfills()
       emit('up:framework:boot', message: 'Booting framework')
       emit('up:framework:booted', message: 'Framework booted')
       # User-provided compiler definitions will be registered once this function terminates.
@@ -447,6 +446,8 @@ up.bus = (($) ->
           # The following event will cause Unpoly to compile the <body>
           emit('up:app:boot', message: 'Booting user application')
           emit('up:app:booted', message: 'User application booted')
+    else
+      console.log?("Unpoly doesn't support this browser. Framework was not booted.")
   ###*
   This event is [emitted](/up.emit) when Unpoly [starts to boot](/up.boot).

data/lib/assets/javascripts/unpoly/dom.coffee CHANGED Viewed

@@ -415,7 +415,8 @@ up.dom = (($) ->
   parseResponse = (html) ->
     # jQuery cannot construct transient elements that contain <html> or <body> tags
     htmlElement = u.createElementFromHtml(html)
-    title: -> htmlElement.querySelector("title")?.textContent
+    title: ->
+      htmlElement.querySelector("head title")?.textContent
     first: (selector) ->
       # Although we cannot have a jQuery collection from an entire HTML document,
       # we can use jQuery's Sizzle engine to grep through a DOM tree.

data/lib/assets/javascripts/unpoly/form.coffee CHANGED Viewed

@@ -131,34 +131,25 @@ up.form = (($) ->
     options.restoreScroll = u.option(options.restoreScroll, u.castedAttr($form, 'up-restore-scroll'))
     options.origin = u.option(options.origin, $form)
     options.layer = u.option(options.layer, $form.attr('up-layer'), 'auto')
-    options.data = up.util.requestDataFromForm($form)
+    options.data = u.requestDataFromForm($form)
     options = u.merge(options, up.motion.animateOptions(options, $form))
-    hasFileInputs = $form.find('input[type=file]').length
-    canAjaxSubmit = !hasFileInputs || u.isFormData(options.data)
-    canHistoryOption = up.browser.canPushState() || options.history == false
     if options.validate
       options.headers ||= {}
       options.transition = false
       options.failTransition = false
       options.headers[up.protocol.config.validateHeader] = options.validate
-      # If a form has file inputs and the browser does not support FormData,
-      # we cannot offer inline validations.
-      unless canAjaxSubmit
-        return u.unresolvablePromise()
     up.feedback.start($form)
-    # If we can't submit this form via AJAX or if we wouldn't be able to change
-    # the location URL as the result, fall back to a vanilla form submission.
-    unless canAjaxSubmit && canHistoryOption
+    # If we can't update the location URL, fall back to a vanilla form submission.
+    unless up.browser.canPushState() || options.history == false
       $form.get(0).submit()
       return u.unresolvablePromise()
     promise = up.replace(target, url, options)
     promise.always -> up.feedback.stop($form)
-    return promise
+    promise
   ###*
   Observes form fields and runs a callback when a value changes.
@@ -285,11 +276,6 @@ up.form = (($) ->
     # we always bind to both events in case another script manually triggers it.
     changeEvents = 'input change'
-    unless up.browser.canInputEvent()
-      # In case this browser doesn't support input, we listen
-      # to all sorts of events that might change form controls.
-      changeEvents += ' keypress paste cut click propertychange'
     $field.on(changeEvents, check)
     # return destructor

data/lib/assets/javascripts/unpoly/motion.coffee CHANGED Viewed

@@ -78,16 +78,14 @@ up.motion = (($) ->
   ###*
   Returns whether Unpoly will perform animations.
-  Animations will be performed if the browser supports
-  [CSS transitions](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Transitions/Using_CSS_transitions)
-  and if [`up.motion.config.enabled`](/up.motion.config) is set to `true` (which is the default).
+  Set [`up.motion.config.enabled`](/up.motion.config) `false` in order to disable animations globally.
   @function up.motion.isEnabled
   @return {Boolean}
   @stable
   ###
   isEnabled = ->
-    config.enabled && up.browser.canCssTransition()
+    config.enabled
   ###*
   Applies the given animation to the given element.

data/lib/assets/javascripts/unpoly/protocol.coffee CHANGED Viewed

@@ -28,13 +28,14 @@ Unpoly requires an additional response header to detect redirects, which are
 otherwise undetectable for any AJAX client.
 After the form's action performs a redirect, the next response should include the new
-URL in this HTTP header:
+URL in the HTTP headers:
 ```http
+X-Up-Method: GET
 X-Up-Location: /current-url
 ```
-The **simplest implementation** is to set this header for every request.
+The **simplest implementation** is to set these headers for every request.
 \#\#\# Optimizing responses
@@ -131,14 +132,19 @@ but you can adapt it for other languages:
 \#\#\# Signaling the initial request method
-This is a edge case you might or might not care about:
 If the initial page was loaded  with a non-`GET` HTTP method, Unpoly prefers to make a full
-page load when you try to update a fragment. Once a page was loaded with a `GET` method,
+page load when you try to update a fragment. Once the next page was loaded with a `GET` method,
 Unpoly will restore its standard behavior.
-The reason for this is that some browsers remember the method of the initial page load and don't let
-the application change it, even with `pushState`. Thus, when the user reloads the page much later,
-an affected browser might request a `POST`, `PUT`, etc. instead of the correct method.
+This fixes two edge cases you might or might not care about:
+1. Unpoly replaces the initial page state so it can later restore it when the user
+   goes back to that initial URL. However, if the initial request was a POST,
+   Unpoly will wrongly assume that it can restore the state by reloading with GET.
+2. Some browsers have a bug where the initial request method is used for all
+   subsequently pushed states. That means if the user reloads the page on a later
+   GET state, the browser will wrongly attempt a POST request.
+   Modern Firefoxes, Chromes and IE10+ don't seem to be affected by this.
 In order to allow Unpoly to detect the HTTP method of the initial page load,
 the server must set a cookie:
@@ -180,7 +186,8 @@ up.protocol = (($) ->
   @internal
   ###
   methodFromXhr = (xhr) ->
-    xhr.getResponseHeader(config.methodHeader)
+    if method = xhr.getResponseHeader(config.methodHeader)
+      u.normalizeMethod(method)
   ###*
   Server-side companion libraries like unpoly-rails set this cookie so we

data/lib/assets/javascripts/unpoly/util.coffee CHANGED Viewed

@@ -196,44 +196,18 @@ up.util = (($) ->
     classes = classString.split(' ')
     select classes, (klass) -> isPresent(klass) && !klass.match(/^up-/)
+  openTagPattern = (tag) ->
+    new RegExp("<#{tag}(?: [^>]*)?>", 'i')
   # jQuery's implementation of $(...) cannot create elements that have
   # an <html> or <body> tag. So we're using native elements.
   # Also IE9 cannot set innerHTML on a <html> or <head> element.
   createElementFromHtml = (html) ->
-    openTag = (tag) -> "<#{tag}(?: [^>]*)?>"
-    closeTag = (tag) -> "</#{tag}>"
-    anything = '(?:.|\\s)*?'
-    capture = (pattern) -> "(#{pattern})"
-    titlePattern = new RegExp(
-      openTag('title') +
-        capture(anything) +
-      closeTag('title'),
-    'i')
-    bodyPattern = new RegExp(
-      openTag('body') +
-        capture(anything) +
-      closeTag('body'),
-    'i')
-    if bodyMatch = html.match(bodyPattern)
-      htmlElement = document.createElement('html')
-      bodyElement = createElement('body', bodyMatch[1])
-      htmlElement.appendChild(bodyElement)
-      if titleMatch = html.match(titlePattern)
-        headElement = createElement('head')
-        htmlElement.appendChild(headElement)
-        titleElement = createElement('title', titleMatch[1])
-        headElement.appendChild(titleElement)
-      htmlElement
+    bodyPattern = openTagPattern('body')
+    return if html.match(bodyPattern)
+      parser = new DOMParser()
+      parser.parseFromString(html, 'text/html')
     else
       # we possibly received a layout-less fragment
       createElement('div', html)
@@ -544,7 +518,7 @@ up.util = (($) ->
   @internal
   ###
   isFormData = (object) ->
-    up.browser.canFormData() && object instanceof FormData
+    object instanceof FormData
   ###*
   Converts the given array-like argument into an array.
@@ -1646,8 +1620,9 @@ up.util = (($) ->
   ###
   requestDataAsArray = (data) ->
     if isFormData(data)
-      # Until FormData#entries is implemented in all major browsers
-      # we must give up here
+      # Until FormData#entries is implemented in all major browsers we must give up here.
+      # However, up.form will prefer to serialize forms as arrays, so we should be good
+      # in most cases. We only use FormData for forms with file inputs.
       up.fail('Cannot convert FormData into an array')
     else
       query = requestDataAsQuery(data)
@@ -1669,8 +1644,9 @@ up.util = (($) ->
   ###
   requestDataAsQuery = (data) ->
     if isFormData(data)
-      # Until FormData#entries is implemented in all major browsers
-      # we must give up here
+      # Until FormData#entries is implemented in all major browsers we must give up here.
+      # However, up.form will prefer to serialize forms as arrays, so we should be good
+      # in most cases. We only use FormData for forms with file inputs.
       up.fail('Cannot convert FormData into a query string')
     else if isPresent(data)
       query = $.param(data)
@@ -1689,11 +1665,16 @@ up.util = (($) ->
   requestDataFromForm = (form) ->
     $form = $(form)
     hasFileInputs = $form.find('input[type=file]').length
-    if hasFileInputs && up.browser.canFormData()
+    # We try to stick with an array representation, whose contents we can inspect.
+    # We cannot inspect FormData on IE11 because it has no support for `FormData.entries`.
+    # Inspection is needed to generate a cache key (see `up.proxy`) and to make
+    # vanilla requests when `pushState` is unavailable (see `up.browser.loadPage`).
+    if hasFileInputs
       new FormData($form.get(0))
     else
       $form.serializeArray()
   ###*
   Adds a key/value pair to the given request data representation.
@@ -2096,6 +2077,6 @@ up.util = (($) ->
   flatten: flatten
   isTruthy: isTruthy
-)($)
+)(jQuery)
 up.fail = up.util.fail