unparser 0.4.7 → 0.4.8

data/spec/unit/unparser_spec.rb

@@ -57,11 +57,82 @@ describe Unparser, mutant_expression: 'Unparser::Emitter*' do
 
   describe '.parse' do
     def apply
-      described_class.parse('self[1]=2')
+      described_class.parse(source)
     end
 
-    it 'returns expected AST' do
-      expect(apply).to eql(s(:indexasgn, s(:self), s(:int, 1), s(:int, 2)))
+    context 'on present source' do
+      let(:source) { 'self[1]=2' }
+
+      it 'returns expected AST' do
+        expect(apply).to eql(s(:indexasgn, s(:self), s(:int, 1), s(:int, 2)))
+      end
+    end
+
+    context 'on empty source' do
+      let(:source) { '' }
+
+      it 'returns ni' do
+        expect(apply).to be(nil)
+      end
+    end
+
+    context 'on syntax error' do
+      let(:source) { '[' }
+
+      it 'raises error' do
+        expect { apply }.to raise_error(Parser::SyntaxError)
+      end
+    end
+  end
+
+  describe '.parse_either' do
+    def apply
+      described_class.parse_either(source)
+    end
+
+    context 'on present source' do
+      let(:source) { 'self[1]=2' }
+
+      it 'returns right value with expected AST' do
+        expect(apply).to eql(MPrelude::Either::Right.new(s(:indexasgn, s(:self), s(:int, 1), s(:int, 2))))
+      end
+    end
+
+    context 'on empty source' do
+      let(:source) { '' }
+
+      it 'returns right value with nil' do
+        expect(apply).to eql(MPrelude::Either::Right.new(nil))
+      end
+    end
+
+    context 'on syntax error' do
+      let(:source) { '[' }
+
+      it 'returns left value with syntax error' do
+        result = apply
+
+        # Syntax errors that compare nicely under #eql? are hard to construct
+        expect(result).to be_instance_of(MPrelude::Either::Left)
+        expect(result.from_left).to be_instance_of(Parser::SyntaxError)
+      end
+    end
+  end
+
+  describe '.unparse' do
+    context 'on unknown node type' do
+      def apply
+        Unparser.unparse(node)
+      end
+
+      let(:node) { s(:example_node) }
+
+      it 'raises UnknownNodeError' do
+        expect { apply }.to raise_error(
+          Unparser::UnknownNodeError,
+          'Unknown node type: :example_node'
+        )
+      end
     end
   end
 

data/unparser.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name        = 'unparser'
-  gem.version     = '0.4.7'
+  gem.version     = '0.4.8'
 
   gem.authors     = ['Markus Schirp']
   gem.email       = 'mbj@schirp-dso.com'
@@ -18,15 +18,18 @@ Gem::Specification.new do |gem|
 
   gem.add_dependency('abstract_type', '~> 0.0.7')
   gem.add_dependency('adamantium',    '~> 0.2.0')
-  gem.add_dependency('equalizer',     '~> 0.0.9')
-  gem.add_dependency('diff-lcs',      '~> 1.3')
+  gem.add_dependency('anima',         '~> 0.3.1')
   gem.add_dependency('concord',       '~> 0.1.5')
+  gem.add_dependency('diff-lcs',      '~> 1.3')
+  gem.add_dependency('equalizer',     '~> 0.0.9')
+  gem.add_dependency('mprelude',      '~> 0.1.0')
   gem.add_dependency('parser',        '>= 2.6.5')
   gem.add_dependency('procto',        '~> 0.0.2')
 
-  gem.add_development_dependency('anima',        '~> 0.3.1')
-  gem.add_development_dependency('devtools',     '~> 0.1.23')
-  gem.add_development_dependency('morpher',      '~> 0.2.6')
-  gem.add_development_dependency('mutant',       '~> 0.9.4')
-  gem.add_development_dependency('mutant-rspec', '~> 0.9.4')
+  gem.add_development_dependency('mutant',       '~> 0.9.9')
+  gem.add_development_dependency('mutant-rspec', '~> 0.9.9')
+  gem.add_development_dependency('rspec',        '~> 3.9')
+  gem.add_development_dependency('rspec-core',   '~> 3.9')
+  gem.add_development_dependency('rspec-its',    '~> 1.2.0')
+  gem.add_development_dependency('rubocop',      '~> 0.79.0')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unparser
 version: !ruby/object:Gem::Version
-  version: 0.4.7
+  version: 0.4.8
 platform: ruby
 authors:
 - Markus Schirp
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-01-04 00:00:00.000000000 Z
+date: 2020-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: abstract_type
@@ -39,19 +39,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.2.0
 - !ruby/object:Gem::Dependency
-  name: equalizer
+  name: anima
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.9
+        version: 0.3.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.9
+        version: 0.3.1
+- !ruby/object:Gem::Dependency
+  name: concord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.5
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.5
 - !ruby/object:Gem::Dependency
   name: diff-lcs
   requirement: !ruby/object:Gem::Requirement
@@ -67,19 +81,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: concord
+  name: equalizer
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.5
+        version: 0.0.9
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.5
+        version: 0.0.9
+- !ruby/object:Gem::Dependency
+  name: mprelude
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.0
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement
@@ -109,75 +137,89 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.0.2
 - !ruby/object:Gem::Dependency
-  name: anima
+  name: mutant
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.1
+        version: 0.9.9
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.1
+        version: 0.9.9
 - !ruby/object:Gem::Dependency
-  name: devtools
+  name: mutant-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.23
+        version: 0.9.9
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.23
+        version: 0.9.9
 - !ruby/object:Gem::Dependency
-  name: morpher
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.6
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.6
+        version: '3.9'
 - !ruby/object:Gem::Dependency
-  name: mutant
+  name: rspec-core
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.4
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.4
+        version: '3.9'
 - !ruby/object:Gem::Dependency
-  name: mutant-rspec
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.2.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.2.0
+- !ruby/object:Gem::Dependency
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.4
+        version: 0.79.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.4
+        version: 0.79.0
 description: Generate equivalent source for parser gem AST nodes
 email: mbj@schirp-dso.com
 executables:
@@ -186,7 +228,7 @@ extensions: []
 extra_rdoc_files:
 - README.md
 files:
-- ".circleci/config.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -202,18 +244,16 @@ files:
 - config/flog.yml
 - config/mutant.yml
 - config/reek.yml
-- config/rubocop.yml
 - config/yardstick.yml
 - lib/unparser.rb
 - lib/unparser/ast.rb
 - lib/unparser/ast/local_variable_scope.rb
 - lib/unparser/buffer.rb
 - lib/unparser/cli.rb
-- lib/unparser/cli/color.rb
-- lib/unparser/cli/differ.rb
-- lib/unparser/cli/source.rb
+- lib/unparser/color.rb
 - lib/unparser/comments.rb
 - lib/unparser/constants.rb
+- lib/unparser/diff.rb
 - lib/unparser/dsl.rb
 - lib/unparser/emitter.rb
 - lib/unparser/emitter/alias.rb
@@ -270,6 +310,7 @@ files:
 - lib/unparser/finalize.rb
 - lib/unparser/node_helpers.rb
 - lib/unparser/preprocessor.rb
+- lib/unparser/validation.rb
 - spec/integration/unparser/corpus_spec.rb
 - spec/integrations.yml
 - spec/spec_helper.rb
@@ -281,18 +322,21 @@ files:
 - spec/unit/unparser/buffer/indent_spec.rb
 - spec/unit/unparser/buffer/nl_spec.rb
 - spec/unit/unparser/buffer/unindent_spec.rb
+- spec/unit/unparser/color_spec.rb
 - spec/unit/unparser/comments/consume_spec.rb
 - spec/unit/unparser/comments/take_all_spec.rb
 - spec/unit/unparser/comments/take_before_spec.rb
 - spec/unit/unparser/comments/take_eol_comments_spec.rb
+- spec/unit/unparser/diff_spec.rb
 - spec/unit/unparser/emitter/class_methods/handle_spec.rb
+- spec/unit/unparser/validation_spec.rb
 - spec/unit/unparser_spec.rb
 - unparser.gemspec
 homepage: http://github.com/mbj/unparser
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -308,7 +352,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.0.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Generate equivalent source for parser gem AST nodes
 test_files:
@@ -323,9 +367,12 @@ test_files:
 - spec/unit/unparser/buffer/indent_spec.rb
 - spec/unit/unparser/buffer/nl_spec.rb
 - spec/unit/unparser/buffer/unindent_spec.rb
+- spec/unit/unparser/color_spec.rb
 - spec/unit/unparser/comments/consume_spec.rb
 - spec/unit/unparser/comments/take_all_spec.rb
 - spec/unit/unparser/comments/take_before_spec.rb
 - spec/unit/unparser/comments/take_eol_comments_spec.rb
+- spec/unit/unparser/diff_spec.rb
 - spec/unit/unparser/emitter/class_methods/handle_spec.rb
+- spec/unit/unparser/validation_spec.rb
 - spec/unit/unparser_spec.rb

data/.circleci/config.yml

@@ -1,49 +0,0 @@
-defaults: &defaults
-  working_directory: ~/unparser
-  docker:
-    - image: circleci/ruby:2.6.5
-version: 2
-jobs:
-  unit_specs:
-    <<: *defaults
-    steps:
-      - checkout
-      - run: bundle install
-      - run: bundle exec rspec spec/unit
-  integration_specs:
-    <<: *defaults
-    steps:
-      - checkout
-      - run: bundle install
-      - run: bundle exec rspec spec/integration
-  metrics:
-    <<: *defaults
-    steps:
-      - checkout
-      - run: bundle install
-      - run: bundle exec rake metrics:rubocop
-      - run: bundle exec rake metrics:reek
-      - run: bundle exec rake metrics:flay
-      - run: bundle exec rake metrics:flog
-  mutant:
-    <<: *defaults
-    steps:
-      - checkout
-      - run: bundle install
-      - run: |
-          bundle                                                  \
-            exec                                                  \
-            mutant                                                \
-            --ignore-subject 'Unparser::AST::LocalVariableScope*' \
-            --since origin/master                                 \
-            --zombie                                              \
-            --                                                    \
-            'Unparser*'
-workflows:
-  version: 2
-  test:
-    jobs:
-      - unit_specs
-      - integration_specs
-      - metrics
-      - mutant

data/config/rubocop.yml

@@ -1,122 +0,0 @@
-inherit_from: ../.rubocop.yml
-
-AllCops:
-  Include:
-    - 'lib/unparser.rb'
-    - 'lib/unparser/**/*.rb'
-    - '**/*.rake'
-    - 'Gemfile'
-    - 'Gemfile.triage'
-
-# Avoid parameter lists longer than five parameters.
-ParameterLists:
-  Max: 3
-  CountKeywordArgs: true
-
-MethodLength:
-  CountComments: false
-  Max: 17
-
-AbcSize:
-  Max: 18
-
-# Avoid more than `Max` levels of nesting.
-BlockNesting:
-  Max: 3
-
-# Align with the style guide.
-CollectionMethods:
-  PreferredMethods:
-    collect:  'map'
-    inject:   'reduce'
-    find:     'detect'
-    find_all: 'select'
-
-# Limit line length
-LineLength:
-  Max: 113  # TODO: lower to 79 once the rubocop branch in shared/Gemfile is removed
-
-ClassLength:
-  Max: 204
-
-# Prefer modifiers and explicit if statements over returning early for small methods
-GuardClause:
-  Enabled: false
-
-Metrics/BlockLength:
-  Exclude:
-  # Ignore RSpec DSL
-  - spec/**/*
-
-# Flags freezes for singletons that could still be mutated like Regexps
-RedundantFreeze:
-  Enabled: false
-
-# Allow Fixnum and Bignum. This Gem supports versions before 2.4
-UnifiedInteger:
-  Enabled: false
-
-# Disabled because of indenting with private keyword in class bodies.
-IndentationWidth:
-  Enabled: false
-
-# I like raise more
-SignalException:
-  Enabled: false
-
-# False positive in unparser source
-OneLineConditional:
-  Enabled: false
-
-Documentation:
-  Enabled: false
-
-# Disable documentation checking until a class needs to be documented once
-Documentation:
-  Enabled: false
-
-# Do not favor modifier if/unless usage when you have a single-line body
-IfUnlessModifier:
-  Enabled: false
-
-# Allow case equality operator (in limited use within the specs)
-CaseEquality:
-  Enabled: false
-
-# Constants do not always have to use SCREAMING_SNAKE_CASE
-ConstantName:
-  Enabled: false
-
-# Not all trivial readers/writers can be defined with attr_* methods
-TrivialAccessors:
-  Enabled: false
-
-# I like to have an empty line before closing the currently opened body
-EmptyLinesAroundBlockBody:
-  Enabled: false
-
-EmptyLinesAroundClassBody:
-  Enabled: false
-
-EmptyLinesAroundModuleBody:
-  Enabled: false
-
-# I like my style more
-AccessModifierIndentation:
-  Enabled: false
-
-Style/CommentedKeyword:
-  Enabled: false
-
-Style/MixinGrouping:
-  Enabled: false
-
-Lint/BooleanSymbol:
-  Enabled: false
-
-Style/AccessModifierDeclarations:
-  Enabled: false
-
-Layout/AlignHash:
-  EnforcedColonStyle: table
-  EnforcedHashRocketStyle: table