unobtainium 0.8.1 → 0.9.0

data/spec/support_identifiers_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+require_relative '../lib/unobtainium/support/identifiers'
+
+describe ::Unobtainium::Support::Identifiers do
+  let(:tester) { Class.new { extend ::Unobtainium::Support::Identifiers } }
+
+  it "creates IDs starting with the given scope" do
+    expect(tester.identifier('noodle', 'foo')).to start_with 'noodle'
+  end
+
+  it "creates the same ID for identical input" do
+    opts = { foo: 'bar', "baz" => 42 }
+    first = tester.identifier('test', 'mylabel', opts.dup)
+    second = tester.identifier('test', 'mylabel', opts.dup)
+    expect(first).to eql second
+  end
+
+  context "different input" do
+    it "creates different IDs for different scopes" do
+      opts = { foo: 'bar', "baz" => 42 }
+      first = tester.identifier('scope1', 'mylabel', opts.dup)
+      second = tester.identifier('scope2', 'mylabel', opts.dup)
+      expect(first).not_to eql second
+    end
+
+    it "creates different IDs for different labels" do
+      opts = { foo: 'bar', "baz" => 42 }
+      first = tester.identifier('test', 'label1', opts.dup)
+      second = tester.identifier('test', 'label2', opts.dup)
+      expect(first).not_to eql second
+    end
+
+    it "creates different IDs for different options" do
+      opts1 = { foo: 'bar', "baz" => 42 }
+      opts2 = opts1.dup
+      opts2['baz'] = 123
+      first = tester.identifier('test', 'mylabel', opts1)
+      second = tester.identifier('test', 'mylabel', opts2)
+      expect(first).not_to eql second
+    end
+  end
+end

data/spec/{port_scanner_spec.rb → support_port_scanner_spec.rb}

@@ -47,6 +47,27 @@ describe ::Unobtainium::Support::PortScanner do
         tester.port_open?('localhost', 1234, :FOO)
       end.to raise_error(ArgumentError)
     end
+
+    it "handles unsupported protocols gracefully" do
+      allow_any_instance_of(Socket).to receive(:connect_nonblock).and_raise(
+          Errno::EINVAL # or EAFNOSUPPORT
+      )
+      expect(tester.port_open?('localhost', 1234, [:INET, :INET6])).to be_falsy
+    end
+
+    it "retries for several seconds if a socket is being created" do
+      allow_any_instance_of(Socket).to receive(:connect_nonblock).and_raise(
+          Errno::EINPROGRESS
+      )
+      before = Time.now.utc
+      expect(tester.port_open?('localhost', 1234, [:INET, :INET6])).to be_falsy
+      after = Time.now.utc
+
+      elapsed = after - before
+      expected_max_time = ::Unobtainium::Support::PortScanner::MAX_RETRIES \
+                          * ::Unobtainium::Support::PortScanner::RETRY_DELAY
+      expect(elapsed).to be <= expected_max_time
+    end
   end
 
   describe "scan" do
@@ -113,6 +134,14 @@ describe ::Unobtainium::Support::PortScanner do
       expect(tester.scan('localhost', 1230..4330, amount: :first)).to eql [1234]
     end
 
+    it "can return successfully after the first find" do
+      allow_any_instance_of(Socket).to receive(:connect_nonblock) do |sock, addr|
+        connect_mock(sock, addr)
+      end
+
+      expect(tester.scan('localhost', 1230..4330, amount: :first)).to eql [1234]
+    end
+
     it "can scan for closed/available ports" do
       allow_any_instance_of(Socket).to receive(:connect_nonblock) do |sock, addr|
         connect_mock(sock, addr)
@@ -121,6 +150,26 @@ describe ::Unobtainium::Support::PortScanner do
       expect(tester.scan('localhost', 1233..1234, for: :closed)).to eql [1233]
     end
 
+    it "can scan for the first closed/available port" do
+      allow_any_instance_of(Socket).to receive(:connect_nonblock) do |sock, addr|
+        connect_mock(sock, addr)
+      end
+
+      opts = {
+        amount: :first,
+        for: :closed,
+      }
+      expect(tester.scan('localhost', 1232..1234, opts)).to eql [1232]
+    end
+
+    it "can scan for the first string port" do
+      allow_any_instance_of(Socket).to receive(:connect_nonblock) do |sock, addr|
+        connect_mock(sock, addr)
+      end
+
+      expect(tester.scan('localhost', '1234', amount: :first)).to eql [1234]
+    end
+
     it "rejects bad amounts" do
       expect do
         tester.scan('localhost', 1230..4330, amount: :foo)

data/spec/world_spec.rb

@@ -19,6 +19,11 @@ describe ::Unobtainium::World do
     @tester = Tester.new
   end
 
+  it "has set the config file as expected" do
+    expect(::Unobtainium::World.config_file).to end_with \
+      File.join('data', 'driverconfig.yml')
+  end
+
   it "loads the global config" do
     expect(@tester.config["drivers.mock.mockoption"]).to eql 42
   end
@@ -32,7 +37,40 @@ describe ::Unobtainium::World do
   end
 
   it "extends driver options, but doesn't pass 'base' on" do
-    expect(@tester.config["drivers.leaf.base"]).to eql %w(.drivers.mock)
+    expect(@tester.config["drivers.leaf.base"]).to eql %w(.global
+                                                          .drivers.mock
+                                                          .drivers.branch1
+                                                          .drivers.branch2)
     expect(@tester.driver.passed_options["base"]).to be_nil
   end
+
+  context "object identity" do
+    context "#driver" do
+      it "returns the same object for the same config" do
+        first = @tester.driver.object_id
+        second = @tester.driver.object_id
+        expect(first).to eql second
+      end
+
+      it "returns a different object for different config" do
+        first = @tester.driver(:mock, foo: true).object_id
+        second = @tester.driver(:mock, foo: false).object_id
+        expect(first).not_to eql second
+      end
+    end
+
+    context "driver.impl" do
+      it "returns the same object for the same config" do
+        first = @tester.driver.impl.object_id
+        second = @tester.driver.impl.object_id
+        expect(first).to eql second
+      end
+
+      it "returns a different object for different config" do
+        first = @tester.driver(:mock, foo: true).impl.object_id
+        second = @tester.driver(:mock, foo: false).impl.object_id
+        expect(first).not_to eql second
+      end
+    end
+  end
 end

data/unobtainium.gemspec

@@ -57,7 +57,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "sys-proctable", "~> 1.1"
   spec.add_dependency "ptools", "~> 1.3"
-  spec.add_dependency "collapsium", "~> 0.6"
+  spec.add_dependency "collapsium", "~> 0.8"
   spec.add_dependency "collapsium-config", "~> 0.4"
 end
 # rubocop:enable Metrics/BlockLength

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unobtainium
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.9.0
 platform: ruby
 authors:
 - Jens Finkhaeuser
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-08 00:00:00.000000000 Z
+date: 2016-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -198,14 +198,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: collapsium-config
   requirement: !ruby/object:Gem::Requirement
@@ -253,6 +253,7 @@ files:
 - lib/unobtainium/drivers/phantom.rb
 - lib/unobtainium/drivers/selenium.rb
 - lib/unobtainium/runtime.rb
+- lib/unobtainium/support/identifiers.rb
 - lib/unobtainium/support/port_scanner.rb
 - lib/unobtainium/support/runner.rb
 - lib/unobtainium/support/util.rb
@@ -262,12 +263,16 @@ files:
 - media/video.ogv
 - spec/data/driverconfig.yml
 - spec/driver_spec.rb
+- spec/drivers_appium_spec.rb
+- spec/drivers_phantom_spec.rb
+- spec/drivers_selenium_spec.rb
 - spec/mock_driver.rb
-- spec/port_scanner_spec.rb
-- spec/runner_spec.rb
 - spec/runtime_spec.rb
 - spec/spec_helper.rb
-- spec/utility_spec.rb
+- spec/support_identifiers_spec.rb
+- spec/support_port_scanner_spec.rb
+- spec/support_runner_spec.rb
+- spec/support_utility_spec.rb
 - spec/world_spec.rb
 - unobtainium.gemspec
 homepage: https://github.com/jfinkhaeuser/unobtainium
@@ -301,10 +306,14 @@ test_files:
 - features/world.feature
 - spec/data/driverconfig.yml
 - spec/driver_spec.rb
+- spec/drivers_appium_spec.rb
+- spec/drivers_phantom_spec.rb
+- spec/drivers_selenium_spec.rb
 - spec/mock_driver.rb
-- spec/port_scanner_spec.rb
-- spec/runner_spec.rb
 - spec/runtime_spec.rb
 - spec/spec_helper.rb
-- spec/utility_spec.rb
+- spec/support_identifiers_spec.rb
+- spec/support_port_scanner_spec.rb
+- spec/support_runner_spec.rb
+- spec/support_utility_spec.rb
 - spec/world_spec.rb