universities 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e17c80ae38373129710744282dd2aeeaabbfd118
-  data.tar.gz: f513351f3cd6491724ae9d9dd682febd74dd2796
+  metadata.gz: 1429ebeda856f5deb9664551ddf751fc6fd0aff3
+  data.tar.gz: 634c00d6b85b6162d798a5eb47fa978e05b6b891
 SHA512:
-  metadata.gz: 114c1bec9835c07b2fc068320e8a56f69e12459315e57b791c50bdc5c24991688a5a96f88f72d1401b6160d1189f6fe53bbb2d98a493ead5f69b6bb175c5a553
-  data.tar.gz: 3b765c1a6f25739d976008dc84d5e88d041e98fc749d4c5f9bd428ddec22e840fc5e73d339d981f8a45af4dc23855225f869e1937c6cc4189d32550609953ca2
+  metadata.gz: 90b3cda8ef69c73fca7ccd72f9976addc6634e01db546f6961516afcfadf2679646bf1e3e2033c13ebfab762ecf223fbe5797ed35c22cb42fd4ff6299c2fe67b
+  data.tar.gz: 874f9a62e6e458a967918bb22ecd9a47ec40cb4b2b41549315b1c36b86fddccad3fb493bcd2f8cbc0f4576f8f06f6f4f74a1778e9ec394ff31e7886f040bba57

data/.codeclimate.yml

@@ -0,0 +1,7 @@
+plugins:
+  rubymotion:
+    enabled: true
+  rubocop:
+    enabled: true
+    config:
+      file: .rubocop.yml

data/.rubocop.yml

@@ -1,6 +1 @@
-Metrics/LineLength:
-  Max: 120
-Style/Documentation:
-  Enabled: false
-Layout/EndOfLine:
-  Enabled: false
+inherit_from: https://raw.githubusercontent.com/laurentzziu/utils/master/gems/.rubocop.yml

data/.travis.yml

@@ -1,5 +1,16 @@
 sudo: false
+env:
+  global:
+    - CC_TEST_REPORTER_ID=6727774317142f42ffb6d3c2ea8764c3ef7e639ac7bff13a30d16a484439c1b9
 language: ruby
 rvm:
   - 2.4.3
 before_install: gem install bundler -v 1.16.1
+before_script:
+  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+  - chmod +x ./cc-test-reporter
+  - ./cc-test-reporter before-build
+script:
+  - bundle exec rspec
+after_script:
+  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT

data/Gemfile

@@ -1,6 +1,6 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in universities.gemspec
 gemspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    universities (0.1.0)
+    universities (0.1.1)
       activesupport
       httparty
 
@@ -15,28 +15,39 @@ GEM
       tzinfo (~> 1.1)
     addressable (2.6.0)
       public_suffix (>= 2.0.2, < 4.0)
+    ansi (1.5.0)
+    ast (2.4.0)
     coderay (1.1.2)
     concurrent-ruby (1.1.4)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.3)
+    docile (1.3.1)
     hashdiff (0.3.8)
+    hirb (0.7.3)
     httparty (0.16.4)
       mime-types (~> 3.0)
       multi_xml (>= 0.5.2)
-    i18n (1.5.3)
+    i18n (1.6.0)
       concurrent-ruby (~> 1.0)
-    method_source (0.8.2)
+    jaro_winkler (1.5.2)
+    json (2.2.0)
+    method_source (0.9.2)
     mime-types (3.2.2)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2018.0812)
     minitest (5.11.3)
     multi_xml (0.6.0)
-    pry (0.10.4)
+    parallel (1.14.0)
+    parser (2.6.0.0)
+      ast (~> 2.4.0)
+    powerpack (0.1.2)
+    pry (0.12.2)
       coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
+      method_source (~> 0.9.0)
+    psych (3.1.0)
     public_suffix (3.0.3)
+    rainbow (3.0.0)
     rake (10.5.0)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
@@ -51,11 +62,32 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.0)
+    rubocop (0.65.0)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.5, != 2.5.1.1)
+      powerpack (~> 0.1)
+      psych (>= 3.1.0)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.4.0)
+    rubocop-rspec (1.32.0)
+      rubocop (>= 0.60.0)
+    ruby-progressbar (1.10.0)
     safe_yaml (1.0.5)
-    slop (3.6.0)
+    simplecov (0.16.1)
+      docile (~> 1.1)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-console (0.4.2)
+      ansi
+      hirb
+      simplecov
+    simplecov-html (0.10.2)
     thread_safe (0.3.6)
     tzinfo (1.2.5)
       thread_safe (~> 0.1)
+    unicode-display_width (1.4.1)
     vcr (4.0.0)
     webmock (3.5.1)
       addressable (>= 2.3.6)
@@ -70,6 +102,10 @@ DEPENDENCIES
   pry
   rake (~> 10.0)
   rspec (~> 3.0)
+  rubocop
+  rubocop-rspec
+  simplecov
+  simplecov-console
   universities!
   vcr
   webmock

data/README.md

@@ -1,4 +1,7 @@
 [![Build Status](https://travis-ci.org/laurentzziu/universities.svg?branch=master)](https://travis-ci.org/laurentzziu/universities)
+[![Gem Version](https://badge.fury.io/rb/universities.svg)](https://rubygems.org/gems/universities)
+[![Maintainability](https://api.codeclimate.com/v1/badges/06e863f836bf7faeaeb5/maintainability)](https://codeclimate.com/github/laurentzziu/universities/maintainability)
+[![Test Coverage](https://api.codeclimate.com/v1/badges/06e863f836bf7faeaeb5/test_coverage)](https://codeclimate.com/github/laurentzziu/universities/test_coverage)
 
 # Universities
 
@@ -37,25 +40,25 @@ Available filters: `country`, `name`.
 #### Filter by *country*
 ```ruby
 Universities.get.country('Romania').fetch
-# alias_method: 
+# alias_method:
 Universities.get.by_country('Romania').fetch
 ```
 
 #### Filter by *name*
 ```ruby
 Universities.get.name('Politehnica').fetch
-# alias_method: 
+# alias_method:
 Universities.get.by_name('Politehnica').fetch
 ```
 
 #### Filter by *country* and *name*
 ```ruby
 Universities.get.country('Romania').name('Politehnica').fetch
-# alias_method: 
+# alias_method:
 Universities.get.by_country('Romania').by_name('Politehnica').fetch
 ```
 
-#### University::Entity 
+#### University::Entity
 Example
 
 ```ruby

data/Rakefile

@@ -1,10 +1,12 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
 task :console do
-  exec "pry -r universities -I ./lib"
+  exec 'pry -r universities -I ./lib'
 end
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,14 +1,14 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "universities"
+require 'bundler/setup'
+require 'universities'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
 # (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
+# require 'pry'
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/lib/universities/entity.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'active_support/core_ext/hash'
 
 module Universities
@@ -10,16 +11,17 @@ module Universities
       country: 'country',
       domains: 'domains',
       name: 'name'
-    }
+    }.freeze
+
+    attr_reader(*ATTRIBUTES_MAPPING.keys)
 
     def initialize(web_pages: nil, alpha_two_code: nil, state_province: nil, country: nil, domains: nil, name: nil)
-      local_variables.each do |key|
-        self.class.class_eval do
-          attr_reader key
-        end
-        value = eval(key.to_s)
-        instance_variable_set("@#{key}", value)
-      end
+      @web_pages = web_pages
+      @alpha_two_code = alpha_two_code
+      @state_province = state_province
+      @country = country
+      @domains = domains
+      @name = name
     end
 
     def self.build(hash)
@@ -33,4 +35,4 @@ module Universities
       end.to_h
     end
   end
-end
+end

data/lib/universities/request.rb

@@ -23,17 +23,17 @@ module Universities
       dup_and_update(country: word)
     end
 
-    alias_method :by_country, :country
+    alias by_country country
 
     def name(word)
       dup_and_update(name: word)
     end
 
-    alias_method :by_name, :name
+    alias by_name name
 
     private
 
-    BASE_URL = 'http://universities.hipolabs.com/search'
+    BASE_URL = 'http://universities.hipolabs.com/search'.freeze
 
     def params
       hash = {}

data/lib/universities/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Universities
-  VERSION = "0.1.0"
+  VERSION = '0.1.1'.freeze
 end

data/universities.gemspec

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
@@ -9,8 +10,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ['Florinel Gorgan']
   spec.email         = ['florin@floringorgan.com']
 
-  spec.summary       = %q(Ruby gem for Hipo/university-domains-list.)
-  spec.description   = %q(Ruby gem for Hipo/university-domains-list.)
+  spec.summary       = 'Ruby gem for Hipo/university-domains-list.'
+  spec.description   = 'Ruby gem for Hipo/university-domains-list.'
   spec.homepage      = 'https://github.com/laurentzziu/universities'
   spec.license       = 'MIT'
 
@@ -21,13 +22,17 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'httparty'
   spec.add_runtime_dependency 'activesupport'
+  spec.add_runtime_dependency 'httparty'
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'rubocop-rspec'
+  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'simplecov-console'
   spec.add_development_dependency 'vcr'
   spec.add_development_dependency 'webmock'
 end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: universities
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Florinel Gorgan
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-03-04 00:00:00.000000000 Z
+date: 2019-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: httparty
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -25,7 +25,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -94,6 +94,62 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov-console
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -129,6 +185,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"