universign 0.2.1 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4a162d62ec1ebc95ac4c719c2bebe7b47f64f7df
-  data.tar.gz: bc40b9c1401827933fd9d4223f7d199447929cb1
+  metadata.gz: 046e117415f3768789d8a8aaf03ada6bd372a90c
+  data.tar.gz: 27cd5cdd9b584f96eeb15f09802cd3616d7e7240
 SHA512:
-  metadata.gz: 55c5e8b2e43b16ba960f67d7400b53791123da170f4a81a3611bfdc06557b8ec539a18108251faec05b3ae8a71314f7e5b0e60834a652384f04117e23a23071d
-  data.tar.gz: 4b215f199a03f964cfb78118cfc14032de3f723c91f376c83f742253deb41d4d02489c5cb5b4ae562b4c031df206297d949ff1e8382f9167efa6eb068066a50a
+  metadata.gz: 8f7f79044e8b41ae62bdc2bb26532bc50dc1ae31556ddb1428fe0adfec46a2b2a5b6d058c54052865a103bec1a9acfec915f4d855f1129978846b67598ddb2c7
+  data.tar.gz: 923214c7d517c5c4db57f466082f758cdd986d9a45d3c8ff7c5b8cba34e19e7d0876fd488f4f8624e0d52dacaf7bbeeb9cb0277d0ddef1ac057a8d574ed73f25

data/lib/universign.rb

@@ -17,41 +17,28 @@ module Universign
   # Configuration class
   class Configuration
     attr_accessor :language, :production, :user, :password, :debug,
-                  :profile
+                  :profile, :handwritten_signature_mode
 
     def initialize
       @language = 'en'
       @debug = false
       @production = false
       @profile = 'default'
+      @handwritten_signature_mode = 0
     end
   end
 
   module Sign
     class << self
-      SignerDefaultOptions = { firstname: nil,
-                               lastname: nil,
-                               organization: nil,
-                               profile: 'default',
-                               emailAddress: nil,
-                               phoneNum: nil,
-                               role: 'signer',
-                               signatureField: nil,
-                               successURL: nil,
-                               cancelURL: nil,
-                               failURL: nil,
-                               certificateType: 'simple',
-                               idDocuments: nil
-      }.freeze
       SANDBOX_URL = 'sign.test.cryptolog.com'.freeze
       PROD_URL = 'sign.cryptolog.com'.freeze
+      PATH = '/sign/rpc'.freeze
 
       def client
         fail 'You need to set config options' if Universign.configuration.nil?
         host = Universign.configuration.production ? PROD_URL : SANDBOX_URL
-        path = '/sign/rpc'
         client = Universign::Sign::Client.new(
-            host, path, nil, nil, nil,
+            host, PATH, nil, nil, nil,
             Universign.configuration.user,
             Universign.configuration.password, true
         )
@@ -60,36 +47,37 @@ module Universign
       end
 
       def transaction_signer(options = {})
-        options = options.reverse_merge(SignerDefaultOptions)
         validate_transaction_signer_argument options
-        options.reject! { |_, v| v.nil? }
+        options
       end
 
-      def transaction_document(content, name)
-        { content: XMLRPC::Base64.new(content), name: name }
+      def transaction_document(content, name, options = {})
+        { content: XMLRPC::Base64.new(content), name: name }.merge options
       end
 
       private
 
       def validate_transaction_signer_argument(options)
         fail(ArgumentError, 'You have to provide a firstname') if
-            options[:firstname].empty?
+            options[:firstname].to_s == ''
         fail(ArgumentError, 'You have to provide a lastname') if
-            options[:lastname].empty?
+            options[:lastname].to_s == ''
         fail(ArgumentError, 'You have to provide an email') if
-            options[:emailAddress].empty?
+            options[:emailAddress].to_s == ''
       end
     end
 
     class Client < XMLRPC::Client
       # Request signature (Client side)
-      def request_transaction(signers, docs)
-        signers = [signers] unless signers.is_a? Array
-        docs = [docs] unless docs.is_a? Array
-        request = { documents: docs, signers: signers,
-                    handwrittenSignatureMode: 0,
-                    profile: Universign.configuration.profile,
-                    language: Universign.configuration.language }
+      def request_transaction(signers, docs, options = {})
+        options[:documents] = (docs.is_a? Array) ? docs : [docs]
+        options[:signers] = (signers.is_a? Array) ? signers : [signers]
+        request = options.reverse_merge(
+            handwrittenSignatureMode: \
+            Universign.configuration.handwritten_signature_mode,
+            profile: Universign.configuration.profile,
+            language: Universign.configuration.language
+        )
         call('requester.requestTransaction', request)
       end
 

data/lib/universign/hash.rb

@@ -1,7 +1,5 @@
 class Hash
-  unless Hash.respond_to? :reverse_merge
-    def reverse_merge(other_hash)
-      other_hash.merge(self)
-    end
+  def reverse_merge(other_hash)
+    other_hash.merge(self)
   end
 end

data/lib/universign/version.rb

@@ -1,3 +1,3 @@
 module Universign
-  VERSION = '0.2.1'.freeze
+  VERSION = '0.2.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: universign
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.3
 platform: ruby
 authors:
 - Matthieu Foillard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-02 00:00:00.000000000 Z
+date: 2016-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler