unitsdb 2.2.2 → 2.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e2982ead6dc990098c687109bd98560cd35945c6272e01a88bcd4f1270ffdffa
-  data.tar.gz: f89db123f11036b7963fd5fc60a1e37476cd7dac43664be26c95776089479844
+  metadata.gz: '098dae7946c10a2e7ed4b5c7f5b3e75e8aed43c0112f9bd49137e629c4c1dfad'
+  data.tar.gz: c8fc41cfa9f239b892cf5baf4b8febc48b00db6d433c8421f6b1c24a92ef1dcb
 SHA512:
-  metadata.gz: 811a621748d4936a1668e7f6969e5090f4da626b7ca0122bbce24ea1d3b217a533d2ea0e5759a812c22faa4d097941538e9273db4c2f84beb908ee301c0ef51a
-  data.tar.gz: 23456a3351a981a001f57476bba3815b95c93ce65008189bf1334ae87cf6c0aa57201f897301c8579e0cc9866af10dc2989eb9a58af1aad2c7e63c15d6f05e42
+  metadata.gz: e31bda3acc961a0720c039072a6fe13ed94e0790bed425104d455b239569faebd2cb003827ca518c4935e6a89252e0a5b8d4e9d95a37d82a449e7286f62a1bcb
+  data.tar.gz: 0d0cc478a993d34134c6fc0f5aa9b62275b8d7de8b66df60dc64895fc94accb273356391086beae96e706a1699117217bf89841c58b8f738918fac59b2208e10

data/.github/workflows/opal.yml

@@ -0,0 +1,36 @@
+name: opal
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  boot-file-spec:
+    name: Opal boot file verification
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+      with:
+        submodules: 'recursive'
+
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: '3.3'
+        bundler-cache: true
+
+    - name: Set up Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version: '18'
+
+    - name: Run opal boot file spec
+      # The spec statically verifies that lib/unitsdb/opal.rb is well-formed
+      # (every require resolves to a real file, no Opal-gated entry points
+      # leak in, and the boot file actually compiles under Opal::Builder with
+      # the native-only deps stubbed).
+      run: bundle exec rspec spec/unitsdb/unitsdb_opal_boot_spec.rb

data/.gitignore

@@ -11,3 +11,6 @@
 .rspec_status
 
 Gemfile.lock
+
+# Local-only refactor audit notes — never commit
+TODO*

data/Gemfile

@@ -6,8 +6,9 @@ source "https://rubygems.org"
 gemspec
 
 gem "canon"
-gem "lutaml-model", github: "lutaml/lutaml-model", branch: "fix/global-context-register-lookup-fallback"
+gem "lutaml-model", github: "lutaml/lutaml-model", branch: "main"
 gem "nokogiri"
+gem "opal", "~> 1.8"
 gem "rake"
 gem "rspec"
 gem "rubocop"

data/Rakefile

@@ -3,7 +3,9 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
-RSpec::Core::RakeTask.new(:spec)
+RSpec::Core::RakeTask.new(:spec) do |t|
+  t.pattern = "spec/unitsdb/**/*_spec.rb"
+end
 
 require "rubocop/rake_task"
 

data/lib/unitsdb/cli.rb

@@ -1,20 +1,9 @@
 # frozen_string_literal: true
 
 require "thor"
-require "fileutils"
 
 module Unitsdb
-  class Cli < Thor
-    # Enable --trace globally for all subcommands
-    # When enabled, Thor shows full backtraces on error
-    class_option :trace, type: :boolean, default: false,
-                         desc: "Show full backtrace on error"
-
-    # Fix Thor deprecation warning
-    def self.exit_on_failure?
-      true
-    end
-
+  class Cli < Unitsdb::Commands::Thor
     desc "ucum SUBCOMMAND", "UCUM-related commands"
     subcommand "ucum", Commands::UcumCommand
 
@@ -41,7 +30,7 @@ module Unitsdb
                       desc: "Path to UnitsDB database (required)"
 
     def search(query)
-      run_command(Commands::Search, :run, query)
+      run_command(Commands::Search, options, query, method: :run)
     end
 
     desc "get ID", "Get detailed information about an entity by ID"
@@ -52,7 +41,7 @@ module Unitsdb
     option :database, type: :string, required: true, aliases: "-d",
                       desc: "Path to UnitsDB database (required)"
     def get(id)
-      run_command(Commands::Get, :get, id)
+      run_command(Commands::Get, options, id, method: :get)
     end
 
     desc "check_si",
@@ -71,7 +60,7 @@ module Unitsdb
                       desc: "Path to UnitsDB database (required)"
 
     def check_si
-      run_command(Commands::CheckSiCommand, :run)
+      run_command(Commands::CheckSiCommand, options)
     end
 
     desc "release", "Create release files (unified YAML and/or ZIP archive)"
@@ -84,32 +73,7 @@ module Unitsdb
     option :database, type: :string, required: true, aliases: "-d",
                       desc: "Path to UnitsDB database (required)"
     def release
-      run_command(Commands::Release, :run)
-    end
-
-    private
-
-    def run_command(command_class, method, *args)
-      command = command_class.new(options)
-      command.send(method, *args)
-    rescue Unitsdb::Errors::CLIRuntimeError => e
-      handle_cli_error(e)
-    rescue StandardError => e
-      handle_error(e)
-    end
-
-    def handle_cli_error(error)
-      raise error if debugging?
-
-      warn "Error: #{error.message}"
-      exit 1
-    end
-
-    def handle_error(error)
-      raise error if debugging?
-
-      warn "Error: #{error.message}"
-      exit 1
+      run_command(Commands::Release, options)
     end
   end
 end

data/lib/unitsdb/commands/_modify.rb

@@ -4,11 +4,7 @@ require "thor"
 
 module Unitsdb
   module Commands
-    class ModifyCommand < Thor
-      # Inherit trace option from parent CLI
-      class_option :trace, type: :boolean, default: false,
-                           desc: "Show full backtrace on error"
-
+    class ModifyCommand < Unitsdb::Commands::Thor
       desc "normalize INPUT OUTPUT",
            "Normalize a YAML file or all YAML files with --all"
       method_option :sort, type: :string,
@@ -23,35 +19,6 @@ module Unitsdb
 
       def normalize(input = nil, output = nil)
         run_command(Normalize, options, input, output)
-      rescue Unitsdb::Errors::CLIRuntimeError => e
-        handle_cli_error(e)
-      rescue StandardError => e
-        handle_error(e)
-      end
-
-      private
-
-      def run_command(command_class, options, *args)
-        command = command_class.new(options)
-        command.run(*args)
-      end
-
-      def handle_cli_error(error)
-        if options[:trace]
-          raise error
-        else
-          warn "Error: #{error.message}"
-          exit 1
-        end
-      end
-
-      def handle_error(error)
-        if options[:trace]
-          raise error
-        else
-          warn "Error: #{error.message}"
-          exit 1
-        end
       end
     end
   end

data/lib/unitsdb/commands/check_si/si_formatter.rb

@@ -238,7 +238,7 @@ module Unitsdb
             matches.each do |match|
               db_entity = match[:db_entity]
               entity_id = match[:entity_id] || db_entity.short
-              entity_name = db_entity.respond_to?(:names) ? db_entity.names&.first : "unnamed"
+              entity_name = db_entity.names.first || "unnamed"
               si_suffix = SiTtlParser.extract_identifying_suffix(match[:ttl_uri])
 
               ttl_label = match[:ttl_entity] ? (match[:ttl_entity][:label] || match[:ttl_entity][:name]) : "Unknown"
@@ -279,7 +279,7 @@ module Unitsdb
               # Get match description if available
               entity_id = match[:db_entity].short
               match_pair_key = "#{entity_id}:#{ttl_entities.first[:uri]}"
-              match_details = Unitsdb::Commands::CheckSi::SiMatcher.instance_variable_get(:@match_details)&.dig(match_pair_key)
+              match_details = Unitsdb::Commands::CheckSi::SiMatcher.match_details&.dig(match_pair_key)
               match_desc = match_details[:match_desc] if match_details && match_details[:match_desc]
 
               # Symbol matches and partial matches should always be potential matches
@@ -301,7 +301,7 @@ module Unitsdb
               exact_matches.each do |match|
                 db_entity = match[:db_entity]
                 entity_id = match[:entity_id] || db_entity.short
-                entity_name = db_entity.respond_to?(:names) ? db_entity.names&.first : "unnamed"
+                entity_name = db_entity.names.first || "unnamed"
 
                 # Handle multiple TTL entities in a single row
                 ttl_entities = match[:ttl_entities]
@@ -347,7 +347,7 @@ module Unitsdb
 
                 # Get match details for this match
                 match_pair_key = "#{db_entity.short}:#{ttl_entities.first[:uri]}"
-                match_details = Unitsdb::Commands::CheckSi::SiMatcher.instance_variable_get(:@match_details)&.dig(match_pair_key)
+                match_details = Unitsdb::Commands::CheckSi::SiMatcher.match_details&.dig(match_pair_key)
 
                 # Format match info
                 match_info = ""
@@ -377,7 +377,7 @@ module Unitsdb
               potential_matches.each do |match|
                 db_entity = match[:db_entity]
                 entity_id = match[:entity_id] || db_entity.short
-                entity_name = db_entity.respond_to?(:names) ? db_entity.names&.first : "unnamed"
+                entity_name = db_entity.names.first || "unnamed"
 
                 # Handle multiple TTL entities in a single row
                 ttl_entities = match[:ttl_entities]
@@ -423,7 +423,7 @@ module Unitsdb
 
                 # Get match details
                 match_pair_key = "#{db_entity.short}:#{ttl_entities.first[:uri]}"
-                match_details = Unitsdb::Commands::CheckSi::SiMatcher.instance_variable_get(:@match_details)&.dig(match_pair_key)
+                match_details = Unitsdb::Commands::CheckSi::SiMatcher.match_details&.dig(match_pair_key)
 
                 # Format match info
                 match_info = ""