unit_record 0.4.1 → 0.9.0

data/lib/unit_record/association_stubbing.rb

@@ -0,0 +1,39 @@
+module UnitRecord
+  module AssociationStubbing
+    
+    private
+    
+    def initialize_with_association_stubbing(attributes = {})
+      attributes ||= {}
+      associations = extract_associations attributes
+      initialize_without_association_stubbing attributes
+      stub_associations associations
+    end
+    
+    protected
+  
+    def extract_associations(attributes = {})
+      attributes.inject({}) do |associations,(attr,value)|
+        next associations unless self.class.reflections.keys.include? attr
+        unless value.is_a?(self.class.reflections[attr].klass)
+          associations[attr] = attributes.delete attr
+        end
+        associations
+      end
+    end
+  
+    def stub_associations(associations = {})
+      associations.each do |attr,value|
+        self.stubs(attr).returns(value)
+      end
+    end
+
+    def self.included(klass)
+      klass.class_eval do
+        unless (instance_methods + private_instance_methods).include?("initialize_without_association_stubbing")
+          alias_method_chain :initialize, :association_stubbing
+        end
+      end
+    end
+  end
+end

data/lib/unit_record/column_extension.rb

@@ -1,5 +1,16 @@
 module UnitRecord
   module ColumnExtension
+    def self.included(base)
+      base.class_eval do
+        alias_method_chain :simplified_type, :boolean
+      end
+    end
+    
+    def simplified_type_with_boolean(field_type)
+      return :boolean if field_type.to_s.downcase.index("tinyint(1)")
+      simplified_type_without_boolean field_type
+    end
+
     def ==(other)
       other && instance_variables.all? { |ivar| instance_variable_get(ivar) == other.instance_variable_get(ivar) }
     end

data/lib/unit_record/disconnected_active_record.rb

@@ -1,43 +1,21 @@
 module UnitRecord
   module DisconnectedActiveRecord
     def disconnected?
-      false
+      connected? && connection.is_a?(ActiveRecord::ConnectionAdapters::UnitRecordAdapter)
     end
-    def disconnect!
+
+    def disconnect!(options = {})
       return if disconnected?
-      (class << self; self; end).class_eval do
-        def cache
-          yield
-        end
-        
-        def cached_columns
-          @@_cached_columns ||= {}
-        end
-        
-        def columns
-          cached_columns[table_name] ||
-           raise("Columns are not cached for '#{table_name}' - check schema.rb")
-        end
-        
-        def connection
-          raise "(from #{to_s}): ActiveRecord is disconnected; database access is unavailable in unit tests."
-        end
-        
-        def connected?
-          false
-        end
-        
-        def disconnected?
-          true
-        end
-        
-        def table_exists?
-          true
-        end
+      establish_connection options.merge(:adapter => "unit_record")
+      if options[:stub_associations]
+        ActiveRecord::Base.send :include, UnitRecord::AssociationStubbing
       end
       Fixtures.disconnect!
       Test::Unit::TestCase.disconnect!
-      ColumnCacher.cache(RAILS_ROOT + "/db/schema.rb")
+      ActiveRecord::Migration.verbose = false
+      ActiveRecord::Base.connection.change_strategy(:noop) do
+        load(RAILS_ROOT + "/db/schema.rb")
+      end
     end
   end
 end

data/lib/unit_record/disconnected_test_case.rb

@@ -2,6 +2,12 @@ module UnitRecord
   module DisconnectedTestCase
     def disconnect!
       self.use_transactional_fixtures = false
+      
+      class_eval do
+        def self.fixtures(*args)
+          raise "Fixtures cannot be used with UnitRecord. ActiveRecord is disconnected; database access is unavailable in unit tests."
+        end
+      end
     end
   end
 end

data/test/active_record/connection_adapters/unit_record_adapter_test.rb

@@ -0,0 +1,103 @@
+require File.dirname(__FILE__) + "/../../test_helper"
+
+functional_tests do
+
+  test "reconnect works" do
+    ActiveRecord::Base.connection.reconnect!
+    assert_kind_of ActiveRecord::ConnectionAdapters::UnitRecordAdapter,
+      ActiveRecord::Base.connection
+  end
+
+  test "find(:all)" do
+    ActiveRecord::Base.connection.change_strategy(:raise) do
+      assert_raises(RuntimeError) { Person.find(:all) }
+    end
+    ActiveRecord::Base.connection.change_strategy(:noop) do
+      assert_equal [], Person.find(:all)
+    end
+  end
+  
+  test "execute raises an exception" do
+    assert_raises_disconnected_exception do
+      ActiveRecord::Base.connection.execute "SELECT 1"
+    end
+  end
+  
+  test "select_rows raises an exception" do
+    assert_raises_disconnected_exception do
+      ActiveRecord::Base.connection.select_rows "SELECT * FROM people"
+    end
+  end
+
+  test "select raises an exception" do
+    assert_raises_disconnected_exception do
+      ActiveRecord::Base.connection.send :select, "SELECT * FROM people"
+    end
+  end
+  
+  test "rename_table raises an exception" do
+    assert_raises_disconnected_exception do
+      ActiveRecord::Base.connection.rename_table "people", "persons"
+    end
+  end
+
+  test "change_column raises an exception" do
+    assert_raises_disconnected_exception do
+      ActiveRecord::Base.connection.change_column "people", "first_name", :string, :null => false
+    end
+  end
+
+  test "change_column_default raises an exception" do
+    assert_raises_disconnected_exception do
+      ActiveRecord::Base.connection.change_column_default "people", "first_person", "george"
+    end
+  end
+
+  test "rename_column raises an exception" do
+    assert_raises_disconnected_exception do
+      ActiveRecord::Base.connection.rename_column "people", "first_name", "name_first"
+    end
+  end
+
+  test "insert raises an exception" do
+    assert_raises_disconnected_exception do
+      ActiveRecord::Base.connection.rename_column "people", "first_name", "name_first"
+    end
+  end
+  
+  test "initialize can set strategy" do
+    ActiveRecord::Base.establish_connection :adapter => "unit_record", :strategy => :noop
+    assert_nil ActiveRecord::Base.connection.execute("SELECT 1")
+    ActiveRecord::Base.establish_connection :adapter => "unit_record", :strategy => :raise
+    assert_raises(RuntimeError) { ActiveRecord::Base.connection.execute("SELECT 1") }
+  end
+
+  test "noop" do
+    ActiveRecord::Base.connection.change_strategy(:noop) do
+      assert_nil ActiveRecord::Base.connection.execute("SELECT 1")
+      assert_nil ActiveRecord::Base.connection.insert("INSERT INTO ...")
+      assert_equal [], ActiveRecord::Base.connection.select_rows("SELECT * FROM people")
+      assert_equal [], ActiveRecord::Base.connection.send(:select, "SELECT * FROM people")
+      assert_nil ActiveRecord::Base.connection.rename_table("people", "persons")
+      assert_nil ActiveRecord::Base.connection.change_column("people", "first_name", :string, :null => false)
+      assert_nil ActiveRecord::Base.connection.change_column_default("people", "first_person", "george")
+      assert_nil ActiveRecord::Base.connection.rename_column("people", "first_name", "name_first")
+    end
+  end
+  
+  test "change_strategy raises if invalid strategy" do
+    assert_nothing_raised { ActiveRecord::Base.connection.change_strategy(:noop) {} }
+    assert_nothing_raised { ActiveRecord::Base.connection.change_strategy(:raise) {} }
+    assert_raises(ArgumentError) { ActiveRecord::Base.connection.change_strategy(:bogus) {} }
+  end
+
+  def assert_raises_disconnected_exception(&block)
+    exception = nil
+    begin
+      yield
+    rescue Exception => exception
+    end
+    assert_not_nil exception
+    assert_equal "ActiveRecord is disconnected; database access is unavailable in unit tests.", exception.message    
+  end
+end

data/test/db/schema.rb

@@ -9,6 +9,15 @@ ActiveRecord::Schema.define(:version => 0) do
     t.column :last_name,  :string
   end
   
+  create_table "profiles", :force => true do |t|
+    t.column "description", :string
+    t.column "person_id", :integer
+  end
+  
+  create_table :pets, :force => true do |t|
+    t.column :name, :string
+  end
+  
   create_table :foofoo, :force => true do |t|
     t.column :bar, :string
   end

data/test/sample_spec.rb

@@ -0,0 +1,40 @@
+require "rubygems"
+gem "rspec", "1.1.11"
+require "test/unit"
+require "spec"
+
+$:.unshift(File.dirname(__FILE__) + '/../lib')
+
+RAILS_ROOT = File.dirname(__FILE__)
+
+if rails_version = ENV['RAILS_VERSION']
+  gem "rails", rails_version
+end
+require "rails/version"
+puts "==== Testing with Rails #{Rails::VERSION::STRING} ===="
+require 'active_record'
+require 'active_record/fixtures'
+require "action_controller"
+require "action_controller/test_process"
+
+require "unit_record"
+
+# Needed because of this line in setup_with_fixtures and teardown_with_fixtures:
+#   return unless defined?(ActiveRecord::Base) && !ActiveRecord::Base.configurations.blank?
+ActiveRecord::Base.configurations = {"irrelevant" => {:adapter => "stub"}}
+
+ActiveRecord::Base.disconnect! :strategy => :raise, :stub_associations => true
+
+describe UnitRecord do
+  it "disconnects tests from the database" do
+    lambda do
+      ActiveRecord::Base.connection.select_value("SELECT 1")
+    end.should raise_error
+  end
+
+  it "can change strategy to noop" do
+    ActiveRecord::Base.connection.change_strategy(:noop) do
+      ActiveRecord::Base.connection.select_value("SELECT 1").should == nil
+    end
+  end
+end

data/test/test_helper.rb

@@ -1,3 +1,5 @@
+unless defined?(TEST_HELPER_LOADED)
+TEST_HELPER_LOADED = true
 $:.unshift(File.dirname(__FILE__) + '/../lib')
 RAILS_ROOT = File.dirname(__FILE__)
 
@@ -8,6 +10,7 @@ if rails_version = ENV['RAILS_VERSION']
   gem "rails", rails_version
 end
 require "rails/version"
+puts "==== Testing with Rails #{Rails::VERSION::STRING} ===="
 require 'active_record'
 require 'active_record/fixtures'
 require "action_controller"
@@ -17,14 +20,17 @@ end
 require "action_controller/test_process"
 
 begin
+  gem "mocha"
   require 'mocha'
-  require 'dust'
-rescue LoadError
-  raise "Need Mocha and Dust gems to Test"
+rescue LoadError, Gem::LoadError
+  raise "need mocha to test"
 end
+$LOAD_PATH << File.dirname(__FILE__) + "/../vendor/dust-0.1.6/lib"
+require 'dust'
 Test::Unit::TestCase.disallow_setup!
 
-require "#{File.dirname(__FILE__)}/../init"
+$LOAD_PATH << File.dirname(__FILE__) + "/../lib"
+require "unit_record"
 
 Test::Unit::TestCase.use_transactional_fixtures = true
 
@@ -34,11 +40,29 @@ ActiveRecord::Base.configurations = {"irrelevant" => {:adapter => "stub"}}
 
 class Preference < ActiveRecord::Base
 end
+
 class Person < ActiveRecord::Base
+  has_many :pets
+  has_one :profile
+end
+
+class Profile < ActiveRecord::Base
+  belongs_to :person
+end
+
+class Pet < ActiveRecord::Base
+  belongs_to :person
 end
+
 class Foo < ActiveRecord::Base
   set_table_name :foofoo
 end
+
 class DoesNotExist < ActiveRecord::Base
   set_table_name "table_does_not_exist"
 end
+
+ActiveRecord::Base.disconnect! :strategy => :raise, :stub_associations => true
+# make sure calling disconnect multiple times does not cause problems
+ActiveRecord::Base.disconnect! :strategy => :raise, :stub_associations => true
+end

data/test/unit_record/association_stubbing_test.rb

@@ -0,0 +1,37 @@
+require File.dirname(__FILE__) + "/../test_helper"
+
+functional_tests do
+  
+  test "stubbing a has_many" do
+    pets = [stub, stub]
+    person = Person.new :pets => pets
+    assert_equal pets, person.pets
+  end
+  
+  test "stubbing a belongs_to" do
+    person = stub
+    pet = Pet.new :person => person
+    assert_equal person, pet.person
+  end
+  
+  test "using correct classes does not stub" do
+    person = Person.new(:first_name => "Dan")
+    pet = Pet.new :person => person
+    pet.person = Person.new(:first_name => "Tom")
+    assert_equal "Tom", pet.person.first_name
+  end
+
+  test "using other than correct classes does stub" do
+    person = Object.new
+    def person.first_name; "Dan"; end
+    pet = Pet.new :person => person
+    pet.person = Person.new(:first_name => "Tom")
+    assert_equal "Dan", pet.person.first_name
+  end
+  
+  test "multiple includes doesn't hurt" do
+    ActiveRecord::Base.send :include, UnitRecord::AssociationStubbing
+    Person.new
+  end
+  
+end

data/test/unit_record/column_cacher_test.rb

@@ -0,0 +1,26 @@
+require File.dirname(__FILE__) + "/../test_helper"
+
+functional_tests do
+  test "caching columns with no defaults or not nulls" do
+    expected = [
+      ActiveRecord::ConnectionAdapters::Column.new("id", nil, "int(11) DEFAULT NULL auto_increment PRIMARY KEY", nil),
+      ActiveRecord::ConnectionAdapters::Column.new("first_name", nil, "varchar(255)", nil),
+      ActiveRecord::ConnectionAdapters::Column.new("last_name", nil, "varchar(255)", nil)
+    ]
+    expected[0].primary = true
+    expected[1..-1].each { |column| column.primary = false }
+    assert_equal expected, Person.columns
+  end
+  
+  test "caching column with default" do
+    expected = ActiveRecord::ConnectionAdapters::Column.new("show_help", true, "tinyint(1)", nil)
+    expected.primary = false
+    assert_equal expected, Preference.columns.detect { |c| c.name == "show_help" }
+  end
+  
+  test "boolean columns" do
+    expected = ActiveRecord::ConnectionAdapters::Column.new("show_help", true, "tinyint(1)", nil)
+    expected.primary = false
+    assert_equal :boolean, Preference.columns.detect { |c| c.name == "show_help" }.type
+  end
+end

data/test/{unit → unit_record}/column_extension_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/unit_test_helper"
+require File.dirname(__FILE__) + "/../test_helper"
 
 unit_tests do
   test "equality" do

data/test/{functional → unit_record}/column_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/functional_test_helper"
+require File.dirname(__FILE__) + "/../test_helper"
 
 functional_tests do
   test "instantiating" do

data/test/{functional → unit_record}/controller_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/functional_test_helper'
+require File.dirname(__FILE__) + '/../test_helper'
 
 class SampleController < ActionController::Base
   def sample_action

data/test/unit_record/disconnected_active_record_test.rb

@@ -0,0 +1,52 @@
+require File.dirname(__FILE__) + "/../test_helper"
+
+functional_tests do  
+  test "find_by_sql gives disconnected exception message" do
+    exception = nil
+    begin
+      Person.find_by_sql "SELECT * FROM people"
+    rescue => exception
+    end
+    assert_not_nil exception
+    assert_equal "ActiveRecord is disconnected; database access is unavailable in unit tests.", exception.message
+  end
+  
+  test "connected? is true" do
+    assert_equal true, ActiveRecord::Base.connected?
+  end
+  
+  test "disconnected? is true" do
+    assert_equal true, ActiveRecord::Base.disconnected?
+  end
+  
+  test "inspect does not blow up" do
+    assert_nothing_raised { Person.inspect }
+  end
+  
+  test "table_exists?" do
+    assert_equal true, Person.table_exists?
+    if ActiveRecord::Base.connection.respond_to?(:table_exists?)
+      assert_equal false, ActiveRecord::Base.connection.table_exists?("bogus_table")
+    end
+  end
+  
+  test "setting a has_one association" do
+    person = Person.new
+    person.profile = Profile.new
+  end
+  
+  test "boolean columns do type casting" do
+    pref = Preference.new
+    pref.show_help = "0"
+    assert_equal false, pref.send(:read_attribute, :show_help)
+    assert_equal false, pref.show_help
+    assert_equal false, pref.show_help?
+    pref.show_help = "1"
+    assert_equal true, pref.show_help
+    assert_equal true, pref.show_help?
+  end
+  
+  test "migrations are not verbose" do
+    assert_equal false, ActiveRecord::Migration.verbose
+  end
+end