unique_validation_inspector 0.1.3 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 46a8e208afca114d0cf07b514a54fb91bc0f9d02
-  data.tar.gz: b34defca8e956fd5a338cc38c8bd5684243e5f30
+  metadata.gz: 657d8b8f263904dcf7ddc6bd423c28de265fe5e0
+  data.tar.gz: f1a2ddead37ddd750d97ed91c7831937263917f6
 SHA512:
-  metadata.gz: ed84da62e136620b773e90f2658beb41b697d6cd899030d86d282a41b3dd58e3f516f3e1540b901281f947604122a194de4715cc72270c46189476c10400c392
-  data.tar.gz: a8c57932bc049e372ed622320c90c5fdd02f1a4c870eb56cede6513c394fadbf85bb965501de5d7da12f49c525c9f1def18e0c7bceff85f21d3c66b9375993a3
+  metadata.gz: b1b2d0d481f3d1d0e156ee6de7a913363a98c76e05a4c7fc93078471ad25a3da2d651fcd3a0c73e838d0dd58916e14119b907a8578df96d2d576ae80d347fdb5
+  data.tar.gz: 72ce6e1f88ffeef1d9ea43d68df50226e7885c0c7d83461d0acc0da75f5912d4c60dc1c7793d2ff64a8614b9a4980aff1c612f93fdb876c72babfc134d60b3d8

data/lib/tasks/inspect_unique_validations.rake

@@ -6,19 +6,44 @@ task :inspect_unique_validations => :environment do
   defined_unique_validations = inspector.defined_unique_validations
 
   puts
-  puts "You have the following unique validations:"
 
-  defined_unique_validations.each do |item|
-    model = item[:model]
+  if defined_unique_validations.any?
+    puts "You have the following unique validations:"
+
+    have_at_least_one_issue = false
+
+    defined_unique_validations.each do |item|
+      model = item[:model]
+      puts
+      puts "Model '#{model.name}':"
+      item[:validators].each do |validation|
+        scope = validation.options[:scope]
+        attributes = validation.attributes
+        index_exists = inspector.defined_unique_indexes(model.table_name, attributes, scope)
+        have_at_least_one_issue = true unless index_exists
+        message = "#{attributes}"
+        message += " (scope '#{scope}')" if scope
+        message += ". Index exists: #{index_exists}."
+        puts message
+      end
+    end
+
     puts
-    puts "Model '#{model.name}':"
-    item[:validators].each do |validation|
-      scope = validation.options[:scope]
-      attributes = validation.attributes
-      index_exists = inspector.defined_unique_indexes(model.table_name, attributes, scope)
-      puts "#{attributes} (scope '#{scope}'). Index exists: #{index_exists}"
+
+    if have_at_least_one_issue
+      puts "Consider use one of the following solutions to resolve above issues:\n"
+      puts "#1. Add proper DB index.\n"
+      puts "#2. Move unique validation to DB level.\n"
+      puts "More info in the article https://medium.com/@igorkhomenko/rails-make-sure-you-have-proper-db-indexes-for-your-models-unique-validations-ffd0364df26f"
+    else
+      puts "Congrats! You do not have any issues with your unique validations - all the indexes are fine!\n"
+      puts "Quick recommendation: you may consider move unique validations to DB level.\n"
+      puts "More info in the article https://medium.com/@igorkhomenko/rails-make-sure-you-have-proper-db-indexes-for-your-models-unique-validations-ffd0364df26f"
     end
+  else
+    puts "You do not have any unique validations in your project so you are fine."
   end
+
   puts
 
 end

data/lib/unique_validation_inspector/version.rb

@@ -1,3 +1,3 @@
 module UniqueValidationInspector
-  VERSION = "0.1.3"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unique_validation_inspector
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.0
 platform: ruby
 authors:
 - Igor Khomenko
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-08-23 00:00:00.000000000 Z
+date: 2017-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails