uniform_notifier 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 169bfc94c2eacda49ee03c204a9d6533ac8d24e5
-  data.tar.gz: eda7a77778c26b9875d48807b712eb112a7fdfda
+  metadata.gz: 61cb8e4a13116e9f516f1ce964bc97b9113e60f9
+  data.tar.gz: 9a6779d8bf219015cf5d14c69394d0cc525224be
 SHA512:
-  metadata.gz: 9c13344e390f5bc8df51048af5baf7618279e8dfc4210a6ce922c950ccdab8cd983769cfb055a8b7c1a32991936ddbebe013c04d69a16887b171794d479d96bc
-  data.tar.gz: 78e83f46ab990bf1933a00dac4a97c8cfaae2ca45c2f8ac619dead742951e4c29df2f05adbb272c9e68397ddc334a570a8173ba0f9ddb3f5ac0251d710744e85
+  metadata.gz: b3390be5ee6e2eda38b9e575ac012c7417763b708be2d4dba1979a9adfdccabd7d81d5e4a6dea8c1e04088a2e10d5afea663838dd31273494ee16faba73a3690
+  data.tar.gz: d14fdb5871e395efcb08a8b172e172d1028dc51821f4243f86c391a533e0bad9e4ab28bb0da6d8a3aed70a72d9bb61ca17b1646494687d33c52c880fb383fb97

data/lib/uniform_notifier.rb

@@ -16,7 +16,7 @@ module UniformNotifier
   class <<self
     attr_accessor :alert, :console, :growl, :rails_logger, :xmpp, :airbrake, :bugsnag, :raise
 
-    NOTIFIERS = [JavascriptAlert, JavascriptConsole, Growl, Xmpp, RailsLogger, CustomizedLogger, AirbrakeNotifier, Raise]
+    NOTIFIERS = [JavascriptAlert, JavascriptConsole, Growl, Xmpp, RailsLogger, CustomizedLogger, AirbrakeNotifier, BugsnagNotifier, Raise]
 
     def active_notifiers
       NOTIFIERS.select { |notifier| notifier.active? }

data/lib/uniform_notifier/bugsnag.rb

@@ -7,15 +7,16 @@ module UniformNotifier
     protected
 
     def self._out_of_channel_notify(data)
-      message = data.values.compact.join("\n")
-
       opt = {}
       if UniformNotifier.bugsnag.is_a?(Hash)
         opt = UniformNotifier.bugsnag
       end
 
-      exception = Exception.new(message)
-      Bugsnag.notify(exception, opt)
+      exception = Exception.new(data[:title])
+      Bugsnag.notify(exception, opt.merge(
+        :grouping_hash => data[:body] || data[:title],
+        :notification => data,
+      ))
     end
   end
 end

data/lib/uniform_notifier/version.rb

@@ -1,3 +1,3 @@
 module UniformNotifier
-  VERSION = "1.6.0"
+  VERSION = "1.6.1"
 end

data/spec/uniform_notifier/bugsnag_spec.rb

@@ -5,21 +5,43 @@ class Bugsnag
 end
 
 describe UniformNotifier::BugsnagNotifier do
+  let(:notification_data) { {} }
   it "should not notify bugsnag" do
-    UniformNotifier::BugsnagNotifier.out_of_channel_notify(:title => "notify bugsnag").should be_nil
+    Bugsnag.should_not_receive(:notify)
+    UniformNotifier::BugsnagNotifier.out_of_channel_notify(notification_data)
   end
+  context "with string notification" do
+    let(:notification_data) { {:user => 'user', :title => 'notify bugsnag', :url => 'URL', body: 'something'} }
 
-  it "should notify bugsnag" do
-    Bugsnag.should_receive(:notify).with(UniformNotifier::Exception.new("notify bugsnag"), {})
+    it "should notify bugsnag" do
+      Bugsnag.should_receive(:notify).with(UniformNotifier::Exception.new(notification_data[:title]), :grouping_hash => notification_data[:body], :notification => notification_data)
 
-    UniformNotifier.bugsnag = true
-    UniformNotifier::BugsnagNotifier.out_of_channel_notify(:title => "notify bugsnag")
+      UniformNotifier.bugsnag = true
+      UniformNotifier::BugsnagNotifier.out_of_channel_notify(notification_data)
+    end
+
+    it "should notify bugsnag with option" do
+      Bugsnag.should_receive(:notify).with(UniformNotifier::Exception.new(notification_data[:title]), :foo => :bar, :grouping_hash => notification_data[:body], :notification => notification_data)
+
+      UniformNotifier.bugsnag = { :foo => :bar }
+      UniformNotifier::BugsnagNotifier.out_of_channel_notify(notification_data)
+    end
   end
+  context "with hash notification" do
+    let(:notification_data) { "notify bugsnag" }
+
+    it "should notify bugsnag" do
+      Bugsnag.should_receive(:notify).with(UniformNotifier::Exception.new("notify bugsnag"), :grouping_hash => "notify bugsnag", :notification => {:title => "notify bugsnag"})
+
+      UniformNotifier.bugsnag = true
+      UniformNotifier::BugsnagNotifier.out_of_channel_notify(notification_data)
+    end
 
-  it "should notify bugsnag with option" do
-    Bugsnag.should_receive(:notify).with(UniformNotifier::Exception.new("notify bugsnag"), :foo => :bar)
+    it "should notify bugsnag with option" do
+      Bugsnag.should_receive(:notify).with(UniformNotifier::Exception.new("notify bugsnag"), :foo => :bar, :grouping_hash => "notify bugsnag", :notification => {:title => "notify bugsnag"})
 
-    UniformNotifier.bugsnag = { :foo => :bar }
-    UniformNotifier::BugsnagNotifier.out_of_channel_notify("notify bugsnag")
+      UniformNotifier.bugsnag = { :foo => :bar }
+      UniformNotifier::BugsnagNotifier.out_of_channel_notify(notification_data)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: uniform_notifier
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-30 00:00:00.000000000 Z
+date: 2014-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-growl