unifonic_integration 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e1c947f72ec779398665ace9b3617a827134ce130cac63114be1e4a716080c48
-  data.tar.gz: 0ee6fc7ec4adb5dfcf8505c18d1562f7e4aea011806ef7de64031566fadb4aa7
+  metadata.gz: 1149192ea4eda376f35c9a21836e7bb7bf2edd9d72e7e084ecee7141cff093e0
+  data.tar.gz: '06481f2b30d7477f2cd3549ed6415976c44240c30898fb1ea0ae546062ecd0b0'
 SHA512:
-  metadata.gz: ce15d512face145fef31aaf2aa0084ca82ecaccd4a7c79d44155693f668c3c015a01897832cd9f6483188a70340d6ee28bbf32c860c9f81cf6046a28f306aa1f
-  data.tar.gz: 3a5b5ebf394c476013633a042da36a02aab263048c9b220dea8533e3c5b2e4ce58735a84935a3c0aa700195c898affc89134bc13a446f3c1caaaa58aecb68ef5
+  metadata.gz: bf6e4c5babd9b0a560fabdcd2898001fdcdc1d426603e2563765a82d72be5235582c064ed9a8530af97e1ef730602a4392014adcb6038ef44cb645c88e38fea0
+  data.tar.gz: 54b199ad447ce3af1b907189ddb7fa1313db64703e597705b5b971f4a0c17fe13f3d10a53ce41b3515866e313dce519d583df16884118ec0de1dec34014ebb9d

data/README.md

@@ -1,8 +1,6 @@
 # UnifonicIntegration
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/unifonic_integration`. To experiment with that code, run `bin/console` for an interactive prompt.
-
-TODO: Delete this and the text above, and describe your gem
+This is an integration with with unifonic SMS API that allow you to send sms messages and scheduled messages
 
 ## Installation
 
@@ -22,7 +20,14 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+    $ rails generate unifonic_integration:install
+
+This Will create a file in config/initializers/unifonic_integration.rb, Edit this file to set your configrations
+
+    $ UnifonicIntegration.configure do |config|
+        config.app_sid = UNIFONIC_APP_SID
+        config.sender_id = UNIFONIC_SENDER_ID
+      end
 
 ## Development
 

data/lib/unifonic_integration/client.rb

@@ -11,15 +11,11 @@ module UnifonicIntegration
 
     def initialize
       @config = UnifonicIntegration.configuration
+      validate_configuration
     end
 
     def send_message(body, recipient)
-
-      unless validate_recipient(recipient)
-        puts "Invalid recipient phone number format. Please provide a valid international format."
-        return
-      end
-
+      validate_recipient(recipient)
       endpoint = '/messages?async=false'
       set_headers
       set_message_params(body, recipient)
@@ -29,16 +25,13 @@ module UnifonicIntegration
     end
 
     def validate_recipient(recipient)
-      cleaned_number = recipient.to_s.gsub(/^(\+|00)/, '')
-      cleaned_number =~ /\A\d+\z/
+      if recipient.to_s.start_with?('+', '00')
+        raise ArgumentError, "Phone number should not start with '+' or '00'."
+      end
     end
 
     def send_scheduled_message(body, recipient, time_scheduled)
-      unless validate_recipient(recipient)
-        puts "Invalid recipient phone number format. Please provide a valid international format."
-        return
-      end
-
+      validate_recipient(recipient)
       endpoint = '/messages/scheduledmessages?async=false'
       set_headers
       set_scheduled_message_params(body, recipient, time_scheduled)
@@ -66,5 +59,13 @@ module UnifonicIntegration
         Recipient: recipient
       }
     end
+    def validate_configuration
+      unless @config.app_sid && @config.sender_id
+        raise ConfigurationError, "UnifonicIntegration gem not properly configured. Please set app_sid and sender_id."
+      end
+    end
   end
+
+class ConfigurationError < StandardError; end
+
 end

data/lib/unifonic_integration/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module UnifonicIntegration
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unifonic_integration
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Omar Elsamahy
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-01-17 00:00:00.000000000 Z
+date: 2024-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -73,7 +73,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.3.7
 signing_key: 
 specification_version: 4
 summary: SMS Unifonic