unifacop 0.66.0.0 → 0.82.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d5a7980e79c4077481c8bbd5d292d05f98972f2d3d7d37a1f61c2a652538d951
-  data.tar.gz: 63ab828942dcc468473956a7c27d92e0b200eac0bfe944d6fbcf85ab9af9029e
+  metadata.gz: dca54e6b4e298b1d08aaa6f9d58cf63190f13fa268711c5ae4571b184aa4b339
+  data.tar.gz: faae672828ccd280f3a34495876a1ca05654fd8afbe519fdeda000ef8a7b01fa
 SHA512:
-  metadata.gz: 2818c39c4cd0489f9a67311906bfa27b80e8d8ddf381be5345b4f506fd3bda00d71e742e7bc96e95893309f25b9678a18007b9daa89afe10841b19adbf3a2572
-  data.tar.gz: 7e650ea64ee2ab2f7ae9fd6c5db1cb97be6f7541f28c12ca231c44aa54b5b78c078c689361b8b10c071c599c259aa2418938a4e3faa0e81b686cadf9860ac014
+  metadata.gz: 8da3a4c78e7e385bf7072ae77fa9ec41f2a8f6d1741eb636a1e50e9c1fbfd962fce3389ae01c108df29f5577dcb2b5e8c567d22c9f424015f480920130aac261
+  data.tar.gz: 5b28d2f65126b4075932c0546264326529f97f95e69fb4c1bce3c3443efd5c022eec5e86dc73b45b63d8919dd4c7a1be456e7d93c1d7938f0a36c8e2a7b498d8

data/config/performance.yml

@@ -0,0 +1,10 @@
+require: 'rubocop-performance'
+
+## Performance
+# https://github.com/rubocop-hq/rubocop-performance/blob/master/manual/cops_performance.md
+
+# onkcop参照
+# > downcase or upcase しての比較はイディオムの域なので、多少の
+# > パフォーマンスの違いがあろうが casecmp に変える意義を感じない
+Performance/Casecmp:
+  Enabled: false

data/config/rails.yml

@@ -1,3 +1,5 @@
+require: 'rubocop-rails'
+
 Rails:
   Enabled: true
 

data/config/rubocop.yml

@@ -19,12 +19,6 @@ AllCops:
 ## Layout cops
 #  https://rubocop.readthedocs.io/en/latest/cops_layout/
 
-# Does not allow both table and key alignment
-# From v0.70.0 there are more configuration
-# options it so could be used
-Layout/AlignHash:
-  Enabled: false
-
 # ユニファの既存コードを見ると「leading」が多いため、こちらに統一する。
 Layout/DotPosition:
   Enabled: true
@@ -38,15 +32,31 @@ Layout/EmptyLinesAroundArguments:
 # > special_inside_parentheses (default) と比べて
 # > * 横に長くなりづらい
 # > * メソッド名の長さが変わったときに diff が少ない
-Layout/IndentArray:
+Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 
 # onkcop参照
 # > ({ と hash を開始した場合に ( の位置にインデントさせる
 # > そもそも {} が必要ない可能性が高いが Style/BracesAroundHashParameters はチェックしないことにしたので
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
 
+# Allow both table and key hash alignment
+Layout/HashAlignment:
+  EnforcedColonStyle:
+    - key
+    - table
+  EnforcedHashRocketStyle:
+    - key
+    - table
+
+# 多くのRubyコーディング規約では「80」か「100」が主流な値であった。
+# 「80」だと厳しすぎるので、「100」に設定する。
+Layout/LineLength:
+  Max: 100
+  Exclude:
+    - 'db/migrate/*.rb'
+
 # onkcop参照
 # > メソッドチェーン感がより感じられるインデントにする
 # 個人的にもこの形式の方が、上の行とのつながりを感じられるのでいいと思う。
@@ -58,6 +68,9 @@ Layout/MultilineMethodCallIndentation:
 Layout/RescueEnsureAlignment:
   Enabled: false
 
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
 ## Lint cops
 #  https://rubocop.readthedocs.io/en/latest/cops_lint/
 
@@ -95,6 +108,12 @@ Lint/EmptyWhen:
 Lint/InheritException:
   EnforcedStyle: standard_error
 
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
 # キーワード引数の先頭に「_」をつけてしまうと、呼び出し側で「_」をつけて呼ばないとキーが存在せずエラーになってしまうため。
 Lint/UnusedMethodArgument:
   AllowUnusedKeywordArguments: true
@@ -137,13 +156,6 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Max: 10
 
-# 多くのRubyコーディング規約では「80」か「100」が主流な値であった。
-# 「80」だと厳しすぎるので、「100」に設定する。
-Metrics/LineLength:
-  Max: 100
-  Exclude:
-    - 'db/migrate/*.rb'
-
 # onkcop参照
 # > 20 行超えるのは migration ファイル以外滅多に無い
 Metrics/MethodLength:
@@ -167,27 +179,23 @@ Metrics/PerceivedComplexity:
 ## Naming
 #  http://rubocop.readthedocs.io/en/latest/cops_naming/
 
+# Allow short method param names like e or _
+Naming/MethodParameterName:
+  Enabled: false
+
 # onkcop参照
 # > has_ から始まるメソッドは許可する
 Naming/PredicateName:
-  NamePrefixBlacklist:
+  ForbiddenPrefixes:
     - 'is_'
     - 'have_'
   NamePrefix:
     - 'is_'
     - 'have_'
 
-# Allow short method param names like e or _
-Naming/UncommunicativeMethodParamName:
-  Enabled: false
-
-## Performance
-#  https://rubocop.readthedocs.io/en/latest/cops_performance/
-
-# onkcop参照
-# > downcase or upcase しての比較はイディオムの域なので、多少の
-# > パフォーマンスの違いがあろうが casecmp に変える意義を感じない
-Performance/Casecmp:
+# This limits variable name exceptions
+# Can be set on a per project basis if needed
+Naming/RescuedExceptionsVariableName:
   Enabled: false
 
 ## Security
@@ -221,11 +229,6 @@ Style/BlockDelimiters:
   Exclude:
     - 'spec/**/*'
 
-# onkcop参照
-# > option 等、明示的にハッシュにした方が分かりやすい場合もある
-Style/BracesAroundHashParameters:
-  Enabled: false
-
 # onkcop参照
 # > scope が違うとか親 module の存在確認が必要とかデメリットはあるが、
 # > namespace 付きのクラスはかなり頻繁に作るので簡単に書きたい。
@@ -278,6 +281,9 @@ Style/EmptyMethod:
 Style/Encoding:
   Enabled: true
 
+Style/ExponentialNotation:
+  Enabled: true
+
 # onkcop参照
 # > strftime("%Y%m%d") の %d で引っかかる false positive がある。
 # > また、url escape でも引っかかるらしい。
@@ -293,6 +299,17 @@ Style/FormatStringToken:
 Style/GuardClause:
   MinBodyLength: 5
 
+# Both .each_key and .keys.each are readable
+# and have different return values
+Style/HashEachMethods:
+  Enabled: false
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
 # onkcop参照
 # > rake タスクの順序の hash は rocket を許可する。
 Style/HashSyntax:

data/lib/unifacop/cli.rb

@@ -27,7 +27,7 @@ module UniFaCop
       return nil if args.empty?
 
       meth = args.first.to_s
-      args.shift if meth !~ /^\-/
+      args.shift unless /^\-/.match?(meth)
     end
 
     def self.print_help
@@ -35,7 +35,7 @@ module UniFaCop
       puts '  init - Setup .rubocop.yml'
     end
 
-    CONFIG_FILE_NAME = '.rubocop.yml'.freeze
+    CONFIG_FILE_NAME = '.rubocop.yml'
 
     def init(args)
       raise 'usage: unifacop init' unless args.empty?

data/lib/unifacop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module UniFaCop
-  VERSION = '0.66.0.0'.freeze
+  VERSION = '0.82.0.0'
 end

data/templates/.rubocop.yml

@@ -1,9 +1,10 @@
 inherit_gem:
   unifacop:
     - 'config/rubocop.yml'
+    - 'config/performance.yml'
     # Uncomment if your project uses rails. Do not forget to specify TargetRailsVersion.
     #- 'config/rails.yml'
-    # Uncomment if use rspec cops
+    # Uncomment to use rspec cops
     #- 'config/rspec.yml'
 
 inherit_from:
@@ -12,7 +13,7 @@ inherit_from:
 AllCops:
   # Please specify your Ruby version
   TargetRubyVersion: 2.4
-  # uncomment if use rails cops
+  # Uncomment if using rails cops
   #TargetRailsVersion: 5.0
 
 # Add your project specific configurations here.

data/unifacop.gemspec

@@ -21,10 +21,13 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.2.0'
+  spec.required_ruby_version = '>= 2.4.0'
+
+  spec.add_runtime_dependency 'rubocop', '~> 0.82.0'
+  spec.add_runtime_dependency 'rubocop-performance', '~> 1.5.2'
+  spec.add_runtime_dependency 'rubocop-rails', '~> 2.5.2'
+  spec.add_runtime_dependency 'rubocop-rspec', '>= 1.39.0'
 
-  spec.add_runtime_dependency 'rubocop', '~> 0.66.0'
-  spec.add_runtime_dependency 'rubocop-rspec', '>= 1.35.0'
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unifacop
 version: !ruby/object:Gem::Version
-  version: 0.66.0.0
+  version: 0.82.0.0
 platform: ruby
 authors:
 - UniFa Co. Ltd.
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-05-08 00:00:00.000000000 Z
+date: 2020-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.66.0
+        version: 0.82.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.66.0
+        version: 0.82.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.2
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.5.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.5.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.35.0
+        version: 1.39.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.35.0
+        version: 1.39.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -75,6 +103,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - Gemfile
+- config/performance.yml
 - config/rails.yml
 - config/rspec.yml
 - config/rubocop.yml
@@ -95,7 +124,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="