unidom-price 1.7.4 → 1.7.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: af6155b7fa6b0db7e89984b77185841d4c17cb10
-  data.tar.gz: 65fa87de86bff3302a12c3053af1c7300e21b166
+  metadata.gz: 2a61dafa0005f117a0f8a4399db39e38b378d0dd
+  data.tar.gz: 944c6ec8824681f2017b5d695b6d0730ea1225dc
 SHA512:
-  metadata.gz: 9f536bfcad78f27a142255a382b131a5fbf6e0546086cd9db70a28c89c07027dc63bbb9bb3321086937a83aa17a150eff95310e7922054e880e3ec80dd0c2b3e
-  data.tar.gz: 8f2d5fca12f00cba093737f6da900ee59d19872133162f3af77d228d983787927e4b328864a8535a41dbcbf62762d397c00e02b7d81a643e47c42ca197a03af2
+  metadata.gz: 151fe246663561bab24cb12ec9b8c7d5930e560a971f64f5842dee93f7c2db964f9cce6762de64be3289d633c7752cf42a92d91668474c779846276969383382
+  data.tar.gz: b10a1c96510d2fbf28db596b2d4e4b2012f248727999b6c58533e23250b191cdcb58f654c87a0340419c8136b1136caca705bd5003b0f0a27f085b66e44cb874

data/README.md

@@ -203,7 +203,9 @@ describe Unidom::Product::Product do
     packing_norm:     '1 per 1'
   }
 
-  it_behaves_like 'Unidom::Price::Concerns::AsPriced', model_attribtues
+  pricer = Unidom::Party::Person.create! name: 'Tim'
+
+  it_behaves_like 'Unidom::Price::Concerns::AsPriced', model_attribtues, pricer
 
 end
 ```

data/app/models/unidom/price/concerns/as_priced.rb

@@ -3,20 +3,31 @@
 
 module Unidom::Price::Concerns::AsPriced
 
-  extend ActiveSupport::Concern
+  extend  ActiveSupport::Concern
+  include Unidom::Common::Concerns::ArgumentValidation
 
   included do |includer|
 
     has_many :prices, class_name: 'Unidom::Price::Price', as: :priced
 
     def is_priced!(amount, by: nil, at: Time.now)
+
+      assert_present! :amount, amount
+      assert_present! :by,     by
+      assert_present! :at,     at
+
       pricing = prices.valid_at(now: at).alive.first
       pricing.soft_destroy if pricing.present?
       prices.create! pricer: by, amount: amount, opened_at: at
+
     end
 
     def is_priced?(at: Time.now)
+
+      assert_present! :at, at
+
       prices.valid_at(now: at).alive.exists?
+
     end
 
   end

data/lib/rspec/models/unidom/price/concerns/as_priced_shared_examples.rb

@@ -1,17 +1,69 @@
-shared_examples 'Unidom::Price::Concerns::AsPriced' do |model_attributes|
+shared_examples 'Unidom::Price::Concerns::AsPriced' do |model_attributes, pricer|
 
-  price_1_attribtues = {
-      pricer_id:   SecureRandom.uuid,
-      pricer_type: 'Unidom::Price::Pricer::Mock',
-      amount:      10.00
-    }
+  before :each do
+    @priced = described_class.create! model_attributes
+    @amount = 10.00
+  end
 
-  price_2_attribtues = {
-      pricer_id:   SecureRandom.uuid,
-      pricer_type: 'Unidom::Price::Pricer::Mock',
-      amount:      21.00
-    }
+  after :each do
+  end
 
-  it_behaves_like 'has_many', model_attributes, :prices, Unidom::Price::Price, [ price_1_attribtues, price_2_attribtues ]
+  context '#is_priced!' do
+
+    it 'should reject the amount argument = nil' do expect { @priced.is_priced! nil,     by: pricer, at: Time.now }.to raise_error(ArgumentError, 'The amount argument is required.') end
+    it 'should reject the by argument = nil'     do expect { @priced.is_priced! @amount, by: nil,    at: Time.now }.to raise_error(ArgumentError, 'The by argument is required.')     end
+    it 'should reject the at argument = nil'     do expect { @priced.is_priced! @amount, by: pricer, at: nil      }.to raise_error(ArgumentError, 'The at argument is required.')     end
+
+    it "should be able to be priced by #{pricer.inspect}" do
+      price = @priced.is_priced! @amount, by: pricer
+      expect(price).to     be_present
+      expect(price).to     be_a(Unidom::Price::Price)
+      expect(price).not_to be_new_record
+    end
+
+    it "should be able to be priced by #{pricer.inspect}, at #{Time.now.inspect}" do
+      price = @priced.is_priced! @amount, by: pricer, at: Time.now
+      expect(price).to     be_present
+      expect(price).to     be_a(Unidom::Price::Price)
+      expect(price).not_to be_new_record
+    end
+
+  end
+
+  context '#is_priced?' do
+
+    it 'should reject the at argument = nil' do expect { @priced.is_priced? at: nil }.to raise_error(ArgumentError, 'The at argument is required.') end
+
+    it "should be able to be priced by #{pricer.inspect}" do
+      expect(@priced.is_priced?).to be_falsey
+      @priced.is_priced! @amount, by: pricer
+      expect(@priced.is_priced?).to be_truthy
+    end
+
+    it "should be able to be priced by #{pricer.inspect}, at #{Time.now.inspect}" do
+      expect(@priced.is_priced?   at: Time.now).to be_falsey
+      @priced.is_priced! @amount, by: pricer, at: Time.now
+      expect(@priced.is_priced?   at: Time.now).to be_truthy
+    end
+
+  end
+
+  context do
+
+    price_1_attribtues = {
+        pricer_id:   SecureRandom.uuid,
+        pricer_type: 'Unidom::Price::Pricer::Mock',
+        amount:      10.00
+      }
+
+    price_2_attribtues = {
+        pricer_id:   SecureRandom.uuid,
+        pricer_type: 'Unidom::Price::Pricer::Mock',
+        amount:      21.00
+      }
+
+    it_behaves_like 'has_many', model_attributes, :prices, Unidom::Price::Price, [ price_1_attribtues, price_2_attribtues ]
+
+  end
 
 end

data/lib/unidom/price/version.rb

@@ -1,5 +1,5 @@
 module Unidom
   module Price
-    VERSION = '1.7.4'.freeze
+    VERSION = '1.7.5'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unidom-price
 version: !ruby/object:Gem::Version
-  version: 1.7.4
+  version: 1.7.5
 platform: ruby
 authors:
 - Topbit Du
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-18 00:00:00.000000000 Z
+date: 2017-03-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: unidom-common