unidom-accession 2.3.3 → 2.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 35637667e550ce271dc4b432d0da3e50e4d47770
-  data.tar.gz: 58e760fe421bdd5936781e26cf5a236938b8c540
+  metadata.gz: 4706a65d450b15934cac5b2cd59fade50a0534e9
+  data.tar.gz: 79f2cc54b9709820fc798c0fe04b11690e945910
 SHA512:
-  metadata.gz: 211757d42604b0934d97edf9e7c6426eb2c0f2965948c494cefac28bc7db3e8396fef7a5a7909a98bf6a49e78628b58116a8e47fe87f95fecc0c4a660cdbd826
-  data.tar.gz: 6982d9db7e776ce0aed4af5fe1ad7e924e8278eda500a5ebee0d0df9ceb7b953091a8fe26701c7c8a92574ae28d22d6f6db1f2af92ab480b059935a8ed03b5be
+  metadata.gz: 29cac17f8c878a17404bcea59be8694ccbddbf8bf5e3070f8504109def78b0b9f405696b127a35725ee252d9f9054c5fceef758f2b6ceb4f22c7c7b96acf0a68
+  data.tar.gz: 894b4accc8160de910d2b40f728f6ff9f7d1204e865dc87dd83e83bee218e82e52795a9615c647561097ccffeb331ad1b761df1e159e51c498052a89ca40a9fa

data/README.md

@@ -144,7 +144,15 @@ describe Unidom::Party::Person do
     name: 'Tim'
   }
 
-  it_behaves_like 'Unidom::Accession::Concerns::AsPostFulfiller', model_attribtues
+  post_attribtues = {
+    name:              'HR Manager',
+    organization_id:   SecureRandom.uuid,
+    organization_type: 'Unidom::Position::Organization::Mock',
+    position_id:       SecureRandom.uuid
+  }
+  post = Unidom::Position::Post.create! post_attributes
+
+  it_behaves_like 'Unidom::Accession::Concerns::AsPostFulfiller', model_attribtues, post
 
 end
 

data/app/models/unidom/accession/concerns/as_post_fulfiller.rb

@@ -3,7 +3,8 @@
 
 module Unidom::Accession::Concerns::AsPostFulfiller
 
-  extend ActiveSupport::Concern
+  extend  ActiveSupport::Concern
+  include Unidom::Common::Concerns::ArgumentValidation
 
   included do |includer|
 
@@ -16,9 +17,12 @@ module Unidom::Accession::Concerns::AsPostFulfiller
     # 或者
     # selected_person.fulfill_post! post, at: Time.now-1.day
     def fulfill_post!(post, at: Time.now)
-      raise ArgumentError.new('The post argument is required.') if post.blank?
-      raise ArgumentError.new('The at argument is required.'  ) if at.blank?
+
+      assert_present! :post, post
+      assert_present! :at,   at
+
       post_fulfillments.create! fulfilled: post, opened_at: at
+
     end
 
     ##
@@ -27,9 +31,12 @@ module Unidom::Accession::Concerns::AsPostFulfiller
     # 或者
     # post.fulfill_post? post, at: Time.now
     def fulfill_post?(post, at: Time.now)
-      raise ArgumentError.new('The post argument is required.') if post.blank?
-      raise ArgumentError.new('The at argument is required.'  ) if at.blank?
+
+      assert_present! :post, post
+      assert_present! :at,   at
+
       post_fulfillments.fulfilled_is(post).valid_at(now: at).exists?
+
     end
 
   end

data/lib/rspec/models/unidom/accession/concerns/as_post_fulfilled_shared_examples.rb

@@ -1,31 +1,14 @@
 shared_examples 'Unidom::Accession::Concerns::AsPostFulfilled' do |model_attributes, post_fulfiller|
 
   before :each do
-
     @post = described_class.create! model_attributes
-
-  end
-
-  after :all do
-
-    #@post.destroy
-
   end
 
-=begin
-  context do
-
-    post = described_class.create! model_attributes
-    it_behaves_like 'assert_present!', post, :is_fulfilled_as_post!, [ { by: post_fulfiller, at: Time.now } ], [ :by, :at ]
-
+  after :each do
   end
-=end
 
   context '#is_fulfilled_as_post!' do
 
-    it 'should reject the by argument = nil' do expect { @post.is_fulfilled_as_post! by: nil,            at: Time.now }.to raise_error(ArgumentError, 'The by argument is required.') end
-    it 'should reject the at argument = nil' do expect { @post.is_fulfilled_as_post! by: post_fulfiller, at: nil      }.to raise_error(ArgumentError, 'The at argument is required.') end
-
     it "should be able to be fulfilled as post by #{post_fulfiller.inspect}" do
       post_fulfillment = @post.is_fulfilled_as_post! by: post_fulfiller
       expect(post_fulfillment).to     be_present
@@ -44,9 +27,6 @@ shared_examples 'Unidom::Accession::Concerns::AsPostFulfilled' do |model_attribu
 
   context '#is_fulfilled_as_post?' do
 
-    it 'should reject the by argument = nil' do expect { @post.is_fulfilled_as_post? by: nil,            at: Time.now }.to raise_error(ArgumentError, 'The by argument is required.') end
-    it 'should reject the at argument = nil' do expect { @post.is_fulfilled_as_post? by: post_fulfiller, at: nil      }.to raise_error(ArgumentError, 'The at argument is required.') end
-
     it "should be able to be fulfilled as post by #{post_fulfiller.inspect}" do
       expect(@post.is_fulfilled_as_post? by: post_fulfiller).to be_falsey
       @post.is_fulfilled_as_post!        by: post_fulfiller
@@ -75,6 +55,10 @@ shared_examples 'Unidom::Accession::Concerns::AsPostFulfilled' do |model_attribu
 
     it_behaves_like 'has_many', model_attributes, :post_fulfillments, Unidom::Accession::PostFulfillment, [ post_fulfillment_1_attribtues, post_fulfillment_2_attribtues ]
 
+    post = described_class.create! model_attributes
+    it_behaves_like 'assert_present!', post, :is_fulfilled_as_post!, [ { by: post_fulfiller, at: Time.now } ], [ :by, :at ]
+    it_behaves_like 'assert_present!', post, :is_fulfilled_as_post?, [ { by: post_fulfiller, at: Time.now } ], [ :by, :at ]
+
   end
 
 end

data/lib/rspec/models/unidom/accession/concerns/as_post_fulfiller_shared_examples.rb

@@ -1,15 +1,64 @@
-shared_examples 'Unidom::Accession::Concerns::AsPostFulfiller' do |model_attributes|
+shared_examples 'Unidom::Accession::Concerns::AsPostFulfiller' do |model_attributes, post|
 
-  post_fulfillment_1_attribtues = {
-      fulfilled_id:   SecureRandom.uuid,
-      fulfilled_type: 'Unidom::Accession::Fulfilled::Mock'
-    }
+  before :each do
+    @post_fulfiller = described_class.create! model_attributes
+  end
 
-  post_fulfillment_2_attribtues = {
-      fulfilled_id:   SecureRandom.uuid,
-      fulfilled_type: 'Unidom::Accession::Fulfilled::Mock'
-    }
+  after :each do
+  end
 
-  it_behaves_like 'has_many', model_attributes, :post_fulfillments, Unidom::Accession::PostFulfillment, [ post_fulfillment_1_attribtues, post_fulfillment_2_attribtues ]
+  context '#fulfill_post!' do
+
+    it "should be able to fulfill post #{post.inspect}" do
+      post_fulfillment = @post_fulfiller.fulfill_post! post
+      expect(post_fulfillment).to     be_present
+      expect(post_fulfillment).to     be_a(Unidom::Accession::PostFulfillment)
+      expect(post_fulfillment).not_to be_new_record
+    end
+
+    it "should be able to fulfill post #{post.inspect}, at #{Time.now.inspect}" do
+      post_fulfillment = @post_fulfiller.fulfill_post! post, at: Time.now
+      expect(post_fulfillment).to     be_present
+      expect(post_fulfillment).to     be_a(Unidom::Accession::PostFulfillment)
+      expect(post_fulfillment).not_to be_new_record
+    end
+
+  end
+
+  context '#fulfill_post?' do
+
+    it "should be able to fulfill post #{post.inspect}" do
+      expect(@post_fulfiller.fulfill_post? post).to be_falsey
+      @post_fulfiller.fulfill_post!        post
+      expect(@post_fulfiller.fulfill_post? post).to be_truthy
+    end
+
+    it "should be able to fulfill post #{post.inspect}, at #{Time.now.inspect}" do
+      expect(@post_fulfiller.fulfill_post? post, at: Time.now).to be_falsey
+      @post_fulfiller.fulfill_post!        post, at: Time.now
+      expect(@post_fulfiller.fulfill_post? post, at: Time.now).to be_truthy
+    end
+
+  end
+
+  context do
+
+    post_fulfillment_1_attribtues = {
+        fulfilled_id:   SecureRandom.uuid,
+        fulfilled_type: 'Unidom::Accession::Fulfilled::Mock'
+      }
+
+    post_fulfillment_2_attribtues = {
+        fulfilled_id:   SecureRandom.uuid,
+        fulfilled_type: 'Unidom::Accession::Fulfilled::Mock'
+      }
+
+    it_behaves_like 'has_many', model_attributes, :post_fulfillments, Unidom::Accession::PostFulfillment, [ post_fulfillment_1_attribtues, post_fulfillment_2_attribtues ]
+
+    post_fulfiller = described_class.create! model_attributes
+    it_behaves_like 'assert_present!', post_fulfiller, :fulfill_post!, [ post, { at: Time.now } ], [ { 0 => :post }, :at ]
+    it_behaves_like 'assert_present!', post_fulfiller, :fulfill_post?, [ post, { at: Time.now } ], [ { 0 => :post }, :at ]
+
+  end
 
 end

data/lib/unidom/accession/version.rb

@@ -1,5 +1,5 @@
 module Unidom
   module Accession
-    VERSION = '2.3.3'.freeze
+    VERSION = '2.3.4'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unidom-accession
 version: !ruby/object:Gem::Version
-  version: 2.3.3
+  version: 2.3.4
 platform: ruby
 authors:
 - Topbit Du
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-23 00:00:00.000000000 Z
+date: 2017-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: unidom-common