unidom-accession 2.3.2 → 2.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 570339b998187c75dffb782585abf1d5e701205a
-  data.tar.gz: c8a60afa72db9234325900288021e65fd636e7aa
+  metadata.gz: 35637667e550ce271dc4b432d0da3e50e4d47770
+  data.tar.gz: 58e760fe421bdd5936781e26cf5a236938b8c540
 SHA512:
-  metadata.gz: 6c16cca2d5660da1209bdd5aaf44489337ce386fdbdbff28d1891246a773d3ab855f897aace9401f56d9b456969d8d061aa92c3c40bc25bb906338ee5da3561b
-  data.tar.gz: 7ca9c6b401d4103cd8ba304036253946f2747af1bb2772d9abed444956d512a012d8f17442d7b0fa58002def732590ddb6cb34f29af7a5fac4b0f61ab0e29e20
+  metadata.gz: 211757d42604b0934d97edf9e7c6426eb2c0f2965948c494cefac28bc7db3e8396fef7a5a7909a98bf6a49e78628b58116a8e47fe87f95fecc0c4a660cdbd826
+  data.tar.gz: 6982d9db7e776ce0aed4af5fe1ad7e924e8278eda500a5ebee0d0df9ceb7b953091a8fe26701c7c8a92574ae28d22d6f6db1f2af92ab480b059935a8ed03b5be

data/README.md

@@ -158,7 +158,9 @@ describe Unidom::Position::Post do
     position_id:       SecureRandom.uuid
   }
 
-  it_behaves_like 'Unidom::Accession::Concerns::AsPostFulfilled', model_attribtues
+  post_fulfiller = Unidom::Party::Person.create! name: 'Tim'
+
+  it_behaves_like 'Unidom::Accession::Concerns::AsPostFulfilled', model_attribtues, post_fulfiller
 
 end
 ```

data/app/models/unidom/accession/concerns/as_post_fulfilled.rb

@@ -3,7 +3,8 @@
 
 module Unidom::Accession::Concerns::AsPostFulfilled
 
-  extend ActiveSupport::Concern
+  extend  ActiveSupport::Concern
+  include Unidom::Common::Concerns::ArgumentValidation
 
   included do |includer|
 
@@ -16,8 +17,10 @@ module Unidom::Accession::Concerns::AsPostFulfilled
     # 或者
     # post.is_fulfilled_as_post! by: tom, at: Time.now
     def is_fulfilled_as_post!(by: nil, at: Time.now)
-      raise ArgumentError.new('The by argument is required.') if by.blank?
-      raise ArgumentError.new('The at argument is required.') if at.blank?
+      assert_present! :by, by
+      assert_present! :at, at
+      #raise ArgumentError.new('The by argument is required.') if by.blank?
+      #raise ArgumentError.new('The at argument is required.') if at.blank?
       post_fulfillments.create! fulfiller: by, opened_at: at
     end
 
@@ -27,8 +30,10 @@ module Unidom::Accession::Concerns::AsPostFulfilled
     # 或者
     # post.is_fulfilled_as_post? by: tom, at: Time.now
     def is_fulfilled_as_post?(by: nil, at: Time.now)
-      raise ArgumentError.new('The by argument is required.') if by.blank?
-      raise ArgumentError.new('The at argument is required.') if at.blank?
+      assert_present! :by, by
+      assert_present! :at, at
+      #raise ArgumentError.new('The by argument is required.') if by.blank?
+      #raise ArgumentError.new('The at argument is required.') if at.blank?
       post_fulfillments.fulfilled_by(by).valid_at(now: at).exists?
     end
 

data/app/models/unidom/accession/post_fulfillment.rb

@@ -22,9 +22,8 @@ class Unidom::Accession::PostFulfillment < Unidom::Accession::ApplicationRecord
   def self.fulfill!(fulfilled: nil, fulfiller: nil, opened_at: Time.now)
     assert_present! :fulfilled, fulfilled
     assert_present! :fulfiller, fulfiller
-    #raise ArgumentError.new('Argument fulfilled is required.') if fulfilled.blank?
-    #raise ArgumentError.new('Argument fulfiller is required.') if fulfiller.blank?
-    raise ArgumentError.new('Argument opened_at is required.') if opened_at.blank?
+    assert_present! :opened_at, opened_at
+
     self.create! fulfiller: fulfiller, fulfilled: fulfilled, opened_at: opened_at
   end
 

data/lib/rspec/models/unidom/accession/concerns/as_post_fulfilled_shared_examples.rb

@@ -1,15 +1,80 @@
-shared_examples 'Unidom::Accession::Concerns::AsPostFulfilled' do |model_attributes|
+shared_examples 'Unidom::Accession::Concerns::AsPostFulfilled' do |model_attributes, post_fulfiller|
 
-  post_fulfillment_1_attribtues = {
-      fulfiller_id:   SecureRandom.uuid,
-      fulfiller_type: 'Unidom::Accession::Fulfiller::Mock'
-    }
+  before :each do
 
-  post_fulfillment_2_attribtues = {
-      fulfiller_id:   SecureRandom.uuid,
-      fulfiller_type: 'Unidom::Accession::Fulfiller::Mock'
-    }
+    @post = described_class.create! model_attributes
 
-  it_behaves_like 'has_many', model_attributes, :post_fulfillments, Unidom::Accession::PostFulfillment, [ post_fulfillment_1_attribtues, post_fulfillment_2_attribtues ]
+  end
+
+  after :all do
+
+    #@post.destroy
+
+  end
+
+=begin
+  context do
+
+    post = described_class.create! model_attributes
+    it_behaves_like 'assert_present!', post, :is_fulfilled_as_post!, [ { by: post_fulfiller, at: Time.now } ], [ :by, :at ]
+
+  end
+=end
+
+  context '#is_fulfilled_as_post!' do
+
+    it 'should reject the by argument = nil' do expect { @post.is_fulfilled_as_post! by: nil,            at: Time.now }.to raise_error(ArgumentError, 'The by argument is required.') end
+    it 'should reject the at argument = nil' do expect { @post.is_fulfilled_as_post! by: post_fulfiller, at: nil      }.to raise_error(ArgumentError, 'The at argument is required.') end
+
+    it "should be able to be fulfilled as post by #{post_fulfiller.inspect}" do
+      post_fulfillment = @post.is_fulfilled_as_post! by: post_fulfiller
+      expect(post_fulfillment).to     be_present
+      expect(post_fulfillment).to     be_a(Unidom::Accession::PostFulfillment)
+      expect(post_fulfillment).not_to be_new_record
+    end
+
+    it "should be able to be fulfilled as post by #{post_fulfiller.inspect}, at #{Time.now.inspect}" do
+      post_fulfillment = @post.is_fulfilled_as_post! by: post_fulfiller, at: Time.now
+      expect(post_fulfillment).to     be_present
+      expect(post_fulfillment).to     be_a(Unidom::Accession::PostFulfillment)
+      expect(post_fulfillment).not_to be_new_record
+    end
+
+  end
+
+  context '#is_fulfilled_as_post?' do
+
+    it 'should reject the by argument = nil' do expect { @post.is_fulfilled_as_post? by: nil,            at: Time.now }.to raise_error(ArgumentError, 'The by argument is required.') end
+    it 'should reject the at argument = nil' do expect { @post.is_fulfilled_as_post? by: post_fulfiller, at: nil      }.to raise_error(ArgumentError, 'The at argument is required.') end
+
+    it "should be able to be fulfilled as post by #{post_fulfiller.inspect}" do
+      expect(@post.is_fulfilled_as_post? by: post_fulfiller).to be_falsey
+      @post.is_fulfilled_as_post!        by: post_fulfiller
+      expect(@post.is_fulfilled_as_post? by: post_fulfiller).to be_truthy
+    end
+
+    it "should be able to be fulfilled as post by #{post_fulfiller.inspect}, at #{Time.now.inspect}" do
+      expect(@post.is_fulfilled_as_post? by: post_fulfiller).to be_falsey
+      @post.is_fulfilled_as_post!        by: post_fulfiller, at: Time.now
+      expect(@post.is_fulfilled_as_post? by: post_fulfiller).to be_truthy
+    end
+
+  end
+
+  context do
+
+    post_fulfillment_1_attribtues = {
+        fulfiller_id:   SecureRandom.uuid,
+        fulfiller_type: 'Unidom::Accession::Fulfiller::Mock'
+      }
+
+    post_fulfillment_2_attribtues = {
+        fulfiller_id:   SecureRandom.uuid,
+        fulfiller_type: 'Unidom::Accession::Fulfiller::Mock'
+      }
+
+    it_behaves_like 'has_many', model_attributes, :post_fulfillments, Unidom::Accession::PostFulfillment, [ post_fulfillment_1_attribtues, post_fulfillment_2_attribtues ]
+
+  end
 
 end

data/lib/unidom/accession/version.rb

@@ -1,5 +1,5 @@
 module Unidom
   module Accession
-    VERSION = '2.3.2'.freeze
+    VERSION = '2.3.3'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unidom-accession
 version: !ruby/object:Gem::Version
-  version: 2.3.2
+  version: 2.3.3
 platform: ruby
 authors:
 - Topbit Du
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-11 00:00:00.000000000 Z
+date: 2017-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: unidom-common