unicorn 5.3.1 → 5.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: cae827cc4674fdbfd9291caf3037f0fe4a5e67b7
-  data.tar.gz: e6518f02407def59575f3efb01a54019e0fdcab9
+SHA256:
+  metadata.gz: c0ccf5d1fa9326ffe756484e343d135b31e82f02260901e12effb9675a94e9bb
+  data.tar.gz: c273ee8cc51bdad405c8c35f814b66bd7c571b9e50947e9cf974c10a8f55107f
 SHA512:
-  metadata.gz: 2a9bd5f4dacb2aa56002b9899d1725bdfc124def5b9287ff464b3ed0e47785db1aa14b52757173d990972ad5a3a4afc44e37f052f7ef8ac92ae7fac0daa3645d
-  data.tar.gz: da9be558581cb34ee8b8c81bdcfcd659dc5e26d0cc42aa291ced5749ea07cbfe14fdce7a2fbfd43339990331e9c58e346d0129ea035c817ff59c8825d34f5645
+  metadata.gz: 6e3efff490b9b3ed6ce63ae9a179abb1f1199f7fd0a6799a71b3e6124e1ea9c64096eafd40039a6d485e47c9b1ccd77d3479c098c04935048101bf2c02dcad9e
+  data.tar.gz: 7a7f7ce0fbb2295882b13e641522b112cc8a4b60a767219fdf4734487b329e8ffc45bde32e96b7064b62738ebf20ee8b9324473542d8ef2eb4bd14eac7de3f91

data/.manifest

@@ -128,6 +128,8 @@ t/t0116-client_body_buffer_size.sh
 t/t0116.ru
 t/t0200-rack-hijack.sh
 t/t0300-no-default-middleware.sh
+t/t0301-no-default-middleware-ignored-in-config.sh
+t/t0301.ru
 t/t9000-preread-input.sh
 t/t9001-oob_gc.sh
 t/t9002-oob_gc-path.sh

data/.olddoc.yml

@@ -1,6 +1,6 @@
 ---
 cgit_url: https://bogomips.org/unicorn.git
-git_url: git://bogomips.org/unicorn.git
+git_url: https://bogomips.org/unicorn.git
 rdoc_url: https://bogomips.org/unicorn/
 ml_url: https://bogomips.org/unicorn-public/
 merge_html:

data/Application_Timeouts

@@ -23,10 +23,10 @@ Most database adapters allow configurable timeouts.
 Net::HTTP and Net::SMTP in the Ruby standard library allow
 configurable timeouts.
 
-Even for things as fast as {memcached}[http://memcached.org/],
-{dalli}[http://rubygems.org/gems/dalli],
-{memcached}[http://rubygems.org/gems/memcached] and
-{memcache-client}[http://rubygems.org/gems/memcache-client] RubyGems all
+Even for things as fast as {memcached}[https://memcached.org/],
+{dalli}[https://rubygems.org/gems/dalli],
+{memcached}[https://rubygems.org/gems/memcached] and
+{memcache-client}[https://rubygems.org/gems/memcache-client] RubyGems all
 offer configurable timeouts.
 
 Consult the relevant documentation for the libraries you use on

data/Documentation/unicorn.1.txt

@@ -182,6 +182,6 @@ the unicorn config file.
 * [Rackup HowTo][3]
 
 [1]: https://bogomips.org/unicorn/
-[2]: http://www.rubydoc.info/github/rack/rack/
+[2]: https://www.rubydoc.info/github/rack/rack/
 [3]: https://github.com/rack/rack/wiki/tutorial-rackup-howto
 [4]: https://bogomips.org/unicorn/SIGNALS.html

data/Documentation/unicorn_rails.1.txt

@@ -12,14 +12,12 @@ unicorn_rails [-c CONFIG_FILE] [-E RAILS_ENV] [-D] [RACKUP_FILE]
 
 # DESCRIPTION
 
-A rackup(1)-like command to launch Rails applications using Unicorn.  It
-is expected to be started in your Rails application root (RAILS_ROOT),
-but the "working_directory" directive may be used in the CONFIG_FILE.
+A rackup(1)-like command to launch ancient Rails (2.x and earlier)
+applications using Unicorn.  Rails 3 (and later) support Rack natively,
+so users are encouraged to use unicorn(1) instead of unicorn_rails(1).
 
-It is designed to help Rails 1.x and 2.y users transition to Rack, but
-it is NOT needed for Rails 3 applications.  Rails 3 users are encouraged
-to use unicorn(1) instead of unicorn_rails(1).  Users of Rails 1.x/2.y
-may also use unicorn(1) instead of unicorn_rails(1).
+It is expected to be started in your Rails application root (RAILS_ROOT),
+but the "working_directory" directive may be used in the CONFIG_FILE.
 
 The outward interface resembles rackup(1), the internals and default
 middleware loading is designed like the `script/server` command
@@ -170,6 +168,6 @@ used by Unicorn.
 * [Rackup HowTo][3]
 
 [1]: https://bogomips.org/unicorn/
-[2]: http://www.rubydoc.info/github/rack/rack/
+[2]: https://www.rubydoc.info/github/rack/rack/
 [3]: https://github.com/rack/rack/wiki/tutorial-rackup-howto
 [4]: https://bogomips.org/unicorn/SIGNALS.html

data/GIT-VERSION-FILE

@@ -1 +1 @@
-GIT_VERSION = 5.3.1
+GIT_VERSION = 5.5.1

data/GIT-VERSION-GEN

@@ -1,5 +1,5 @@
 #!/usr/bin/env ruby
-DEF_VER = "v5.3.1"
+DEF_VER = "v5.5.1"
 CONSTANT = "Unicorn::Const::UNICORN_VERSION"
 RVF = "lib/unicorn/version.rb"
 GVF = "GIT-VERSION-FILE"

data/GNUmakefile

@@ -175,7 +175,7 @@ doc: .document $(ext)/unicorn_http.c man html .olddoc.yml $(PLACEHOLDERS)
 	find bin lib -type f -name '*.rbc' -exec rm -f '{}' ';'
 	$(RM) -r doc
 	$(OLDDOC) prepare
-	$(RDOC) -f oldweb
+	$(RDOC) -f dark216
 	$(OLDDOC) merge
 	install -m644 COPYING doc/COPYING
 	install -m644 NEWS.atom.xml doc/NEWS.atom.xml
@@ -249,5 +249,10 @@ endif
 $(PLACEHOLDERS):
 	echo olddoc_placeholder > $@
 
+check-warnings:
+	@(for i in $$(git ls-files '*.rb' bin | grep -v '^setup\.rb$$'); \
+	  do $(RUBY) --disable-gems -d -W2 -c \
+	  $$i; done) | grep -v '^Syntax OK$$' || :
+
 .PHONY: .FORCE-GIT-VERSION-FILE doc $(T) $(slow_tests) man
 .PHONY: test-install

data/ISSUES

@@ -15,6 +15,11 @@ submit patches and/or obtain support after you have searched the
 * The email submission port (587) is enabled on the bogomips.org MX:
   https://bogomips.org/unicorn-public/20141004232241.GA23908@dcvr.yhbt.net/t/
 
+We will never have a centralized or formal bug tracker.  Instead we
+can interoperate with any bug tracker which can Cc: us plain-text to
+mailto:unicorn-public@bogomips.org   This includes the Debian BTS
+at https://bugs.debian.org/unicorn and possibly others.
+
 If your issue is of a sensitive nature or you're just shy in public,
 use anonymity tools such as Tor or Mixmaster; and rely on the public
 mail archives for responses.  Be sure to scrub sensitive log messages
@@ -34,6 +39,7 @@ https://bugs.ruby-lang.org/ and discuss+fix them on the ruby-core
 list at mailto:ruby-core@ruby-lang.org
 Subscription to post is required to ruby-core, unfortunately:
 mailto:ruby-core-request@ruby-lang.org?subject=subscribe
+Unofficial archives are available at: https://public-inbox.org/ruby-core/
 
 For uncommon bugs in Rack, we may forward bugs to
 mailto:rack-devel@googlegroups.com and discuss there.
@@ -41,6 +47,7 @@ Subscription (without any web UI or Google account) is possible via:
 mailto:rack-devel+subscribe@googlegroups.com
 Note: not everyone can use the proprietary bug tracker used by Rack,
 but their mailing list remains operational.
+Unofficial archives are available at: https://public-inbox.org/rack-devel/
 
 Uncommon bugs we encounter in the Linux kernel should be Cc:-ed to the
 Linux kernel mailing list (LKML) at mailto:linux-kernel@vger.kernel.org
@@ -49,11 +56,12 @@ and subsystem maintainers such as mailto:netdev@vger.kernel.org
 involved with any problematic commits (including those in the
 Signed-off-by: and other trailer lines).  No subscription is necessary,
 and the our mailing list follows the same conventions as LKML for
-interopability.  There is a kernel.org Bugzilla instance, but it is
-ignored by most developers.
+interopability. Archives are available at https://lore.kernel.org/lkml/
+There is a kernel.org Bugzilla instance, but it is ignored by most.
 
 Likewise for any rare glibc bugs we might encounter, we should Cc:
 mailto:libc-alpha@sourceware.org
+Unofficial archives are available at: https://public-inbox.org/libc-alpha/
 Keep in mind glibc upstream does use Bugzilla for tracking bugs:
 https://sourceware.org/bugzilla/
 
@@ -86,11 +94,3 @@ Or Atom feeds:
 	The HTML archives at https://bogomips.org/unicorn-public/
 	also has links to per-thread Atom feeds and downloadable
 	mboxes.
-
-You may optionally subscribe via plain-text email:
-
-	mailto:unicorn-public+subscribe@bogomips.org
-	(and confirming the auto-reply)
-
-Just keep in mind we suck at delivering email, so using NNTP,
-or Atom feeds might be a better bet...

data/LATEST

@@ -1,103 +1,23 @@
-=== unicorn 5.3.0 / 2017-04-01 08:03 UTC
-
-  A couple of portability fixes from Dylan Thacker-Smith and
-  Jeremy Evans since 5.3.0.pre1 over a week ago, but this looks
-  ready for a stable release, today.
-
-  When I started this over 8 years ago, I wondered if this would
-  just end up being an April Fools' joke.  Guess not.  I guess I
-  somehow tricked people into using a terribly marketed web server
-  that cannot talk directly to untrusted clients :x  Anyways,
-  unicorn won't be able to handle slow clients 8 years from now,
-  either, or 80 years from now.  And I vow never to learn to use
-  new-fangled things like epoll, kqueue, or threads :P
-
-  Anyways, this is a largish release with several new features,
-  and no backwards incompatibilities.
-
-  Simon Eskildsen contributed heavily using TCP_INFO under Linux
-  to implement the (now 5 year old) check_client_connection feature:
-
-    https://bogomips.org/unicorn/Unicorn/Configurator.html#method-i-check_client_connection
-    https://bogomips.org/unicorn-public/?q=s:check_client_connection&d:..20170401&x=t
-
-  This also led to FreeBSD and OpenBSD portability improvements in
-  one of our dependencies, raindrops:
-
-     https://bogomips.org/raindrops-public/20170323024829.GA5190@dcvr/T/#u
-
-  Jeremy Evans contributed several new features.  First he
-  implemented after_worker_exit to aid debugging:
-
-    https://bogomips.org/unicorn/Unicorn/Configurator.html#method-i-after_worker_exit
-    https://bogomips.org/unicorn-public/?q=s:after_worker_exit&d:..20170401&x=t#t
-
-  And then security-related features to isolate workers.  Workers
-  may now chroot to drop access to the master filesystem, and the
-  new after_worker_ready configuration hook now exists to aid with
-  chroot support in workers:
-
-    https://bogomips.org/unicorn/Unicorn/Configurator.html#method-i-after_worker_ready
-    https://bogomips.org/unicorn/Unicorn/Worker.html#method-i-user
-    https://bogomips.org/unicorn-public/?q=s:after_worker_ready&d:..20170401&x=t#t
-    https://bogomips.org/unicorn-public/?q=s:chroot&d:..20170401&x=t#t
-
-  Additionally, workers may run in a completely different VM space
-  (nullifying preload_app and any CoW savings) with the new
-  worker_exec option:
-
-    https://bogomips.org/unicorn/Unicorn/Configurator.html#method-i-worker_exec
-    https://bogomips.org/unicorn-public/?q=s:worker_exec&d:..20170401&x=t#t
-
-  There are also several improvements to FreeBSD and OpenBSD
-  support with the addition of these features.
-
-  shortlog of changes since v5.2.0 (2016-10-31):
-
-  Dylan Thacker-Smith (1):
-        Check for Socket::TCP_INFO constant before trying to get TCP_INFO
-
-  Eric Wong (30):
-        drop rb_str_set_len compatibility replacement
-        TUNING: document THP caveat for Linux users
-        tee_input: simplify condition for IO#write
-        remove response_start_sent
-        http_request: freeze constant strings passed IO#write
-        Revert "remove response_start_sent"
-        t/t0012-reload-empty-config.sh: access ivars directly if needed
-        t0011-active-unix-socket.sh: fix race condition in test
-        new test for check_client_connection
-        revert signature change to HttpServer#process_client
-        support "struct tcp_info" on non-Linux and Ruby 2.2+
-        unicorn_http: reduce rb_global_variable calls
-        oob_gc: rely on opt_aref_with optimization on Ruby 2.2+
-        http_request: reduce insn size for check_client_connection
-        freebsd: avoid EINVAL when setting accept filter
-        test-lib: expr(1) portability fix
-        tests: keep disabled tests defined
-        test_exec: SO_KEEPALIVE value only needs to be true
-        doc: fix links to raindrops project
-        http_request: support proposed Raindrops::TCP states on non-Linux
-        ISSUES: expand on mail archive info + subscription disclaimer
-        test_ccc: use a pipe to synchronize test
-        doc: remove private email support address
-        input: update documentation and hide internals.
-        http_server: initialize @pid ivar
-        gemspec: remove olddoc from build dependency
-        doc: add version annotations for new features
-        unicorn 5.3.0.pre1
-        doc: note after_worker_exit is also 5.3.0+
-        test_exec: SO_KEEPALIVE value only needs to be true (take #2)
-
-  Jeremy Evans (7):
-        Add after_worker_exit configuration option
-        Fix code example in after_worker_exit documentation
-        Add support for chroot to Worker#user
-        Add after_worker_ready configuration option
-        Add worker_exec configuration option
-        Don't pass a block for fork when forking workers
-        Check for SocketError on first ccc attempt
-
-  Simon Eskildsen (1):
-        check_client_connection: use tcp state on linux
+=== unicorn 5.5.0 / 2019-03-04 00:41 UTC
+
+  Mostly identical to 5.5.0.pre1, which I didn't hear any feedback
+  from:
+
+    https://bogomips.org/unicorn-public/20181220222842.GA27382@dcvr/
+
+  > Jeremy Evans contributed the "default_middleware" configuration option:
+  >
+  >   https://bogomips.org/unicorn-public/20180913192055.GD48926@jeremyevans.local/
+  >
+  > Jeremy also contributed the ability to use separate groups for the process
+  > and log files:
+  >
+  >   https://bogomips.org/unicorn-public/20180913192449.GE48926@jeremyevans.local/
+  >
+  > There's also a couple of uninteresting minor optimizations and
+  > documentation additions.
+
+  Otherwise, there's one extra change to use
+  rb_gc_register_mark_object which is finally a documented part of
+  the Ruby C-API, but has existed since the 1.9 days.
 

data/LICENSE

@@ -8,8 +8,8 @@ any later version.  We currently prefer the GPLv3 or later for
 derivative works, but the GPLv2 is fine.
 
 The complete texts of the GPLv2 and GPLv3 are below:
-GPLv2 - http://www.gnu.org/licenses/gpl-2.0.txt
-GPLv3 - http://www.gnu.org/licenses/gpl-3.0.txt
+GPLv2 - https://www.gnu.org/licenses/gpl-2.0.txt
+GPLv3 - https://www.gnu.org/licenses/gpl-3.0.txt
 
 You may (against our _preference_) also use the Ruby 1.8 license terms
 which we inherited from the original Mongrel project when we forked it:

data/Links

@@ -10,7 +10,7 @@ The unicorn project is not responsible for the content in these links.
 Furthermore, the unicorn project has never, does not and will never endorse:
 
 * any for-profit entities or services
-* any non-{Free Software}[http://www.gnu.org/philosophy/free-sw.html]
+* any non-{Free Software}[https://www.gnu.org/philosophy/free-sw.html]
 
 The existence of these links does not imply endorsement of any entities
 or services behind them.
@@ -31,26 +31,28 @@ or services behind them.
 
 === unicorn is written to work with
 
-* {Rack}[http://rack.github.io/] - a minimal interface between webservers
+* {Rack}[https://rack.github.io/] - a minimal interface between webservers
   supporting Ruby and Ruby frameworks
 
 * {Ruby}[https://www.ruby-lang.org/en/] - the programming language of
   Rack and unicorn
 
-* {nginx}[http://nginx.org/] (Free versions) -
+* {nginx}[https://nginx.org/] (Free versions) -
   the reverse proxy for use with unicorn
 
 === Derivatives
 
-* {Green Unicorn}[http://gunicorn.org/] - a Python version of unicorn
+* {Green Unicorn}[https://gunicorn.org/] - a Python version of unicorn
 
-* {Starman}[http://search.cpan.org/dist/Starman/] - Plack/PSGI version
+* {Starman}[https://metacpan.org/release/Starman/] - Plack/PSGI version
   of unicorn
 
 === Prior Work
 
-* {Mongrel}[http://rubygems.org/gems/mongrel] - the awesome webserver
-  unicorn is based on
+* {Mongrel}[https://rubygems.org/gems/mongrel] - the awesome webserver
+  unicorn is based on.  A historical archive of the mongrel dev list
+  featuring early discussions of unicorn is available at:
+  https://bogomips.org/mongrel-devel/
 
 * {david}[https://bogomips.org/david.git] - a tool to explain why you need
   nginx in front of unicorn

data/NEWS

@@ -1,3 +1,110 @@
+=== unicorn 5.5.0 / 2019-03-04 00:41 UTC
+
+  Mostly identical to 5.5.0.pre1, which I didn't hear any feedback
+  from:
+
+    https://bogomips.org/unicorn-public/20181220222842.GA27382@dcvr/
+
+  > Jeremy Evans contributed the "default_middleware" configuration option:
+  >
+  >   https://bogomips.org/unicorn-public/20180913192055.GD48926@jeremyevans.local/
+  >
+  > Jeremy also contributed the ability to use separate groups for the process
+  > and log files:
+  >
+  >   https://bogomips.org/unicorn-public/20180913192449.GE48926@jeremyevans.local/
+  >
+  > There's also a couple of uninteresting minor optimizations and
+  > documentation additions.
+
+  Otherwise, there's one extra change to use
+  rb_gc_register_mark_object which is finally a documented part of
+  the Ruby C-API, but has existed since the 1.9 days.
+
+=== unicorn 5.5.0.pre1 / 2018-12-20 20:11 UTC
+
+  Jeremy Evans contributed the "default_middleware" configuration option:
+
+    https://bogomips.org/unicorn-public/20180913192055.GD48926@jeremyevans.local/
+
+  Jeremy also contributed the ability to use separate groups for the process
+  and log files:
+
+    https://bogomips.org/unicorn-public/20180913192449.GE48926@jeremyevans.local/
+
+  There's also a couple of uninteresting minor optimizations and
+  documentation additions.
+
+  Eric Wong (10):
+        remove random seed reset atfork
+        use IO#wait instead of kgio_wait_readable
+        Merge branch '5.4-stable'
+        shrink pipes under Linux
+        socket_helper: add hint for FreeBSD users for accf_http(9)
+        tests: ensure -N/--no-default-middleware not supported in config.ru
+        doc: update more URLs to use HTTPS and avoid redirects
+        deduplicate strings VM-wide in Ruby 2.5+
+        doc/ISSUES: add links to git clone-able mail archives of our dependencies
+        README: minor updates and additional disclaimer
+
+  Jeremy Evans (2):
+        Make Worker#user support different process primary group and log file group
+        Support default_middleware configuration option
+
+=== unicorn 5.4.1 / 2018-07-23 17:13 UTC
+
+  This release quiets some warnings for Ruby 2.6 preview releases
+  and enables tests to pass under Ruby 1.9.3.  Otherwise, nothing
+  interesting for Ruby 2.0..2.5 users.  *YAWN*
+
+  Eric Wong (1):
+        quiet some mismatched indentation warnings
+
+  Fumiaki MATSUSHIMA (1):
+        Use IO#wait instead to fix test for Ruby 1.9
+
+=== unicorn 5.4.0 / 2017-12-23 23:33 UTC
+
+  Rack hijack support improves as the app code can capture and use
+  the Rack `env' privately without copying it (to avoid clobbering
+  by another client).  Thanks to Sam Saffron for reporting and
+  testing this new feature:
+    https://bogomips.org/unicorn-public/CAAtdryPG3nLuyo0jxfYW1YHu1Q+ZpkLkd4KdWC8vA46B5haZxw@mail.gmail.com/T/
+
+  We also now support $DEBUG being set by the Rack app (instead of
+  relying on the "-d" CLI switch).  Thanks to James P Robinson Jr
+  for reporting this bug:
+    https://bogomips.org/unicorn-public/D6324CB4.7BC3E%25james.robinson3@cigna.com/T/
+    (Coincidentally, this fix will be irrelevant for Ruby 2.5
+     which requires 'pp' by default)
+
+  There's a few minor test cleanups and documentation updates, too.
+
+  All commits since v5.3.1 (2017-10-03):
+
+      reduce method calls with String#start_with?
+      require 'pp' if $DEBUG is set by Rack app
+      avoid reusing env on hijack
+      tests: cleanup some unused variable warnings
+      ISSUES: add a note about Debian BTS interopability
+
+  Roughly all mailing discussions since the last release:
+
+    https://bogomips.org/unicorn-public/?q=d:20171004..20171223
+
+=== unicorn 5.3.1 / 2017-10-03 19:03 UTC
+
+  This release fixes an occasional GC problem introduced in v5.3.0
+  to reduce global variable overhead (commit 979ebcf91705709b)
+
+  Thanks to Xuanzhong Wei for the patch which lead to this release:
+
+  https://bogomips.org/unicorn-public/20171003182054.76392-1-azrlew@gmail.com/T/#u
+  https://bogomips.org/unicorn-public/20171003145718.30404-1-azrlew@gmail.com/T/#u
+
+  Xuanzhong Wei (1):
+        fix GC issue on rb_global_variable array
+
 === unicorn 5.3.0 / 2017-04-01 08:03 UTC
 
   A couple of portability fixes from Dylan Thacker-Smith and

data/README

@@ -10,7 +10,7 @@ both the the request and response in between unicorn and slow clients.
 
 * Designed for Rack, Unix, fast clients, and ease-of-debugging.  We
   cut out everything that is better supported by the operating system,
-  {nginx}[http://nginx.org/] or {Rack}[http://rack.github.io/].
+  {nginx}[https://nginx.org/] or {Rack}[https://rack.github.io/].
 
 * Compatible with Ruby 1.9.3 and later.
   unicorn 4.x remains supported for Ruby 1.8 users.
@@ -37,12 +37,15 @@ both the the request and response in between unicorn and slow clients.
   You can upgrade unicorn, your entire application, libraries
   and even your Ruby interpreter without dropping clients.
 
+* transparent upgrades using systemd socket activation is
+  supported since unicorn 5.0
+
 * before_fork and after_fork hooks in case your application
   has special needs when dealing with forked processes.  These
   should not be needed when the "preload_app" directive is
   false (the default).
 
-* Can be used with copy-on-write-friendly memory management
+* Can be used with copy-on-write-friendly GC in Ruby 2.0+
   to save memory (by setting "preload_app" to true).
 
 * Able to listen on multiple interfaces including UNIX sockets,
@@ -55,7 +58,7 @@ both the the request and response in between unicorn and slow clients.
 
 == License
 
-unicorn is copyright 2009-2016 by all contributors (see logs in git).
+unicorn is copyright 2009-2018 by all contributors (see logs in git).
 It is based on Mongrel 1.1.5.
 Mongrel is copyright 2007 Zed A. Shaw and contributors.
 
@@ -77,13 +80,13 @@ You may install it via RubyGems on RubyGems.org:
 You can get the latest source via git from the following locations
 (these versions may not be stable):
 
-  git://bogomips.org/unicorn.git
-  git://repo.or.cz/unicorn.git (mirror)
+  https://bogomips.org/unicorn.git
+  https://repo.or.cz/unicorn.git (mirror)
 
 You may browse the code from the web:
 
 * https://bogomips.org/unicorn.git
-* http://repo.or.cz/w/unicorn.git (gitweb)
+* https://repo.or.cz/w/unicorn.git (gitweb)
 
 See the HACKING guide on how to contribute and build prerelease gems
 from git.
@@ -122,6 +125,10 @@ unicorn is designed to only serve fast clients either on the local host
 or a fast LAN.  See the PHILOSOPHY and DESIGN documents for more details
 regarding this.
 
+Due to its ability to tolerate crashes and isolate clients, unicorn
+is unfortunately known to prolong the existence of bugs in applications
+and libraries which run on top of it.
+
 == Contact
 
 All feedback (bug reports, user/development dicussion, patches, pull

data/Sandbox

@@ -3,7 +3,7 @@
 Since unicorn includes executables and is usually used to start a Ruby
 process, there are certain caveats to using it with tools that sandbox
 RubyGems installations such as
-{Bundler}[http://bundler.io/] or
+{Bundler}[https://bundler.io/] or
 {Isolate}[https://github.com/jbarnette/isolate].
 
 == General deployment
@@ -66,7 +66,7 @@ before_exec hook as illustrated by https://gist.github.com/534668
 Ruby 2.0.0 enforces FD_CLOEXEC on file descriptors by default.  unicorn
 has been prepared for this behavior since unicorn 4.1.0, and bundler
 needs the "--keep-file-descriptors" option for "bundle exec":
-http://bundler.io/man/bundle-exec.1.html
+https://bundler.io/man/bundle-exec.1.html
 
 == Isolate
 

data/bin/unicorn

@@ -6,6 +6,7 @@ require 'optparse'
 ENV["RACK_ENV"] ||= "development"
 rackup_opts = Unicorn::Configurator::RACKUP
 options = rackup_opts[:options]
+set_no_default_middleware = true
 
 op = OptionParser.new("", 24, '  ') do |opts|
   cmd = File.basename($0)
@@ -60,7 +61,7 @@ op = OptionParser.new("", 24, '  ') do |opts|
 
   opts.on("-N", "--no-default-middleware",
           "do not load middleware implied by RACK_ENV") do |e|
-    rackup_opts[:no_default_middleware] = true
+    rackup_opts[:no_default_middleware] = true if set_no_default_middleware
   end
 
   opts.on("-D", "--daemonize", "run daemonized in the background") do |d|
@@ -110,6 +111,7 @@ op = OptionParser.new("", 24, '  ') do |opts|
   opts.parse! ARGV
 end
 
+set_no_default_middleware = false
 app = Unicorn.builder(ARGV[0] || 'config.ru', op)
 op = nil
 

data/bin/unicorn_rails

@@ -132,11 +132,11 @@ def rails_builder(ru, op, daemonize)
 
   # this lambda won't run until after forking if preload_app is false
   # this runs after config file reloading
-  lambda do ||
+  lambda do |x, server|
     # Rails 3 includes a config.ru, use it if we find it after
     # working_directory is bound.
     ::File.exist?('config.ru') and
-      return Unicorn.builder('config.ru', op).call
+      return Unicorn.builder('config.ru', op).call(x, server)
 
     # Load Rails and (possibly) the private version of Rack it bundles.
     begin

data/examples/logrotate.conf

@@ -2,7 +2,7 @@
 # /etc/logrotate.d/unicorn_app on my Debian systems
 #
 # See the logrotate(8) manpage for more information:
-#    http://linux.die.net/man/8/logrotate
+#    https://linux.die.net/man/8/logrotate
 #
 # public logrotate-related discussion in our archives:
 #    https://bogomips.org/unicorn-public/?q=logrotate

data/examples/nginx.conf

@@ -56,7 +56,8 @@ http {
   # to configure it all in one place here for static files and also
   # to disable gzip for clients who don't get gzip/deflate right.
   # There are other gzip settings that may be needed used to deal with
-  # bad clients out there, see http://wiki.nginx.org/NginxHttpGzipModule
+  # bad clients out there, see
+  # https://nginx.org/en/docs/http/ngx_http_gzip_module.html
   gzip on;
   gzip_http_version 1.0;
   gzip_proxied any;
@@ -117,7 +118,7 @@ http {
 
     location @app {
       # an HTTP header important enough to have its own Wikipedia entry:
-      #   http://en.wikipedia.org/wiki/X-Forwarded-For
+      #   https://en.wikipedia.org/wiki/X-Forwarded-For
       proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
 
       # enable this if you forward HTTPS traffic to unicorn,