unicorn 1.0.1 → 1.0.2

data/GIT-VERSION-GEN

@@ -1,7 +1,7 @@
 #!/bin/sh
 
 GVF=GIT-VERSION-FILE
-DEF_VER=v1.0.1.GIT
+DEF_VER=v1.0.2.GIT
 
 LF='
 '

data/GNUmakefile

@@ -169,7 +169,7 @@ NEWS: GIT-VERSION-FILE .manifest
 	$(RAKE) -s news_rdoc > $@+
 	mv $@+ $@
 
-SINCE = 0.991.0
+SINCE = 1.0.0
 ChangeLog: LOG_VERSION = \
   $(shell git rev-parse -q "$(GIT_VERSION)" >/dev/null 2>&1 && \
           echo $(GIT_VERSION) || git describe)
@@ -189,7 +189,7 @@ atom = <link rel="alternate" title="Atom feed" href="$(1)" \
 doc: .document $(ext)/unicorn_http.c NEWS ChangeLog
 	for i in $(man1_rdoc); do echo > $$i; done
 	find bin lib -type f -name '*.rbc' -exec rm -f '{}' ';'
-	rdoc -a -t "$(shell sed -ne '1s/^= //p' README)"
+	rdoc -t "$(shell sed -ne '1s/^= //p' README)"
 	install -m644 COPYING doc/COPYING
 	install -m644 $(shell grep '^[A-Z]' .document)  doc/
 	$(MAKE) -C Documentation install-html install-man

data/Rakefile

@@ -15,7 +15,7 @@ def tags
   timefmt = '%Y-%m-%dT%H:%M:%SZ'
   @tags ||= `git tag -l`.split(/\n/).map do |tag|
     next if tag == "v0.0.0"
-    if %r{\Av[\d\.]+\z} =~ tag
+    if %r{\Av[\d\.]+} =~ tag
       header, subject, body = `git cat-file tag #{tag}`.split(/\n\n/, 3)
       header = header.split(/\n/)
       tagger = header.grep(/\Atagger /).first
@@ -168,8 +168,12 @@ task :fm_update do
       "changelog" => changelog,
     },
   }.to_json
-  Net::HTTP.start(uri.host, uri.port) do |http|
-    p http.post(uri.path, req, {'Content-Type'=>'application/json'})
+  if ! changelog.strip.empty? && version =~ %r{\A[\d\.]+\d+\z}
+    Net::HTTP.start(uri.host, uri.port) do |http|
+      p http.post(uri.path, req, {'Content-Type'=>'application/json'})
+    end
+  else
+    warn "not updating freshmeat for v#{version}"
   end
 end
 

data/lib/unicorn.rb

@@ -422,10 +422,12 @@ module Unicorn
               respawn = false
               logger.info "gracefully stopping all workers"
               kill_each_worker(:QUIT)
+              self.worker_processes = 0
             else
               logger.info "SIGWINCH ignored because we're not daemonized"
             end
           when :TTIN
+            respawn = true
             self.worker_processes += 1
           when :TTOU
             self.worker_processes -= 1 if self.worker_processes > 0
@@ -486,12 +488,9 @@ module Unicorn
     # wait for a signal hander to wake us up and then consume the pipe
     # Wake up every second anyways to run murder_lazy_workers
     def master_sleep(sec)
-      begin
-        IO.select([ SELF_PIPE.first ], nil, nil, sec) or return
-        SELF_PIPE.first.read_nonblock(Const::CHUNK_SIZE, HttpRequest::BUF)
+      IO.select([ SELF_PIPE[0] ], nil, nil, sec) or return
+      SELF_PIPE[0].read_nonblock(Const::CHUNK_SIZE, HttpRequest::BUF)
       rescue Errno::EAGAIN, Errno::EINTR
-        break
-      end while true
     end
 
     def awaken_master

data/lib/unicorn/configurator.rb

@@ -40,21 +40,24 @@ module Unicorn
 
     def initialize(defaults = {}) #:nodoc:
       self.set = Hash.new(:unset)
-      use_defaults = defaults.delete(:use_defaults)
+      @use_defaults = defaults.delete(:use_defaults)
       self.config_file = defaults.delete(:config_file)
 
       # after_reload is only used by unicorn_rails, unsupported otherwise
       self.after_reload = defaults.delete(:after_reload)
 
-      set.merge!(DEFAULTS) if use_defaults
-      defaults.each { |key, value| self.send(key, value) }
+      set.merge!(DEFAULTS) if @use_defaults
+      defaults.each { |key, value| self.__send__(key, value) }
       Hash === set[:listener_opts] or
           set[:listener_opts] = Hash.new { |hash,key| hash[key] = {} }
       Array === set[:listeners] or set[:listeners] = []
-      reload
+      reload(false)
     end
 
-    def reload #:nodoc:
+    def reload(merge_defaults = true) #:nodoc:
+      if merge_defaults && @use_defaults
+        set.merge!(DEFAULTS) if @use_defaults
+      end
       instance_eval(File.read(config_file), config_file) if config_file
 
       parse_rackup_file
@@ -361,7 +364,10 @@ module Unicorn
 
     # sets the working directory for Unicorn.  This ensures SIGUSR2 will
     # start a new instance of Unicorn in this directory.  This may be
-    # a symlink, a common scenario for Capistrano users.
+    # a symlink, a common scenario for Capistrano users.  Unlike
+    # all other Unicorn configuration directives, this binds immediately
+    # for error checking and cannot be undone by unsetting it in the
+    # configuration file and reloading.
     def working_directory(path)
       # just let chdir raise errors
       path = File.expand_path(path)

data/lib/unicorn/const.rb

@@ -8,8 +8,8 @@ module Unicorn
   # Symbols did not really improve things much compared to constants.
   module Const
 
-    # The current version of Unicorn, currently 1.0.1
-    UNICORN_VERSION="1.0.1"
+    # The current version of Unicorn, currently 1.0.2
+    UNICORN_VERSION="1.0.2"
 
     DEFAULT_HOST = "0.0.0.0" # default TCP listen host address
     DEFAULT_PORT = 8080      # default TCP listen port

data/t/t0009-winch_ttin.sh

@@ -0,0 +1,59 @@
+#!/bin/sh
+. ./test-lib.sh
+t_plan 8 "SIGTTIN succeeds after SIGWINCH"
+
+t_begin "setup and start" && {
+	unicorn_setup
+cat >> $unicorn_config <<EOF
+after_fork do |server, worker|
+  # test script will block while reading from $fifo,
+  File.open("$fifo", "wb") { |fp| fp.syswrite worker.nr.to_s }
+end
+EOF
+	unicorn -D -c $unicorn_config pid.ru
+	unicorn_wait_start
+	test 0 -eq $(cat $fifo) || die "worker.nr != 0"
+}
+
+t_begin "read worker pid" && {
+	orig_worker_pid=$(curl -sSf http://$listen/)
+	test -n "$orig_worker_pid" && kill -0 $orig_worker_pid
+}
+
+t_begin "stop all workers" && {
+	kill -WINCH $unicorn_pid
+}
+
+# we have to do this next step before delivering TTIN
+# signals aren't guaranteed to delivered in order
+t_begin "wait for worker to die" && {
+	i=0
+	while kill -0 $orig_worker_pid 2>/dev/null
+	do
+		i=$(( $i + 1 ))
+		test $i -lt 600 || die "timed out"
+		sleep 1
+	done
+}
+
+t_begin "start one worker back up" && {
+	kill -TTIN $unicorn_pid
+}
+
+t_begin "wait for new worker to start" && {
+	test 0 -eq $(cat $fifo) || die "worker.nr != 0"
+	new_worker_pid=$(curl -sSf http://$listen/)
+	test -n "$new_worker_pid" && kill -0 $new_worker_pid
+	test $orig_worker_pid -ne $new_worker_pid || \
+	   die "worker wasn't replaced"
+}
+
+t_begin "killing succeeds" && {
+	kill $unicorn_pid
+}
+
+t_begin "check stderr" && check_stderr
+
+dbgcat r_err
+
+t_done

data/t/t0012-reload-empty-config.sh

@@ -0,0 +1,82 @@
+#!/bin/sh
+. ./test-lib.sh
+t_plan 9 "reloading unset config resets defaults"
+
+t_begin "setup and start" && {
+	unicorn_setup
+	rtmpfiles unicorn_config_orig before_reload after_reload
+	cat $unicorn_config > $unicorn_config_orig
+	cat >> $unicorn_config <<EOF
+logger Logger.new(STDOUT)
+preload_app true
+timeout 0x7fffffff
+worker_processes 2
+after_fork { |s,w| }
+\$dump_cfg = lambda { |fp,srv|
+  defaults = Unicorn::Configurator::DEFAULTS
+  defaults.keys.map { |x| x.to_s }.sort.each do |key|
+    next if key =~ %r{\Astd(?:err|out)_path\z}
+    key = key.to_sym
+    def_value = defaults[key]
+    srv_value = srv.__send__(key)
+    fp << "#{key}|#{srv_value}|#{def_value}\\n"
+  end
+}
+before_fork { |s,w|
+  File.open("$before_reload", "a") { |fp| \$dump_cfg.call(fp, s) }
+}
+before_exec { |s| }
+EOF
+	unicorn -D -c $unicorn_config env.ru
+	unicorn_wait_start
+}
+
+t_begin "ensure worker is started" && {
+	curl -sSf http://$listen/ > $tmp
+}
+
+t_begin "replace config file with original(-ish)" && {
+	grep -v ^pid < $unicorn_config_orig > $unicorn_config
+	cat >> $unicorn_config <<EOF
+before_fork { |s,w|
+  File.open("$after_reload", "a") { |fp| \$dump_cfg.call(fp, s) }
+}
+EOF
+}
+
+t_begin "reload signal succeeds" && {
+	kill -HUP $unicorn_pid
+	while ! egrep '(done|error) reloading' $r_err >/dev/null
+	do
+		sleep 1
+	done
+
+	grep 'done reloading' $r_err >/dev/null
+}
+
+t_begin "ensure worker is started" && {
+	curl -sSf http://$listen/ > $tmp
+}
+
+t_begin "pid file no longer exists" && {
+	if test -f $pid
+	then
+		die "pid=$pid should not exist"
+	fi
+}
+
+t_begin "killing succeeds" && {
+	kill $unicorn_pid
+}
+
+t_begin "check stderr" && {
+	check_stderr
+}
+
+t_begin "ensure reloading restored settings" && {
+	awk < $after_reload -F'|' '
+$1 != "before_fork" && $2 != $3 { print $0; exit(1) }
+'
+}
+
+t_done

data/unicorn.gemspec

@@ -36,7 +36,7 @@ Gem::Specification.new do |s|
   s.homepage = %q{http://unicorn.bogomips.org/}
 
   summary = %q{Rack HTTP server for fast clients and Unix}
-  s.rdoc_options = [ "-Na", "-t", "Unicorn: #{summary}" ]
+  s.rdoc_options = [ "-t", "Unicorn: #{summary}" ]
   s.require_paths = %w(lib ext)
   s.rubyforge_project = %q{mongrel}
   s.summary = summary
@@ -49,7 +49,7 @@ Gem::Specification.new do |s|
   # *strongly* recommended for security reasons.
   s.add_dependency(%q<rack>)
 
-  s.add_development_dependency('isolate', '~> 2.0.2')
+  s.add_development_dependency('isolate', '~> 3.0.0')
 
   # s.licenses = %w(GPLv2 Ruby) # licenses= method is not in older RubyGems
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: unicorn
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: false
   segments: 
   - 1
   - 0
-  - 1
-  version: 1.0.1
+  - 2
+  version: 1.0.2
 platform: ruby
 authors: 
 - Unicorn hackers
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-07-13 00:00:00 +00:00
+date: 2010-10-27 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -40,12 +40,12 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 11
+        hash: 7
         segments: 
-        - 2
+        - 3
+        - 0
         - 0
-        - 2
-        version: 2.0.2
+        version: 3.0.0
   type: :development
   version_requirements: *id002
 description: |-
@@ -211,6 +211,8 @@ files:
 - t/t0006.ru
 - t/t0007-working_directory_no_embed_cli.sh
 - t/t0008-back_out_of_upgrade.sh
+- t/t0009-winch_ttin.sh
+- t/t0012-reload-empty-config.sh
 - t/t0300-rails3-basic.sh
 - t/t0301-rails3-missing-config-ru.sh
 - t/t0302-rails3-alt-working_directory.sh
@@ -319,7 +321,6 @@ licenses: []
 
 post_install_message: 
 rdoc_options: 
-- -Na
 - -t
 - "Unicorn: Rack HTTP server for fast clients and Unix"
 require_paths: