umlaut 3.0.5 → 3.1.0.pre1

data/test/fixtures/sfx_urls.yml

@@ -2,3 +2,6 @@
 gateway:
   id: 1
   url: gateway.ovid.com
+proquest:
+  id: 2
+  url: proquest.umi.com

data/test/functional/export_email_controller_test.rb

@@ -0,0 +1,43 @@
+require 'test_helper'
+
+
+# The ExportEmailController provides custom interactions
+# for the ExportEmail service. 
+class ExportEmailControllerTest < ActionController::TestCase
+  fixtures :requests, :referents, :referent_values, :dispatched_services, :service_responses
+
+  setup do
+    @email_service_response = service_responses(:service_response3)
+    @txt_holding_service_response = service_responses(:service_response9)
+  end
+
+  test "layout" do
+    get(:email, :id => @email_service_response.id)
+    assert_response :success
+    assert_select "body div.umlaut-container", 1
+    assert_select "div.email", 1
+  end
+
+  test "layout xhr" do
+    xhr :get, :email, :id => @email_service_response.id
+    assert_response :success
+    # Assert that no layout was included in the request
+    assert_select "body", 0
+    assert_select "div.umlaut-container", 0
+    assert_select "div.email", 1
+  end
+
+  test "send email" do
+    to_addr = "nobody@example.org"
+    post :send_email, :id => @email_service_response.id, :email => to_addr
+
+
+    # Mail was sent
+    assert !ActionMailer::Base.deliveries.empty?
+    assert ActionMailer::Base.deliveries.find do |message|
+      message.to.include? to_addr      
+    end
+
+    assert_select "div", :text => /Sent to #{to_addr}/
+  end
+end

data/test/functional/link_router_controller_test.rb

@@ -0,0 +1,16 @@
+require 'test_helper'
+class LinkRouterControllerTest < ActionController::TestCase
+  fixtures :service_responses
+  test "index" do
+    service_response = service_responses(:service_response8)
+    get :index, {id: service_response.id}
+    assert_response :redirect
+    assert_redirected_to "http://holding.library.edu/DOCID"
+  end
+
+  test "error" do
+    assert_raises(ActiveRecord::RecordNotFound) {
+      get :index, {id: "this should throw an error"}
+    }
+  end
+end

data/test/functional/resolve_controller_test.rb

@@ -0,0 +1,102 @@
+# encoding: UTF-8
+require 'test_helper'
+class ResolveControllerTest < ActionController::TestCase
+  extend TestWithCassette
+  fixtures :requests, :referents, :referent_values, :dispatched_services, :service_responses
+  
+  setup do
+    @controller = ResolveController.new
+  end
+  
+  test_with_cassette("nytimes by issn", :resolve, :match_requests_on => [:method, :uri_without_ctx_tim]) do
+    get :index, "umlaut.request_id" => 80
+    assert_response :success
+    assert_select "title", "Find It | The New York times"
+    assert_select "h1", "Find It"
+    assert_select "h2.title", "The New York times"
+
+    assert_select ".umlaut-main .umlaut-resource-info dl.citation-info" do |dls|
+      assert_equal 1, dls.size
+      dls.each do |dl|
+        assert_select dl, "dt", 1
+        assert_select dl, "dt" do |dts|
+          assert dts.last, "ISSN:"
+        end
+        assert_select dl, "dd", 1
+        assert_select dl, "dd" do |dds|
+          assert dds.last, "0362-4331"
+        end
+      end
+    end
+    # puts @response.body
+    assert_select ".umlaut-main .umlaut-section.fulltext" do |sections|
+      assert_equal 1, sections.size
+      sections.each do |section|
+        assert_select section, ".response_list", 1
+        assert_select section, ".response_list" do |response_lists|
+          assert_select section, "li.response_item", 4
+        end
+      end
+    end
+    assert_select ".umlaut-main .umlaut-section.holding" do |sections|
+      assert_equal 1, sections.size
+      sections.each do |section|
+        assert_select section, ".umlaut-holdings", 1
+        assert_select section, ".umlaut-holdings .umlaut-holding" do |holdings|
+          # This record only has 1 holding
+          assert_equal 1, holdings.size
+          holdings.each do |holding|
+            # Make sure the edition warning shows up.
+            assert_select holding, ".umlaut-holding-match-reliability", 1
+            # Make sure the coverage shows up.
+            assert_select holding, ".umlaut-holding-coverage", 1
+            assert_select holding, ".umlaut-holding-coverage li", 2
+            # Make sure the notes show up.
+            assert_select holding, ".umlaut-holding-notes", 1
+          end
+        end
+      end
+    end
+    assert_select ".umlaut-sidebar .umlaut-section.export_citation" do |sections|
+      assert_equal 1, sections.size
+      sections.each do |section|
+        assert_select section, ".response_list", 1
+      end
+    end
+    assert_select ".umlaut-sidebar .umlaut-section.highlighted_link" do |sections|
+      assert_equal 1, sections.size
+      sections.each do |section|
+        assert_select section, ".response_list", 1
+      end
+    end
+  end
+
+  test_with_cassette("fulltext with edition warning", :resolve, :match_requests_on => [:method, :uri_without_ctx_tim]) do
+    umlaut_request = requests(:momo)
+    get(:index, {'umlaut.request_id' => umlaut_request.id})
+    assert_response :success
+    assert_select 'div#fulltext ul.response_list li.response_item' do |elements|
+      assert_equal(1, elements.size)
+      elements.each do |element|
+        assert_select element, "a", {:count => 1, :href => "", :text => "the Internet Archive: Open Source Book"}
+        assert_select element, 'div.edition_warning', {:count => 1,
+          :text => "Edition information Momo, ovvero l&#x27;arcana storia dei ladri di tempo e della bambina che restituì agli uomini il tempo trafugato"}
+      end
+    end
+  end
+
+  test_with_cassette("no holdings", :resolve, :match_requests_on => [:method, :uri_without_ctx_tim]) do
+    umlaut_request = requests(:advocate)
+    get(:index, {'umlaut.request_id' => umlaut_request.id, "umlaut.institution" => "NYU"})
+    assert_response :success
+    assert_select 'div#fulltext ul.response_list li.response_item' do |elements|
+      assert_equal(1, elements.size)
+      elements.each do |element|
+        assert_select element, "a", {:count => 1, :href => "", :text => "Gale Cengage Newsstand"}
+        assert_select element, 'div.response_coverage_statement', {:count => 1, :text => "Available from 2009."}
+      end
+    end
+    # Assert no holdings
+    assert_select 'div#holding div.umlaut-holdings', :count => 0
+  end
+end

data/test/functional/search_controller_test.rb

@@ -0,0 +1,40 @@
+require 'test_helper'
+class SearchControllerTest < ActionController::TestCase
+  setup do
+    @controller = SearchController.new
+  end
+
+  test "index" do
+    get :index
+    assert_response :success
+    assert_select "title", "Find It | Journals"
+    assert_select ".umlaut-search-form", 2
+    assert_select ".umlaut-results", 0
+  end
+
+  # Tests don't currently support contains searching because sdalton can't/won't
+  # figure out FULLTEXT indexing in MySQL, so we'll test begins with searching.
+  test "journal search" do
+    return unless Sfx4::Local::AzTitle.connection_configured?
+    get :journal_search, "rft.jtitle"=>"Account", "umlaut.title_search_type"=>"begins"
+    assert_response :success
+    assert_select "title", "Find It | Journal titles that begin with &#x27;Account&#x27;"
+    assert_select ".umlaut-search-form", 1
+    assert_select ".umlaut-results", 1
+    assert_select ".umlaut-results .umlaut-result", :minimum => 1
+    assert_select ".umlaut-pagination", 2
+    assert_select ".umlaut-az", 0
+  end
+
+  test "journal list" do
+    return unless Sfx4::Local::AzTitle.connection_configured?
+    get :journal_list, :id => "A"
+    assert_response :success
+    assert_select "title", "Find It | Browse by Journal Title: A"
+    assert_select ".umlaut-search-form", 1
+    assert_select ".umlaut-results", 1
+    assert_select ".umlaut-results .umlaut-result", :minimum => 1 
+    assert_select ".umlaut-pagination", 2
+    assert_select ".umlaut-az", 1
+  end
+end

data/test/functional/store_controller_test.rb

@@ -0,0 +1,29 @@
+require 'test_helper'
+class StoreControllerTest < ActionController::TestCase
+  fixtures :permalinks, :requests, :referents, :referent_values
+  test "index with permalink referent" do
+    permalink = permalinks(:nytimes)
+    referent = permalink.referent
+    get :index, {id: permalink.id}
+    # assert_redirected_to doesn't work as advertised so HACK!
+    assert(@controller.location.starts_with?("http://test.host/resolve?umlaut.referent_id=#{referent.id}&url_ver=Z39.88-2004&url_ctx_fmt=info%3Aofi%2Ffmt%3Akev%3Amtx%3Actx&ctx_ver=Z39.88-2004&"), "Not redirecting to the correct location.")
+    assert(/rft\.issn=0362-4331/===@controller.location, "In the redirect url, rft.issn is expected to be \"0362-4331\", but isn't. Actual location: #{@controller.location}")
+    assert(/rft\.jtitle=The\+New\+York\+times/===@controller.location, "In the redirect url, rft.jtitle is expected to be \"The New York times\", but isn't. Actual location: #{@controller.location}")
+  end
+
+  test "index without permalink referent" do
+    permalink = permalinks(:expired_referent)
+    get :index, {id: permalink.id}
+    assert_response :redirect
+    # assert_redirected_to doesn't work as advertised so HACK!
+    assert(@controller.location.starts_with?("http://test.host/resolve?umlaut.referent_id="), "Not redirecting to the correct location.")
+    assert(/rft\.issn=0028792X/===@controller.location, "In the redirect url, rft.issn is expected to be \"0028792X\", but isn't. Actual location: #{@controller.location}")
+    assert(/rft\.jtitle=The\+New\+Yorker/===@controller.location, "In the redirect url, rft.jtitle is expected to be \"The New Yorker\", but isn't. Actual location: #{@controller.location}")
+  end
+
+  test "error" do
+    get :index, {id: "this should not be found"}
+    assert_response :not_found
+    assert_select 'title', "The page you were looking for doesn't exist (404)"
+  end
+end

data/test/helper/list_with_limit_test.rb

@@ -0,0 +1,90 @@
+require 'test_helper'
+require 'nokogiri'
+
+class ListWithLimitTest < ActionView::TestCase
+  include ResolveHelper
+  
+  def setup
+    @user_request = Request.new(:id => 999999)
+  end
+  
+  # the visible 'ul', and the one hidden under expand-contract. 
+  # second one may be empty. 
+  def both_lists(str)
+    dom = Nokogiri::HTML::fragment(str)
+    
+    first = dom.at_css("ul")
+    second = dom.at_css("div.collapse ul")
+    
+    return [first, second, dom]
+  end
+    
+  @@li_lambda = lambda do |item, index|
+    "<li data-value='#{item}'>#{item}</li>".html_safe
+  end
+  
+  def test_list_under_limit            
+    out = list_with_limit("foo", %w{1 2 3 4}, :limit => 5, &@@li_lambda)
+      
+    visible_list, hidden_list = both_lists(out)
+    
+    assert_not_nil visible_list    
+    assert_length 4, visible_list.css("li")
+    
+    assert_nil hidden_list    
+  end
+  
+  def test_list_at_limit
+    out = list_with_limit("foo", %w{1 2 3 4 5}, :limit => 5, &@@li_lambda)
+      
+    visible_list, hidden_list = both_lists(out)
+    
+    assert_not_nil visible_list    
+    assert_length 5, visible_list.css("li")
+    
+    assert_nil hidden_list
+  end
+  
+  def test_list_one_more_than_limit
+    # Only FOUR orig items in visible list, then the 'more' link, then two
+    # in hidden -- this makes sense for screen real estate purposes of the limit.
+    out = list_with_limit("foo", %w{1 2 3 4 5 6}, :limit => 5, &@@li_lambda)
+      
+    visible_list, hidden_list, dom = both_lists(out)
+    
+    assert_not_nil visible_list    
+    assert_length 4, visible_list.css("li") 
+    
+    assert_present dom.at_css("ul + div.collapsible a.collapse-toggle")
+        
+    assert_not_nil hidden_list
+    assert_length 2, hidden_list.css("li")
+
+    assert dom.at_css(".collapsible").text.include?("Show 2 more")
+  end
+  
+  def test_list_many_more_than_limit    
+    out = list_with_limit("foo", %w{1 2 3 4 5 6 7 8 9 10}, :limit => 5, &@@li_lambda)
+      
+    visible_list, hidden_list, dom = both_lists(out)
+    
+    assert_not_nil visible_list    
+    assert_length 4, visible_list.css("li") 
+    
+    assert_present dom.at_css("ul + div.collapsible a.collapse-toggle")
+    
+    assert_not_nil hidden_list
+    assert_length 6, hidden_list.css("li") 
+  end
+  
+  def test_html_unsafety_maintained
+    out = list_with_limit("foo", %w{1 2 3 4 5 6 7 8 9 10}, :limit => 5) do |item|
+      "<should be escaped> #{item}"
+    end
+    
+    assert ! out.include?("<should be escaped>"), "Does not include un-escaped angle brackets"
+    assert_equal 10, out.scan("&lt;should be escaped&gt;").length, "Includes escaped angle brackets"     
+  end
+
+end
+

data/test/integration/permalinks_test.rb

@@ -0,0 +1,14 @@
+require 'test_helper'
+
+class PermalinksTest < ActionDispatch::IntegrationTest
+
+    
+  test "missing id" do    
+    get "/go/999999999"
+    
+    assert_response(:missing)    
+  end
+  
+  
+  
+end

data/test/support/test_with_cassette.rb

@@ -0,0 +1,37 @@
+# Copied from jrochkind's bento search.
+# TODO: Investigate a DRYer way to copy from jrochkind's bento search.
+module TestWithCassette
+  def test_with_cassette(name, group = nil, vcr_options ={}, &block)
+    # cribbed from Rails and modified for VCR
+    # https://github.com/rails/rails/blob/b451de0d6de4df6bc66b274cec73b919f823d5ae/activesupport/lib/active_support/testing/declarative.rb#L25
+
+    test_name_safe = name.gsub(/\s+/,'_')
+
+    test_method_name = "test_#{test_name_safe}".to_sym
+
+    raise "#{test_method_name} is already defined in #{self}" if methods.include?(test_method_name)
+
+    cassette_name = vcr_options.delete(:cassette)
+    unless cassette_name
+      # calculate default cassette name from test name
+      cassette_name = test_name_safe
+      # put in group subdir if group
+      cassette_name = "#{group}/#{cassette_name}" if group
+    end
+
+    # default tag with groupname, can be over-ridden.
+    vcr_options = {:tag => group}.merge(vcr_options) if group
+
+    if block_given?
+      define_method(test_method_name) do
+        VCR.use_cassette(cassette_name , vcr_options) do
+          instance_eval &block
+        end
+      end
+    else
+      define_method(test_method_name) do
+        flunk "No implementation provided for #{name}"
+      end
+    end
+  end
+end

data/test/test_helper.rb

@@ -1,9 +1,10 @@
+require 'coveralls'
+Coveralls.wear!
 # Configure Rails Environment
 ENV["RAILS_ENV"] = "test"
 
 require File.expand_path("../dummy/config/environment.rb",  __FILE__)
 require "rails/test_help"
-
 ActiveSupport::TestCase.fixture_path = File.expand_path("../fixtures", __FILE__) 
 
 Rails.backtrace_cleaner.remove_silencers!
@@ -14,37 +15,82 @@ Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 # Complete stack trace with deprecation warnings from rails
 ActiveSupport::Deprecation.debug = true
 
-# Custom method for NYU-only tests. We still have a bunch of tests for aleph/
-# primo that work against live nyu services and can only succeed if you are 
-# nyu. Oops. We provide this convenience function to wrap test_* class
-# method bodies for nyu only tests, so they'll only be run if
-# ENV variable NYU_TEST is set, otherwise you'll get a little message
-# and a fake test. 
-
-
-# 'skip' only works in ruby 1.9.x, plus outputs a bunch of annoying stuff.
-#, plus doesn't give NYU any good way to run em without editing 'skip' out
-# of a buncha places. 
-
-# nyu_only_test("AlephTests") do
-#   def test_something
-#     assert_something
-#   end
-#   def test_something_else
-#     assert_else
-#   end
-# end
-def nyu_only_tests(test_name="Some")
-
-  run_tests = ENV['NYU_TEST'] || false
+class ActiveSupport::TestCase
+  # Load SFX 4 fixtures only if we are explicitly creating a mock_instance
+  # which should really only be the case for travis-ci.org
+  def self.sfx4_fixtures(*fixture_names)
+    # Load SFX 4 fixtures only if we are explicitly creating a mock_instance
+    # which should really only be the case for travis-ci.org
+    if (sfx4_mock_instance?)
+      warn "Loading SFX4 fixtures."
+      sfx4s = ["Global", "Local"]
+      sfx4s.each do |sfx4|
+        # Get the db module associate with this sfx4 instance
+        sfx4_module = Sfx4.const_get(sfx4.to_sym)
+        # Get the connection from the :Base class for each sfx4
+        # Set the path
+        path = "#{File.dirname(__FILE__)}/fixtures/#{sfx4_module.to_s.underscore}"
+        # Get class names hash of table_name => class_name
+        class_names = {}
+        connection = nil
+        fixture_names.collect{|t|t.to_s}.each do |table| 
+          next unless sfx4_module.const_defined?(table.classify)
+          #Find class from table name
+          klass = sfx4_module.const_get table.classify
+          connection ||= klass.connection
+          class_names[klass.table_name.downcase.to_sym] = klass.name
+        end
+        # Table names are just the keys of the class names
+        table_names = class_names.keys.collect{|t| t.to_s.upcase}
+        # Create and Instantiate Fixtures
+        ActiveRecord::Fixtures.create_fixtures(path, table_names, class_names){connection}.first.fixtures
+      end
+    else
+      warn  "Skipping SFX4 fixtures since the SFX DB specified is not a mock instance."
+    end
+  end
   
-  unless run_tests
-    warn("#{test_name} tests can't be run outside of NYU, skipping.")
-    def test_nothing
-      # avoid "no tests were specified" error. 
+  def self.sfx4_mock_instance?
+    (Sfx4::Local::Base.connection_configured? and
+      Sfx4::Local::Base.connection_config[:mock_instance] and 
+        Sfx4::Global::Base.connection_configured? and
+          Sfx4::Global::Base.connection_config[:mock_instance])
+  end
+end
+
+# VCR is used to 'record' HTTP interactions with
+# third party services used in tests, and play em
+# back. Useful for efficiency, also useful for
+# testing code against API's that not everyone
+# has access to -- the responses can be cached
+# and re-used. 
+require 'vcr'
+require 'webmock'
+
+# To allow us to do real HTTP requests in a VCR.turned_off, we
+# have to tell webmock to let us. 
+WebMock.allow_net_connect!
+
+without_ctx_tim = VCR.request_matchers.uri_without_param(:ctx_tim)
+VCR.configure do |c|
+  c.cassette_library_dir = 'test/vcr_cassettes'
+  # webmock needed for HTTPClient testing
+  c.hook_into :webmock 
+  c.register_request_matcher(:uri_without_ctx_tim, &without_ctx_tim)
+  # c.debug_logger = $stderr
+end
+
+# Silly way to not have to rewrite all our tests if we
+# temporarily disable VCR, make VCR.use_cassette a no-op
+# instead of no-such-method. 
+if ! defined? VCR
+  module VCR
+    def self.use_cassette(*args)
+      yield
     end
-  else
-    yield
   end
 end
 
+def assert_length(size, list)
+  assert_equal size, list.length, "Expected size of #{size} for #{list}"
+end