ultron 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 69b914d9f16335035655a79ba254c6dddb28fdea
-  data.tar.gz: 99eaf8d276b7036e57376c2b9539032417c73600
+  metadata.gz: 6195265a3aa3ffae282744daa6ffaaab7415d9fe
+  data.tar.gz: 8f647150c7d3d127967591e1bf089907243d1420
 SHA512:
-  metadata.gz: 237d10bf3c136b2dd6433eb0b0703b328ae09f9b6c9811232f5e848b6f1e9dd8b31a00f8a20ea11d1c17da6ade53503e12be7fb1dd70ef63e60d2960ffcd1986
-  data.tar.gz: d6b43d18a54ae12ab359055153445f1b828a0ab760963e3cf1f52b575a6383631130dd6c7c7177ff4b7cdc1c43e26a3e7053283238b4172df7ba847c37821a5e
+  metadata.gz: 19cea53dd77e216e09839cc1617b51ae0cff573973196ecdd77d223db1ca581239f940221713d5e2f5d35ea94be161a3d89359c2932bb29dcee2346342b4fb44
+  data.tar.gz: c1916685fb592072dbacddb8e6864f87475a9e1a728b082900671108df8506212d02b4f61b3c2bcce944a41a7c218d7baa69ece68608e6010e39d4f1dcd3c5b4

data/README.md

@@ -14,13 +14,17 @@ Ruby bindings for the [Marvel Comics API](http://developer.marvel.com/)
     ultron
     bundle
     rake
+    
+Or just
+
+    gem install ultron
 
-To actually use it you need an API key and secret which you can get from [here](https://developer.marvel.com/signup), put them into `.env` like this
+To actually use it you need an API keypair which you can get from [here](https://developer.marvel.com/signup), put them into `.env` like this
 
     PUBLIC_KEY: this_r_public_key
     PRIVATE_KEY: this_one_r_private_key
-    
-This all got a lot more elegant after chat over a fry-up with @floppy at the always-superb [First-Step Cafe](https://plus.google.com/100027883675109761806/about?gl=uk&hl=en) in Shoreditch.
+
+I've made a [little toy app](https://github.com/pikesley/powerman) which uses this gem to explore the data.
 
 ## API
 
@@ -92,12 +96,14 @@ I've tried to follow the [Marvel API](http://developer.marvel.com/docs#!/public/
       end
     end
     
-### Raise a custom exception when no results are found
+### Raise a custom exception when we do something dumb
 
-    it 'should throw an Ultron exception for something internal to Ultron', :vcr do
+    it 'should throw a Resource Not Found exception when we search for something nonsensical', :vcr do
       begin
-        comics = Comics.where offset: 1000000
+        characters = Characters.by_creator 186 # characters by creator is a nonsense concept in the Marvel API
       rescue UltronException => e
-        e.status.should == 'The search returned no results'
+        e.status.should == 'Resource does not exist. Check http://developer.marvel.com/docs'
       end
-    end
+    end
+    
+This all got a lot more elegant after a chat over a fry-up with @floppy at the always-superb [First-Step Cafe](https://plus.google.com/100027883675109761806/about?gl=uk&hl=en) in Shoreditch.

data/lib/ultron/models/entities.rb

@@ -31,7 +31,7 @@ module Ultron
     def self.response url
       response = Ultron::Connection.perform url
       case response['code'].to_s
-        when /^4/
+        when /^4/, /^5/
           raise MarvelException.new response
         when 'ResourceNotFound'
           raise UltronException.new 'Resource does not exist. Check %s' % Config.instance.config.api_docs

data/lib/ultron/version.rb

@@ -1,3 +1,3 @@
 module Ultron
-  VERSION = "0.1.4"
+  VERSION = "0.1.5"
 end

data/spec/cassettes/exceptions/should_throw_a_Resource_Not_Found_exception_when_we_search_for_something_nonsensical.yml

@@ -0,0 +1,33 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://gateway.marvel.com/v1/public/creators/186/characters?apikey=<PUBLIC_KEY>&hash=a304d29c7e65217654f6ddd18daf2b3c&ts=1392317244
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - application/json
+      User-Agent:
+      - 'Ultron v0.1.4: https://rubygems.org/gems/ultron'
+  response:
+    status:
+      code: 404
+      message: Not Found
+    headers:
+      Content-Type:
+      - application/json
+      Content-Length:
+      - '181'
+      Date:
+      - Sat, 15 Feb 2014 21:34:57 GMT
+      Connection:
+      - keep-alive
+    body:
+      encoding: ASCII-8BIT
+      string: "{\"code\":\"ResourceNotFound\",\"message\":\"/v1/public/creators/186/characters?ts=1392317244&apikey=<PUBLIC_KEY>&hash=a304d29c7e65217654f6ddd18daf2b3c
+        does not exist\"}"
+    http_version: 
+  recorded_at: Thu, 13 Feb 2014 18:47:24 GMT
+recorded_with: VCR 2.8.0

data/spec/cassettes/exceptions/should_throw_an_Ultron_exception_when_we_do_something_dumb.yml

@@ -0,0 +1,34 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://gateway.marvel.com/v1/public/comics?apikey=<PUBLIC_KEY>&hash=a304d29c7e65217654f6ddd18daf2b3c&offset=1000000&ts=1392317244
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - application/json
+      User-Agent:
+      - 'Ultron v0.1.4: https://rubygems.org/gems/ultron'
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Etag:
+      - c6221500e62a7317e759c6bd37130ee5c62c0cba
+      Content-Type:
+      - application/json
+      Content-Length:
+      - '150'
+      Date:
+      - Sun, 16 Feb 2014 16:52:41 GMT
+      Connection:
+      - keep-alive
+    body:
+      encoding: ASCII-8BIT
+      string: "{\"code\":200,\"status\":\"Ok\",\"etag\":\"c6221500e62a7317e759c6bd37130ee5c62c0cba\",\"data\":{\"offset\":1000000,\"limit\":20,\"total\":31917,\"count\":0,\"results\":[]}}"
+    http_version: 
+  recorded_at: Thu, 13 Feb 2014 18:47:24 GMT
+recorded_with: VCR 2.8.0

data/spec/ultron/exceptions_spec.rb

@@ -24,7 +24,7 @@ module Ultron
       end
     end
 
-    it 'should throw an Ultron exception for something internal to Ultron', :vcr do
+    it 'should throw an Ultron exception when we do something dumb', :vcr do
       begin
         comics = Comics.where offset: 1000000
       rescue UltronException => e

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ultron
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - pikesley
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-15 00:00:00.000000000 Z
+date: 2014-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: curb
@@ -298,7 +298,9 @@ files:
 - spec/cassettes/exceptions/should_throw_a_No_Results_exception.yml
 - spec/cassettes/exceptions/should_throw_a_Not_Found_exception.yml
 - spec/cassettes/exceptions/should_throw_a_Resource_Not_Found_exception_when_we_search_for_something_non-sensical.yml
+- spec/cassettes/exceptions/should_throw_a_Resource_Not_Found_exception_when_we_search_for_something_nonsensical.yml
 - spec/cassettes/exceptions/should_throw_an_Ultron_exception_for_something_internal_to_Ultron.yml
+- spec/cassettes/exceptions/should_throw_an_Ultron_exception_when_we_do_something_dumb.yml
 - spec/cassettes/sample/let_us_pick_a_random_item/should_get_a_count_of_items_for_a_lookup.yml
 - spec/cassettes/sample/let_us_pick_a_random_item/should_give_us_a_random_comic.yml
 - spec/cassettes/sample/let_us_pick_a_random_item/should_give_us_a_random_comic_for_a_more_complex_search.yml
@@ -378,7 +380,9 @@ test_files:
 - spec/cassettes/exceptions/should_throw_a_No_Results_exception.yml
 - spec/cassettes/exceptions/should_throw_a_Not_Found_exception.yml
 - spec/cassettes/exceptions/should_throw_a_Resource_Not_Found_exception_when_we_search_for_something_non-sensical.yml
+- spec/cassettes/exceptions/should_throw_a_Resource_Not_Found_exception_when_we_search_for_something_nonsensical.yml
 - spec/cassettes/exceptions/should_throw_an_Ultron_exception_for_something_internal_to_Ultron.yml
+- spec/cassettes/exceptions/should_throw_an_Ultron_exception_when_we_do_something_dumb.yml
 - spec/cassettes/sample/let_us_pick_a_random_item/should_get_a_count_of_items_for_a_lookup.yml
 - spec/cassettes/sample/let_us_pick_a_random_item/should_give_us_a_random_comic.yml
 - spec/cassettes/sample/let_us_pick_a_random_item/should_give_us_a_random_comic_for_a_more_complex_search.yml